DDraceNetwork - developer

bors[bot]

[ddnet/ddnet] Issue closed: #4307 Another crash in CDragger (Jap)

00:06

bors[bot]

[ddnet:master] 2 new commits

e13987b Fix crash in CDragger (fixes #4307) - def- 70607b4 Merge #4311 - bors[bot]

00:06

bors[bot]

[ddnet/ddnet] Pull request closed: #4311 Fix crash in CDragger (fixes #4307)

bors[bot]

[ddnet:master] 2 new commits

724fbff Use uint64_t for network stats (fixes #4309) - def- 66fdc39 Merge #4313 - bors[bot]

00:17

bors[bot]

[ddnet/ddnet] Issue closed: #4309 Undefined behavior in net_udp_send

00:17

bors[bot]

[ddnet/ddnet] Pull request closed: #4313 Use uint64_t for network stats (fixes #4309)

def-

[ddnet-web:master] 1 new commit

4455567 Add USA1, CHN7 - def-

sample rate 48000 is pretty much todays standard

00:53

you dont need to adjust anything

bors[bot]

[ddnet/ddnet] Issue closed: #4308 Undefined behavior in linereader

01:41

bors[bot]

[ddnet:master] 2 new commits

030163b Don't access out of bounds in linereader (fixes #4308) - def- cc96d90 Merge #4312 - bors[bot]

01:41

bors[bot]

[ddnet/ddnet] Pull request closed: #4312 Don't access out of bounds in linereader (fixes #4308)

bors[bot]

[ddnet:master] 2 new commits

b5c09b9 Improve performance of SnapFindItem for extended item types - heinrich5991 15319a3 Merge #4321 - bors[bot]

02:18

bors[bot]

[ddnet/ddnet] Pull request closed: #4321 Improve performance of `SnapFindItem` for extended item types

ddnet-maps

[ddnet-maps:master] 1 new commit

7bbe609 A SeMang 1 - ddnet-maps

@heinrich5991: how do i do that? https://github.com/ddnet/ddnet/pull/4316#issuecomment-962502174

Option to disallow dummys (#4305) by ChillerDragon · Pull Request #...

#4305 Since the ddnet client dummy has an aimbot and other advantages some server owners maybe also in pvp might not want that. Checklist Tested the change ingame Provided screenshots if it is ...

ignore that '-'

How do i do a ddnet release build for linux so all libs are statically linked and stuff so it runs on every system?

You have to build with a really old glibc system lib, I use Debian 6

oh fak

09:26

and what cmake options i need?

09:26

oldest sys i have is debian 11 yikes

See https://github.com/ddnet/ddnet-scripts/blob/master/release/build.sh#L104

ddnet-scripts/build.sh at master · ddnet/ddnet-scripts

The magic scripts that make DDNet run. Contribute to ddnet/ddnet-scripts development by creating an account on GitHub.

but i guess im rlsing only for my self anyways so thats fine

09:26

ty

09:27

i dont see the part that tells it to statically link?

09:27

is that make package_default ?

09:27

or bundled libs?

bundled libs

bundled libs takes the ddnet submodule libs instead of system right?

09:28

and also links then statically oke

yes

09:29

but we don't statically link all libs

09:29

only what's in ddnet-libs

cool thanks :)

trml

[ddnet/ddnet] Pull request opened: #4324 Use valid sort comparator

Changed the sort calls to use a single comparison instead, which ended up looking at bit cleaner. (I believe the previous version didn't satisfy strict weak ordering) I'm not able to reproduce #4317, but this hopefully fixes it. @Jupeyy can you test this?

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c es...

ChillerDragon

[ddnet/ddnet] Issue opened: #4325 weird debug macro

https://github.com/ddnet/ddnet/blob/15319a3e50e294c6a368332cc5c7e242b2d267d5/src/game/server/player.cpp#L168

def-

[ddnet/ddnet] Pull request opened: #4326 Fix spacing in HUD settings for 5:4 resolution

Before: !screenshot-20211107@112309 Now: !screenshot-20211107@112758

Checklist

[x] Tested the change ingame
[x] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works st...

def-

[ddnet/ddnet] Issue opened: #4327 Can't save demo after cutting, demo recorder videos

Reported by Gummibaer12345 on Discord !Unbenannt @Robyt3 I'm not seeing anything unicode, but could this still be related? I can't reproduce on Linux

def-

[ddnet/ddnet] Issue opened: #4328 heap-use-after-free in demo player

``` SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /media/ddnet/src/game/client/prediction/gameworld.cpp:157:20 in ================================================================= ==84582==ERROR: AddressSanitizer: heap-use-after-free on address 0x6190000b40c4 at pc 0x558b85a4e87b bp 0x7ffc81337590 sp 0x7ffc81337588 WRITE of size 4 at 0x6190000b40c4 thread T0 #0 0x558b85a4e87a in CGameWorld::RemoveEntity(CEntity*) /media/ddnet/src/game/client/prediction/gameworld.cpp:157:34...

11:08

ChillerDragon

[ddnet/ddnet] Pull request opened: #4329 DbgDummy check belongs to check ingame not to sql (closed #4325)

Introduced by oy to skip ingame check https://github.com/ddnet/ddnet/commit/68faba809c9c0be9c63a462f91d5dac3c540a8b6

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] ...

11:14

def-

[ddnet/ddnet] Pull request opened: #4330 Try crc for maps if sha256 isn't available (fixes #4327)

Happens with demos cut from KoG

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddn...

image.png

11:15

ouch ddnet git log is full of unticked checkboxes ;c

11:15

makes me nervous

murpii

[ddnet/ddnet] Issue opened: #4331 No longer able to copy text from Terminal

I'm no longer able to copy text from the black terminal (cl_show_console 1). Workaround is to rightclick > Select all, which only works once though. Windows 10 64bit, latest version (15.6.1)

Hi, i have issue with teeworlds 0.6 server (not ddnet one). If u use ddnet client, connect to this kind of server and connect dummy i will see literally nothing but u could controll ur tee, u can also open scoreboard and see this

Is this with DDNet client 15.6.1?

Anyway, the issue is in teeworlds server and maybe u can point me where i can fiz it there

deen

Is this with DDNet client 15.6.1?

Prob in most of ddnets

11:33

I use older client and same issue

11:34

Its smth with 0.6 net code

I couldn't reproduce it, any specific server?

enter vanilla server

I did, connected dummy, works fine

ughm

11:35

Okay let me check on other device

I get a segfault when connecting dummy to vanilla

11:47

but i thought that is not meant to be supported

11:47

https://github.com/ddnet/ddnet/issues/1698

Dummy support for 0.6.5 · Issue #1698 · ddnet/ddnet

Dummys get really glitchy on latest vanilla. Probably they can't handle the anti spoof. Graphic bugs connection problems and falling through walls -.-

11:47

i think 0.6.4 works better

oh, i didn't test on 0.6.5

11:49

ah, actually I did, but it was one of the ddnet ones

def-

[ddnet/ddnet] Issue opened: #4332 Connecting dummy on 0.6.5 vanilla server (reims iCTF Server) crashes

``` ================================================================= ==118958==ERROR: AddressSanitizer: heap-use-after-free on address 0x62e00011015c at pc 0x55f88195ffa3 bp 0x7ffe68a623d0 sp 0x7ffe68a623c8 READ of size 1 at 0x62e00011015c thread T0 #0 0x55f88195ffa2 in CCollision::GetTileIndex(int) const /media/ddnet/src/game/collision.cpp:980:25 #1 0x55f88195fb69 in CCollision::GetMoveRestrictions(bool ()(int, void), void*, vector2_base, float, int) /media/ddnet/src/game/col...

wow issue dupe

hmh

@heinrich5991 My server isnt in the http master anymore...

14:14

Now it is?! so weird

@fokkonaut: what changed in your server compared to yesterday?

i have entityex in aswell as switchstate implemented

and yesterday not?=

i think my server is pretty much a 15.6 server for ddnet clients xd

Jupstar ✪

and yesterday not?=

yesterday too

ok strange

why?

yesterday macos crashed, now it doesnt

i get multiple reports about players not being able to join xd

14:20

also without macos

14:20

starting from 15.6

@fokkonaut is it possible your servers sends the same ID for multiple netobjects (tthat are not EntityEx)?

yesterday i could reproduce it every time i connected, over the span of 1-2 hours

trml

@fokkonaut is it possible your servers sends the same ID for multiple netobjects (tthat are not EntityEx)?

shouldnt, i think

14:22

Well, you mean like ID 1 for characters and ID 1 for a door or so?

not character I think, but more something like 1 for door and 1 for pickup, or something similar

btw there are 2 fokkonaut servers

14:22

is one not real?

one is test server

14:23

if it says [TEST]

14:23

otherwise i dont see any second one

trml

not character I think, but more something like 1 for door and 1 for pickup, or something similar

shouldnt, i use snap newID

ok, just to be sure since you and vali are so big friends

fokkonaut

shouldnt, i use snap newID

that should take care

Jupstar ✪

ok, just to be sure since you and vali are so big friends

xd

fokkonaut

shouldnt, i use snap newID

yes, should

14:25

btw, from #bugs it looks like it happened on fng too

isnt it possible to use wireshark or so to check?

fokkonaut

isnt it possible to use wireshark or so to check?

I tested on your server with a debug print earlier today and didn't see anything like that, so don't think it happens now

14:27

(and could also have been an entirely different bug)

hmm

as in, could have been a client bug

You could try to visit the plots, use /pause Fluffy

14:30

There are many objects, entityex is only sent when you are on the same plot as the objects are built in, to reduce filling the snap :D

14:30

It probbaly wont be enough objects, since they dont get clipped with zoom, so they only have the normal range

14:31

i can place sme more doors if you wanna test

14:31

outside of plots

what i get often and also only on fokko is

/src/engine/shared/snapshot.cpp:192:18: runtime error: signed integer overflow: -2139062272 + -930647296 cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /src/engine/shared/snapshot.cpp:192:18 in 
/src/engine/shared/snapshot.cpp:177:21: runtime error: signed integer overflow: 1225257728 - -2139062272 cannot be represented in type 'int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /src/engine/shared/snapshot.cpp:177:21 in

Tho i dunno if that speaks for a broken snapshot or if that happenes generally sometimes

Can you tell me how to trigger it or what it does/where it is?

i cant say, it happened sometimes, i can look if the demo triggers it too

okay, because i had some weird snapshots for sure... I still dont know how to find it or how to fix it, it seemed to be a broken character snapshot for some players

14:57

It would glitch the characters, their positions have a small offset, etc

14:57

very weird, and it could cause connection problems i think

BlmapChill_2021-11-07_15-41-00_d3.demo

1.61 MB

15:03

it happens between at insan: [D] nenny: fokkonaut: they are always on nuborn, like placed from game layer

15:03

chat messages

funny to see at insan pinging nenny in ddnet dev channel :D

def-

[ddnet/ddnet] Issue opened: #4333 it looks like skins with a space in the name don't work

it looks like skins with a space in the name don't work

Reported by Ravie on Discord. Can reproduce with "Evil Puffi".

ChillerDragon

[ddnet/ddnet] Pull request opened: #4334 Add GetInt64

Comes in handy for my downstream

def-

[ddnet/ddnet] Pull request opened: #4335 Escape skin name when downloading (fixes #4333)

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

bors[bot]

[ddnet:master] 2 new commits

8db53f2 Fix sort comparator - trml 34642b1 Merge #4324 - bors[bot]

16:46

bors[bot]

[ddnet/ddnet] Pull request closed: #4324 Use valid sort comparator

@deen u probs missed it but main page still downloads 15.6 instead of 15.6.1

bors[bot]

[ddnet:master] 2 new commits

ce10e29 Escape skin name when downloading (fixes #4333) - def- ac3d9d0 Merge #4335 - bors[bot]

18:15

bors[bot]

[ddnet/ddnet] Issue closed: #4333 it looks like skins with a space in the name don't work

18:15

bors[bot]

[ddnet/ddnet] Pull request closed: #4335 Escape skin name when downloading (fixes #4333)

def-

[ddnet-web:master] 1 new commit

68de84d Update 15.6.1 on mainpage - def-

@Ryozuki thanks

def-

[ddnet:15.6.2-rc1] 28 new commits

01d097c Version 15.6 - def- 6fc198a Update language files for 15.6 release - def- 6e4221b Translate German - def- 74a499b Fix pickup network clipping - fokkonaut b4ea62a Use correct (larger) m_NumSwitchers bound - trml be65574 update catalan - edg-l 8252f46 Update spanish.txt (#4256) - n0Ketchp 4e698d3 Update spanish.txt - n0Ketchp 3dc733c Update spanish.txt - n0Ketchp d62ca7f Update spanish.txt - n0Ketchp 74d314d Update russian.txt - NikGreens 8ed1a93 Update russian.txt - NikGreens 8ea1655 Update russian.txt - NikGreens 642eaa4 Update brazilian_portuguese.txt - rffontenelle 47e2c4c Add exception id to TeamKill - Jupeyy 0000d75 Reset selection, if gui element was changed outside of DoEditBox - Jupeyy 160e02b Fix characters disappearing (fixes #4285) - fokkonaut dc95187 fix fs_makedir and fs_storage_path with unicode on windows - Robyt3 4bdcbef fix fs_getcwd with unicode on windows - Robyt3 10ec409 fix fs_chdir with unicode on windows - Robyt3 d65a8e8 Don't call uuid lookup, if the expected type isn't an uuid extended type anyway - Jupeyy c396711 Version 15.6.1 - def- 952174c Remove upper resolution bound - Jupeyy c7699e3 Fix snd_chat and snd_team_chat (fixes #4302) - def- 8bbc1ff Support unicode filenames on windows with pnglite (fixes #4301) - def- f144c21 Use delete[] for m_pSwitchers - Jupeyy 35b31c9 Fix sort comparator - trml d3c3889 Version 15.6.2 - def-

21:34

def-

[ddnet:15.6.2] 29 new commits

01d097c Version 15.6 - def- 6fc198a Update language files for 15.6 release - def- 6e4221b Translate German - def- 74a499b Fix pickup network clipping - fokkonaut b4ea62a Use correct (larger) m_NumSwitchers bound - trml be65574 update catalan - edg-l 8252f46 Update spanish.txt (#4256) - n0Ketchp 4e698d3 Update spanish.txt - n0Ketchp 3dc733c Update spanish.txt - n0Ketchp d62ca7f Update spanish.txt - n0Ketchp 74d314d Update russian.txt - NikGreens 8ed1a93 Update russian.txt - NikGreens 8ea1655 Update russian.txt - NikGreens 642eaa4 Update brazilian_portuguese.txt - rffontenelle 47e2c4c Add exception id to TeamKill - Jupeyy 0000d75 Reset selection, if gui element was changed outside of DoEditBox - Jupeyy 160e02b Fix characters disappearing (fixes #4285) - fokkonaut dc95187 fix fs_makedir and fs_storage_path with unicode on windows - Robyt3 4bdcbef fix fs_getcwd with unicode on windows - Robyt3 10ec409 fix fs_chdir with unicode on windows - Robyt3 d65a8e8 Don't call uuid lookup, if the expected type isn't an uuid extended type anyway - Jupeyy c396711 Version 15.6.1 - def- 952174c Remove upper resolution bound - Jupeyy c7699e3 Fix snd_chat and snd_team_chat (fixes #4302) - def- 8bbc1ff Support unicode filenames on windows with pnglite (fixes #4301) - def- f144c21 Use delete[] for m_pSwitchers - Jupeyy 35b31c9 Fix sort comparator - trml d3c3889 Version 15.6.2 - def- 4ab674d Escape skin name when downloading (fixes #4333) - def-

def-

[ddnet-web:master] 1 new commit

ede7a9a Version 15.6.2 - def-

Hopefully no more bad bugs popping up in 15.6

sha256sum plz

21:45

done

21:45

they always take a few min

oh ok

21:47

im the fastest in the west

@fokkonaut same answer as last time for the http master

murpii

[ddnet/ddnet] Issue closed: #4331 No longer able to copy text from Terminal

def-

[ddnet/ddnet] Issue opened: #4336 Updater fails to update sqlite3.dll when server is running on Windows

Since sqlite3.dll is required by server, and thus we can't replace it. Not sure how to resolve this well. Reported by Nikola on Discord

heinrich5991

[ddnet/ddnet] Pull request opened: #4337 Fix DbgDummy check being at the wrong place

Fixes #4325.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-address...