Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2021-11-05 00:00:00Z and 2021-11-06 00:00:00Z
Avatar
@Learath2 could you look at / merge https://github.com/ddnet/ddnet-discordbot/pull/25 please?
uploads bot-produced maps directly to the servers gives okay emoji to maps with no errors
Avatar
@Learath2 it seems the easiest way to fix this particular problem would be to move the SnapFindItem method into the snapshot class and do the reverse lookup from the external type to the internal type and then compare each snapshot object with the internal type
02:32
(the current fix doesn't work if you look for extended snapshot objects)
02:33
I agree that in the long term, a hashmap of ((typeid, id) -> offset) in the snapshot would be nice, this doesn't break iteration because it's just an additional offset map
02:37
the approach in the PR works for vanilla types, which are the only ones we search for anyway(?)
02:37
but it breaks down if you search for extended net objects
Avatar
Jupstar ✪ BOT 2021-11-05 02:41:03Z
Most performance loss currently comes from the simple fact that lookupuuid is slow. This addresses the problem by making sure its only called for net messages, that are extended anyway @trml or @he...
Avatar
yes
Avatar
Jupstar ✪ BOT 2021-11-05 02:41:23Z
can you explain why it breaks it?
Avatar
okay, it doesn't fix the problem if you search for extended net objects
02:42
it does fix the problem if you search for vanilla net objects
02:42
(i.e. it doesn't break anything, it fixes half of the things (and maybe all of the things we care about?))
Avatar
Jupstar ✪ BOT 2021-11-05 02:42:51Z
yeah its there to minize the uuid lookup, currently only ddnet_projectiles is the only one that uses snapfinditem and is uuid
Avatar
the approach mentioned above works the same on non-extended net objects and has similar performance for extended ones (AFAICT)
02:44
i.e. translate the external type into the internal snapshot type (which is a no-op for vanilla snapshot types, and a one-time search for extended snapshot types)
Avatar
Jupstar ✪ BOT 2021-11-05 02:44:41Z
i think the best would be to split the keys and have too snapfinditem branches bcs the mapping is also only useful for uuid items
02:46
two* xd
Avatar
which mapping?
Avatar
Jupstar ✪ BOT 2021-11-05 02:46:24Z
but yeah i agree the mapping could be useful and generally having binary search too
02:46
mapping from external type to snapshot type
02:46
or extended typ to external type to be precise
Avatar
Avatar
heinrich5991
@Learath2 it seems the easiest way to fix this particular problem would be to move the SnapFindItem method into the snapshot class and do the reverse lookup from the external type to the internal type and then compare each snapshot object with the internal type
this approach doesn't need said mapping
02:47
at least not in an efficient way
02:48
it's an optimization. instead of looking up the external type of each item, it translates the external type we're looking for into the internal type so each item type comparison is a cheap integer comparison
Avatar
Jupstar ✪ BOT 2021-11-05 02:48:48Z
yeah
Avatar
9f9427e Remove upper resolution bound - Jupeyy e73d1ef Merge #4295 - bors[bot]
Avatar
Nakimar on Discord reports:
the red sign is gone, the servers are working but the skins and texture packs are not loaded
@Robyt3 is it related?
09:45
Windows 11 can run linux version of ddnet now
09:45
mouse doesn't work tho
Avatar
heh, that's cool
09:46
Didn't know WSL supports X11
Avatar
ye it just did
09:47
it is gpu accelerated too apparently
09:49
Avatar
be5645f Add 56 € donation by Immortal - def-
Avatar
WSL runs graphical applications in Weston with an RDP backend
12:34
It sounds like a horrible idea but apparently it works well enough
Avatar
hello there is a bug in the settings with the sound, if we deactivate all the chat sounds and only activate the team chat sound we will hear the normal messages sounds
Avatar
I think 15.6 wasn't pushed on Steam yet? Running without beta only gives me 15.5.4
Avatar
Jupstar ✪ BOT 2021-11-05 15:54:26Z
i think its rc only rn
Avatar
yes, I reverted it since there were bugs
Avatar
Most performance loss currently comes from the simple fact that lookupuuid is slow. This addresses the problem by making sure its only called for net messages, that are extended anyway @trml or @he...
Nakimar on Discord reports: the red sign is gone, the servers are working but the skins and texture packs are not loaded @Robyt3 is it related?
🇫 1
Avatar
I'll try to hotfix pnglite usage later today or tomorrow, but I don't mind if someone else wants to give it a try. Should be pretty straightforward 🙂 (edited)
Avatar

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
4ddb553 Fix snd_chat and snd_team_chat (fixes #4302) - def- 06c0b32 Merge #4303 - bors[bot]
Avatar

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
16:50
506be24 Upload too long debug messages as file + more - Patiga 72e9bf4 Merge pull request #25 from Patiga/pr-fix-too-long-message - Learath2
16:52
they added this on nightly rust
16:52
poggers
Avatar
@Learath2 a list with all the tiles with a direction is here https://gitlab.com/Patiga/twmap/-/blob/master/src/bin/check_ddnet.rs#L100
17:10
@Learath2 if you want to approach this: would you rather do it in python or rust?
Avatar
01d097c Version 15.6 - def- 6fc198a Update language files for 15.6 release - def- 6e4221b Translate German - def- 74a499b Fix pickup network clipping - fokkonaut b4ea62a Use correct (larger) m_NumSwitchers bound - trml be65574 update catalan - edg-l 8252f46 Update spanish.txt (#4256) - n0Ketchp 4e698d3 Update spanish.txt - n0Ketchp 3dc733c Update spanish.txt - n0Ketchp d62ca7f Update spanish.txt - n0Ketchp 74d314d Update russian.txt - NikGreens 8ed1a93 Update russian.txt - NikGreens 8ea1655 Update russian.txt - NikGreens 642eaa4 Update brazilian_portuguese.txt - rffontenelle 47e2c4c Add exception id to TeamKill - Jupeyy 0000d75 Reset selection, if gui element was changed outside of DoEditBox - Jupeyy 160e02b Fix characters disappearing (fixes #4285) - fokkonaut dc95187 fix fs_makedir and fs_storage_path with unicode on windows - Robyt3 4bdcbef fix fs_getcwd with unicode on windows - Robyt3 10ec409 fix fs_chdir with unicode on windows - Robyt3 d65a8e8 Don't call uuid lookup, if the expected type isn't an uuid extended type anyway - Jupeyy c396711 Version 15.6.1 - def- 952174c Remove upper resolution bound - Jupeyy c7699e3 Fix snd_chat and snd_team_chat (fixes #4302) - def- 8bbc1ff Support unicode filenames on windows with pnglite (fixes #4301) - def-
Avatar
ef5e2ec Support unicode filenames on windows with pnglite (fixes #4301) - def- 8ecb364 Merge #4304 - bors[bot]
Avatar
I don't like the way the github bot looks when I add a new tag
Avatar
Avatar
Patiga
@Learath2 if you want to approach this: would you rather do it in python or rust?
rust ofc, may god never leave anyone in a situation where they are forced to use python
17:22
learath said it
Avatar
Avatar
deen
I don't like the way the github bot looks when I add a new tag
I can filter tags if you want
Avatar
but leave master on
17:22
and maybe stagging
Avatar
But I never tag on master
Avatar
ah its just for tags
Avatar
Ah, actually I doubt it's the tag causing the message, isn't it more likely the branch?
Avatar
i meant for when it shows new commits
17:23
ye
17:23
it shows new commits for x branch
17:23
just filter for master and stagging
Avatar
Wait, you don't branch for rc's
Avatar
staging*
Avatar
Um, where do you tag these @deen ? 😄
Avatar
maybe the fault is that I tag them both in my fork and on upstream
Avatar
Threat actors are exploiting a security flaw in GitLab self-hosted servers to assemble botnets and launch gigantic distributed denial of service (DDoS) attacks, with some in excess of 1 terabit per second (Tbps).
17:46
wew
23:18
i wanna create my map for me and my friends
23:18
how can i do it?
Avatar
ctrl-shift-e for editor
23:19
edit it, run your map on https://trashmap.ddnet.tw/ to test with your friends
Avatar
how to place dirt blocks?
Avatar
thank you very much ❤️
Exported 95 message(s)