Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2021-10-26 00:00:00Z and 2021-10-27 00:00:00Z
Avatar
aodq 2021-10-26 00:02:42Z
its an ugly wip https://github.com/AODQ/pulcher
GitHub - AODQ/pulcher: 2D quake-inspired game
2D quake-inspired game. Contribute to AODQ/pulcher development by creating an account on GitHub.
Thumbnail
Avatar
aodq 2021-10-26 00:11:30Z
i do the Tiled JSON map loading stuff here tho if thats what you were asking https://github.com/AODQ/pulcher/blob/master/plugins/base/src/base/map/map.cpp
pulcher/map.cpp at master · AODQ/pulcher
2D quake-inspired game. Contribute to AODQ/pulcher development by creating an account on GitHub.
Thumbnail
00:11
Just use JSON loader and ignore anything tiled related
Avatar
Jupstar ✪ BOT 2021-10-26 00:51:31Z
the youtube video looks quite impressive
Avatar
aodq 2021-10-26 00:53:45Z
thanks. im working on the AI for the single player campaign enemies but I hate writing AI lol
Avatar
murpi 2021-10-26 01:03:35Z
looks very similar to Soldat 🙂
Avatar
aodq 2021-10-26 01:20:03Z
Yeah it takes a lot of stuff from Soldat. If you've played Xonotic a lot of weapons and mechanics are similar to that too
Avatar
GitHub BOT 2021-10-26 04:30:31Z
Author icon
ddnet-maps
[ddnet-maps:master] 1 new commit
556345f M Multeasymap - ddnet-maps
Avatar
chillerdragon BOT 2021-10-26 06:33:40Z
New Multeasy update?
Avatar
chillerdragon BOT 2021-10-26 07:41:01Z
image.png
Image attachment
07:41
lmao pistol damage :) love it
07:42
Petition to make ddnet mod friendly :)
07:42
Can we get some custom controller hooks like vanilla has?
Avatar
GitHub BOT 2021-10-26 09:38:04Z
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #4246 Selection in f2 console doesn't stay in place
09:38
Author icon
bors[bot]
[ddnet:master] 2 new commits
4af9bc7 Fix mouse select position in console when using different page - Jupeyy 3adadd0 Merge #4250 - bors[bot]
09:38
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #4250 Fix mouse select position in console when using different page
09:41
Author icon
def-
[ddnet/ddnet] Pull request opened: #4251 Add inp_translated_keys (fixyes #4241)

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
09:43
Author icon
def-
[ddnet:master] 1 new commit
1e1d56d Upgrade ddnet-libs - def-
Avatar
GitHub BOT 2021-10-26 10:03:19Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
e2dbba3 Network clipping for entityex in CPickup and CProjectile, snap gamecontroller before gameworld, bound checks for switchers in client - trml 5df2feb Merge #4245 - bors[bot]
10:03
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #4244 Remaining problem on Skill Rises map
10:03
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #4245 Further fixes for cpu/zoom on large maps with entityex
Avatar
Avatar
chillerdragon
lmao pistol damage :) love it
deen 2021-10-26 11:14:37Z
That was for an April 1 event where I enabled pistol damage on DDNet servers
Avatar
chillerdragon BOT 2021-10-26 11:26:32Z
Oh that sounds fun!
Avatar
Learath2 2021-10-26 12:11:05Z
@deen do you need any help getting a release out? I have a couple hours today, I can give a hand if there are any outstanding issues that need fixing
Avatar
Avatar
Learath2
@deen do you need any help getting a release out? I have a couple hours today, I can give a hand if there are any outstanding issues that need fixing
Ryozuki 2021-10-26 12:11:46Z
make the changelog greenthing
Avatar
deen 2021-10-26 12:12:05Z
I can try to make the changelog now
Avatar
Learath2 2021-10-26 12:12:11Z
I proposed a couple years back to automate generating a changelog :D
Avatar
deen 2021-10-26 12:12:12Z
I think we need the crash fixed before release
Avatar
Ryozuki 2021-10-26 12:12:12Z
👀
Avatar
Avatar
Learath2
I proposed a couple years back to automate generating a changelog :D
Ryozuki 2021-10-26 12:12:24Z
i proposed it some weeks ago
Avatar
deen 2021-10-26 12:12:30Z
https://github.com/ddnet/ddnet/issues/4240 if you can find something out
Crash in CGameContext::Collision · Issue #4240 · ddnet/ddnet
Core was generated by ./DDRace64-Server_sql -f servers/8304.cfg'. Program terminated with signal SIGSEGV, Segmentation fault. warning: Section .reg-xstate/1115820' in core file to...
Thumbnail
Avatar
Ryozuki 2021-10-26 12:12:39Z
@Learath2 https://www.conventionalcommits.org/en/v1.0.0/
12:12
with this
Avatar
Learath2 2021-10-26 12:12:50Z
@deen do we have the core and the binary of the crash?
Avatar
deen 2021-10-26 12:13:05Z
yes, it's on a few servers
12:13
ssh fra.ddnet.tw
12:13
cd servers/crash
Avatar
Learath2 2021-10-26 12:14:03Z
Perfect. I'll get home in like an hour then I'll take a look
12:15
Ooh, I even have an idea what the issue is
12:15
That backtrace sounds familiar
12:19
@deen does it happen on a shutdown?
Avatar
deen 2021-10-26 12:25:18Z
I don't thin kso
12:25
I saw it in logs where a player killed and left, but there were other players on the server I think
Avatar
Learath2 2021-10-26 12:27:48Z
Wish I'd taken my laptop with me, so curious :D
Avatar
Learath2 2021-10-26 12:38:39Z
Mh it's not what I thought it was :/
Avatar
Jupstar ✪ BOT 2021-10-26 12:46:18Z
@Ryozuki: make a wiki site with automated changelogs, i was asked a few times ingame already if there are human readable changelogs for github somewhere :D
Avatar
Ryozuki 2021-10-26 12:52:15Z
thats hard to do without conventional commits
12:52
with conv commits and https://github.com/orhun/git-cliff
GitHub - orhun/git-cliff: A highly customizable Changelog Generator...
A highly customizable Changelog Generator that follows Conventional Commit specifications ⛰️ - GitHub - orhun/git-cliff: A highly customizable Changelog Generator that follows Conventional Commit ...
Thumbnail
12:52
u just need 1 command
12:52
we just need to enforce it monkalaugh
12:53
as ez as putting "fix:" before a fix and "feat:" before a feature
Avatar
Jupstar ✪ BOT 2021-10-26 12:53:34Z
cant it use pr names?
Avatar
Ryozuki 2021-10-26 12:54:03Z
it uses commit messages
12:54
https://www.conventionalcommits.org/en/v1.0.0/#summary
Conventional Commits
A specification for adding human and machine readable meaning to commit messages
Avatar
Jupstar ✪ BOT 2021-10-26 12:54:40Z
they are probs sometimes too specific
Avatar
Ryozuki 2021-10-26 12:54:57Z
not rly
12:55
they allow lot of flexibility
12:55
e.g "chore:" for something not related to code like CI settings
Avatar
GitHub BOT 2021-10-26 12:55:23Z
Author icon
def-
[ddnet-web:pr-15.6] 1 new commit
de82446 Version 15.6 - def-
Avatar
Ryozuki 2021-10-26 12:55:29Z
recommends build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others.
12:56
e.g you add a new feature to client, you would do "feat(client): added blood and gore"
12:56
and when the changeloge generates it creates sub sections for each
12:56
client, server, etc
12:56
https://github.com/orhun/git-cliff/blob/main/CHANGELOG.md
12:57
an example generated changelog
Avatar
Jupstar ✪ BOT 2021-10-26 12:58:49Z
ok, but sounds pretty complicated xD
Avatar
Ryozuki 2021-10-26 12:58:56Z
how so
12:59
u just add fix or feat:
12:59
i thought dev ppl were smart
Avatar
Jupstar ✪ BOT 2021-10-26 12:59:24Z
i am a potato
Avatar
Ryozuki 2021-10-26 12:59:35Z
Image attachment
12:59
this would just need to be written
12:59
chore: Upgrade ddnet-libs
12:59
omg
12:59
so much iq
12:59
needed
12:59
monkalaugh
Avatar
Jupstar ✪ BOT 2021-10-26 13:00:03Z
alone the word "chore"
Avatar
Ryozuki 2021-10-26 13:00:09Z
?
Avatar
Jupstar ✪ BOT 2021-10-26 13:00:10Z
i'd forget it
13:00
bcs i never use that vocabulary
Avatar
GitHub BOT 2021-10-26 13:00:19Z
Author icon
def-
[ddnet-web:pr-15.6] 1 new commit
50d2cd9 Version 15.6 - def-
Avatar
Ryozuki 2021-10-26 13:00:20Z
not if u see it before
13:00
cmon ur just being petty
Avatar
GitHub BOT 2021-10-26 13:01:28Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
4894b51 Add inp_translated_keys (fixyes #4241) - def- a9bdaef Merge #4251 - bors[bot]
13:01
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #4241 ddnet does not detect remapped ESC
13:01
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #4251 Add inp_translated_keys (fixyes #4241)
Avatar
Ryozuki 2021-10-26 13:01:33Z
u usually dont do any chore anyway
13:01
u would do just fix or feat
Avatar
HappyFray 2021-10-26 13:03:41Z
@Learath2 i got the ddnetbot to work now but it cant find players cant list points or smth
Avatar
Learath2 2021-10-26 13:05:52Z
You need to run the support scripts to download and generate the required tables
Avatar
deen 2021-10-26 13:06:14Z
Jupstar: Why am I not seeing colors on console when I run DDNet?
Avatar
Jupstar ✪ BOT 2021-10-26 13:06:42Z
maybe ur terminal doesnt support it
Avatar
deen 2021-10-26 13:06:54Z
urxvt-256colors, should be ok
13:07
how is it detected?
Avatar
Jupstar ✪ BOT 2021-10-26 13:07:11Z
wait i added a arch wiki link in the code
Avatar
Ryozuki 2021-10-26 13:07:17Z
i see colors
Avatar
Jupstar ✪ BOT 2021-10-26 13:07:43Z
Some terminals support the full range of 16 million colors (RGB, each with 8 bit resolution): xterm, konsole, st, etc. The corresponding TERM values xterm-direct, konsole-direct, st-direct, etc. are supported starting with ncurses version 6.1 [4]. For more info about terminal emulators and applications that support true color, see [5]. Note that the Linux kernel supports the SGR escape sequences for true-color, but it is pointless to use it, because the driver maps the 24-bit color specifications to a 256-colors color map in the kernel (see the functions rgb_foreground, rgb_background). For this reason, there is no terminfo entry linux-direct.
13:07
https://wiki.archlinux.org/title/Color_output_in_console#True_color_support
Color output in console
13:08
the last sentence sounds to me like, it auto converts it if true color not supported
Avatar
Ryozuki 2021-10-26 13:09:39Z
maybe u need rxvt-unicode
13:09
on arch
Avatar
deen 2021-10-26 13:09:49Z
I have that, weird
Avatar
Jupstar ✪ BOT 2021-10-26 13:10:03Z
well i dunno, just use a good terminal then xD
Avatar
Ryozuki 2021-10-26 13:10:04Z
i use alacritty and it works for me
Avatar
Jupstar ✪ BOT 2021-10-26 13:10:14Z
we cant support all stuff that never works
Avatar
Avatar
Learath2
You need to run the support scripts to download and generate the required tables
HappyFray 2021-10-26 13:10:28Z
where are they? what are they called?
Avatar
Jupstar ✪ BOT 2021-10-26 13:11:09Z
even xterm can handle it
Avatar
Ryozuki 2021-10-26 13:11:20Z
what does tput colors say
Avatar
deen 2021-10-26 13:11:35Z
256
Avatar
Ryozuki 2021-10-26 13:11:36Z
❯ tput colors 256
13:11
hmm
13:11
weird
13:11
echo $COLORTERM truecolor
13:11
and this?
Avatar
Avatar
HappyFray
where are they? what are they called?
Learath2 2021-10-26 13:12:16Z
data/tools
Avatar
fokkonaut 2021-10-26 13:12:31Z
I can't ping nuborn here, but it looks like he removed the blinking code on the server side for disabled pickups
Avatar
Learath2 2021-10-26 13:12:51Z
I dont remember the order you run the scripts in
Avatar
Jupstar ✪ BOT 2021-10-26 13:12:52Z
@trml:
Avatar
GitHub BOT 2021-10-26 13:13:00Z
Author icon
def-
[ddnet-web:pr-15.6] 1 new commit
16b105a Version 15.6 - def-
Avatar
fokkonaut 2021-10-26 13:13:12Z
wwwwwaaaaaaaait xd
Avatar
deen 2021-10-26 13:13:16Z
rxvt-xpm
Avatar
Ryozuki 2021-10-26 13:13:21Z
Note: By default urxvt uses the same colors as Xterm, except one. Add URxvt.color12: rgb:5c/5c/ff to Xresources to change this.
Avatar
fokkonaut 2021-10-26 13:13:24Z
@deen
Avatar
Ryozuki 2021-10-26 13:13:34Z
idk xd
Avatar
Avatar
fokkonaut
I can't ping nuborn here, but it looks like he removed the blinking code on the server side for disabled pickups
fokkonaut 2021-10-26 13:13:47Z
We need this for older clients that do not predict the doors
13:14
or any 0.7 client or whatever, basically any client except the one that is not released yet
Avatar
Learath2 2021-10-26 13:14:02Z
Pickups?
Avatar
fokkonaut 2021-10-26 13:14:04Z
yea
13:14
ah wait a sec
13:14
its door code and doors dont blink right
13:14
then its fine sorry
Avatar
GitHub BOT 2021-10-26 13:15:54Z
Author icon
def-
[ddnet/ddnet] Pull request opened: #4252 Update language files for 15.6 release

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
Avatar
Learath2
I dont remember the order you run the scripts in
HappyFray 2021-10-26 13:17:50Z
all gives me errors like that
Image attachment
Avatar
Learath2 2021-10-26 13:19:14Z
Well you first need the diskcache module, and that script needs to run in python2
13:21
You also need to download the cache file from ddnet.tw
Avatar
Avatar
Learath2
You also need to download the cache file from ddnet.tw
HappyFray 2021-10-26 13:25:13Z
where
Avatar
Avatar
Learath2
Well you first need the diskcache module, and that script needs to run in python2
HappyFray 2021-10-26 13:25:19Z
seems to work now the scripts but still dont know what to do with them (edited)
Avatar
Learath2 2021-10-26 13:26:09Z
https://ddnet.tw/players-cache.zip
13:26
You also need https://ddnet.tw/players.json is one you need too iirc
Avatar
Avatar
Learath2
You also need https://ddnet.tw/players.json is one you need too iirc
HappyFray 2021-10-26 13:26:53Z
page not found
Avatar
Learath2 2021-10-26 13:27:09Z
Yeah I dont remember the exact url for that one
Avatar
deen 2021-10-26 13:27:17Z
https://ddnet.tw/players.msgpack maybe?
Avatar
Learath2 2021-10-26 13:27:22Z
Ah yes msgpack
Avatar
deen 2021-10-26 13:27:41Z
I too type ls into chats
13:27
😄
Avatar
HappyFray 2021-10-26 13:27:47Z
haha
Avatar
Learath2 2021-10-26 13:28:02Z
Why are you even trying to run the bot? It really is hard to keep running
Avatar
HappyFray 2021-10-26 13:28:24Z
@ṨtylerTime wants it xD
Avatar
Learath2 2021-10-26 13:28:30Z
You'll need cron jobs to get all these files and run the scripts regularly
13:28
There is one more file you need from ddnet.tw, the releases file. Idk the url for that either
13:29
You also need the records table from our sql backup, dont remember the url to that either
Avatar
GitHub BOT 2021-10-26 13:34:08Z
Author icon
fokkonaut
[ddnet/ddnet] Pull request opened: #4253 Fix pickup network clipping

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
fokkonaut 2021-10-26 13:39:42Z
Wait a second, are doors not being predicted for movements? :(
13:40
aww, i thought they would be predicted already in this pr, then what is all of this for when its not being used right now?
Avatar
Learath2 2021-10-26 13:41:59Z
I thought we also got prediction in for them didn't we?
Avatar
fokkonaut 2021-10-26 13:42:38Z
i just tested it on my server, it seems like its not there :/ the only thing that works for doors is showing them closed/open correctly while always sending end and start points
13:42
so, they get sent correctly but there seems to be no prediction
Avatar
Learath2 2021-10-26 13:43:29Z
So you still get the weird jittery movement when trying to got thru a closed door?
Avatar
fokkonaut 2021-10-26 13:43:33Z
yes
Avatar
Learath2 2021-10-26 13:43:53Z
Would have been nice to get that in aswell
Avatar
fokkonaut 2021-10-26 13:43:57Z
yea
13:44
released already?
Avatar
deen 2021-10-26 13:48:49Z
no
Avatar
trml 2021-10-26 13:48:52Z
@fokkonaut projectiles and pickups are predicted now, doors and draggers are not
Avatar
deen 2021-10-26 13:48:54Z
I'll rebuild 15.6-rc3 with it
Avatar
Avatar
deen
I'll rebuild 15.6-rc3 with it
fokkonaut 2021-10-26 13:49:04Z
with what?
13:49
There is no prediction for doors :/
Avatar
deen 2021-10-26 13:49:35Z
with your pull request
Avatar
fokkonaut 2021-10-26 13:50:31Z
ah, but i think it shouldnt be too much to add prediction for doors before the release. We got the CCollision m_NumSwitchers and the switcher array filled already, plus we know which door is closed etc by switchstatus, we would just need to fix them up for the moverestrictions clientside
Avatar
trml 2021-10-26 13:50:39Z
yes, clipping pickups in general (fokkonauts pr) should improve things even more
Avatar
fokkonaut 2021-10-26 13:52:08Z
lol, actually it should be predicted already
13:52
ohhhh
Avatar
trml 2021-10-26 13:53:15Z
it's not that hard to add door prediction, but getting it to work consistently when doors are added/removed from the snapshot is a little more work/thinking
13:53
since the code for doing something like that doesn't exist already (in the server doors are just static and created when map is loaded)
Avatar
fokkonaut 2021-10-26 13:54:22Z
yea
Avatar
Jupstar ✪ BOT 2021-10-26 13:54:57Z
what about this: https://github.com/ddnet/ddnet/pull/4245#issuecomment-951810850
Further fixes for cpu/zoom on large maps with entityex by trml · Pu...
Attempt to fix #4244 Added network clipping to entity ex for projectiles and pickups, and made snapping of gamecontroller happen before gameworld (as suggested in #4236), which should help when zoo...
Thumbnail
Avatar
deen 2021-10-26 13:55:02Z
Please no more new features for this release
Avatar
Jupstar ✪ BOT 2021-10-26 13:55:04Z
does it need a fix?
Avatar
Learath2 2021-10-26 13:56:18Z
@trml how do you handle the case where doors intersect?
Avatar
fokkonaut 2021-10-26 13:56:47Z
@trml i think its pretty easy to do, if we use a CDoor clientside too, like other entities
13:56
then they would only exist when the objects are there
Avatar
trml 2021-10-26 13:58:05Z
Jupstar: yes, it looks like the length of m_pSwitchers is actually m_NumSwitchers+1, while m_NumSwitchers is the last index
Avatar
GitHub BOT 2021-10-26 13:58:20Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
5d86646 Fix pickup network clipping - fokkonaut dbde2cc Merge #4253 - bors[bot]
13:58
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #4253 Fix pickup network clipping
Avatar
trml 2021-10-26 14:00:06Z
@Learath2 yes, that part wouldn't be trivial, so didn't want to rush anything
Avatar
Learath2 2021-10-26 14:00:24Z
I wonder how we do it on the serverside
Avatar
Avatar
Learath2
I wonder how we do it on the serverside
fokkonaut 2021-10-26 14:01:28Z
doors that got created first get overriden
Avatar
Learath2 2021-10-26 14:01:37Z
Lol what?
Avatar
trml 2021-10-26 14:01:41Z
I think the server just overwrites the tiles in CCollision when the map is loaded, so CDoor doesn't actually do anything after that
14:01
so doors can overwrite each other, etc (I think, at least)
Avatar
fokkonaut 2021-10-26 14:02:17Z
@Learath2 yes, crossing two doors of different numbers can create a hole where the cross, when the one only is deactivated
14:02
crossing of the same numbers dont matter (edited)
Avatar
Learath2 2021-10-26 14:02:37Z
The people who made ddrace initially collectively thought about 10 seconds on the problem
Avatar
fokkonaut 2021-10-26 14:02:53Z
xd
Avatar
Learath2 2021-10-26 14:04:54Z
I was thinking of an elaborate solution like generating a linked list of intersecting doors we can loop thru to figure out when to remove the collision
Avatar
fokkonaut 2021-10-26 14:05:30Z
have fun :D
14:05
its not nice code to work with at all
Avatar
Learath2 2021-10-26 14:05:52Z
Cant fix it now. I bet there are runs abusing that fact
14:06
Anyway, atleast makes prediction easier
Avatar
fokkonaut 2021-10-26 14:06:44Z
I have created an ingame editor to place entities like pickups, doors and for the doors its really annoying to not fuck up existing doors
14:06
on add/remove
14:07
took a while to have all of that working fine
14:13
@heinrich5991 i am getting a little bit mad about the fact that my server keeps disappearing from the master list, do you know why that happens?
14:13
Server respons its registering just fine
14:14
Its not any firewall, since it happened with my old and new hoster
Avatar
deen 2021-10-26 14:14:32Z
I would appreciate some instructions for how to debug https masterserver issues like that too ^
14:14
at the moment it's a block box for me
Avatar
fokkonaut 2021-10-26 14:14:44Z
blocker
14:14
ban
Avatar
deen 2021-10-26 14:14:53Z
black*
Avatar
fokkonaut 2021-10-26 14:15:19Z
I also saw ddnet sevrers disappearing from time to time
14:15
they came back at some point
14:15
i have no idea what this is about tho
14:16
once a full brutal server disappeared while i was on it, i couldnt find it anymore, 5-10 min later it appeared again
Avatar
deen 2021-10-26 14:16:12Z
yeah, you're not the only one affected
Avatar
fokkonaut 2021-10-26 14:16:28Z
manually pinging these servers works fine
Avatar
GitHub BOT 2021-10-26 14:18:03Z
Author icon
trml
[ddnet/ddnet] Pull request opened: #4254 Use correct (larger) m_NumSwitchers bound
The bounds check in #4245 should have been one larger, since m_NumSwitchers is the last index for m_pSwitchers (while length is actually m_NumSwitchers + 1).

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no ...
👍 1
Avatar
Learath2 2021-10-26 14:39:30Z
I don't really know how best to debug https master issues that happen randomly like this either
Avatar
Jupstar ✪ BOT 2021-10-26 14:44:11Z
add more log?
Avatar
GitHub BOT 2021-10-26 14:44:25Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
4a8f18c Use correct (larger) m_NumSwitchers bound - trml 9d5c21e Merge #4254 - bors[bot]
14:44
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #4254 Use correct (larger) m_NumSwitchers bound
Avatar
Jupstar ✪ BOT 2021-10-26 14:45:00Z
i mean it should know that it doesnt contact the server anymore, or if its a logic bug, maybe allow a var that on fly can tell what servers are about to be pinged(even if not reached)
14:47
MACRO_CONFIG_INT(SvServerInfoPerSecond, sv_server_info_per_second, 50, 0, 10000, CFGFLAG_SERVER, "Maximum number of complete server info responses that are sent out per second (0 for no limit)")
14:47
couldnt it also be that you have a small dos and the master list gets ignored?
14:48
or have you made sure already that its not that
14:49
its only for clients i see, so thats why kog in the past sometimes didnt show clients on a ddos attack
Avatar
Ryozuki 2021-10-26 14:51:34Z
@trml i knew one day the numswitchers would be a problem again
14:51
monkalaugh
Avatar
Jupstar ✪ BOT 2021-10-26 14:51:50Z
rename it to NumSwitchersPlusOne
14:51
or MinusOne
Avatar
Ryozuki 2021-10-26 14:52:04Z
MinusOne
14:52
m_NumSwitchersNotLength
Avatar
trml 2021-10-26 14:52:33Z
yes, it would be more intuitive to have the length
Avatar
Ryozuki 2021-10-26 14:52:56Z
this fixed the crash?
14:52
or is that unrelated
Avatar
Jupstar ✪ BOT 2021-10-26 14:53:07Z
unrelated
Avatar
Ryozuki 2021-10-26 14:53:13Z
rip
Avatar
trml 2021-10-26 14:53:18Z
also, what if the number of switchers is 1? m_NumSwitchers = 0. or length = 0 -> -1
Avatar
Ryozuki 2021-10-26 14:53:19Z
wanted to see the RC
14:53
ye length is always 1
14:53
minimum
14:53
for some reason there is always one switcher
Avatar
trml 2021-10-26 14:54:44Z
oh, yes, we always add one more, so it kind of always works
Avatar
GitHub BOT 2021-10-26 14:55:02Z
Author icon
bors[bot]
[ddnet:master] 3 new commits
73a6be0 Update language files for 15.6 release - def- 33865bc Translate German - def- 5cd47e5 Merge #4252 - bors[bot]
14:55
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #4252 Update language files for 15.6 release
Avatar
Jupstar ✪ BOT 2021-10-26 14:57:23Z
lmddracecodeo
Avatar
Ryozuki 2021-10-26 15:08:47Z
translating from english to any latin based lang is hard
15:08
cuz english uses to much tech stuff
15:09
i dont even use my native lang in ddnet client
15:09
but well i like translating it
15:10
i also use english so much i forget the words in my native language
15:10
monkaS
Avatar
Jupstar ✪ BOT 2021-10-26 15:11:38Z
its also that alot of words sound so bad in native languages xD
15:11
map would translate to "Karte" in german. Sounds so shit xDDD
15:12
like you try to find a way without navigation system
15:13
lets play a Karte lets play a card xDDDDDDD
15:13
it has two meanings
Avatar
GitHub BOT 2021-10-26 15:14:24Z
Author icon
edg-l
[ddnet/ddnet] Pull request opened: #4255 update catalan

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
Jupstar ✪ BOT 2021-10-26 15:16:27Z
maybe Spieldfeld would be better, but also uses much more letters than "map"
Avatar
GitHub BOT 2021-10-26 15:16:34Z
Author icon
def-
[ddnet-web:master] 1 new commit
9134a6d Update translations - def-
Avatar
Avatar
Jupstar ✪
its also that alot of words sound so bad in native languages xD
Ryozuki 2021-10-26 15:16:41Z
bugs in catalan means "insectes"
15:16
and nobody uses this
Avatar
Jupstar ✪ BOT 2021-10-26 15:17:15Z
ok but this is special case :D, bcs bug actually means bug
Avatar
Ryozuki 2021-10-26 15:17:25Z
monkaS
Avatar
Jupstar ✪ BOT 2021-10-26 15:17:26Z
its also "wrong" in english
Avatar
Ryozuki 2021-10-26 15:18:25Z
nah
15:18
in english has the meaning of software bug
15:19
if you say "he trobat un insecte al meu codi!" (i found a bug in my code!) (edited)
15:19
people will look u weird imho
15:19
xddd
Avatar
Jupstar ✪ BOT 2021-10-26 15:19:46Z
"In 1946, when Hopper was released from active duty, she joined the Harvard Faculty at the Computation Laboratory where she continued her work on the Mark II and Mark III. Operators traced an error in the Mark II to a moth trapped in a relay, coining the term bug. This bug was carefully removed and taped to the log book. Stemming from the first bug, today we call errors or glitches in a program a bug"
Avatar
Ryozuki 2021-10-26 15:20:02Z
bluekitty
Avatar
Jupstar ✪ BOT 2021-10-26 15:20:24Z
thanks little moth xD
Avatar
Ryozuki 2021-10-26 15:20:58Z
well computers back then were rly big right
15:20
xd
15:21
was bound to happen
Avatar
Jupstar ✪ BOT 2021-10-26 15:21:11Z
:D
Avatar
GitHub BOT 2021-10-26 15:26:58Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
98789d1 update catalan - edg-l 83a5f4e Merge #4255 - bors[bot]
15:27
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #4255 update catalan
Avatar
GitHub BOT 2021-10-26 16:53:59Z
Author icon
def-
[ddnet-web:pr-15.6] 1 new commit
2394bfb Version 15.6 - def-
Avatar
Ryozuki 2021-10-26 16:57:09Z
Image attachment
16:57
Image attachment
16:57
@deen is there a reason for the margin?
16:57
(bottom is the actual)
Avatar
Avatar
Ryozuki
for some reason there is always one switcher
fokkonaut 2021-10-26 16:57:47Z
switcher 0, from game layer
Avatar
Ryozuki 2021-10-26 16:58:39Z
ah its cuz its applied globally
Avatar
fokkonaut 2021-10-26 16:58:40Z
also very stupid: game and front layer doors dont work if switch layer doesnt exist, probably known by many already tho
Avatar
Ryozuki 2021-10-26 16:58:46Z
maybe i can disable the margin for the changelog specifically
Avatar
Avatar
fokkonaut
switcher 0, from game layer
Ryozuki 2021-10-26 16:58:56Z
ah ok
Avatar
GitHub BOT 2021-10-26 17:00:46Z
Author icon
edg-l
[ddnet/ddnet-web] Pull request opened: #152 make the News text be on a block too
17:03
Author icon
edg-l
[ddnet/ddnet-web] Pull request opened: #153 fix changelog li margin
Avatar
Ryozuki 2021-10-26 17:04:30Z
greenthing
Avatar
Jupstar ✪ BOT 2021-10-26 17:10:10Z
when add colors, client yellow, server red, editor green xdd (@Ryozuki)
Author icon
Ryozuki
unknown.png
Image
2021-10-26 16:57:13Z
17:11
and names also in colors, i want purple
17:11
but a dark purple, not a light one
Avatar
Avatar
Learath2
There is one more file you need from ddnet.tw, the releases file. Idk the url for that either
HappyFray 2021-10-26 17:15:06Z
still no idea.
Avatar
ṨtylerTime 2021-10-26 17:17:12Z
https://ddnet.tw/releases/
17:17
?
17:17
https://maps.ddnet.tw/
Avatar
Avatar
fokkonaut
@heinrich5991 i am getting a little bit mad about the fact that my server keeps disappearing from the master list, do you know why that happens?
heinrich5991 2021-10-26 19:24:42Z
can you give me a pcap from a time where that happens?
Avatar
Avatar
deen
I would appreciate some instructions for how to debug https masterserver issues like that too ^
heinrich5991 2021-10-26 19:26:35Z
a pcap on the serverside would also be interesting. alternatively, one could log very verbosely with RUST_LOG=debug
19:27
the log option is probably not realistic, it's probably too much data
Avatar
Learath2 2021-10-26 19:31:34Z
mh, are the outages long enough that getting a pcap is viable?
Avatar
heinrich5991 2021-10-26 19:31:57Z
could also get a pcap and wait for an outage
Avatar
Avatar
Ryozuki
@deen is there a reason for the margin?
deen 2021-10-26 20:20:17Z
i think it looks too cramped without
Avatar
aodq 2021-10-26 20:25:44Z
i like that the word 'bug' and also how it was originally found, makes the onus of the error put on an external force. 'Yes, there is a bug in my software' as if it's some external force of nature outside anyone programmer's control.
Avatar
heinrich5991 2021-10-26 20:29:47Z
I don't think of an insect when I say bug, I seem to view the word similar to defect
Avatar
GitHub BOT 2021-10-26 20:34:46Z
Author icon
def-
[ddnet/ddnet-web] Pull request closed: #152 make the News text be on a block too
20:34
Author icon
def-
[ddnet-web:master] 2 new commits
b333833 make the News text be on a block too - edg-l 8a1c981 Merge pull request #152 from edg-l/pr/fix/news - def-
Avatar
ṨtylerTime 2021-10-26 21:03:12Z
when im hosting 2 servers with ddnet-server, is there a easy way to connect bans?
21:03
like when i ban someone on the first he also gets banned on the second one
Avatar
deen 2021-10-26 21:05:10Z
no
Avatar
ṨtylerTime 2021-10-26 21:08:01Z
where do self hosted server store the bans?
Avatar
deen 2021-10-26 21:13:27Z
I don't know, we use something like a globalbans.cfg for official ddnet servers
Avatar
Avatar
ṨtylerTime
where do self hosted server store the bans?
HappyFray 2021-10-26 21:18:31Z
The server ban list is not stored on the hard drive. Type "bans" in F2. they are pretty deep in the engine
21:20
with bans_save you can save it to a file
Avatar
aodq 2021-10-26 23:01:12Z
yeah if they're saved to different files, then you could just merge them manually with a python script set(server1Banlist.readlines() + server2Banlist.readline())
Exported 318 message(s)