DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2021-10-18 00:00:00Z and 2021-10-19 00:00:00Z

how does cmake work :c

12:38

does order matter when i want to link a lib?

12:38

cant feed md5 as dependency to the auth manager :c

Ofc the order matters when linking

12:38

Sometimes :D

:D

12:41

image.png

Image attachment

12:41

i mean all md5 occurences looksi fine

12:41

so it has to be the order

I mean we already link it properly in ddnet, maybe just check that?

right is ddnet

12:42

i just cant find the diff to my crappy forks cmakelist

12:42

what to look at

12:42

everything i look at is the same

12:42

except the position in the file

I dont exactly remember where we build authmanager, maybe ENGINE_SERVER

yes

So did you add md5 as a dep to engine server target?

how

Yeah idk, I'm on phone

set(DEPS ${DEP_SQLITE3} ${DEP_JSON} ${DEP_MD5} ${ZLIB_DEP}) add_executable(${TARGET_SERVER} ${DEPS} ${SERVER_SRC} ${SERVER_ICON} $<TARGET_OBJECTS:engine-shared> $<TARGET_OBJECTS:game-shared> )

12:44

i did that

Hm, show error maybe?

/usr/bin/ld: authmanager.cpp:(.text+0x552): undefined reference to `md5_append'

Mh

I added md5 years ago already and got it working in hash_bundled.c

12:47

it works there but not in the new authmanager

12:47

cmake is so unclear to me

Yeah the only one who understands cmake is heinrich :D

time to bruteforce then

i'd start with message(FATAL_ERROR "Test ${DEPDS}")

12:56

then you know what the content of DEPS is

12:57

Edit: i'd start with message(FATAL_ERROR "Test ${DEPS}")

smort

12:57

i like log driven debugging :D

12:58

Test $<TARGET_OBJECTS:sqlite3>;$<TARGET_OBJECTS:json>

12:58

hue

12:58

where did md5 go

rip

set(DEP_SQLITE3 $<TARGET_OBJECTS:sqlite3>) set(DEP_JSON $<TARGET_OBJECTS:json>) set(DEP_MD5)

12:59

i guess it makes sense

12:59

its set to nothing

13:00

weird that it worked for the files in base/ tho

13:01

if i add set(DEP_MD5 $<TARGET_OBJECTS:md5>) it breaks because then i get it defined twice for the base stuff omawgd

13:01

can this be a c vs c++ thing?

if(NOT CRYPTO_FOUND)
  set(DEP_MD5 $<TARGET_OBJECTS:md5>)
endif()

yee saw tha

i guess if you have crypto you shouldnt also define MD5

13:04

have you tried to delete CMakeCache, solves all problems xd

yas

find_package(Crypto)

13:08

did you remove it?

more like never added it xd

13:08

nah but i got it

do you meantion authmanager.cpp somewhere?

?

what do you even compile, ddnet or own project?

ddnet++

13:12

own

is authmanager in the server source?

yes

mhh, maybe you somehow changed the order of libs somewhere?

13:13

normally you append the libs you need for each cpp object after you mention it

13:14

is your repo up to date?

haha

i mean can i compile it

13:14

and have the same error xD

?

13:15

oh u mean pushed to github?

yes

nah

its easier than guessing xd

its in no pushable state :D

13:15

i currently try to crack in latest cmakelists from ddnet master

push it into your chillerdragon github

13:16

i can clone it from there

im in the middle of merge conflict :D

13:16

gimme sec finish this try

13:23

i slowly feel like its a src not a cmake issue

13:27

Jupstar ✪: pushed to master https://github.com/DDNetPP/DDNetPP🤭

You're invited to talk on Matrix

You're invited to talk on Matrix

how did you even get to the linking step xD

ah right

13:31

first u gotta run "bam"

13:31

then cmake

13:31

:D

bam5?

yes

13:32

or 4

13:32

both should work

biggest troll

ikr

tbh i think its broken in ddnet repo too

13:45

ddnet just doesnt use md5_append

yea i think so too

13:46

im currently trying to crack in latest crypto code into old ddnet

i guess you are supposed to use md5_update

13:47

// Hash the password and the salt
	MD5_CTX Md5;
	md5_init(&Md5);
	md5_update(&Md5, (unsigned char *)pPassword, str_length(pPassword));
	md5_update(&Md5, aSalt, SALT_BYTES);
	return md5_finish(&Md5);

example ddnet code

13:47

so not broken, just missused

image.png

Image attachment

13:49

ich bin ein junger gott

13:49

thanks a lot Jupstar ✪ :)

You're invited to talk on Matrix

You're invited to talk on Matrix

13:50

wtf it doesnt even segfault nor does it break rcon

13:50

not bad

it mixes bam and cmake and works

13:50

thats more impressive

haha yea :D

but i guess just for the generated sources? :D

yes

13:51

but now since i have new cmake

13:51

i might not need bam anymore

13:51

lets see

13:51

yup i just casually droped bam dependency

@murpi: still get an occasional weapon switch when switching dummy any idea?

Nope :/

u dont have it?

No, I don't

unfair

Does anyone else have issues with alt-tabbing with console open on nightly makes the cursor invisible?

no cuz alt tabbing doesnt exist in my linux (edited)

16:17

f1 console? (@murpi)

Does anyone else have issues with alt-tabbing with console open on nightly makes the cursor invisible?

yes

16:22

can't reproduce, but I had this like a couple of times today

are you on fullsreen or borderless or desktop fullscreen?

fullscreen

lol for me under windows it crashes when i join a server

I think I know what it is

16:26

copy pasting breaks the game

16:26

(ctrl+v)

past in console?

16:28

paste*

yes

16:31

ok thats not it

16:31

it's something else

16:35

Jupstar: are you on windows right now?

16:37

Start game > join any server > tab out > tab in > open console > tab out > tab in > cursor gone

16:38

(f1 console)

[ddnet/ddnet] Issue opened: #4227 DemoRecorder_HandleAutoStart causes insane lag (or probably endless loop)

I have alot of demos in windows(around 5k) so it might be that It happens when i join a server, so i dont open the demo view I'm not 100% sure what it tries todo, but looks like it wants to delete some files ``` DDNet.exe!fs_listdir(const char * dir, int()(const char *, int, int, void *) cb, int type, void * user) Zeile 2096 unter c:\users\c\desktop\teeworlds\ddnet\src\base\system.cpp (2096) DDNet.exe!CStorage::ListDirectory(int Type, const char * pPath, int()(const char *, int...

ok thx (@murpi)

Jupstar: are you on windows right now?

oh yeah shit xd

@deen: hey, a bit trouble for you, but can you rebuild all SDL shared libs with the forced push SDL pryou can also ignore the 2nd pr(the one with wayland over x11) since we dont use it yet anyway

burh notch on laptop is so dumb

17:50

Image attachment

17:50

who asked for this

since it was released, apple fans asked for it

i actually wanted a new apple sillicon macbook tho

18:00

this is so hard to look at.

omfg i can't get over how ugly it is

imagine it hiding timer in tw

omfg youre right

lol I thought that laptop with a notch was edited before I looked it up xd

Jupstar: can you replicate it? ^^

is there a way to see my packet loss % ?

yeah i fixed it :D (@murpi)

Jupstar: can you replicate it? ^^

20:11

thanks for exact reproduce steps, then its really ez :D

Aaah, thanks for fixing it

Cipy29

is there a way to see my packet loss % ?

Ping Plotter or traceroute manually with terminal

thx

Jupstar windows user confirmed

[ddnet/ddnet] Issue opened: #4228 Mouse is captured if f1 is open and the mouse is moved out of the window and into it again

Steps to reproduce: 1) Open local console f1. OS mouse cursor appears. 2) Move mouse cursor out of the window. 3) Move the mouse into the window again. OS mouse cursor disappears and is now stuck inside the window. OS: Arch Linux with window manager i3. Probably related to #4095?

Jupstar ✪

@deen: hey, a bit trouble for you, but can you rebuild all SDL shared libs with the forced push SDL pryou can also ignore the 2nd pr(the one with wayland over x11) since we dont use it yet anyway

on my way

[ddnet-libs:master] 1 new commit

916e5d4 Update SDL2 with new pull request states - def-

that affects all SDL versions btw @deen :/

oh

21:05

somehow I thought we only build SDL2 for windows, my bad

21:08

Now I'm confused where the SDL2 version for mac comes from

21:08

It's not in my build script

:o

21:08

we could also automate lib building probably, like i did for android

21:09

ok i dunno how to build for macos, if thats hard

21:09

or do you do that anyway

I think for mac I just used http://www.libsdl.org/release/SDL2-2.0.16.dmg

21:12

well, older versions of that

well without the SDL patch the worst case is that the cursor is not visisble while hovering over ddnet client, so its too insanly bad, just also not perfect (e.g. having fullscreen desktop and not knowing where your cursor is if ddnet is in the background XD)

yep, confirmed

21:14

I don't know how to build the dmg, I can give it a try

building dmgs without a mac is probably hard if sdl doesn't have explicit support for cross compiling

I guess I never tried since the release dmg always worked for us

yeah thats why i thought maybe a CI buillding the libs can help

21:17

but i dunno, in the cmakelists there are weird macos hacks, so i cant judge xD

Seems like the DMG build is only available through some xcode pbxproj

21:20

maybe I can fumbly things together manually

@heinrich5991: just to be clear, you did use the RC?

I used steam's RC

ok :D

[ddnet/ddnet-libs] New branch created: pr-sdl

21:25

[ddnet-libs:pr-sdl] 1 new commit

7ae4e44 Also try to update SDL2 libs on Linux and Mac - def-

21:25

[ddnet/ddnet-libs] Pull request opened: #19 Also try to update SDL2 libs on Linux and Mac

Untested, especially Mac

@heinrich5991: another question since you use a different WM than me and deen In menus with RC, when you play windowed mode, how does the mouse behave, does it get stuck if you reach the window borders, or does it just move freely

simply in menus?

21:31

or ingame?

yeah in menus only, and i dont mean if it leaves the game

21:31

but if the mouse cannot be dragged down up, as soon as you hit the borders

it doesn't leave the game window in menus

21:32

hm

21:32

it says "desktop fullscreen" in the settings

wait i send a video

but doesn't change when I do "windowed"

test.mp4

that's what happens for me

ok good

21:33

strange :/ (@heinrich5991)

heinrich5991#9827

but doesn't change when I do "windowed"

21:34

in windowed mode it should be freely resizable and movable

I wanted to say that the behavior of the mouse doesn't change when I try to move the mouse out of the window (desktop fullscreen vs windowed)

oh ok :D

21:35

ah ok i only have 1 screen

21:35

so maybe that confused me xD

but my window manager isn't really interested whether the game claims it's fullscreen or not

21:35

I can make it fullscreen/windowed in either case

desktop fullscreen is like fullscreen for me :D

21:36

oh ok

[ddnet-libs:pr-sdl] 1 new commit

f1905b3 Also try to update SDL2 libs on Linux and Mac - def-

21:52

[ddnet/ddnet-libs] Pull request closed: #19 Also try to update SDL2 libs on Linux and Mac

21:52

[ddnet-libs:master] 2 new commits

f1905b3 Also try to update SDL2 libs on Linux and Mac - def- 381d44a Merge pull request #19 from ddnet/pr-sdl - def-

21:52

[ddnet/ddnet] Pull request opened: #4229 Update SDL2 with new pull request states (fixes #4228, fixes #4095)

As requested by @Jupeyy in #4228

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/dd...

I'll build 15.6-rc2 now with the new sdl

thanks, i can also quickly test if the macos build still works

yeah, would be great

21:56

Help, hoster can't tell apart incoming from outgoing traffic, now they think we were attacking instead of getting attacked...

ouch

This looks pretty obvious to me (from https://ddnet.tw/stats/server/#tur2.ddnet.tw), but it's honestly not the first hoster that mislabeled in/out in their internal systems

Image attachment

maybe they do it for legal reasons(/to be safe)? i also had this once, and had to agree, that i am not dosing others

have you sent that graph to the people?

yes

oof, that's logarithmic scale

22:00

anyway, I'm out. good night

gn8

[ddnet-scripts:master] 1 new commit

3f03f00 Add SDL2 instructions for mac - def-

22:20

[ddnet:master] 2 new commits

4c750bc Update SDL2 with new pull request states (fixes #4228, fixes #4095) - def- f0ef018 Merge #4229 - bors[bot]

22:20

[ddnet/ddnet] Issue closed: #4228 Mouse is captured if f1 is open and the mouse is moved out of the window and into it again

22:20

[ddnet/ddnet] Pull request closed: #4229 Update SDL2 with new pull request states (fixes #4228, fixes #4095)

Exported 231 message(s)