DDraceNetwork

i dont know if this is done on purpose but if you add spaces to a name it still counts as if it is the same name

4

Oh certainly troll

, I had said months ago that the client sees some letters as the same and if someone comes with Coke on the server is still a (1) in front of it.... Although I have a special letter (edited)

2

qweeeeeeed

i dont know if this is done on purpose but if you add spaces to a name it still counts as if it is the same name

There are different sized space characters and some are so small that you could effectively fake names, I guess all whitespace is ignored to be sure

hm, spaces? I didn't think it happened with standard whitespace

11:04

I thought we only did it with those invisible whitespace characters

@heinrich5991 hm, the confusables table doesn't seem to have any transformation for SPACE, but our generated confusables_data says it has 0 length

we ignore all whitespace for confusable comparison

14:14

https://github.com/ddnet/ddnet/blob/b2efcb8ba4de40df6b1c6ea716c7cbb014471f17/scripts/generate_unicode_confusables_data.py#L23-L26 @Learath2

ddnet/generate_unicode_confusables_data.py at b2efcb8ba4de40df6b1c6...

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/generate_unicode_confusables_data.py at b2efcb8ba4de40df6b1c6ea716c7cbb014471f17 · ddnet/ddnet

heinrich5991

https://github.com/ddnet/ddnet/blob/b2efcb8ba4de40df6b1c6ea716c7cbb014471f17/scripts/generate_unicode_confusables_data.py#L23-L26 @Learath2

@heinrich5991 is that sane? I think normal whitespace should be considered

@Learath2 comes from here: https://github.com/ddnet/ddnet/commit/771eb1a62561091e925bc723f42d03e849b02a40

14:29

(dug that up while trying to understand why it was there)

Hm, well I think we should only be disregarding the weird whitespaces, not proper ascii whitespace

there are whitespaces of varying widths. with the current system, we'd have to decide on a width from which on we treat it as a simple ASCII space. it sounds like it needs more complicated treatment

14:32

another observation: false positives aren't so bad in this system

if u put a space at the end or beginning it could look the same

How about we pretend all weird spaces are 0 len, and only treat simple ascii spaces as spaces?

then a name with ascii space and name with a weird space of correct length look the same but aren't marked as confusable

mh, no simple solutions

when i select something in the external console (cl_show_console 1) doesnt matter how long and than try to to connect to a server the game freezes. Im using the https://ddnet.tw/news/nightly-build-revived/ version tho, as u can see from the screenshot [2021-10-05 18:42:01][client]: version 0.6 626fce9a778df4d4

is that on windows? I think that behavior is known and not really fixable

16:51

https://github.com/ddnet/ddnet/issues/3925

16:51

ah, Learath2 proposed a fix

heinrich5991

is that on windows? I think that behavior is known and not really fixable

jup windows

you can copy the selection by pressing enter, the client should unfreeze then

thanks