DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2021-09-18 00:00:00Z and 2021-09-19 00:00:00Z

- Bonobobo

which one is the file with ingame commands?

ddracechat.h and ddracechat.cpp, aswell as gamecontext.h

last one , yes ty

02:08

are pull requests accepted by the DDnet team?

02:12

any idea where gamecontest.h is included throughout the fileS?

it's not the last one, it's all 3 btw. The commands callbacks are declared in gamecontext.h, they are implemented in ddracechat.cpp and the commands are registered in ddracechat.h

- Bonobobo

are pull requests accepted by the DDnet team?

Yep

- Bonobobo

any idea where gamecontest.h is included throughout the fileS?

It is included all over the place, it's the core of the game side of the server

I'm interested in the engine of "ConTeamRank" (edited)

02:17

or the teaamtop5 command

most of the magic for those happen in src/game/server/score.cpp

I suggested this in the KOG discord, but it should have been here

02:18

New command for /cmdlist Problem: All /teamrank's are stored in a database regardless of the fact that one player might have one or more scores from the past. Such scores are possible to retrive using a bruteforce aproach. "/teamtop5 i " where i is a number between 1 and the total amount of rank teams scores in said map, to know the max u must do it manually by givin it large numbers and scaling down until you find it. For player X to know all of his /teamrank from a specific map he must do it manually so, teamtop5 [1,n+5] until the limit of the 'array'. if the map has 2000 teamscores he must do said comand 2000/5 times. [01:09] Proposal: Add a command such as /teamrankall (username) for a user to be able to check all of the scores for said username [01:10] An improvement to /teamrank "username" would be for the increment of more inputs, give it 2 usernames or more and retrive, if there is, the score of said team

sounds interesting, you should probably create an issue for it before implementing anything so we can all have a bit of input to figure out the most ergonomic user experience

02:22

I would definitely be open to a pr that implements a fix to this annoyance

before all that, I need to reverse engineer the whole sourcecode

02:28

I mean, understanding how teamtop5 is retrived or even teamrank, its most likely all i need, a shortcut if u will, ofc the code won't be efficient

02:30

also the vote for pause or spec a player doesn't do a thing

02:32

CTRL+SHIFT+D could have a better UI, it's terrible the way it pops up, adding in the setting tab some preferences on what to see and 'where to' see it its quite beneficial.

Ñ

[ddnet-maps:master] 1 new commit

89900fa A Bowling, M Lavender Forest, A Jajpack - ddnet-maps

https://www.phoronix.com/scan.php?page=news_item&px=Mesa-Rust-2021-Experiment

Experimenting Is Underway For Rust Code Within Mesa

07:14

monkalaugh

pepeH

monkalaugh

- Bonobobo

But in the source files

ddracechat.h probably

when new version

08:36

feelsbadman

https://www.phoronix.com/scan.php?page=news_item&px=Red-Hat-Hiring-For-Linux-HDR

Red Hat Is Hiring So Linux Can Finally Have Good HDR Display Support

09:39

nice

Ryozuki

when new version

Someone created a milestone, so I guessed I shouldn't release a new version until these are all in: https://github.com/ddnet/ddnet/milestone/7

DDNet 15.6 Milestone · ddnet/ddnet

DDraceNetwork, a cooperative racing mod of Teeworlds - DDNet 15.6 Milestone · ddnet/ddnet

@Deleted User get to work monkalaugh

monkalaugh

most are waiting for new SDL version xD

10:50

#4154 can be removed i guess

https://github.com/ddnet/ddnet/issues/4154

Fix shell injection in open_link · Issue #4154 · ddnet/ddnet

Since we pass untrusted file system paths to it, this is a security vulnerability.

and someone has to review and merge #4166

https://github.com/ddnet/ddnet/pull/4166

Only set ddrace tunes, if ddrace tiles should be predicted by Jupey...

fixes #4140 Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test if it works s...

@Ryozuki your work xd

monkaS

nuborn reviewed it already anyway xd

Image attachment

10:56

justatest

yeah we ended up using a completly different fix anyway

libpng gets 1 year soon

11:07

the pr xd

xd

wtf when i click the last commit in https://github.com/ddnet/ddnet/pull/3407 it redirects me to an issue link (404) (edited)

ok happens everywhere xd

exactly 1 year ago

Image attachment

[ddnet/ddnet] Issue closed: #1033 f1 as non-editable, selectable (with cursor) text field?

@Deleted User https://github.com/libsdl-org/SDL/pull/4306 doesn'T build for me:

CFLAGS=-fPIC make -j4
  GEN    gen/idle-inhibit-unstable-v1-client-protocol.h
  GEN    gen/keyboard-shortcuts-inhibit-unstable-v1-client-protocol.h
usage: ./scanner [client-header|server-header|code]

Converts XML protocol descriptions supplied on stdin to client headers,
server headers, or protocol marshalling code.
usage: ./scanner [client-header|server-header|code]

Converts XML protocol descriptions supplied on stdin to client headers,
server headers, or protocol marshalling code.
Makefile:861: recipe for target 'gen/idle-inhibit-unstable-v1-client-protocol.h' failed
make: *** [gen/idle-inhibit-unstable-v1-client-protocol.h] Error 1
  GEN    gen/pointer-constraints-unstable-v1-client-protocol.h
make: *** Waiting for unfinished jobs....
Makefile:873: recipe for target 'gen/keyboard-shortcuts-inhibit-unstable-v1-client-protocol.h' failed
make: *** [gen/keyboard-shortcuts-inhibit-unstable-v1-client-protocol.h] Error 1
usage: ./scanner [client-header|server-header|code]

Converts XML protocol descriptions supplied on stdin to client headers,
server headers, or protocol marshalling code.
  GEN    gen/relative-pointer-unstable-v1-client-protocol.h
Makefile:885: recipe for target 'gen/pointer-constraints-unstable-v1-client-protocol.h' failed
make: *** [gen/pointer-constraints-unstable-v1-client-protocol.h] Error 1
usage: ./scanner [client-header|server-header|code]

Converts XML protocol descriptions supplied on stdin to client headers,
server headers, or protocol marshalling code.
Makefile:897: recipe for target 'gen/relative-pointer-unstable-v1-client-protocol.h' failed
make: *** [gen/relative-pointer-unstable-v1-client-protocol.h] Error 1

[DONOTMERGE] video: Prefer Wayland over X11 by flibitijibibo · Pull...

This is a draft patch that will (at last) prioritize the Wayland video driver over X11. This is here purely for internal testing only and is NOT meant for wider community testing; to test SDL Wayla...

and its bcs of that commit?=

The error message comes from wayland-scanner, so I guess

it looks like this commit just changes the order not really any content

ah

mhh is that the CMake build?

nope, ./configure and make

strange that this commit causes it, looks like its really just swapping the order

Yeah, maybe not the commit, but it's a wayland error

maybe cmake is safer

12:20

since it tells you what packages are missing

I don't know how to cross-compile with cmake

12:20

but I can try

i just use the toolchains we use in ddnet too

12:21

atleast for windows they work fine

ok, figured it out. the wayland-scanner version is so old that it has to be used with < and > instead of params

12:42

maybe I have to upgrade debian

oh

12:43

sry for trouble xd

no trouble

Did you see https://frame.work ? I might get one if they make ryzen versions

Framework Laptop pre-orders are now open

Framework Laptop: upgradeable, repairable, and 100% yours. Starting at $999, with a fully refundable $100 deposit, place your pre-order now

i want arm laptop that is good

12:53

so its not empty after 1h use xd

well the m1 macs are as good as it gets for now, they will get a new gen soon iirc and intel was also scheduled to come out with a hybrid core architecture. So soon we'll have alternatives

yes, m1 is nice

12:55

just needs a different brand to ship them

12:55

and i dont mean the processor itself

12:55

like an asus laptop just with apples m1

don't think anyone has arm processors strong enough yet and I highly doubt apple wants to sell their ticket to profits for years

yeah sadly

[ddnet-scripts:master] 1 new commit

081984e Update libs - def-

@trml if #4108 gets merged, do you also want to try to implement the predicitions for that for the next release? Else it's not that useful is it?

https://github.com/ddnet/ddnet/pull/4108

Send extended entity info by trml · Pull Request #4108 · ddnet/ddnet

For prediction of bullets and moving pickups in switch layer (#3990). This sends the info in a separate netobject (as proposed in #4102), as an alternative to adding new netobjects/fields for each ...

@Deleted User yeah, predictions would be a separate pr

ok, i dunno how long it takes, thats why i asked if you want to try it for the next release

I might have something for that this weekend, but if you want to do a release soon I'm also ok with waiting for the next one

yeah hard to say when we'll release, but no hurry

ok^^ either way I think it would perhaps be a good idea to get the extended netobject and prediction in the same release, yes

In worst case i'll remove it from milestone, so no hurry

It'd be nice to get the protocol extension and it's use in the same patch so we can test and see if the extension is enough or if we want more

13:21

It's still impossible to extend further after we have a release without some very ugly workarounds

yeah thats true

true

13:30

u talking about switch pred?

yeah. I first thought having two different prs would be the cleanest, but I suppose i could just add it to the pr

13:30

yes

13:31

for projectiles/pickups and other things that require the extra extended netobject (switch number, etc)

you can make it a new pr and base it off of the other one if you want

yeah, I can do that, so it can be tested before the protocol change is merged

Learath2

It's still impossible to extend further after we have a release without some very ugly workarounds

but in worst case rename extension to @v2 and then older clients arent supported anymore xdd

ew

Learath2

Did you see https://frame.work ? I might get one if they make ryzen versions

is there any difference between this and normal modern laptop? both have soldered CPU, integrated and nonstandard battery, no board schematics available, proprietary firmware

14:29

RAM modules, SSDs and WiFi module are still more or less replaceable today

Well they committed to providing board schematics to interested repair shops, they gave out cad files for the chassis so you can print it. At this form factor all their competitors are almost completely integrated

14:30

Microsoft surface comes with glued on chassis. Apple solders their ssds. Dell comes with soldered ram

raspberry > propietary hardware laptop

14:31

greenthing

Learath2

Microsoft surface comes with glued on chassis. Apple solders their ssds. Dell comes with soldered ram

true, it's slowly getting worse and worse

With this one each module is changable, you just don’t get to change the cpu and mainboard

lol that sucks

14:31

changing the cpu is what i would want most

14:31

specially in a laptop

Learath2

With this one each module is changable, you just don’t get to change the cpu and mainboard

ideapad rulz

well im anti laptop anyway

14:32

i dont use any

2

Cmon, it’s better than anything out there, except for a couple clevo mainboards using downclocked desktop cpus to let you replace them

Ryozuki

well im anti laptop anyway

I’d guess you don’t travel

nah

14:32

xd

ryositter

i dont travel outside catalonia

14:33

greenthing

true laptops suck, but my room sucks too, so its a compromise xd

Ryozuki

i dont travel outside catalonia

i don't travel outside russia too kek

kek

14:33

but russia is large af

@gerdoe lol nobo

14:33

i never went into spain

14:33

btw

14:33

and im from "spain"

14:33

i refuse to visit this filthy country kek

Anyway, I appreciate any move towards a more repairable future. My thinkpad is fairly user serviceable but you need a fair bit of experience messing around with it as there are dozens of screws to get to most things. I like that they made it much easier

i want this for phones

14:34

my battery is slowly dieing

14:34

and fairphone hardware is soo dated

only trust this https://www.fsf.org/resources/hw/systems/?set_language=da

Deleted User

i want this for phones

The day samsung killed replacable batteries was so sad

F

https://ryf.fsf.org/

14:35

this i mean

They killed the damn headphone jack to help the bluetooth headphone industry too

is there any button nokia user?

Then they lied about both saying it was for “water resistance”

aight ima drop the laptop into water

The S5 had an ip67 rating, with a user replaceable battery and a headphone jack

Learath2

The day samsung killed replacable batteries was so sad

yeah idk why they removed those

15:10

were so cool

One word: Capitalism

15:12

It’s more profitable for the shareholders if you have to throw away your flagship phone after 2 years of use because its/ battery won’t last anymore (edited)

apple offers battery replacement, and its not that expensive

As if anyone is okay with 3-5 business days for a battery replacement

Image attachment

16:27

If you are lucky to live near an apple store, you can get it replaced within the day though

Just use a cheap ass phone in the meanwhile

So let me get this straight, I pay 90$ out of pocket for a 20$ battery, find another phone to use for 3-5 business days, for something that might not even fix the issues I'm having

16:36

Sounds extremely consumer friendly, if only there was a way for the consumer to just replace the battery themselves. Something like a, uhm what were they called "removable back cover"?

16:39

The best part about these battery replacement programs is that the only reason they exist was because apple got caught slowing down older iphones for the consumers "safety"

Is this the moment you’re realizing we’re living in capitalism?

Not really?

16:43

Apple offering battery replacements after being threatened by a class action lawsuit is not some redeeming moment for them is my point

It is how it is

It doesn’t have to be

Alot of things don’t have to be how they are

16:48

But they are how they are

16:48

Am I not right?

Are you a demotivation trainer? XD

im from japan

owo

You can simultaneously hold both views you know

16:55

Things are how they are, doesn’t imply we can’t change anything

ye

I do have multiple views

16:57

You just need to find the balance

16:57

Or you’ll drift down a dark alley

@Learath2 did u see the news about oil companies suing goverments for 10+ billions for climate change laws that lowered their income

16:58

its insane

16:58

the same ppl that destroy the earth ask money from govs

Its the top 1% of the world that crave the most money

16:59

Its like watching a bad comedy show

just give co2 a correct price and oil companies die by themself

https://www.reddit.com/r/worldnews/comments/pperzs/fossil_fuel_companies_are_suing_governments/

r/worldnews - Fossil fuel companies are suing governments across th...

27,752 votes and 2,382 comments so far on Reddit

17:00

Fossil fuel companies are suing governments across the world for more than $18bn | Climate News

17:00

Image attachment

None of this can be fixed while we allow government officials to be “lobbied”

obviously the sue wont be a success but it costs shitload of time and money for the legal fees

17:01

for the goverment

17:01

which could have been put to other things

Meh, it is quite shameless to sue after you are given everything you could ever want

17:04

But if hypercapitalists had any shame or humanity we wouldn’t be here anyway

feelsbadman

Learath2

But if hypercapitalists had any shame or humanity we wouldn’t be here anyway

right asf

17:05

no comments

Anyway, fairly off-topic as always. Are we any closer to the release?

@heinrich5991 the update on finishing if everybody crossed the startline makes my map TeeInvader unfinishable

17:07

I have to update it now

17:08

can anyone update maps ?

If you can fix it please submit a new version

ok I'll try to do it fast

Any admin can update the map

greenthing

Oh it got released right now toon

17:09

Nooo, this will be so painful to replace with everyone playing it :/

isnt it a fun map?

17:10

why would u care if ppl are playing

Need to restart servers by hand then

admiralMC

gtg, food, ping me when you have a fix @Pipou

i have a fix

17:11

I'll send it to you

17:12

tell me when it's done so we can reload the map

17:16

@Learath2

@Pipou finished uploading

yeah thanks

17:22

is it possible to reload the servers?

17:22

I mean, with the map on them

let me see

@Learath2 https://www.phoronix.com/scan.php?page=news_item&px=AMD-P-State-XDC2021

AMD + Valve Focusing On P-State / CPPC Driver With Schedutil For Be...

17:23

valve goat

17:23

AMD + Valve Focusing On P-State / CPPC Driver With Schedutil For Better Linux Efficiency

17:24

As reported at the start of August, AMD and Valve have been working on Linux CPU performance/frequency scaling improvements with the Steam Deck being one of the leading motivators

17:24

thanks steam deck

[ddnet/ddnet] Pull request opened: #4173 Add ResultStr() to http

Adds ResultStr() which returns a null terminated string. So the http code can be used to do plaintext requests not only json.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing map...

@Pipou I think that was all servers

oh ok thanks @Learath2

17:33

I made the map a long time ago, never thought about that update (edited)

I can't parse this sentence

Well you can probably understand the meaning though

@heinrich5991 sorry I corrected it

[ddnet/ddnet] Pull request opened: #4174 Fixed typo in variable name

Fixed typo 'Automic' --> 'Automatic' in graphics_threaded. I thought i made a comment on the PR (https://github.com/ddnet/ddnet/pull/4160), but seems like i didnt send it in the end.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array in...

is github broken?

18:50

i cant access commits on PR

yes

always says 404

its really annoying xD

18:50

i clicked on that like 10 times today already

damn

you can still click on files changed

18:51

to view them

ah thx for the tip

18:56

@Deleted User did you add to redo bors r+ because i commented?

no, i dunno why the first didnt work

18:57

maybe github is really buggy rn xD

i guess yup

18:57

useless question: shouldn't we use nullptr instead of NULL?

personally idc

but we still use 0 as NULL sometimes NULL is (probably) defined as nullptr in c++11 anyway (edited)

19:05

but 0 can be cast to int, which is potientially more dangerous in overloaded functions

[ddnet:master] 2 new commits

635485d Fixed typo in variable name - Chairn 48f81e2 Merge #4174 - bors[bot]

19:05

[ddnet/ddnet] Pull request closed: #4174 Fixed typo in variable name

We do use nullptr in new code, we just didn't go around replacing it everywhere

damn, i cant push anymore due to token stuff now

you mean ssh?

git push
Logon failed, use ctrl+c to cancel basic credential prompt.
remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.
remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.
fatal: Authentication failed for 'https://github.com/Chairn/ddnet/'

yeahz

19:12

you need to generate a ssh key

Use ssh?

you can change the remote with git remote set-url origin git@github.com:Chairn/ddnet.git

[ddnet-scripts:master] 1 new commit

7ed2c2f Fix libwebsockets dir - def-

[ddnet/ddnet] Pull request opened: #4175 Allow compilation with MinGW

This allow to compile the client and the server with MinGW because socklen_t is defined as unsigned int while rcvfrom expect an int* with this platform which crash the compilation.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array inde...

@Chairn are you using mingw-w64?

23:36

https://github.com/mirror/mingw-w64/blob/2b92dc939918246a28f616ae036e7fde2f5ea979/mingw-w64-headers/include/ws2tcpip.h#L228

mingw-w64/ws2tcpip.h at 2b92dc939918246a28f616ae036e7fde2f5ea979 · ...

mingw-w64 Git mirror. Contribute to mirror/mingw-w64 development by creating an account on GitHub.

i guess not?

i'd suggest to just use that

Exported 259 message(s)