DDraceNetwork - developer

Let's try to finish up the client and get a RC this week

08:03

Oh actually don't think we can without heinrich being here to take a look at the startline patch

tomorrow its 5.9.(21)/91 so he probs gets 30 tomorrow xD

5991

09:12

pog

def-

[ddnet/ddnet] Pull request opened: #4142 Fix parantheses warning

This condition is too complicated to understand I think... ``` src/game/client/components/players.cpp: In member function ‘void CPlayers::RenderPlayer(const CNetObj_Character, const CNetObj_Character, const CTeeRenderInfo*, int, float)’: src/game/client/components/players.cpp:546:130: warning: suggest parentheses around ‘&&’ within ‘’ [-Wparentheses] 546 | if(((!IVideo::Current() && (g_Config.m_ClShowDirection >= 1)) (IVideo::Current() && g_Config.m_ClVideoShowDirection))...

i think it predicts deep hammer wrongly when it's not enabled? i use latest upstream code

09:46

i don't move btw

GitHub

Click to see attachment 🖼️

oops

nori

i think it predicts deep hammer wrongly when it's not enabled? i use latest upstream code

ye you are right

HamidReza585

[ddnet/ddnet] Pull request opened: #4143 Fix cl_show_direction wrong maximum

The maximum for cl_show_direction was supposed to be 2 but it looks like I forgot to change it in #4133 so if someone check show local player's key presses in DDNet settings (or do cl_show_direction 2), it will be reset to 1 next time the client launches.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c espe...

nori

i think it predicts deep hammer wrongly when it's not enabled? i use latest upstream code

if this wasnt before and you have a bit of time, you could do git bisect and open an issue

it was before

this is a sv_config, right? so the client may not know about it

hm?

I mean, the client most likely doesnt know if hammer in deep is enabled or not on the server

actually i can't say anything

11:27

but situation is - sometimes you can see this bug, sometimes not

bors[bot]

[ddnet:master] 2 new commits

00e2206 Fix cl_show_direction 2 wrong maximum - HamidReza585 845c04f Merge #4143 - bors[bot]

11:28

bors[bot]

[ddnet/ddnet] Pull request closed: #4143 Fix cl_show_direction wrong maximum

bors[bot]

[ddnet:master] 2 new commits

f90722c Fix parantheses warning - def- dc03672 Merge #4142 - bors[bot]

11:38

bors[bot]

[ddnet/ddnet] Pull request closed: #4142 Fix parantheses warning

Learath2

Let's try to finish up the client and get a RC this week

@Learath2 please merge before^^

NouaaTW

[ddnet/ddnet] Issue closed: #4135 Bug in editor mode.

ardadem

[ddnet/ddnet] Issue opened: #4144 Client fails to load server settings from map

I get following error messages on console. Client fails to load server settings. [2021-09-04 16:17:34][console]: No such command: sv_team. [2021-09-04 16:17:34][console]: No such command: switch_open. [2021-09-04 16:17:34][console]: No such command: sv_deepfly. [2021-09-04 16:17:34][console]: No such command: sv_max_team_size. This is the origin where messages came from: https://github.com/ddnet/ddnet/blob/master/src/game/client/gameclient.cpp#L3019 and because of that g_Config.m...

Original message was deleted or could not be loaded.

Well I don't think there's anything to fix, that fork is just created for contributing to main one so maybe it was not just fetched when you downloaded it (edited)