Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2021-08-21 00:00:00Z and 2021-08-22 00:00:00Z
06:59
xdd
07:00
07:18
GTFGCClientSystem?
07:18
What is that (edited)
Avatar
team fortress sourcecode
Avatar
@deen if u can fix the style error in #4101 and i can merge it
Avatar
Only used client-side so no protocol change Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options ...
07:30
im sure there is a way to call fix_styles.py on a pre commit hook or something
Avatar
should look into that
Avatar
I don't like having clang-format run in pre-commit, rather pre-push
07:31
because sometimes it destroys nice formatting
07:38
@deen do u know if the swap resets switches only on teams of 2 tees?
07:38
did anyone test it with a team of 3
07:38
it may be because this i guess
Avatar
that would be bad
07:39
can you please check?
07:41
i dont see anywhere else where teamstate is reset and i think thats the only way to reset switches right?
07:41
hmm
Avatar
9a03b6d Fix long maps not showing as finished (fixes #4092) - def- 1aeb09f Merge #4101 - bors[bot]
Avatar
it resets with 3 too
Avatar
i found a fix
07:59
i think
Avatar
Fixes #3806

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addr...
08:07
i tested it so it doesnt seem to break anything
08:07
but better to test it extensively in a rc
08:07
monkaS
Avatar
I think we'll have to do a release before #4088 gets addressed, we probably shouldn't have rolled back to begin with
Avatar
A non started tee leaving the team makes the team unfinishable. This made a couple teams fail some with multiple hours in their timers. Without #3091 system messages are unreadable to some of our p...
Avatar
I have now released my python bindings for twmap https://gitlab.com/Patiga/twmap-py ! Every part of the map can be read, however only the map info is currently writable. You can try it out by installing it with pip install twmap and using help on the module and the different types. Currently you can only use it on linux, but I'm trying to figure out how to get them to windows as well
Avatar
chillerdragon BOT 2021-08-21 10:05:45Z
poggers!
Avatar
@Patiga hm, what is the issue on windows?
Avatar
I'm using https://github.com/PyO3/maturin to publish it for pip directly using a docker container, but I don't know yet how to cross compile and release it with that tool
Avatar
I also changed the license of twmap to lgpl from agpl. the python bindings are also under lgpl (chillerdragon @Ryozuki @gerdoe)
Avatar
chillerdragon BOT 2021-08-21 10:08:55Z
ah nice there are licenses now!
10:09
dafaqa lgpl
10:09
wat does it mean? im forced to do open src?
10:09
wats ur motivation sell me the license please
Avatar
lgpl is more permissive than agpl
Avatar
I want changes to my license to be released publicly, however don't want depending libraries to be forced into my license
Avatar
agpl requires u to provide the source even if ur app is hosted on a server
Avatar
*changes to my library
Avatar
@Patiga lately i use the combo MIT OR Apache 2.0
10:10
this way contributors give u patent rights
10:11
when making pr
10:11
but people who use it
10:11
have the permissive MIT
Avatar
chillerdragon BOT 2021-08-21 10:11:16Z
ah right so one can use the lib in closed src but changes to the lib have to be published?
Avatar
lgpl is the nicest form of gpl imo, but agpl is also nice
Avatar
chillerdragon: exactly
Avatar
chillerdragon BOT 2021-08-21 10:11:39Z
sounds like a good lib license
10:12
but gpl doesnt require that for libs u use on a server
10:12
thats why agpl was made
Avatar
@Patiga nice to hear! really good job^
Avatar
> >
The GNU Affero General Public License is a modified version of the ordinary GNU GPL version 3. It has one added requirement: if you run a modified program on a server and let other users communicate with it there, your server must also allow them to download the source code corresponding to the modified version running there.
>
The purpose of the GNU Affero GPL is to prevent a problem that affects developers of free programs that are often used on servers.
Avatar
I just release most everything I make under bsd license
Avatar
02abc95 Use consistent case for error messages - ChillerDragon 4853166 erros typo and rephrase - ChillerDragon 42f21c6 Merge #3986 - bors[bot]
Avatar
@Ryozuki yeah if it existed I would've use ALGPL ^^
10:13
like agpl and lgpl combined
Avatar
Avatar
gerdoe
@Patiga nice to hear! really good job^
thanks :)
Avatar
do a diff between gpl and agpl, apply the diff to lgpl 😛
Avatar
chillerdragon BOT 2021-08-21 10:14:20Z
@Patiga: go study law and craft the algpl license ur self
Avatar
yeah I think I'll stay with existing licenses for now :p
Avatar
chillerdragon BOT 2021-08-21 10:16:24Z
xd
10:16
does agpl even allow you to change the license?
Avatar
if you depend on a project that is under agpl, you need to use agpl as well afaik
Avatar
chillerdragon BOT 2021-08-21 10:17:43Z
ah ye
10:17
but i mean you as the code owner can you publish under agpl and then change it again ?
10:19
it helps that I'm the only contributor
Avatar
chillerdragon BOT 2021-08-21 10:25:36Z
ah right due to include order
10:25
image.png
10:25
jobs.h depended on that system.h rip
Avatar
chillerdragon BOT 2021-08-21 13:08:09Z
wow @Ryozuki accounts?
13:08
its prob bad
13:08
but its my opportunity to add rust into ddnet monkalaugh
13:10
chilledragon add a base64 encoder to ddnet pls
13:10
chillerdragon *
13:10
no autocompletion for ur name sucks
Avatar
chillerdragon BOT 2021-08-21 13:13:51Z
cant u ping the ChillerDragon on discord? and this should automcomplete.
13:14
Also you do not need an external auth service to add rust. Just rewrite parts of the c++ in rust :D
Avatar
as heinrich did :D
Avatar
chillerdragon BOT 2021-08-21 13:17:34Z
did he?
Avatar
libtw2?
Avatar
chillerdragon BOT 2021-08-21 13:17:54Z
you mean libtw2 right? i mean ddnet/ddnet just replace parts
13:18
libtw2 is also some external stuff
13:18
i mean we could rewrite parts of the actual server and client in rust
Avatar
engine stuff is here
Avatar
chillerdragon BOT 2021-08-21 13:18:39Z
yea not integrated tho
13:18
@heinrich5991: still waiting for the tw server rewritten in rust
Avatar
its rewritten
13:19
basic stuff tho
13:20
like you can launch server with map
Avatar
chillerdragon BOT 2021-08-21 13:22:21Z
yes i know
13:22
but not finished
13:22
and still 0.6 lul
Avatar
Avatar
Patiga
yup :)
Q: Can you actually retroactively change the licensing on a previously published version of the library? Can't people still keep using it under agpl?
Avatar
I can't
13:34
ah
13:34
well, lgpl is strictly more permissive than agpl afaik
Avatar
Yeah, I know, just a hypothetical
Avatar
I think I can make it more permissive, but not stricter
Avatar
You can probably make it stricter but it'd only apply to newer versions
Avatar
yeah, I meant retroactively
Avatar
chillerdragon BOT 2021-08-21 13:38:49Z
but the new version also include the old code right?
13:38
so some code then has two licenses
Avatar
ur the author
13:39
u can change it
13:39
for new versions
13:39
i guess
Avatar
I am not completely sure how it works, but I'd guess code that exists under both licenses can be used under either
13:40
e.g. if a piece of code was published under MIT, but then you applied a stricter license e.g. GPL. People can still use that part of the code under MIT, as long as it is as is from when it was published
Avatar
chillerdragon BOT 2021-08-21 13:40:50Z
yes
13:41
which is super weird because you have the exact same code in a repo with GPL license then
13:41
easiest is to not change licenses @Patiga you took a long time to pick it now u better keep it :p
Avatar
relaxing your license is easy as everyone would just prefer to use the most permissive anyway
Avatar
chillerdragon BOT 2021-08-21 13:43:05Z
relax and drink 🍺
13:43
Beerware is a tongue-in-cheek term for software released under a very relaxed license (beerware licensed software). It provides the end user with the right to use a particular program (or do anything else with the source code).
Avatar
I just noticed how badly steam works on macOS
13:43
how do you fuck it up so bad that a desktop application is laggy
Avatar
chillerdragon BOT 2021-08-21 13:43:44Z
i just noticed how badly macOS works when undusting my old machine to fix mac build
13:43
but tbh steam is buggo anyways even on linux it feels odd
13:44
isnt steam using arch linux for their latest console? :D
Avatar
electron and co are cancers on the industry, I wish they would just die off
f3 1
Avatar
chillerdragon BOT 2021-08-21 13:45:02Z
if electron dies it would probably only be because its replaced by something similar bad
justatest 1
Avatar
alas, cheap outsourced web development is a huge allure for companies
13:45
capitalism is good for innovation and better products my ass
Avatar
chillerdragon BOT 2021-08-21 15:13:16Z
@Learath2: yo still have an mac? Can u build teeworlds without complications?
Avatar
Haven't tried teeworlds but I'd guess it suffers the same issue as ddnet on my catalina macOS
Avatar
Fullscreen window screen resolution setting is broken with SDL master
Avatar
@Learath2 u haven seen the issues right? monkalaugh
15:24
monkaS
15:25
im using the shiniest rust lib by your friends from tokio: https://github.com/tokio-rs/axum
Ergonomic and modular web framework built with Tokio, Tower, and Hyper - GitHub - tokio-rs/axum: Ergonomic and modular web framework built with Tokio, Tower, and Hyper
15:25
monkalaugh
Avatar
Avatar
Maiski
Fullscreen window screen resolution setting is broken with SDL master
SDL seems to contain some code to make SDL_SetWindowSize work on fullscreen windows, but that doesn't work anymore
Avatar
i just have to figure out how the http stuff works in ddnet
15:27
to test it
Avatar
send SDL all bugs u find, we need a stable version to update xdd
Avatar
chillerdragon BOT 2021-08-21 16:29:31Z
watafak SDL
16:31
nobody responded to my SDL issue yet is it even a bug? I mean the SDL_VIDEO_MINIMIZE_ON_FOCUS_LOSS=0 @Maiski suggested fixed it so im not sure if its a SDL bug or just bad sdl configuration
Avatar
as the name says it changes behavior
Avatar
Avatar
Deleted User
send SDL all bugs u find, we need a stable version to update xdd
SDL documentation says that SDL_SetWindowDisplayMode should be used for fullscreen windows instead of SDL_SetWindowSize. DDNet seems to use SDL_SetWindowsize, whose behavior is now different.
16:39
I'm not sure if it's an SDL bug or not
Avatar
ok, is SDL_SetWindowDisplayMode new, or can it already be used in sdl 2.0.8
16:49
ah but we only use it for resizing rn not else
16:49
did you enter a call from that?
Avatar
idea for @DDNet bot , in $points information would appear how many rank 1 maps he have and even maybe what place is he with rank 1
Avatar
oh man
17:39
i forgot how horrible c apis are to use
17:39
u can rly shoot urself
17:39
openssl c api is also rly undocumented
17:40
justatest
Avatar
@Ryozuki i'm in spain in october
Avatar
im becoming a master openssl c dev by copying from stackoverflow monkalaugh
17:40
:o nice
17:40
hi
17:40
may god help me
Avatar
long time no see
Avatar
Walking the camino portugues starting on sept 26
Avatar
From Porto in Portugal idk how that country is called in english to santiago de Compostela in spain
Avatar
Muy bien
Avatar
ok gn
Avatar
Buena noche
17:44
Nobody appreciating my spanish skills
Avatar
Buenas noches
17:44
*
17:44
for some reason we say it in plural
Avatar
Wait you say it in plural?
Avatar
Ok xD
Avatar
Good nights 😆
Avatar
también buenos dias
17:45
días
17:45
i always forget the ´
Avatar
Ah i knew that bueno dia sounds wrong
17:46
Una servesa por favor
Avatar
cerveza
Avatar
whats wine?
17:56
red wine
17:56
wine
17:56
where
Avatar
whats red wine in spanish
Avatar
thanks
Avatar
<3
17:58
i'm a little sorry for abusing the dev channel xD
Avatar
a: buse
Avatar
Q: is there any sense in m_VotePos in CPlayer
Avatar
Avatar
timakro
whats red wine in spanish
vino tinto
Avatar
Q: why do we use m_aActLatency in CPlayer while we can store it in CGameContext
Avatar
SDL_SetWindowSize's documentation tells that SDL_SetWindowDisplayMode should be used to set the sizes of fullscreen windows. SDL commit 72d812852023450b7c3850b8e87b63575df041ee changed SDL_SetWindowSize's behavior so that it can no longer be used to set the screen resolution with windows that are created in fullscreen mode. SDL_SetWindowDisplaymode can be used instead when the window is fullscreen. ...
Avatar
i should make an issue i guess since no one reads my shit-talks xd
Avatar
Avatar
gerdoe
i should make an issue i guess since no one reads my shit-talks xd
most questions are about code that is around 11 years old, so nobody can tell you anyway xD
18:53
@Maiski did you enter it while resizing btw? or just casually
Avatar
I was testing DDNet with new SDL versions
18:58
To see if there are any bugs
Avatar
yeah
18:59
but did you specifically resize?
Avatar
I tested changing the resolution because chillerdragon's problems seemed to be related with RandR
Avatar
ok, i'm just asking bcs of how urgent it is
19:01
resizing is less bad than starting probably xd
Avatar
Avatar
Deleted User
most questions are about code that is around 11 years old, so nobody can tell you anyway xD
ah nice point xdd
19:05
will send another prs then
Avatar
d94f52b Fix fullscreen resolution setting on SDL 2.0.16 - vainiovano 7b3f300 Merge #4104 - bors[bot]
19:39

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
hm seems m_VotePos is thing for regulating player-dummy votes, but can players actually send F3/F4 from dummy and main in one tick?
Avatar
I met the weirdest guy. Complete consipiracy nut and a blockchain enthusiast. Software guy
20:08
Couldnt for the life of me convince him that the vaccines arent to cull the population of earth
20:10
im battling against openssl
20:12
Avatar
could it be they dont allow to sign stuff with ed25519?
20:21
their tool cant do it yet
20:21
stupid nobos
20:21
time to ask on irc
Avatar
I use libsodium
Avatar
@Learath2 should we use it on ddnet?
Avatar
That's what I was planning, either that or noise if I could make it fit. Noise is based on libsodium
20:28
Libsodium is fairly low level
Avatar
wait i make the pr to show u the abomination that is openssl
Avatar
Really WIP Edit: maybe consider using another library I added the base64 encoder which I plan to use to send the public key with this POC backend https://github.com/edg-l/ddnet-authservice Currently it segfaults when trying to sign using SignContent, maybe someone figures out why (or ill eventually figure it out...) ```console Thread 1 "DDNet" received signal SIGSEGV, Segmentation fault. 0x00007ffff7e21f62 in EVP_DigestSign () from /usr/lib/libcrypto.so.1.1 (gdb) bt #0 0x0000...
Avatar
So the protocol part is up to you, it only gives you primitives
Avatar
i cant find Noise
20:29
its too generic word
20:30
such a bad library name
20:30
time to play some dota 2, this c++ stuff rly tired me xd
20:31
Wireguard uses it
Avatar
tbh i just need to fix this segfault and we are pretty much done
20:33
and we already use openssl
20:34
now im confused
20:34
unsigned char **ppSignature = (unsigned char **)malloc(sizeof(unsigned char *));
20:34
this is valid right?
20:34
xd
20:35
meh another day
Avatar
[quakenet] AlirezaOpmc_ BOT 2021-08-21 20:39:03Z
hi
20:39
hey breton
Avatar
36ad87f fix console name of GfxDesktopWidth - Jupeyy da59dee Merge #4105 - bors[bot]
Avatar
Avatar
Ryozuki
Buenas noches
spanish traitor
Exported 267 message(s)