DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2021-08-07 00:00:00Z and 2021-08-08 00:00:00Z

#1

https://github.com/ddnet/ddnet/issues/1

Show time of player you're spectating · Issue #1 · ddnet/ddnet

Probably difficult since spectators don't have a character?

hmm you can communicate a lot of things with these numbers

03:54

https://github.com/ddnet/ddnet/pull/1312

Fix #963 dragging quads by timakro · Pull Request #1312 · ddnet/ddn...

Fixes #963

lynn

have we done issue cleanup in the past?

we kinda did

07:44

but its growing out of control

Omagawd can someone explain ddnet UI code to me? Is there some beginner docs on it? Can we switch to html and CSS :troll: i always mess up things real good

07:55

image.png

Image attachment

lmao (edited)

Embedded image

Ryozuki

but its growing out of control

im down to choose a time to go through them together, or just prioritize things

lynn

have we done issue cleanup in the past?

actually if someone will read my close requests xd

[ddnet/ddnet] Issue opened: #4000 suggestion: new a block

this way for hook can be so confusing when you hook it !hook confusing but no way for fix now so i suggestion for future making/add new block block specification 1. hookable blocks 2. untouchable blocks , which will not affect your body (the body will pass through them) (it's almost like (hook-through blocks) but body pass through them not hook)

1

1

cool

[ddnet/ddnet] Issue opened: #4001 Use GithHub discussions for feature requests, ideas and improvements

We have so many issues currently. Gets a bit messy

there is already hook blockers

wow @Learath2 you are the greatest developer ever!

Q: How does oauth based sso stop the end site from "mitm"ing the authentication site? E.g. malicioussite.com lets you authenticate with google, how do you know the new site it opens is google?

@Learath2 btw most sites like google, you are alreayd logged in

15:07

so its only a matter of allowing

15:07

if i have to enter credentials

15:07

u should check the url

15:07

idk how else to prevent this

15:08

this is why when u login with steam on 3rd party sites, its recommended u login on steam first

15:08

i see this recommended always

Hm, sounds rather janky. Such an undetectable attack too

once google chrome warned me about redirecting to not oauth2 thingie of some service

oath2 requires ssl too

Eh, I never liked the idea of SSO anyway

15:10

Oauth also requires all tokens be associated to ips and only be valid for very short durations. How many people do you think enforce this? :P

:p

15:11

well if u login against some service dont u always get a short lived token?

I guess in this case the best way to do oauth2 inside a game is to open a native browser

tbh i never tried oauth itself

15:11

i only do jwt for myself

Ryozuki

well if u login against some service dont u always get a short lived token?

I got a rather long lived token from stackexchange, e.g.

Image attachment

15:12

from google

That arrow from the user is controlled by your app is where I fail to see any protection against

15:13

I guess as you said your best bet would be to only allow already logged in accounts

@Learath2 are you still on vacation?

Omw back, did something break again? WoJak

WoJak

ofc

whats that emote

15:15

ah me seeing c++ code monkalaugh

monkalaugh

15:15

ok joke joke

Cøke

ofc

Embedded image

cant move maps with commands, and old maps still there.. should be already in the archive (edited)

@Learath2 haver u ever made something only using c++20 modules?

Perfect. Nothing better to ruin my day after a vacation, messing around with the stupid discord bot

maybe i can help with the bot

I was all relaxed too, got some sun, got to enjoy the sea

altho im not familiar with the codebase

Then BAM, python

submit and create new channels working (edited)

15:16

but the commands and archive

(edited)

I will be back in 2.5h, then I can take a look at logs

ok

15:17

maps should be after 1 week in the archive

Learath2

I will be back in 2.5h, then I can take a look at logs

https://discord.com/channels/252358080522747904/321058698023796736/873225651623198740

commands from patiga still working ($optimize etc)

Ryozuki

@Learath2 haver u ever made something only using c++20 modules?

I only got to toy around with C++20 for now. Maybe if a project comes up I might give it a go

Address? Like an offset? What are you even making?

Doubt anyone'd have any idea, you'll need to figure it out yourself. Since you have access to the source it should be trivial, just print it out on the console

@Patiga do you have a minute?

yea :)

can you help me test again? I need you to remove your testing role and react green check on a map or two

17:58

it's quite annoying to test with the admin role

sure, sec

oh god, it's broken again

I can only successfully check the most recent map (orange_2)

here I go again need to inject mitmproxy in there to figure out what damn permission is causing the issue

:/

@Patiga can you try adding a reaction again on one that didn't work

they still don't work

it's supposed to be adding a singular overwrite, and I can add it manually

18:05

If I view the server as that role

18:06

yeah okay, can't avoid injecting the proxy

18:06

shame

:c

@Patiga can you give it another go please?

still the same

18:15

I don't mind the testing at all :)

so silly, it's making the request I think it should be making yet something is causing missing permissions

18:16

@Patiga which map did you try?

I am trying the most recent one and the three above it

Can you try just carebear?

eh, same behavior sorta?

18:19

it popped up once, but only after I tried it, was that your doing?

18:20

(also disappeared again)

Patiga

it popped up once, but only after I tried it, was that your doing?

that was me trying with the bots permissions to grant the same override

18:25

hm, I think this is a discord bug

ouch

18:26

did you also see the log btw? those errors looked like the most generic thing ever

18:26

from https://discord.com/developers/docs/topics/opcodes-and-status-codes:

5xx (SERVER ERROR) The server had an error processing your request (these are rare).0 General error (such as a malformed request body, amongst other things)

18:26

meh formatted badly

18:27

imagine a line break before the 0

the 500s I didn't check yet

18:27

where did you get a 500?

discord.errors.DiscordServerError: 500 Internal Server Error (error code: 0): 500: Internal Server Error

18:28

after some exceptions on commands

18:28

in the bot.log

Okay gave the bot broader permissions, can you try the checkmarks again?

18:30

apparently if the bot doesn't have "View channels" on the broader category it can't grant permissions on the subchannels even if it has "View channel" on them

works perfectly now, nice!

1 bug down 50 to go

18:31

Okay, next up the 5xxs

what a mess

So it was the waiting command that caused a 500

I think a $reset also caused it at least once

waiting seems to be also fixed by the permission thing

18:35

Is there any that needs a reset where I can try that one?

you can play with #deleted-channel

18:36

(but first decline it)

18:37

nice

yep, that's also fixed, I guess discord had a backend change, these companies and their undocumented changes...

18:37

okay, I guess that leaves the archiving thing

i guess those Websocket closed with 1006, attempting a reconnect. are also fixed then? ^^

Only god knows that one

18:38

It's actually rather complicated to resume a bot, so if there is a bug in that I really don't think I have the energy to dig into discord.py

18:39

So we could maybe watch the log for the bot getting stuck and just restarting it

sounds fair

bruh, is there any good way to install ubuntu from ssd on this same ssd without pain in ass

it's quite annoying to do

18:43

actually it's so annoying to do that I'd suggest you go dig for a usb

it's literally 130 km ahead

anyway, the key is the toram parameter if you want to try it, you need to unpack the iso properly into a partition, edit some magic config things I no longer remember and boot to that partition using the toram flag

18:45

which will load the entire image into the ram so you can then overwrite the ssd safely

oh good

18:49

need to lurk a bit more

18:49

thanks

18:49

i did another partition with unpacked iso and booted it

18:49

and now it's formatting new partitions after boot one

18:50

aaand

18:50

it stuck

18:50

uh oh is it good to hard reload my machine to reformat everything

Without the toram flag it will break

18:50

so if you booted without toram you just bricked your computer

no way

(well not bricked per se, but no way to fix it without a usb)

18:53

toram loads the entire image into ram when booting, so it's fine to overwrite the ssd

18:53

without it when you overwrite the partition table badthings(tm) happen :/

thanks again xd

(or maybe you got very lucky and it only sort of broke)

Cøke

maps should be after 1 week in the archive

Can you gimme an example? Seems the bot checks for 60 days not 1 week

It's for waiting

18:58

Archive = 1 week

18:59

Ah sorry I mean 1 week no activity = archive @Learath2 (edited)

Ok, do you have an example of a map that should be archived? @Cøke

19:02

Don't send a message in it so it doesn't get active again

thanks @Learath2! it's: faster easier no need at another drive

19:21

new warrior of home servers is ready to use

@Learath2 #deleted-channel

19:35

And much more

Thank jesus, figured it out

19:36

more missing folders entirely breaking the bot without a single error in sight...

19:36

it will take a bit to catch up to the backlog though so give it a minute

Looks like it caught up

somewhy this (in CCharacter::HandleTiles) does nothing

Image attachment

look up references to m_TileIndex

int MapIndex = Index;
m_TileIndex = GameServer()->Collision()->GetTileIndex(MapIndex);

bcs no one sends tile_air to this function

Now take a look at GetTileIndex

only -1, >0

hm, actually I don't remember filtering TILE_AIR

look up TileExists

21:51

it checks every range of tiles

21:51

unless 0

Ah, we double check the index, I see

@Anime.pdf come here our little prince

gerdoe

@Anime.pdf come here our little prince

have you pushed your quad tree onto them yet

i messed up whole codebase and started to doing 2xp again

lol

gerdoe

@Anime.pdf come here our little prince

22:06

Im sleeping

u are not

troll.pdf

lynn

u are not

Im trying to

gerdoe

troll.pdf

u gertroll

Anime.pdf

Im trying to

fapnighter

gerdoe

fapnighter

u

i still want to see an anti ping feature where you can input an ms delay value (edited)

22:47

so lets say people who were adapted to 40 ping can play with "40 ping" on higher or lower ping servers

22:47

without any problems

Is there a way to spec only a specific team in free spec mode

/specteam ?

23:58

oh in free spec mode

23:58

thonk

Exported 190 message(s)