Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2021-07-26 00:00:00Z and 2021-07-27 00:00:00Z
Avatar
I think it should fix #3964.

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [x] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddne...
Avatar
omg new devs
😔 2
👍 1
07:02
48cd8ea fix home/end buttons - BloodWod-513 ffcc722 Merge #3970 - bors[bot]
Avatar
I should maybe look into reiserfs for storing teehistorian files, the median file size is only 18kb
Avatar
Why? Reiserfs seems really outdated. See for example https://www.phoronix.com/scan.php?page=article&item=reiser4-linux-417&num=3
To little surprise given that Reiser4 doesn't see too much optimization/feature work these days, Reiser4 tended to struggle compared to today's EXT4, F2FS, Btrfs, and XFS competition that are within the mainline Linux kernel. In fact, it's already been a decade since Hans Reiser was last able to contribute to the file-system's development and since then there has just been Edward Shishkin and few other contributors. Given the small bus count for maintaining Reiser4 and the lack of any corporate sponsor, besides the lackluster performance, it makes the likelihood of using Reiser4 in production a risky bet given the uncertain future.
I've never had problems with ext4.
Avatar
hm, my lookups have been taking very long lately, and I'd heard after a couple million files inside a folder ext4 starts to have some trouble
Avatar
then let's not put millions of files into a single folder but presort by prefix
09:01
and create subdirectories for those prefixes
Avatar
That's a good idea actually
09:04
I love how my mind went to some weird filesystem no one used in a decade instead of that :D
Avatar
Lookups on my teehistorian server or yours?
Avatar
I think it should fix #3925. Previously, the game stopped due to the fact that it was possible to turn on the selection by a random click, but if you disable the quick edit flags, then the selection can be made only by right-clicking the mouse and selecting an necessery option. The game will also stop, but after copying it will immediately continue, and this eliminates accidental pressing, that is, the person is fully responsible for his actions. ![console](https://user-images.githu...
Avatar
Hm, I guess what's slow is enumerating, not indexing
Avatar
Avatar
lynn
omg new devs
u
Avatar
pro-tip, having a couple instances of rsync running in parallel better saturates your connection if your files are very small
Avatar
@Learath2 as in it uses all ur net speed?
Avatar
@Learath2 answered on the pull request, not sure what happens there for what reason sometimes. Would be happy if we could get it in, the debug messages of the bot are still kinda failing since check_ddnet apparently debugs some of the stuff to stderr. what I find crazy is that it was never a problem on my test server which I can honestly not explain at all. so one of the commits fixes it and if you want to update the twmap binaries they will also only print the debug info to stdout now (meaning updating the binaries obsoletes that commit)
Avatar
i had a router handed to me by my isp when they installed the internet, it couldnt handle 200 connections at the same time and internet got down for some time (i was torrenting animu), i bought a more decent router and it works flawlessly
10:26
stupid isps
10:27
and i can ssh into my router
10:27
altho i have to tell ssh to use some ancient cyphers
10:27
KexAlgorithms +diffie-hellman-group1-sha1 Ciphers 3des-cbc (edited)
10:27
this
Avatar
@Ryozuki as in it uses more of it atleast
10:39
It was doing 200K down, with 8 jobs running it does 2.6M down
10:41
@Patiga how about I do both? 😄
Avatar
Avatar
Patiga
@Learath2 answered on the pull request, not sure what happens there for what reason sometimes. Would be happy if we could get it in, the debug messages of the bot are still kinda failing since check_ddnet apparently debugs some of the stuff to stderr. what I find crazy is that it was never a problem on my test server which I can honestly not explain at all. so one of the commits fixes it and if you want to update the twmap binaries they will also only print the debug info to stdout now (meaning updating the binaries obsoletes that commit)
hm, seems you didn't answer on the PR? deleted your answer?
10:44
GNU Parallel is also very nice to use, if you ever want to parallelise some tasks
Avatar
Avatar
Learath2
hm, seems you didn't answer on the PR? deleted your answer?
hm it has the 'Pending' tag, not sure what that means
Good point, I would agree by looking at the code, but testing it in my test server shows that I can't use it in #submit-maps anyways. Since only testers can use the command, I don't think we need to investigate it much further
Avatar
@Patiga You accidentally started a review, you need to click send single comment 😛
Avatar
hm how do I get out of the review? o.o
Avatar
You just delete your review comment and resend it as a single
10:51
or you can end the review on the top right
Avatar
okay I feel blind, I only see Submit review
Avatar
anyway, did you try using it on a submission that you already accepted? that's what it looked like it'd work on for me
Avatar
so using the command $edit in the #📬submit-maps channel on a map that got accepted?
Avatar
Avatar
Patiga
okay I feel blind, I only see Submit review
You can submit it as a comment, the top option. Or you can cancel your review by deleting the pending comment
Avatar
Avatar
Patiga
so using the command $edit in the #📬submit-maps channel on a map that got accepted?
yep
10:54
That is accepted as in already has a channel
Avatar
seems like it doesnt do anything, wanna get on my test server?
Avatar
@Patiga btw you don't have to put any comment in the overall review
Avatar
chillerdragon BOT 2021-07-26 11:34:43Z
http headers are weird :D
11:35
can they be trusted in any way? I mean i can set whatever i want as origin and forwarded for etc
Avatar
Ones inserted by your webserver can be trusted if your webserver says so, the others are not to be trusted
Avatar
Avatar
Patiga
You could have left that empty and it wouldn't have sent a comment at all
Avatar
The Cyber Swiss Army Knife - a web app for encryption, encoding, compression and data analysis
12:08
66b0b7d Go through the history for the edit command - Patiga 25a7bc3 Address concern by Ravie - Patiga 9fe60c5 Address minor security concern - Patiga 5819e3c Also use take stderr from check_ddnet - Patiga 25207a9 Merge pull request #23 from Patiga/pr-minor-changes - Learath2
12:09
c9d1225 Merge pull request #1 from ddnet/master - BloodWod-513 89bd2c6 disabling quick editing in the console - BloodWod-513 baff204 Merge #3971 - bors[bot]
Avatar
France perma is laggy
14:07
Fix this please
Avatar
I don't have any issues on fra
Avatar
ddnetSuggestion ddnet What if there was a tick box where if you have more than 1 game skin or emoticon pack every tee except yours is assigned a random one to keep? Like, everyone on a team has a different hammer look or grenade but they all function the same.
Avatar
i think thats actually funny, but its probably not going to be implemented.
Avatar
yea thats probably too hard to make for just a funny feature
16:11
poggers
poggers 1
Avatar
why does server reallocate character on tryrespawn? (edited)
Avatar
ig each time you die your character is destroyed (which is logic), so when you spawn back it does reallocate
16:36
cplayer should be the player itself, ccharacter the tee ingame
Avatar
but is there any need to reallocate it since destroy() makes character isalive = false
Avatar
you could check git blame to find out why
17:02
I don't know a good reason off the top of my head
Avatar
Avatar
gerdoe
why does server reallocate character on tryrespawn? (edited)
The character is recreated but characters are created inside a pool, so they are always in the same place. So no actual allocation happens
17:13
Did you not wonder why the odd new(m_ClientID) CCharacter(...) and not just new CCharacter(...)? 😄
Avatar
i knew about it but anyway why does it happen? xd
17:35
oh wrong question
17:36
why should it happen?
Avatar
why not
Avatar
also noticed that we store m_Tile(F)Index in CCharacter but we can just use them in local scopes (edited)
Avatar
chillerdragon BOT 2021-07-26 18:12:25Z
Anyone has experience with getting filtered by the provider? (Home Connection)Well tbh I am not sure who is filtering me. But I can not reach half the internet including my own servers.All started when I did a stress test of my webapp I sent maybe too many requests :justatest:
Avatar
hmm idk
18:16
first step is to not use ur isp dns
18:16
http over dns helps too
18:16
dns over http
18:16
*
18:16
firefox has the option
18:17
i dont think chrome does cuz google
18:17
oh they do
Avatar
chillerdragon BOT 2021-07-26 18:30:20Z
I can not connect to my vps via ip either
18:30
Only things that work that I tested are Netflix YouTube tw master and tw servers
Exported 89 message(s)