DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2021-07-19 00:00:00Z and 2021-07-20 00:00:00Z

Waw we cant change game resolution anymore in the latest version and also we can't check ping number in the server list

00:06

So far we improving rlly gud !

00:06

That's why i never update my client it is always painful to see those changes

this is why ppl should think before talking

Deleted User

Waw we cant change game resolution anymore in the latest version and also we can't check ping number in the server list

Connect to the server and you'll see the ping, it was changed bcs ddosers could get your IP address and send spoofed packages with your IP, which can help them to ddos servers more easily Your resolution can still be changed, send a picture of the graphic settings and we can probably easily fix it

this is why you dont update late

00:19

people were explaining this all the time when the update first came out

plsplsplslol

people were explaining this all the time when the update first came out

Ikr guess is my fault

00:29

btw fakeskin

u

[ddnet-web:master] 1 new commit

4a04222 Add ban.php - Learath2

troll

I tried looking for this bug a week or two ago, it seems to happen randomly and I have this odd feeling that it is a php issue. If any of you are familiar with php it'd be nice to get another pair of eyes on it. Error:

"PHP message: PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 67108922 bytes) in /var/www/bep/ban.php on line 14

This string is somehow growing to insane sizes and it doesn't always happen, so I could be invoking some ub somewhere and accidentally passing the entire generated file to escapetw. It is a bit of a mess and will be entirely rewritten in the future (it kinda grew organically to accommodate feature requests from mods)

11:35

Two identical requests don't reliably trigger it, so it's not easy to debug at all

ah php

11:38

i only know u can increase the script size, but if its using so much mem its prob a bug

11:38

idk how to help u i suck at php

11:39

justatest

AmberSweat

weeb

11:40

also its rly hard to help u with what u sent

Ryozuki

idk how to help u i suck at php

Maybe just give it a read going backwards from line 14? I've looked at it so much I might be blind to simple mistakes now

oh its public

xd

11:41

oh regex

11:41

is this some kind of regex ddos

11:41

xd

I considered that but 2 problems with that, the regex has no backtracking in it, and the regex is applied to the banfile generated if it was catastrophic backtracking it would always happen since the file doesn't change

i love reading php

11:44

"explode"

11:44

yea explode

11:44

makes sense

11:44

and functions that use snakecase and others that just simply dont

11:44

php ftw

hm, php is fairly consistent in it's snake_case for stdlib functions, and PascalCase for it's oop interfaces

strlen

11:46

why not str_len

11:46

u have

11:46

str_replace

11:47

basename

11:47

why not base_name

11:47

realpath why not real_path

11:47

they dont follow it

11:47

strpost

11:47

strpos*

Ah, libc functions retain their name and there is a subset of libc derived functions that are named like that

11:48

anyway, less spam, more longer posts so my poor question doesn't get buried

@Learath2 hav u tried preg_replace

instead of str_replace? I could but I don't see what that's supposed to tackle

ah actually preg_replace is worse

11:50

is the file rly big?

if banfile is ending up in escapetw it'

11:51

it's about 21K

justatest

1

11:51

(but if the code is executed properly it should never end up in there)

idk then

11:52

can u even debug php code

11:52

xd

11:52

or profile

Sure, xdebug, but I can't debug a problem that randomly happens

this is my recommendation for you

Image attachment

I could try to log everything that ever ends up in escapetw, but it's trying to allocate 67MB, cant exactly output that to the error log :D

maybe change memory_limit

11:56

on php.ini

11:56

if it doesnt crash maybe its easier to debug

11:57

use memory_get_usage to check if its over 67mb maybe xd

Ryozuki

this is my recommendation for you

This is me last night after spending 2 hours injecting a proxy connector into twilight to find a ratelimiter bug

monkaS

11:59

@Learath2

Image attachment

12:00

If Java had true garbage collection, most programs would delete themselves upon execution. – Robert Sewell

justatest

1

monkalaugh

1

12:00

lmao

12:00

http://harmful.cat-v.org/software/java

I would take rust over both so this animegirl is not an accurate representation of me

more quotes here

Now make is C or C++ and it'd be a fairly accuratd conversation between me and you

ye xD

s/is/it/

Learath2

I tried looking for this bug a week or two ago, it seems to happen randomly and I have this odd feeling that it is a php issue. If any of you are familiar with php it'd be nice to get another pair of eyes on it. Error:

"PHP message: PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 67108922 bytes) in /var/www/bep/ban.php on line 14

This string is somehow growing to insane sizes and it doesn't always happen, so I could be invoking some ub somewhere and accidentally passing the entire generated file to escapetw. It is a bit of a mess and will be entirely rewritten in the future (it kinda grew organically to accommodate feature requests from mods)

^^ requesting more phppl

@NeXus i think u use php

12:02

ur the only last one standing

whats up

Learath2

I tried looking for this bug a week or two ago, it seems to happen randomly and I have this odd feeling that it is a php issue. If any of you are familiar with php it'd be nice to get another pair of eyes on it. Error:

"PHP message: PHP Fatal error:  Allowed memory size of 134217728 bytes exhausted (tried to allocate 67108922 bytes) in /var/www/bep/ban.php on line 14

This string is somehow growing to insane sizes and it doesn't always happen, so I could be invoking some ub somewhere and accidentally passing the entire generated file to escapetw. It is a bit of a mess and will be entirely rewritten in the future (it kinda grew organically to accommodate feature requests from mods)

read this

12:03

maybe u know

12:03

https://github.com/ddnet/ddnet-web/blob/master/www/ban.php

12:03

here the file

12:04

@Learath2 i bet rewriting it in rust would solve it

12:04

12:04

monkalaugh

If you want to increase your allowed memory size, configure your php.ini file and set I think memory_limit to something higher

12:05

If you have a memory leak or smth I'll have a look at this take

12:05

code

It's trying to allocate 67 megabytes, whatever it wants to do it's an insanity

12:06

fwiw it's probably a good thing that it dies in escapetw, I don't want to know what would happen if I executed a 67 megabyte ssh line

12:07

for more context escapetw only ever works with single lines

exec("sudo -n -u teeworlds ". $twdir. "execute-all.sh ". escapeshellarg($run). " > /dev/null 2>&1 &", $out, $rc); what does this bash script do

it will ssh to all servers and echo the line given to it to a fifo

@Learath2 its not possible u ever pass a empty string to replace right

12:09

https://bugs.php.net/bug.php?id=79951

12:10

its prob not this xd

Oh that's intriguing, let me take a look

[ddnet-scripts:master] 1 new commit

b2dff12 Update execute-all.sh - Learath2

If you are interested ^^ it's fairly simple in what it does though

This probably isnt the problem

(i have stupid question about mem_copy, if someone wants to answer, ping me pls xd there are so many mem_copys in tw code with references inside, isn't dest = source more idiomatic for cpp?)

@Learath2 maybe try using strtr

gerdoe

(i have stupid question about mem_copy, if someone wants to answer, ping me pls xd there are so many mem_copys in tw code with references inside, isn't dest = source more idiomatic for cpp?)

Well teeworlds is more C than C++, so mem_copys are mostly a legacy

12:14

For POD types it's safe to do a byte by byte copy, so it's safe

huh, thanks for answer

is byte by byte copy called bitwise copy

12:15

ye

Ryozuki

is byte by byte copy called bitwise copy

yep, but the smallest addressable thing is a byte, so I thought I'd use that

i learnt the name bitwise copy from rust

12:16

xd

I don't see an empty string ever making it to escapetw so that's not it

also this thing makes me feel curious

    // it is not allowed to aim in the center
    if(m_LatestInput->m_TargetX == 0 && m_LatestInput->m_TargetY == 0)
        m_LatestInput->m_TargetY = -1;

why? xd

Though I wonder if it is somehow an uninitialized member in one of my classes

gerdoe

also this thing makes me feel curious

    // it is not allowed to aim in the center
    if(m_LatestInput->m_TargetX == 0 && m_LatestInput->m_TargetY == 0)
        m_LatestInput->m_TargetY = -1;

why? xd

It'd make the angle undefined

uh oh

learath pro

12:17

so fast

tw wizard

monkaS

thanks a lot again :p

One could instead define the center to have angle 0, but I guess matricks decided it's safer to just never allow this 0/0 case to happen

Learath2

Though I wonder if it is somehow an uninitialized member in one of my classes

I really don't see how I can end up with an instance of Ban with uninitialized members though, can I even avoid calling the constructor somehow?

@Learath2 Try to use the 4th parameter of str_replace and set it to 1

Eh, that won't work, I need to escape all instances of these in the string, not just one

Maybe you have some sort of recursion of each instance, when replacing \ with even more \

Yeah that's what I was thinking too, but wouldn't that be reproducible?

12:23

Hm, I'll try a couple things, that sounds feasible

ok good luck

Hm, that could indeed be it, I wonder why it's might

Image attachment

12:29

Hm, this doesn't apply to me since I'm not doing multiple replacements

[ddnet-web:master] 1 new commit

51d2fe8 Add some heavy logging - Learath2

Okay, I couldn't figure it out so I added an error handler so next time it happens I have a backtrace

[ddnet-web:master] 1 new commit

959ae14 Wrong place for this - Learath2

@Learath2

it literally was in the wrong folder, nothing interesting

monkaS

I get a 404 for the ban.php link

[ddnet-web:master] 1 new commit

02acf35 Move ban.php - Learath2

Today I learned a rust trick, you can force a reborrow of t using &mut *t

[ddnet/ddnet] Pull request opened: #3958 Make emoticons smoother(?)

@fokkonaut said that sending more gameticks made the emoticon smoother, so I tried to look at the clientside render code. Does this fix it? @fokkonaut.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physic...

@heinrich5991 have a minute for my incompetence?

what is it?

Learath2

Today I learned a rust trick, you can force a reborrow of t using &mut *t

and why u want that

heinrich5991

what is it?

https://paste.pr0.tips/0x?rust clippy is confident I can elide 'a, I don't see how

doesn't look like you can, according to the rules I know

@Learath2 try &'_

Ryozuki

and why u want that

https://paste.pr0.tips/B2?rust this, took a while to figure out what was even going wrong

Ryozuki

@Learath2 try &'_

Already tried it, eventhough I knew it wouldn't work

heinrich5991

doesn't look like you can, according to the rules I know

eh, I guess clippy bug since the ppl in the rust discord don't seem to see it either

Almost wrote reboot on ger2, a lot of ppl would be a lot of mad

monkalaugh

do it

please make +/- keybinds for tele/switch

23:32

i beg u

good first issue

I HATE YOU FOR SAYING THAT

23:33

because you're right

Exported 160 message(s)