Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2021-06-14 00:00:00Z and 2021-06-15 00:00:00Z
Avatar
GitHub BOT 2021-06-14 04:30:29Z
Author icon
ddnet-maps
[ddnet-maps:master] 1 new commit
adece16 M 808 - ddnet-maps
Avatar
GitHub BOT 2021-06-14 05:49:19Z
Author icon
Jupeyy
[ddnet/ddnet] Pull request opened: #3906 Fix str comp parameter in updater
looks wrong to me

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-ad...
Avatar
GitHub BOT 2021-06-14 07:01:53Z
Author icon
def-
[ddnet-web:master] 1 new commit
1736086 M|aria. -> Marii - def-
Avatar
lynn 2021-06-14 07:17:45Z
@M|aria. cuter name
Avatar
GitHub BOT 2021-06-14 08:13:47Z
Author icon
def-
[ddnet/ddnet] Pull request closed: #3906 Fix str comp parameter in updater
08:13
Author icon
def-
[ddnet:master] 2 new commits
d873a5d Fix str comp parameter in updater - Jupeyy df2f666 Merge pull request #3906 from Jupeyy/pr_fix_auto_update_len - def-
08:14
Author icon
def-
[ddnet/ddnet] Issue opened: #3907 bors keeps timing out on PRs
Don't know how to debug bors.
Avatar
Astramast 2021-06-14 09:06:50Z
how do i change client-side system messages ?
Avatar
Anime.pdf 2021-06-14 09:25:19Z
go to OnMessage
09:25
and look for client id
09:25
there are comments about it
Avatar
Avatar
Anime.pdf
go to OnMessage
Astramast 2021-06-14 09:37:45Z
where ? (edited)
Avatar
Anime.pdf 2021-06-14 09:39:49Z
search thru project
Avatar
Avatar
Anime.pdf
search thru project
Astramast 2021-06-14 09:40:44Z
where is project file ?
09:40
Image attachment
Avatar
Anime.pdf 2021-06-14 09:43:27Z
its data folder
09:43
download sources
Avatar
Astramast 2021-06-14 12:52:47Z
Image attachment
12:52
Give that man a slice of Ukraine
Avatar
GitHub BOT 2021-06-14 12:55:29Z
Author icon
heinrich5991
[ddnet/ddnet] Pull request opened: #3908 Fix bors.toml for Ubuntu 18.04
Fixes #3907.

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-add...
Avatar
GitHub BOT 2021-06-14 13:13:48Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
69f987d Fix bors.toml for Ubuntu 18.04 - heinrich5991 92a271a Merge #3908 - bors[bot]
13:13
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #3907 bors keeps timing out on PRs
13:13
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #3908 Fix bors.toml for Ubuntu 18.04
Avatar
GitHub BOT 2021-06-14 14:24:29Z
Author icon
heinrich5991
[ddnet/ddnet] Issue opened: #3909 DDNet's HTTPS requests fail on nixOS on steam
``` [2021-06-14 09:18:48][http]: libcurl version 7.22.0 (compiled = 7.55.0-DEV) […] [2021-06-14 09:18:49][http]: http https://master4.ddnet.tw/ddnet/15/servers.json [2021-06-14 09:18:49][http]: http https://info2.ddnet.tw/info
  • About to connect() to info2.ddnet.tw port 443 (#0)
  • Trying 104.21.78.207... * getaddrinfo(3) failed for master4.ddnet.tw:443
  • Couldn't resolve host 'master4.ddnet.tw'
  • Closing connection #0
[2021-06-14 09:18:49][http]: task failed. libcurl error: Couldn'...
Avatar
Avatar
Astramast
Give that man a slice of Ukraine
Anime.pdf 2021-06-14 14:45:05Z
ok ez
Avatar
heinrich5991 2021-06-14 15:16:17Z
@Learath2 do you know another (preferably free-to-play) game that uses libcurl?
15:16
https://github.com/ddnet/ddnet/issues/3909#issuecomment-860753353
DDNet's HTTPS requests fail on nixOS on steam · Issue #3909 · ddnet...
[2021-06-14 09:18:48][http]: libcurl version 7.22.0 (compiled = 7.55.0-DEV) […] [2021-06-14 09:18:49][http]: http https://master4.ddnet.tw/ddnet/15/servers.json [2021-06-14 09:18:49][http]: http ht...
Thumbnail
Avatar
Avatar
heinrich5991
@Learath2 do you know another (preferably free-to-play) game that uses libcurl?
Learath2 2021-06-14 15:32:57Z
hmm, nope none come to mind, sorry
Avatar
Ryozuki 2021-06-14 15:44:35Z
wasnt someone from a worms game here?
15:44
maybe they do
15:44
he used to hang around in this irc channel
15:45
https://www.hedgewars.org/
Hedgewars
Hedgewars! It's a blast!
15:46
heh they moved to libera chat too
Avatar
Learath2 2021-06-14 15:47:37Z
@Ryozuki I have a function that writes out to something that implements std::io::Write I need to write to a String what is the best way to do that?
15:47
I was thinking of just outputting to a Vec<u8> and then going ot a string from there
Avatar
heinrich5991 2021-06-14 15:47:58Z
yup
15:48
that's the best way, I think
Avatar
Ryozuki 2021-06-14 15:48:25Z
https://doc.rust-lang.org/std/io/struct.Cursor.html
std::io::Cursor - Rust
A Cursor wraps an in-memory buffer and provides it with a [Seek] implementation.
15:48
a cursor around a vec is the best i think
Avatar
heinrich5991 2021-06-14 15:48:57Z
that seems to just extra code when a Vec also works
Avatar
Ryozuki 2021-06-14 15:49:02Z
i guess
15:49
xd
15:51
@Learath2 remember that if u dont wrap the writer around a bufwriter the writes are unbuffered
15:51
i see leddit ppl saying hehe rust is slower than java due to this
Avatar
heinrich5991 2021-06-14 15:51:45Z
doesn't really matter for a vec, I think
Avatar
Ryozuki 2021-06-14 15:51:53Z
monkalaugh
Avatar
TsFreddie 2021-06-14 15:57:16Z
Seems like the serverlist can't be accessed in a netcafe consistently.
15:57
Still can't get the log out of players. So I can't tell why.
Avatar
Avatar
TsFreddie
Seems like the serverlist can't be accessed in a netcafe consistently.
TsFreddie 2021-06-14 15:58:16Z
I mean consistently can not be accessed.
Avatar
heinrich5991 2021-06-14 16:01:01Z
can you just go to a netcafe and check? ^^
Avatar
TsFreddie 2021-06-14 16:12:09Z
😅
16:12
My social anxiety won't let me
16:12
Never been to those places
16:12
I directed him to use a custom cfg that has a cn domain plus a Chinese cdn
16:13
Still didn't work
Avatar
deen 2021-06-14 16:14:04Z
Huh, maybe some firewall blocking it?
Avatar
TsFreddie 2021-06-14 16:14:30Z
maybe. But I don't know what firewall would block a traffic from tencent
16:15
Also in these places I would imagine they don't have a admin windows account. Might be worth checking.
16:15
Although not sure what would be different about it
16:19
or it might be a policy thing where they can only serve Chinese games
16:20
Scratch that, they can connect to servers just fine
16:20
😇
Avatar
heinrich5991 2021-06-14 16:21:04Z
@TsFreddie might they be MITM every connection?
Avatar
TsFreddie 2021-06-14 16:21:15Z
Possible
Avatar
heinrich5991 2021-06-14 16:21:24Z
can you ask them to show a certificate in the browser for https://master1.ddnet.tw/ddnet/15/servers.json ? (edited)
Avatar
TsFreddie 2021-06-14 16:21:39Z
Will do
16:22
Although most of them struggled to paste a string into their file explorer
16:22
I'll do my best😅
16:24
Ah this one isn't replying. I'll wait for the next "victim"
Avatar
afterfx 2021-06-14 16:36:27Z
!invite
16:36
$invite
Avatar
DDNet BOT 2021-06-14 16:36:32Z
https://discord.com/oauth2/authorize?client_id=421296159290687488&scope=bot&permissions=537259072
Avatar
afterfx 2021-06-14 16:38:50Z
$invite
Avatar
DDNet BOT 2021-06-14 16:38:50Z
https://discord.com/oauth2/authorize?client_id=421296159290687488&scope=bot&permissions=537259072
Avatar
afterfx 2021-06-14 16:40:53Z
i cant add the ddnet bot to my server, why?
Image attachment
Avatar
heinrich5991 2021-06-14 16:43:41Z
I think the bot is in 100 different discords, and the developer would need to send their ID card to discord to allow the bot in more servers
Avatar
Im 'corneum 2021-06-14 16:44:12Z
other servers have the ddnet bot?
16:44
can they rename it or is it advertisement
Avatar
heinrich5991 2021-06-14 16:44:52Z
people can rename bots, but I think only ddnet-related discords would have an incentive to use the bot ^^
Avatar
afterfx 2021-06-14 16:51:15Z
@deen its now your turn, to verify your bot (edited)
Avatar
heinrich5991 2021-06-14 16:51:33Z
it's not deen's bot
16:51
it's jao's AFAIK
16:51
and as said, you have to send your ID to discord AFAIK, not everyone will want to do that
Avatar
jao 2021-06-14 16:52:35Z
blame discord
Avatar
Learath2 2021-06-14 16:58:57Z
@Ryozuki do you know if collecting the stream from .fetch() has a performance penalty over .fetch_all() in sqlx?
Avatar
Ryozuki 2021-06-14 17:15:04Z
@Learath2 i think fetch returns a stream
17:15
which i guess is like a iterator
17:15
fetch all is probs the collected items of that
17:16
@Learath2 i think fetch is better
17:19
stream is an async iter
17:19
i guess if u have to map or filter it its better fetch
Avatar
GitHub BOT 2021-06-14 17:37:28Z
Author icon
def-
[ddnet-web:master] 1 new commit
b2cce3b Add sponsored servers by Davide (huge thanks!) - def-
Avatar
Luca 2021-06-14 17:38:54Z
Does anyone know where and what files are created by ddnet on macOS which should be removed on uninstallation? @Learath2 ? (edited)
Avatar
Learath2 2021-06-14 17:56:35Z
@Luca the only thing outside of it's dir that ddnet touches is the teeworlds folder in Application Support
Avatar
Luca 2021-06-14 18:18:45Z
Okay @Learath2 so I would roll with these?! "~/Library/Preferences/DDNet-Server-Launcher.plist", "~/Library/Saved Application State/org.DDNetClient.app.savedState", "~/Library/Application Support/Teeworlds/" (edited)
Avatar
heinrich5991 2021-06-14 18:23:38Z
this will also remove the files created by Teeworlds
18:23
both ddnet and teeworlds write into that folder
18:23
what are you coding? 🙂
Avatar
Luca 2021-06-14 18:24:29Z
Yes that is true.
Avatar
Avatar
heinrich5991
what are you coding? 🙂
Luca 2021-06-14 18:24:39Z
homebrew uninstaller
Avatar
heinrich5991 2021-06-14 18:27:18Z
is it customary for homebrew uninstallers to remove user settings?
Avatar
Ryozuki 2021-06-14 18:27:24Z
imagine wanting to uninstall ddnet feelsbadman
Avatar
Luca 2021-06-14 18:27:35Z
it is not
18:27
That is why I am asking
18:28
So i guess it would be better to not delete the teeworlds dir
18:34
@heinrich5991 good you mentioned it. I didn't think about that. I would have kept it in 🙂
Avatar
heinrich5991 2021-06-14 18:36:03Z
np
Avatar
Avatar
heinrich5991
is it customary for homebrew uninstallers to remove user settings?
Luca 2021-06-14 18:38:08Z
also about this: The zap stanza describes a more complete uninstallation of files associated with ddnet. The zap procedures will never be performed by default, but only if the user uses --zap on uninstall. So you probably could also remove the teeworlds dir. On the other hand most users know this dir exists (because of skins, binds, entities, ...) so they might as well delete it by hand.
Avatar
heinrich5991 2021-06-14 18:38:44Z
ah, it's not by default
Avatar
Luca 2021-06-14 18:38:44Z
zap does then work of a cleaner app.
Avatar
heinrich5991 2021-06-14 18:38:48Z
that makes it less of an issue
Avatar
Luca 2021-06-14 18:39:12Z
yeah but I guess better delete less than too much?!
18:39
I mean I would be pretty sad if my config would get lost this way.
Avatar
heinrich5991 2021-06-14 18:40:00Z
yea
Avatar
Luca 2021-06-14 18:42:33Z
Also, from now on, ddnet on the Mac will be updated automatically if it was originally installed with Homebrew. If this turns out to be a problem for any reason, please let me know.
Avatar
heinrich5991 2021-06-14 18:43:09Z
wdym, updated automatically?
18:43
I think our autoupdater doesn't work on macos
Avatar
Luca 2021-06-14 18:43:26Z
if a new version is available
Avatar
heinrich5991 2021-06-14 18:43:34Z
will it be updated by brew?
Avatar
Luca 2021-06-14 18:43:37Z
yes
Avatar
heinrich5991 2021-06-14 18:44:05Z
ah. sounds good. don't think it'll be a problem
18:44
thanks for working on packaging ddnet 🙂
Avatar
Luca 2021-06-14 18:45:03Z
No worries. I need ways to procrastinate 🙂
Avatar
heinrich5991 2021-06-14 18:46:33Z
now brew is one of two package managers that have an up-to-date version
18:46
https://repology.org/project/ddnet/versions
ddnet package versions - Repology
List of package versions for project ddnet in all repositories
Avatar
Luca 2021-06-14 18:47:37Z
it has been since 15.1.3
18:49
it's the only thing I am contributing to ddnet xD besides some translations
Avatar
Deleted User 2021-06-14 18:49:57Z
is the serverlist script online somewhere
Avatar
heinrich5991 2021-06-14 18:50:19Z
which serverlist script?
Avatar
Deleted User 2021-06-14 18:50:28Z
the program that generates the json
18:51
is it in libtw2?
Avatar
heinrich5991 2021-06-14 18:51:20Z
yes
18:51
stats_browser
Avatar
Deleted User 2021-06-14 18:51:29Z
ok ty
Avatar
heinrich5991 2021-06-14 18:51:34Z
I re-used an old project
18:51
you need --format json (edited)
18:52
be careful running the script, you're incurring traffic for every server hoster in teeworlds
Avatar
Deleted User 2021-06-14 18:52:12Z
yes
18:52
but the cloudflare is really slow for me
18:52
sometimes takes 4-5 seconds to load
Avatar
Avatar
heinrich5991
be careful running the script, you're incurring traffic for every server hoster in teeworlds
Luca 2021-06-14 18:53:02Z
isn't that a huge vulnerability?
Avatar
heinrich5991 2021-06-14 18:53:24Z
@Deleted User do you want to host master3?
18:53
please don't run it for private purposes only, that doesn't scale
Avatar
Deleted User 2021-06-14 18:53:54Z
has ddnet still some server?
18:54
i doubt my vps can handle alot of requests (edited)
Avatar
Avatar
Luca
isn't that a huge vulnerability?
Deleted User 2021-06-14 18:55:16Z
atleast not 2k players are requesting the info 😄
Avatar
Avatar
Deleted User
sometimes takes 4-5 seconds to load
heinrich5991 2021-06-14 18:58:24Z
but only the first connection?
Avatar
Deleted User 2021-06-14 18:58:42Z
its random
18:58
when i switch tabs
18:58
is the load high btw? or is it getting ddos'd?
Avatar
heinrich5991 2021-06-14 18:59:11Z
you could fix the tab switching instead of scraping the servers another time 😉
Avatar
Deleted User 2021-06-14 18:59:53Z
in what way, caching the current list and silently update?
Avatar
heinrich5991 2021-06-14 19:00:15Z
not throwing the http master serverlist away when switching tabs
Avatar
Deleted User 2021-06-14 19:00:19Z
https://ddnet.tw/status/ CPU is 100% often
19:00
if thats the server same
Avatar
heinrich5991 2021-06-14 19:00:27Z
the http master server class has all the data
Avatar
Avatar
Deleted User
if thats the server same
Deleted User 2021-06-14 19:01:54Z
nice english
19:02
i mean is master1 == ddnet.tw
Avatar
heinrich5991 2021-06-14 19:02:55Z
you can simply not throw the server info away on tab change @Deleted User
19:03
then there will be no reloads when switching tabs
Avatar
Deleted User 2021-06-14 19:03:45Z
yes, i generally think it should always show the list
19:03
even if its outdated
Avatar
heinrich5991 2021-06-14 19:03:59Z
that would require caching
Avatar
Deleted User 2021-06-14 19:04:00Z
the normal user doesnt understand it anyway "fetching master list"
Avatar
heinrich5991 2021-06-14 19:04:13Z
but not throwing the old info before obtaining the new one sounds good
Avatar
Deleted User 2021-06-14 19:04:41Z
well caching = writing it and load it at client start
19:04
from that one its always just updating that file
19:04
since it doesnt throw away
Avatar
heinrich5991 2021-06-14 19:04:59Z
yea, enter permission problems etc.
19:05
and concurrency issues with multiple clients
19:05
but maybe you can put it into the sqlite3 db
Avatar
Deleted User 2021-06-14 19:05:33Z
isnt read write safe?
Avatar
heinrich5991 2021-06-14 19:06:29Z
it's certainly not atomic
Avatar
Deleted User 2021-06-14 19:07:56Z
well i guess and start and closing client its as safe as the ddnet_settings.cfg
19:08
at*
Avatar
heinrich5991 2021-06-14 19:08:10Z
which is also not safe and we get reports for that
19:08
also that is already doing the rename trick IIRC
Avatar
Deleted User 2021-06-14 19:08:29Z
requieres a quick ahdn xd
19:08
hand
19:08
yeah the rename trick could be done too ofc
19:09
anyway, i'll see what i'll do
Avatar
Ryozuki 2021-06-14 19:20:43Z
lockfiles monkalaugh
Avatar
Learath2 2021-06-14 19:21:37Z
@heinrich5991 || @Ryozuki https://paste.pr0.tips/6S do you see a way to make this work?
19:22
Issue is that sqlx::error::Error isn't Copy so I don't really see how I can get it out of the closure
Avatar
heinrich5991 2021-06-14 19:23:35Z
what's the error?
19:23
this looks like it could compile in my brain
Avatar
Learath2 2021-06-14 19:24:52Z
https://paste.pr0.tips/Oc (edited)
Avatar
Ryozuki 2021-06-14 19:25:03Z
ERROR: No such paste.
Avatar
Learath2 2021-06-14 19:25:14Z
mixed the O with 0
Avatar
Ryozuki 2021-06-14 19:25:18Z
i wonder what r u doing
19:25
i never had to use pin in my life
19:25
xd
Avatar
Learath2 2021-06-14 19:25:50Z
streams and async in general is very new in rust, it's tough to use
Avatar
Ryozuki 2021-06-14 19:26:04Z
does adding a move fix it?
Avatar
Learath2 2021-06-14 19:26:38Z
Need to pin that stream because the new stream created by filter_map is no longer Unpin and you can't .next on it
Avatar
Avatar
Ryozuki
does adding a move fix it?
Learath2 2021-06-14 19:26:52Z
It would take err by value meaning I can't get it outside
Avatar
heinrich5991 2021-06-14 19:27:00Z
seems like you're not allowed to take a reference to the outside variable somehow?
19:28
you could circumvent this particular problem with an Arc<AtomicPtr<>>, probably
19:28
hm, I don't understand the error message, I think
Avatar
Learath2 2021-06-14 19:29:03Z
I'm allowed to take a reference to the outside, I think I just am not allowed to let e escape
Avatar
Ryozuki 2021-06-14 19:29:10Z
https://stackoverflow.com/questions/62557219/error-on-future-generator-closure-captured-variable-cannot-escape-fnmut-closu
Error on Future generator closure: Captured variable cannot escape ...
I want to create a simple websocket server. I want to process the incoming messages and send a response, but I get an error: error: captured variable cannot escape FnMut closure body --> src...
Thumbnail
Avatar
Learath2 2021-06-14 19:30:09Z
hm a fold is an interesting idea
19:30
but I can just avoid this construct anyway, I just wanted to check if any of you encountered this
19:31
I'll just map the stream items to Result<Row, Error> and handle the error later
Avatar
Ryozuki 2021-06-14 19:31:51Z
i havent rly used much streams
Avatar
Deleted User 2021-06-14 19:39:45Z
couldn't ger2 host a master? seems like a complete OP machine compared to the others anyway
Avatar
heinrich5991 2021-06-14 19:42:36Z
I guess we could try, yes
Avatar
Deleted User 2021-06-14 19:49:04Z
[2021-06-14 21:47:23][http]: fetching https://master1.ddnet.tw/ddnet/15/servers.json [2021-06-14 21:47:23][http]: task done https://master1.ddnet.tw/ddnet/15/servers.json [2021-06-14 21:47:23][http]: fetching https://master1.ddnet.tw/ddnet/15/servers.json [2021-06-14 21:47:24][http]: task done https://master1.ddnet.tw/ddnet/15/servers.json [2021-06-14 21:47:24][http]: fetching https://info2.ddnet.tw/info?name=%5EpDetektiv%20Keks [2021-06-14 21:47:27][http]: task failed. libcurl error: Operation too slow. Less than 500 bytes/sec transferred the last 10 seconds [2021-06-14 21:47:27][http]: fetching https://master1.ddnet.tw/ddnet/15/servers.json [2021-06-14 21:47:28][http]: task done https://master1.ddnet.tw/ddnet/15/servers.json [2021-06-14 21:47:34][http]: task failed. libcurl error: Operation too slow. Less than 500 bytes/sec transferred the last 10 seconds looks like the main reason it sometimes is so slow is bcs info2.ddnet.tw doesnt respond? or just generally slow connection to that server
19:50
its also insanly slow over browser
Avatar
heinrich5991 2021-06-14 19:50:56Z
so the problem isn't even the server list rn?
Avatar
Deleted User 2021-06-14 19:51:08Z
yeah
Avatar
heinrich5991 2021-06-14 19:51:08Z
but it waits for info2.ddnet.tw for some reason?
Avatar
Deleted User 2021-06-14 19:51:12Z
cloudflare timeout
19:51
in browser
19:51
so yes
19:51
dunno how that could be different
19:51
but its the same IP
19:52
maybe its still the connection after all
19:52
but yeah in brwoser the info is much slower
19:52
often takes 5-10 seconds or timeouts
Avatar
heinrich5991 2021-06-14 19:53:13Z
I think it uses http/2 to cloudflare
19:53
so it can multiplex over one connection
Avatar
Deleted User 2021-06-14 19:54:22Z
ah sry, but master1 is indeed a different ip
19:55
or is it just as soon as it routes to cloudflare?
19:55
probably
Avatar
heinrich5991 2021-06-14 19:58:54Z
yes, master1 and info2 are the same server
19:58
but I think db is different
Avatar
Deleted User 2021-06-14 19:59:23Z
but i guess cloudflare checks per URL? bcs master1 always fast and info2 always slow for me 😄
19:59
probably bcs info2 has a ddos incomming or smth
Avatar
pamonha1487777 2021-06-14 20:04:06Z
hi good afternoon i want to know how do i become adm on ddnet on fng map
Avatar
lynn 2021-06-14 20:05:06Z
admin? i don't think you can apply to be an fng admin (edited)
Avatar
pamonha1487777 2021-06-14 20:05:45Z
but why
Avatar
lynn 2021-06-14 20:06:17Z
@noby who's the admin of DDNet FNG
20:06
or is that just all ddnet admins
20:07
also @pamonha1487777 let's move to questions, not rly a dev topic
Avatar
noby 2021-06-14 20:08:32Z
me
Avatar
lynn 2021-06-14 20:11:49Z
i don't see a reason for another admin lol
Avatar
deen 2021-06-14 21:16:13Z
@heinrich5991 no, info2 is db.ddnet.tw
21:16
@Deleted User yes, it's because of a DoS against info2. I don't know how the attackers found out its ip address
Avatar
Patiga 2021-06-14 21:30:40Z
Is there any way for me to test changes to the ddnet-discordbot without running it myself? I'm trying to set up the bot right now, but it seems hard and I'm running into problems
Avatar
GitHub BOT 2021-06-14 21:44:03Z
Author icon
heinrich5991
[ddnet/ddnet] Pull request opened: #3910 Add a new failure log level to the HTTP module
Use it for the "determine best masterserver" job, so that we can debug failures.

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UB...
Avatar
lynn 2021-06-14 21:45:02Z
i wanna confirm, is that why refresh is slightly longer than it was previously? (1-2 seconds)
Avatar
heinrich5991 2021-06-14 21:45:21Z
that only affects the ddnet tab, I think
Avatar
lynn 2021-06-14 21:45:29Z
gotcha
21:46
i noticed after 15.5 refresh takes 1-2 seconds longer, any tab
Avatar
heinrich5991 2021-06-14 21:46:18Z
are you sure it takes longer? 😛
Avatar
lynn 2021-06-14 21:46:23Z
but theoretically it should be shorter, since it doesn't communicate with any server to get ping
21:46
yes
Avatar
heinrich5991 2021-06-14 21:46:29Z
not only taking longer to the first server shown?
Avatar
deen 2021-06-14 21:46:43Z
@heinrich5991 I can reproduce that. Refresh takes multiple seconds for me at the moment
Avatar
lynn 2021-06-14 21:46:54Z
let me check right now, using internet tab
Avatar
deen 2021-06-14 21:46:55Z
ah, only ddnet tab
21:47
then yeah, the info2 problem
Avatar
lynn 2021-06-14 21:47:18Z
initial load was 6 seconds
21:47
got it ok
21:47
subsequent reloads are not that bad, 2 seconds
Avatar
heinrich5991 2021-06-14 21:49:25Z
reloads take <0.5s for me
21:49
but the initial load does indeed take long
Avatar
lynn 2021-06-14 21:50:01Z
that's weird
21:50
it must favor connections close to EU?
21:50
how many master servers are located there?
Avatar
heinrich5991 2021-06-14 21:50:26Z
1
Avatar
lynn 2021-06-14 21:50:30Z
and elsewhere?
Avatar
heinrich5991 2021-06-14 21:50:36Z
1, in china
Avatar
lynn 2021-06-14 21:50:45Z
huh, im kinda in the middle xd
Avatar
heinrich5991 2021-06-14 21:50:59Z
you're likely connecting to the one in europe
Avatar
lynn 2021-06-14 21:51:09Z
well, if I can't have USA2, can I have USA master server 😄 @deen
21:51
i would again sponsor it
21:51
or even host it if it came to that
21:51
but obviously not ideal (edited)
Avatar
heinrich5991 2021-06-14 21:52:04Z
I guess not throwing away the old list when refreshing would help with these problems 😛
Avatar
lynn 2021-06-14 21:52:08Z
lol
Avatar
Deleted User 2021-06-14 21:52:10Z
qtroll
Avatar
heinrich5991 2021-06-14 21:52:12Z
and maybe caching the serverlist across restarts
Avatar
lynn 2021-06-14 21:52:17Z
yea makes sense
21:52
at the very least caching
Avatar
heinrich5991 2021-06-14 21:55:37Z
@lynn can you create a file called ddnet-serverlist-urls.cfg next to your settings_ddnet.cfg and make the only line https://heinrich5991.de/teeworlds/temp/servers-2021-06-14.json
21:55
and report the performance
Avatar
lynn 2021-06-14 21:56:50Z
yes one moment
21:57
so this will override?
Avatar
heinrich5991 2021-06-14 21:57:30Z
yes
Avatar
lynn 2021-06-14 21:57:41Z
jesus christ
21:57
that is so much better
21:57
thanks lol
Avatar
heinrich5991 2021-06-14 21:57:49Z
argh
Avatar
lynn 2021-06-14 21:57:56Z
literally 0.5 like u said earlier
Avatar
heinrich5991 2021-06-14 21:57:59Z
ehm, this is just a snapshot
21:58
you can't keep using it 😛
Avatar
lynn 2021-06-14 21:58:07Z
sadness
Avatar
heinrich5991 2021-06-14 21:58:17Z
but I'll go set up a similar master soon™
transheart 1
Avatar
deen 2021-06-14 21:59:31Z
So why is it faster than the one we have?
Avatar
heinrich5991 2021-06-14 22:00:29Z
because cloudflare apparently makes things slower
22:00
I'll set it up on ger2 when I get to it
Avatar
[quakenet] deen BOT 2021-06-14 22:00:52Z
meh
Avatar
heinrich5991 2021-06-14 22:00:59Z
bad idea?
Avatar
[quakenet] deen BOT 2021-06-14 22:01:07Z
no, cloudflare making things slower is meh
Avatar
GitHub BOT 2021-06-14 22:07:27Z
Author icon
heinrich5991
[ddnet/ddnet] Pull request opened: #3911 Don't set cached pings for servers without info
Fixes #3899.

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-add...
Avatar
GitHub BOT 2021-06-14 22:29:46Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
c5cd8d3 Add a new failure log level to the HTTP module - heinrich5991 343d81e Merge #3910 - bors[bot]
22:29
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #3910 Add a new failure log level to the HTTP module
Avatar
GitHub BOT 2021-06-14 22:37:26Z
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #3899 Ping disappears in serverbrowser when ingame
22:37
Author icon
bors[bot]
[ddnet:master] 2 new commits
97b53c4 Don't set cached pings for servers without info - heinrich5991 ca14d87 Merge #3911 - bors[bot]
22:37
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #3911 Don't set cached pings for servers without info
Avatar
deen 2021-06-14 22:44:46Z
@heinrich5991 If cloudflare is adding a lot of latency, can we use some cdn where we just upload the static file every 5 seconds?
Avatar
heinrich5991 2021-06-14 22:46:00Z
didn't find a cdn where this would be cheap @deen
Avatar
deen 2021-06-14 22:46:03Z
ok
Avatar
heinrich5991 2021-06-14 22:46:19Z
e.g. aws bills per PUT request
Avatar
deen 2021-06-14 22:46:44Z
Would it help to pay for Cloudflare? I think they have better routing for paid accounts
Avatar
heinrich5991 2021-06-14 22:47:05Z
I don't know, I could ask cloudflare support I guess
22:47
I'll write a ticket
22:47
but I guess it could just be the detour to cloudflare's servers that could cost us
22:47
although I learned in network class that splitting up TCP connections can speed them up
Avatar
heinrich5991 2021-06-14 23:21:29Z
@lynn now better?
23:21
I set up master3.ddnet.tw
Avatar
lynn 2021-06-14 23:29:19Z
let me test
23:29
so remove the file you mentioned?
23:29
@heinrich5991 way better now
Avatar
heinrich5991 2021-06-14 23:30:34Z
nice 🙂
Avatar
Deleted User 2021-06-14 23:41:57Z
@heinrich5991 [2021-06-15 01:41:22][serverbrowse_http]: found master, url='https://master1.ddnet.tw/ddnet/15/servers.json' time=0ms [2021-06-15 01:41:22][http]: fetching https://master1.ddnet.tw/ddnet/15/servers.json [2021-06-15 01:41:22][http]: task done https://master1.ddnet.tw/ddnet/15/servers.json [2021-06-15 01:41:24][serverbrowse_http]: found master, url='https://master2.ddnet.tw/ddnet/15/servers.json' time=967ms [2021-06-15 01:41:24][serverbrowse_http]: found master, url='https://master3.ddnet.tw/ddnet/15/servers.json' time=20ms [2021-06-15 01:41:24][serverbrowse_http]: determined best master, url='https://master1.ddnet.tw/ddnet/15/servers.json' time=0ms 0ms
Avatar
lynn 2021-06-14 23:42:13Z
wowow (edited)
Avatar
Deleted User 2021-06-14 23:42:18Z
thats bad xd
Avatar
heinrich5991 2021-06-14 23:42:40Z
can you restart and check if the problem persists?
Avatar
Deleted User 2021-06-14 23:42:44Z
sure
Avatar
heinrich5991 2021-06-14 23:42:53Z
that might be our timekeeping "optimization"
Avatar
Deleted User 2021-06-14 23:43:12Z
now it says 70, but the 0 is to be expected?
Avatar
heinrich5991 2021-06-14 23:43:16Z
no
23:43
the 0ms is probably from our caching time_get values
Avatar
Deleted User 2021-06-14 23:43:37Z
ahh
23:43
i understand
Avatar
heinrich5991 2021-06-14 23:44:27Z
make sure to create a bug report
Exported 329 message(s)