Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2021-06-12 00:00:00Z and 2021-06-13 00:00:00Z
Avatar
i might have a clue know why SDL2 was buggy with the dont minimize flag @Learath2 with the windows taskbar not showing up with SDL 2.0.16 if i just compile it with default cmake flags and use it in our client it also happens there even in wine 0110:fixme:imm:ImeSetCompositionString PROBLEM: This only sets the wine level string 0110:fixme:imm:ImeSetCompositionString Reading string unimplemented 0110:fixme:imm:NotifyIME NI_CLOSECANDIDATE @TsFreddie do you think thats possible?
01:30
(the current sdl dev version has the flag default on)
Avatar
ok maybe its still just timing related bcs of the mouseabsolute call, maybe i should just open an issue on sdl and ask them why this behavior is so weird xd
Avatar
Need some networking help again, I got my new Ethernet cables which connects my router with 2 other PCs. These two PCs have a Realtek PCIE GbE family controller network adapter, and both only reach about 47-52 mbps. I tried the same cables with another laptop and am receiving the full 150 mbps, weird enough: The router interface shows that both pcs are connected as 1 Gbitps, same as both Computers, they report to use 1.0 Gbit/s, so I dont know why only about 50 mbit/s arrive
02:51
The laptop test shows its not the cable or any general setup, and I already checked whether its any green ethernet or power saving mode in my network adapter, but that doesnt seem to affect it.
Avatar
Avatar
Deleted User
i might have a clue know why SDL2 was buggy with the dont minimize flag @Learath2 with the windows taskbar not showing up with SDL 2.0.16 if i just compile it with default cmake flags and use it in our client it also happens there even in wine 0110:fixme:imm:ImeSetCompositionString PROBLEM: This only sets the wine level string 0110:fixme:imm:ImeSetCompositionString Reading string unimplemented 0110:fixme:imm:NotifyIME NI_CLOSECANDIDATE @TsFreddie do you think thats possible?
nvm that actually, i think that this just proves that its an SDL thing, else it would behave differently with wine^^ (edited)
Avatar
chillerdragon BOT 2021-06-12 07:58:10Z
image.png
07:58
aaaaa howto memory management? :/
08:02
ok nevermind i found solution without memory management :D but still i wonder whats wrong about my malloc :c
Avatar
Avatar
fokkonaut
The laptop test shows its not the cable or any general setup, and I already checked whether its any green ethernet or power saving mode in my network adapter, but that doesnt seem to affect it.
Don't use realtek network cards
Avatar
Avatar
fokkonaut
Need some networking help again, I got my new Ethernet cables which connects my router with 2 other PCs. These two PCs have a Realtek PCIE GbE family controller network adapter, and both only reach about 47-52 mbps. I tried the same cables with another laptop and am receiving the full 150 mbps, weird enough: The router interface shows that both pcs are connected as 1 Gbitps, same as both Computers, they report to use 1.0 Gbit/s, so I dont know why only about 50 mbit/s arrive
how do you test network speed? if you use some web speed test, it's possible that those PCs are not powerful enough to allow the JS garbage to reach the full speed of your internet connection
Avatar
@Comrade iperf3
👍 1
09:15
For example this one up to 10 Gbit/s: http://speed.myloc.de/
Avatar
or you can run iperf3 server on one PC to test LAN only
Avatar
DDNet 15.5 🥳
09:22
prepare for "where did the ping go?" support questions
Avatar
server list refresh is much faster now at least 😄
09:27
e318c57 Version 15.5 - def- abf3bfc Merge pull request #132 from ddnet/pr-15.5 - def-
09:31
9030369 Don't refresh, if a job is already running - Jupeyy c60715e Add timeout for serverbrowser http request - def- ac584fa Merge pull request #3889 from Jupeyy/pr_fix_queuehttps_refresh - def-
Avatar
Avatar
Comrade
how do you test network speed? if you use some web speed test, it's possible that those PCs are not powerful enough to allow the JS garbage to reach the full speed of your internet connection
I test via speedtest provided by google, directly on google.com, thats the best one
09:33
Both are high end gaming pcs from about 3-4 years ago
09:33
So they are powerful enough
Avatar
interesting
Avatar
Avatar
Davide
Don't use realtek network cards
Why? Funny enough: If I connect my phone via USB-C and start a USB tetherig, then it also gets capped at 50 mbit/s, but USB ports directly go to the main board. My phone has a much highe connection than 50, depends on where i am in the house
09:36
So my guess would be the mainboard, maybe
09:36
Its software is from 2016, latest version is from 2018
Avatar
But even USB 2.0 should easily reach faster speeds than 50 mbit/s
Avatar
it's not hardware issue probably
Avatar
Avatar
Comrade
it's not hardware issue probably
Yea
Avatar
Avatar
deen
But even USB 2.0 should easily reach faster speeds than 50 mbit/s
Correct
Avatar
can you try iperf3 on loopback? 😄
Avatar
Whats that?
Avatar
iperf3 -s and iperf3 -c localhost
Avatar
sure, let me just stand up and turn on my pc :D
09:38
Just woke up
Avatar
ah good morning then 😄
Avatar
good morning :)
Avatar
meanwhile it's nearly 3am here lol
Avatar
good night for you 🙂
Avatar
lol im listening to music ignoring the fact i inevitably will have to sleep (edited)
Avatar
Avatar
Comrade
iperf3 -s and iperf3 -c localhost
Do it with almost 4 threads so as to see the real maximum speed iperf3 -c 127.0.0.1 -P 4
Avatar
okay
09:42
@Davide whats wrong with realtek adapters? :D
Avatar
Avatar
fokkonaut
@Davide whats wrong with realtek adapters? :D
They are not the "top" of reliability
09:43
Let's say they are actually the worst network chips on the market 😂
09:43
Go with Intel if you need stability
Avatar
at least Intel Management Engine can't use Realtek NIC 😄
Avatar
Avatar
Comrade
iperf3 -s and iperf3 -c localhost
in cmd?
Avatar
couldnt find command iperf3
Avatar
How do I use it?
Avatar
extract it somewhere
Avatar
then
Avatar
open cmd in that folder
Avatar
ah (edited)
09:49
Server listening on 5201
09:50
now open another cmd and run the second command
Avatar
whats happening now?
Avatar
nothing
Avatar
oh, okay
09:50
iperf3 -c 127.0.0.1 -P 4 this one, right?
Avatar
done
Avatar
how much Gbps?
Avatar
which value is the one you need?
Avatar
looks good, so loopback is fine
Avatar
what did this do now?
Avatar
now run iperf3 -s on another PC and connect to it
Avatar
give me a second
09:53
this is from the first window, btw
Avatar
yes, it's the same
Avatar
okay
Avatar
Avatar
Davide
Don't use realtek network cards
i have a "Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 0c)" monkaS
Avatar
Realtek stuff is very common and works just fine usually
Avatar
ye i never seen another brand tbh
Avatar
@Comrade can i connect to the pc where it also gets capped?
09:58
or do i need one that has the full speed?
Avatar
it should reach ~950 Mbps everywhere
09:59
on gigabit ethernet
10:01
you can also try to run the iperf3 client with -R parameter to check download speed instead of upload
10:02
download
10:02
but on the same pc
Avatar
both server and client on the same pc?
10:03
this is the first window
Avatar
test it between 2 PCs
Avatar
about to
10:05
So what do I run where?
Avatar
it doesn't matter
10:06
PC1: iperf3 -s PC2: iperf3 -c 192.168.1.???
10:07
you will need IP of PC running the server
Avatar
sure
Avatar
Avatar
Comrade
Realtek stuff is very common and works just fine usually
For home usage, it's fine, yes
Avatar
Avatar
Comrade
PC1: iperf3 -s PC2: iperf3 -c 192.168.1.???
-R?
10:08
-R 4?
10:08
at the end?
Avatar
server is singlethreaded anyway, so -P is not really needed
10:09
try both with and without -R to test both directions
10:09
receiver pc
10:09
i think
10:09
its the pc where it was listening
Avatar
it shows the same numbers on both sides always
10:10
hmmm 663 Mbps
10:10
it should be higher on gigabit ethernet
10:10
but at least it's higher than 50 Mbps 😄
10:11
and now? xd
Avatar
i suspect your home router
Avatar
its a Fritzbox
Avatar
maybe someone added that 50 Mbps limit there? 😄
Avatar
nop, there is no limit
10:13
btw, what did your tests say now?
10:14
Does it mean its not the network adapter?
Avatar
weid
Avatar
then its probably the bios
Avatar
weird
Avatar
or whatever
Avatar
in the release version of ddnet 15. i have orange chn and green asi
10:16
nvm. i have set my proxy wrong. it is being applied to ddnet 😅
Avatar
@Comrade any other ideas?
10:23
should i maybe update bios?
Avatar
@fokkonaut no
10:25
just test everything first
Avatar
i tested about everything already :D
10:26
but sure, if you have ideas i will test tem
10:26
them
Avatar
did you try iperf3 against the internet server that deen posted?
Avatar
which one?
Avatar
which one do i take?
Avatar
iperf3 -c speedtest.myloc.de -p 5200 and iperf3 -c speedtest.myloc.de -p 5200 -R
10:28
first one
10:28
looks bad :(
10:28
second one is about to be the same
10:28
Avatar
so ~40 Mbps in both directions
10:29
google speedtest
Avatar
and your internet connection should be faster, right?
Avatar
150, yes
10:30
my and the one other pc never gets over 47-52
10:30
same cable plugged into laptop gets 150
Avatar
but LAN test with iperf3 showed >500 Mb/s
Avatar
weird
Avatar
so it's either your home router limiting the speed or some weird speed limit in those PCs that ignores LAN
Avatar
on of those pcs is mine, and i would be surprised if there is any speed limiting program installed :D
10:33
and we just got a new router, i doubt there is anything pre-capped for 2 pcs only :D
Avatar
you tested with USB tethering and the limit was there as well, right?
Avatar
did you unplug ethernet cable to make sure it uses mobile data?
Avatar
i disabled network adapter, so yea
Avatar
i can try it again, if you want
10:35
to make sure
Avatar
you use Win10, right?
Avatar
can you try to boot some linux distro from USB stick? 😄
10:35
and test it there
Avatar
Weird, now I am getting 30 via usb tethering
10:37
where my phone gets 70-80 via wifi
Avatar
Avatar
Comrade
can you try to boot some linux distro from USB stick? 😄
sadly, no :/
Avatar
it's getting even more weird 😄
10:40
can you try iperf3 -c speedtest.myloc.de -p 5200 -R on the laptop that works fine?
10:40
need to boot it, its a few years old xD
Avatar
cmd iperf3 not found
10:49
even tho im in the folder
Avatar
check if dir command shows iperf3.exe
Avatar
doesnt
Avatar
download it again then
Avatar
i just downlaoded it xD
10:51
but sure
Avatar
or maybe cmd is not in the right folder 😄
10:52
cmd as admin works
10:53
130 mbit/s
10:53
So this pc works
10:53
laptop
10:53
same cable as the one in my pc
Avatar
can you check CPU usage on the laptop and on the PC during the test?
Avatar
sure
10:54
cpu usage on laptop is fine
10:55
around 30%-40%
10:55
30% is normal usage
Avatar
normal usage?
Avatar
yea, without the test i mean
10:57
on my pc my cpu is at around 6-10%, during the test it jumped once to 12% and once to 16%
10:57
but otherwise fine
Avatar
how many cores?
Avatar
my pc cpu?
Avatar
with hyperthreading?
Avatar
whats that?
Avatar
2 logical cores per one physical core
10:59
4 => 8
Avatar
not sure, i have 4 logical cores
10:59
it looks fine
11:01
looks like some speed limit in Windows
Avatar
i couldnt find anything about that on the internet tho
11:01
well, nothing that helped me
Avatar
hmmm you can try one more thing
Avatar
sure
Avatar
ping some local IP during the test
11:02
your router for example
11:02
ping 192.168.1.1 /t
11:02
something like that
Avatar
during the iperf3 test?
Avatar
it doesn't stop after 4 pings with /t
11:03
yes
11:03
and check if there are some spikes in latency
Avatar
no spikes
11:04
1ms each
11:05
<1ms, sorry (edited)
Avatar
it must be some speed limit then
11:07
and if you have the same problem with USB tethering, it's not your home router's fault
11:07
by the way, did you test it with mobile data?
11:07
or WiFi only?
Avatar
wifi only, but my mobile data is like 20mbit/s only
11:07
so not worth a test, i think
Avatar
yeah, 22mbps
Avatar
tethering is NATed so your home router shouldn't know that it's the PC doing the test (edited)
11:08
or wait
11:09
which IP your PC gets with USB tethering?
Avatar
let me see
11:10
getting a very weird one
11:11
usually, our range starts somewhere at 192.168.178.20
11:11
router is the .1
11:11
now i get 192.168.42
Avatar
that's good
Avatar
funny tho, my phone is still at 192.168.178.xx
11:12
why is the pc getting such a weird range tho?
11:12
xD
11:12
not .178, but .42
Avatar
because your phone translates it to hide the PC behind it
11:12
can you test USB tethering on the laptop?
Avatar
sure
11:12
just went out of battery
11:12
i hate old laptops
Avatar
150 mbit/s with usb tethering on my laptop
Avatar
good, so the problem is definitely at the PC
Avatar
seems to be higher than my phone xD
11:15
phone speedtest shows about 130 right now
11:15
ah no
Avatar
web speed tests can be pretty heavy
11:15
okay so its the pc
Avatar
if you ask some Windows experts, they will tell you to reinstall Windows, but there should be some other way for sure (edited)
Avatar
i hope so
Avatar
you can try this:
  • go to Device Manager (devmgmt.msc)
  • find your network card and uninstall it
  • click on that "Search for new devices" button
  • do speed test again
Avatar
i already uninstalled my network adapter yesterday, restarted pc searched for new hardware (it found the adapter on restart by itself already), didnt change anything
11:21
did you make sure all these things are disabled?
Avatar
should be
11:25
yes
Avatar
just tried disabling QoS Packet Scheduler
11:28
also didnt work
11:30
HAH
11:30
netsh int tcp set global autotuninglevel=normal did the trick
Avatar
ah nice
Avatar
thanks :)
Avatar
we should've tried googling first 😄
11:33
2 hours of useless debugging
11:34
but it was fun 😄
11:38
true
Avatar
@Ryozuki could you please get the release into the AUR when you have some time?
Avatar
@heinrich5991 what does the Leak IP button do?
Avatar
Avatar
Patiga
@Ryozuki could you please get the release into the AUR when you have some time?
sure i forgot
12:32
@Patiga done
Avatar
@Ryozuki awesome, thanks
Avatar
@fokkonaut it pings the server directly if you are in the favorites view and the server does not appear in the masterserver list
Avatar
was the favorites behavior changed
14:09
oh
14:09
read that wrong
14:10
nvm
Avatar
someone can tell me why with wsl i cant compile my server but with windows command prompt that work
14:54
that dont give the "error"
14:54
just stop compiling
Avatar
the error must be further up
Avatar
no
14:54
no one error
Avatar
can you copy paste the whole log somewhere?
Avatar
just some warming
14:54
hmm yes
14:55
ho shit im wrong sorry but that work with wind cmd so..
14:55
that weird
14:56
maybe i need to install something
Avatar
it seems you need to install python in wsl
Avatar
he is not installed by default?
Avatar
well, try executing python3 --version
Avatar
ye i tried and he is not installed (edited)
14:58
ho shit
14:58
now i have +1000 errors
Avatar
try bam -c all
Avatar
ye that work thx
15:01
❤️
15:01
that for u
Avatar
Makes sure to ignore framebuffer values. This should be part of the next patch.

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan...
Avatar
@Deleted User are you here?
Avatar
yes
15:33
ok wait
15:33
im uploading a video
15:34
do you remember of my clan bug?
15:34
do i even know about it?
15:34
ye i think you already helped me about changing char to another thing
15:34
ah
15:34
yeah
15:35
check that, the first window with vscode is with linux terminal and the second with window
15:35
and the clan dont do the same thing
15:35
any idea?
15:35
to fix that?
15:36
isnt that the same bug again?
15:36
yes but u found the cause
15:36
this is a terminal bug
15:36
the value change when im moving or when i go to a specific tile
15:37
what is the correct name of the clan
15:38
0xo?
15:38
or do you mean the hex numbers?
15:38
i'd say its the same bug
15:39
just bcs its different client side doesn't mean its different bug
15:39
the server sends random stuff and the client does the same
15:40
Oxo is just the account name we dont care of that
15:40
yeah u probs mean the hex stuff
15:41
yes from the game
15:41
i'd say the server decodes the client message wrong, then sends the wrong name to the client and since its UB it acts weird
15:41
in the src i write do not set a clan to the user like that : str_format(aLevel, 16, " ", m_pPlayer->m_Level.m_Clan); (edited)
15:42
but maybe it also breaks when building the packets why not just use -fsigned-char
15:42
doesnt that fix all issues
15:43
there just is a difference if you do 1000 - 128 or 1000 + 255
15:43
or -1
15:43
then they'd be same memory
15:43
hmm ye
15:44
i just fixed it by deleting random lines
15:44
🙂
15:44
ah so it was just a patch from yourself? XD
15:44
thought u talking about just using a different mod or smth
15:44
and have the same bug again
15:45
yeah im using a old mod for remake it
15:45
yeah just always add funsigned-char
15:45
signed*
Avatar
@heinrich5991 was this statement still true? i can't find any reference of "serverlist_urls.cfg" in code.
Avatar
Avatar
TsFreddie
@heinrich5991 was this statement still true? i can't find any reference of "serverlist_urls.cfg" in code.
ddnet-serverlist-urls.cfg
16:16
just renamed ^^
Avatar
cool
Avatar
@TsFreddie u on windows rn?
Avatar
I'm in the shower rn
Avatar
WTF XD
Avatar
What do you need
Avatar
just want to know if screenshot still works
16:17
e.g. if its a common thing on windows
Avatar
I guess ask someone else. I don't really want to turn my PC back on for a screenshot😅
Avatar
yeah np ^^
Avatar
Should've asked like two minutes ago
Avatar
yeah nvm, maybe smone will read this ^^
Avatar
ignoring the screenshot bug, is ping supposed be half numbers and half EUR?
Avatar
its per ip address
16:37
so if its a different bug, yes
16:37
different ip* xd
Avatar
earlier today I saw only EUR
Avatar
once u connect it saves the ping
Avatar
so I guess it's intended
16:38
ugly tho
Avatar
its a trade
16:38
for not leaking the ip to ddossers
Avatar
it looks fine when it's all EUR
Avatar
possibly yes
Avatar
something about the width difference looks bad to me
Avatar
yeah
16:40
you not wrong ^^ (edited)
Avatar
so I'm wrong?
Avatar
hard language
Avatar
Poor ravie
16:51
f8fc05e Force alpha values from glReadPixel to 255 - Jupeyy e869c29 Merge pull request #3896 from Jupeyy/pr_read_pixel_ignore_alpha - def-
16:52
Avatar
@Deleted User do you happen to know if the body shade of the skin is also affected by a costum color?
Avatar
sadly yes
17:14
ok not sadly
17:14
but sadly for the greyscaling it isnt
17:14
so alpha shadows look wrong xD
17:15
was curious because otherwise you could maybe do some trickery with skins and parts of them that shouldnt be colored ^^
17:15
but I guess that wouldn't have been good :D
Avatar
yes, but i still think we should completly break vanilla 0.6 comp and fix the greyscale issue
17:16
e.g. glow skins suffer from this
Avatar
do 0.7 skins have this problem?
Avatar
they dont allow coloring it iirc
Avatar
not?
Avatar
you could fake it with the body marking
17:18
i think thats how i fixed it for my 0.6 to 0.7 tool
Avatar
hm, there is coloring
Avatar
yeah but shadows are ignored arent they
17:18
maybe it changed
17:18
let me test
Avatar
ah idk
Avatar
yeah color isnt changeable for the shadow
17:22
i like the 0.6 behavior more, but as said it also has its "bugs"
Avatar
I missed this during the serverlist_urls.cfgddnet-serverlist-urls.cfg rename.

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASa...
Avatar
@heinrich5991 looks like we are fetching info2.ddnet.tw first before master when user pressed refresh right?
Avatar
not in parallel?
Avatar
I'm not sure. Maybe the master is still super slow for some people
17:55
Ye they seems to be parallel.
17:57
Maybe the large amount of requests to the hong kong server is being picked up by the great firewall as a threat and throttled them somehow.
17:58
I thought a cn company owned hk server would have some privilege of being stable.
Avatar
I'm a bit tired from people constantly asking about the new client and troubleshooting their dns problem. I turned off my notifications just now so I can get some rest 😅
Avatar
poor tsfreddie :/
Avatar
aad9e76 Update settings & commands - def-
18:13
@Jupeyy any idea? 2021-06-12T17:14:38.9177810Z make[3]: *** [CMakeFiles/DDNet.dir/build.make:146: CMakeFiles/DDNet.dir/src/engine/client/backend/opengl/opengl_sl.cpp.o] Error 1 2021-06-12T17:14:38.9183750Z make[3]: *** Waiting for unfinished jobs.... 2021-06-12T17:14:39.2701400Z make[3]: *** [CMakeFiles/DDNet.dir/build.make:132: CMakeFiles/DDNet.dir/src/engine/client/backend/opengl/backend_opengl3.cpp.o] Error 1 https://github.com/ddnet/ddnet/runs/2810400145?check_suite_focus=true
Avatar
@TsFreddie hm, so it's really slow? Should we run a server in mainland China directly then?
Avatar
maybe
Avatar
5a584bd Fix help text of cfg var to mention correct filename - heinrich5991 6491f54 Merge #3897 - bors[bot]
Avatar
It is mostly ok for me. I'll do a poll tomorrow
18:20
I wish we can hook up our cdn directly. But we can't make it use ddnet.tw because cn cdns require cn company owned domain's with icp lisences.
18:21
Although I just tried to make it 302 to a cn cdn and ddnet client seems to accept it just fine. Maybe a small mainland server dedicated for serving 302 redirects would work?
Avatar
Avatar
TsFreddie
Although I just tried to make it 302 to a cn cdn and ddnet client seems to accept it just fine. Maybe a small mainland server dedicated for serving 302 redirects would work?
Since the master is getting hit with > 5M bandwidth constantly and we only have 5M on most of the mainland servers.
Avatar
Right todo
18:29
There are so many todos in the code I have to use // MYTODO: in my mods to identify which are mine. 😇
Avatar
xd
18:30
TODO_FIX_BEFORE_MERGE not fixed until today xd
Avatar
Bruh. I really don't know why so many people can't see the server list in china.
Avatar
how did they connect to ddnet server list before xD
Avatar
Some can access ddnet.tw with a browser. But not the masters ones
Avatar
it mean that was / is also a json isnt it
Avatar
Some can open the masters url in browser but still sees 0/0
Avatar
so its not a problem with the update?
18:59
Ye
18:59
It is weird
19:00
Maybe some people just don't know ddnet tab supposed to have stuff in it.
19:00
Most screenshot I received are showing internet selected
19:00
😅
19:01
And now i just tell everyone asked to use teeworlds.cn/browser
19:01
Can't be bothered troubleshooting rn
Avatar
ah ok, but interesting that tw master servers are not blocked
Avatar
master2 shouldn't be blocked too
19:03
Master2 is literally a tencent server
19:05
One theory I have is some places like netcafe or schools just block tw domain because Taiwan? But that sounds a bit ridiculous to me. And some do have access to ddnet.tw homepage just fine.
Avatar
1 issue was detected with this workflow: git checkout HEAD^2 is no longer necessary. Please remove this step as Code Scanning recommends analyzing the merge commit for best results.
https://github.com/ddnet/ddnet/actions/runs/931568951

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially...
Avatar
maybe we should just cache the current list?
19:12
in worst case its outdated
19:12
but not not shown at all
Avatar
Like in client?
Avatar
si
Avatar
Oof, I'm not sure about that
Avatar
it could be grey if its outdated
19:13
but also when refreshing e.g.
19:13
it would silently refresh it
19:13
instead of not showing it
19:14
@Ravie will know if showing a greyed out old list is appropriate for the human eye or if its more confusing xd
Avatar
😅 well it might make more sense for the old list. The new one would just dim all servers and lit all of them back up probably. (If you click refresh)
19:19
I should stop saying well and I guess
19:20
well, I should stop saying well and I guess I guess. kek
Avatar
well, i guess you should, yes
Avatar
Have you ever been so worked up during the day that you feel like sleeping at all even though you are tired af?
Avatar
i've had the opposite
19:26
like a burnout
19:26
doesnt matter what i tocuh i feel tired xd
Avatar
I think I'm having both of them at the same time
Avatar
so you are hyped for smth, but also burned out? xd
Avatar
Probably. was burned out before ddnet15 dropped
19:28
Then ddnet updated and my qq dm exploded.
Avatar
yeah coding creates burnouts really fast. you go full tryhard for few weeks
19:28
and then u completly fucked xd
19:29
Behold Chinese "emojis"
19:29
Or memes? I don't think they are memes, but they do look like them
Avatar
kinda of a mix
19:30
ryozuki's pepe emoji collection can answer this question xd
19:32
Ye was wondering why we have pepes as server emojis
19:34
poggers not complaining tho. Just didn't think the admins would made the call to add pepes.
19:34
Expect for jao maybe
Avatar
Avatar
TsFreddie
Ye was wondering why we have pepes as server emojis
everyone uses pepes here
19:38
Avatar
Dota2
Avatar
I have almost 1000 hours in dota2 but I played like 4 games total
19:39
afk in menu andy
19:39
monkaS i dont play at all
Avatar
Spend most of my time in custom game sdk
Avatar
autochess?
Avatar
dota is pretty famous over there right?
Avatar
I made Tetris in dota2
19:40
Didn't finish and release it in the end
Avatar
Avatar
Ryozuki
dota is pretty famous over there right?
Probably. I wouldn't know lol
Avatar
they have a pro scene, since they nearly won The International 2019
19:41
The International is like the grand doto tournament featuring a 40.000.000€ prize pool
19:41
i guess thats a lot of chinese coins
19:41
monkalaugh
Avatar
Autochess might be pretty popular since most mobile game provider has a variant of it
Avatar
May I know why you guys ordered the servers in regions?
Avatar
Avatar
Pepe
May I know why you guys ordered the servers in regions?
the ping changed to region cuz we cant know ping accurately without leaking ips to bad actors
19:43
the leaked ip is then used as spoofed ips for ddos
19:43
iirc
Avatar
Avatar
Ryozuki
the leaked ip is then used as spoofed ips for ddos
Wait so that's how that worked
Avatar
I mean, it's a little bit bugged, because for me, servers in SA, appear as good ping, but its clearly not a good ping xd
19:44
And NA appear as bad, when it's good
Avatar
yeah i think that has to be fixed with some matrix stuff
19:45
And it's taking a lot more to load up all servers when you open the game, why is that?
Avatar
Finding the best serverlist server takes a bit of time.
19:49
The 4 list servers seems to be randomly chosen then pinged individually. And the best one was cached too, so it should be a bit faster on the second launch.
19:50
Thx!
Avatar
@Ryozuki I have 2 questions, can you do a small code review for me and have you ever worked with tokio-rs/tracing?
20:02
I guess the same goes for @heinrich5991, but I think you already said you haven't worked with async in rust
20:03
https://github.com/Learath2/discordbot I'm looking to replace part of the bot with this so I can actually debug both sides
Contribute to Learath2/discordbot development by creating an account on GitHub.
Avatar
I should learn rust
Avatar
go sleep xD
Avatar
@TsFreddie I'm in a bit of a love/hate relationship with it, it's limitations are rather annoying and it's libraries are nowhere as mature as they make themselves out to be, but it really does error handling the way I would in my imaginary language
Avatar
@Learath2 did u know TEXT actually is more space efficient than varchar
20:07
atleast on sqlite and psql
Avatar
Depends on the db engine, but yes I did 🙂
20:08
nice to know u prefer rustls over openssl
20:08
poggers
20:09
it may not have a long history like openssl, but they take it serious, here is an audit https://github.com/ctz/rustls/blob/main/audit/TLS-01-report.pdf
A modern TLS library in Rust. Contribute to ctz/rustls development by creating an account on GitHub.
Avatar
I would use openssl but I didn't feel like the linking issues that could come with it
20:10
and besides it's not really exposed to the outside so rustls should be fine
Avatar
@Learath2 can u run "cargo fmt" and push
20:11
it would help me xd
Avatar
I still use ts/js as my go-to language for everything. But I finally run into problems like having to many node apps running in a server that the 1gb memory is running dry.
20:12
😅
Avatar
See this type of stuff is very meh for me, I prefer to format my code myself :/
20:12
I'll run the cargo fmt, sure
20:13
oh, I can't rn, am on windows
Avatar
my personal web under rust uses 35mb
Avatar
Avatar
Learath2
oh, I can't rn, am on windows
why u wouldnt be able on windows
Avatar
I don't have any developmentstuff on windows, it's strictly for games that refuse to run under linux
Avatar
Avatar
Learath2
See this type of stuff is very meh for me, I prefer to format my code myself :/
well its not like u formatted it at all
20:14
cargo fmt is rly good imho
20:14
and everyone uses it
20:14
you can configure it too btw
20:14
rustfmt.toml iirc
Avatar
Yeah, I'll take a look at it
Avatar
My node apps are mostly in the 40mb to 60mb range. But they are really simple. I don't know why I made them separate node apps tho. I have 5 of these running rn.
Avatar
i also had my phase of node apps
20:16
xd
Avatar
Also I need 600mb for my telegram bot. Which might be the main problem than node apps tho.
Avatar
Avatar
TsFreddie
I still use ts/js as my go-to language for everything. But I finally run into problems like having to many node apps running in a server that the 1gb memory is running dry.
node is really wasteful, rust is actually the best backend for web I've seen yet
20:16
actix works really well
20:17
@Learath2 a competitor is appearing soon again
20:17
Rocket is a web framework for the Rust programming language that makes it simple to write fast web applications without sacrificing flexibility or type safety.
20:17
they just need to release it
Avatar
I'd imagine anything native would be more efficient than node
Avatar
I found a feature rust needs immediately. Specializations for generics
20:18
I guess it already has it but need it to be stabilized rn
Avatar
This is a tracking issue for specialization (rust-lang/rfcs#1210). Major implementation steps: Land #30652 =) Restrictions around lifetime dispatch (currently a soundness hole) default impl (#37653...
Avatar
justatest I don't even know why I love typescript so much
Avatar
i think u can try it on nightly with #![feature(specialization)]
Avatar
Avatar
TsFreddie
justatest I don't even know why I love typescript so much
because javascript is so ugly that typescript looks beautiful at its side
Avatar
Ever time I need something in other languages I try to find a typescript transpiler first lol
20:21
Typescript2Lua is pretty cute. Got me through the Dota2 custom game API shithole.
20:22
It's like an addiction
20:30
nvm
20:33
@Learath2 r u sure this works as intended? https://github.com/Learath2/discordbot/blob/master/src/main.rs#L106 isnt it like this? tokio::spawn(async move { handle_message( msg.0, config.clone(), discord_http.clone(), http_client.clone(), pool.clone()).await; }); (edited)
20:36
sqlx also probs has a feature chrono that will do the datetime stuff for u
20:36
+ thiserror
Avatar
It was a way better when I could just check all servers' pings to choose correct one, now I can't see them (color of Russian servers is as yellow as Europeans and marked as EUR).
Avatar
Avatar
Ryozuki
sqlx also probs has a feature chrono that will do the datetime stuff for u
the stable version doesn't have datetime for sqlite yet
Avatar
sqlx = { version = "0.5", features = [ "sqlite", "runtime-actix-rustls", "macros", "migrate", "chrono", "uuid" ] }
21:01
it does
21:01
@Learath2 use NaiveDateTime instead
Avatar
they must have added it a second ago because I just checked it 😛
21:01
It doesn't have datetime at all for sqlite, they just added it 13 days ago on master
Avatar
NaiveDateTime
21:02
DateTime<Utc> is used for timestamps with timezone
21:02
but sqlite doesnt support timezones iirc
Avatar
I'm sure I tried that too, but I'll give it another try when I boot back into linux
21:03
sqlite doesn't support DATETIME at all, they don't even do column types
21:03
they have datetime functions of their own which you use to fill a column
Avatar
add chrono to sqlx features
21:05
it will parse it correctly
21:05
DATETIME in sqlite is an alias to numeric
Avatar
All column types in sqlite is the same internal type, you can put a string inside an integer if you want
21:06
s/is/are/
Avatar
well i dont care about that
21:06
im just telling u u can use naivedatetime on rust side
Avatar
Avatar
Ryozuki
@Learath2 r u sure this works as intended? https://github.com/Learath2/discordbot/blob/master/src/main.rs#L106 isnt it like this? tokio::spawn(async move { handle_message( msg.0, config.clone(), discord_http.clone(), http_client.clone(), pool.clone()).await; }); (edited)
No need to wrap it in another closure, the only requirements for T is that it's Future + Send + 'static and it's output is Send + 'static
Avatar
thanks for approving promt translation into russian.txt 👍
Avatar
7dd4b5e Don't use HEAD^2 in codeql anymore - def- 32523b1 Merge #3900 - bors[bot]
Exported 621 message(s)