DDraceNetwork - developer

[ddnet/ddnet] Issue opened: #3893 Add a minimum vote time required for vote to pass, if someone has veto privilege.

There are several times people getting voted out of their progress by a group of 4 ~ 6. They can usually join-vote-pass in less than 3 seconds.

1

05:13

TsFreddie

[ddnet/ddnet] Issue opened: #3894 Allow team chat to by-pass chat delay restriction

Allow team chat to ignore chat delay/chat initial delay if the race has started (so, no others can join and spam the team)

1

TsFreddie

[ddnet/ddnet] Pull request opened: #3895 Translate "Name" and "Time" header in ghost menu

!image These two headers weren't translated.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physic...

github search keyword highlight is drunk. I thought this was something that needed a fix.

ChillerDragon

[ddnet/ddnet-data-svg] Pull request opened: #25 Fix shellcheck errors and add shellcheck to CI

@deen: @Deleted User can I get at least 24h to have a look at the data svg prs? :)

https://rocket.rs/v0.5-rc/news/2021-06-09-version-0.5-rc.1/

Rocket v0.5 Release Candidate - Rocket Web Framework

Rocket is a web framework for the Rust programming language that makes it simple to write fast web applications without sacrificing flexibility or type safety.

06:58

yo @TsFreddie any plans on porting your text refactor to ddnet? :)

it's too much work justatest

yea i can imagine

07:12

but two different text renders are splitting the code bases even more :/

can it be done step by step? without doing all the work at once?

07:13

is there a way i could support you without knowing what this all textrender stuff is :D

maybe. the TextEx can be replaced without touching all other parts.

07:13

i think

you removed textex right?

i rewrote a new layout code, it behave differently so i just dropped the textex name with something

07:14

else

07:17

if should be possible to port TextDefered and MakeWord as a replacement for TextEx.

07:17

it should be*

sounds like a start :)

def-

[ddnet/ddnet-data-svg] Pull request closed: #25 Fix shellcheck errors and add shellcheck to CI

07:17

def-

[ddnet-data-svg:main] 4 new commits

3d85f00 Fix shellcheck errors and add shellcheck to CI - ChillerDragon a93bbdc Run CI for prs - ChillerDragon ef1aa5e Fix check meta - ChillerDragon 5fd0abc Merge pull request #25 from ChillerDragon/pr_shellcheck - def-

but the behavior of text need to be reexamined case by case for every TextEx call

07:18

which is most of the work for vanilla. is just to redo all text.

07:22

we can also nuke all gpu optimization for text in ddnet, get the entire thing over here. then redo the gpu optimization

. but i'm not sure if that's easier.

or we port gpu optimizations to vanilla and then take all back?

you can't

07:24

at least you can't do it without extending teeworlds's graphic code.

bors[bot]

[ddnet:master] 2 new commits

32b8c8c Translate "Name" and "Time" header in ghost menu - TsFreddie ddcf654 Merge #3895 - bors[bot]

07:25

bors[bot]

[ddnet/ddnet] Pull request closed: #3895 Translate "Name" and "Time" header in ghost menu

yea no omg i do not feel comfortable replacing TextEx

ye...

Chillerdragon webhook

09:37

Smart people in here right?

11:03

I've got a few questions if anyone is willing to answer them

don't ask to ask, just ask ^^

Its not involved with teeworlds thats why @murpi

#offtopic then

chillerdragon

@deen: @Deleted User can I get at least 24h to have a look at the data svg prs? :)

You can look at them the whole day xd

TsFreddie

[ddnet/ddnet] Issue closed: #3893 Add a minimum vote time required for vote to pass, if someone has veto privilege.

@heinrich5991 https://paste.pr0.tips/Fe am I doing something wrong?

14:21

How is this compiling so awfully?

14:22

I'm doing like some TRIVIAL string manipulation

what are you trying? separating "words" by whitespace?

yeah, just return one word

14:23

(I need to do some bookkeeping for further lexing, so I can't just .split_whitespace()

14:23

s/$/)/

Split once?

@Learath2 no, I don't immediately see why this is slow

@Ryozuki need to keep track of indices

https://doc.rust-lang.org/std/primitive.str.html#method.split_once

str - Rust

String slices.

14:28

Ah

Well it's probably not slow in any amount you'd care about anyway, the assembly looks concerning to me

the only thing I notice specifically is that you're splitting on all unicode whitespace

14:29

ah, then this info might be relevant ^

On rust all strings are valid unicode

14:30

I think indexing is harder somethimg about glyphs idk

utf8*

14:30

no

14:30

it's still indexing by byte offsets

indexing by graphemes would be harder, rust just uses fixed size (4 bytes iirc) per char

no, &str uses UTF8 as representation

14:32

the indices are byte indices into this byte array

@Learath2 do you always look at the assembly output of everything you do?

14:32

Should i do that too?

Ryozuki

@Learath2 do you always look at the assembly output of everything you do?

Just while i'm learning a language so I can know it's characteristics

@Learath2 I'm somehow missing a "get index from slice and element"

e.g. what to avoid in critical paths, like virtual calls in languages with bad devirtualization in their compilers

but you can probably hack it yourself

I would only look at it if i was doing something where i know i can help the compiler vectorize it