DDraceNetwork - developer

[ddnet/ddnet] Pull request opened: #3888 Send server info request for ping with different token

Thanks to @Jupeyy for figuring out this bug. Previously, the client would send the request for server info and the server info ping packet with the same token, making the answer indistinguishable from each other. Fix this by generating a token that won't collide. Fixes #3862.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if i...

I spent 6 hours trying to shove an async fn into a Box

03:34

Finally got it to fit in there but my lifetimes don't work out now because I bounded the fn with 'static

Jupeyy

[ddnet/ddnet] Pull request opened: #3889 Don't refresh, if a job is already running

fixes #3856 @heinrich5991 can you check if this is ok, then we can also add it to the release

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change wi...

03:42

Jupeyy

[ddnet/ddnet] Pull request opened: #3890 Remove unused variables

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

HEEEY

05:56

HELP ME

05:57

Need help not for teeworlds, but for me

05:57

SOME ONE PLSSS

bors[bot]

[ddnet:master] 2 new commits

fea070a Remove unused variables - Jupeyy 218705b Merge #3890 - bors[bot]

06:49

bors[bot]

[ddnet/ddnet] Pull request closed: #3890 Remove unused variables

@Deleted User lmao nice old shit

06:58

google mod src was a mix of bad code

06:58

I'm sure you can still find some if(!this) by marcella

@loky what do you need?

Deleted User

make sure to update win7 to latest here is the latest win7 64bit nvidia driver https://www.nvidia.com/Download/driverResults.aspx/82758/en-us

so i'm sure

10:04

he updated win7

10:05

i adviced download default teeworlds from teeworlds.com

10:05

it works

10:05

but ddnet isn't

justabutterflier

but ddnet isn't

I dunno, he can set a steam parameter for the game: gfx_opengl_major 1 But if that also doesn't work it seems to be his setup. Tested nightly yesterday on a VM and it worked

12:19

Better put the parameter in quotes "gfx_opengl_major 1"

12:22

E.g. anti virus are often blocking

hehe no ur not the only one ofc. I mean I aint no saint i also sometimes trash message but in your main project where ppl can be interested in it makes sense to at least try :p (@fokkonaut)

fokkonaut

chillerdragon: and u think i am the only one with such commit messages

12:29

@Deleted User: why use google mod when you can use F-DDrace it also has funny commit messages but the project is activley maintained and supports 0.6 and 0.7

He already used F-DDrace and did the jason54, changing mod name and credits removing me entirely from credits :)

lmao he did the jason

def-

[ddnet/ddnet] Pull request opened: #3891 Add timeout for serverbrowser http request

to prevent getting stuck entirely. Following #3889

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](htt...

Jupeyy

[ddnet/ddnet] Pull request closed: #3891 Add timeout for serverbrowser http request

bors[bot]

[ddnet:master] 2 new commits

97a8fcc Send server info request for ping with different token - heinrich5991 b445862 Merge #3888 - bors[bot]

15:46

bors[bot]

[ddnet/ddnet] Issue closed: #3862 Double serverinfo causes 0 ping

15:46

bors[bot]

[ddnet/ddnet] Pull request closed: #3888 Send server info request for ping with different token

Guys make some option that will not close the vote after selecting it. A small thing, but nice, and what is the cl_show_votes_after_voting option?

16:15

about menu status

set cl_show_votes_after_voting 1 and the vote window won't disappear after voting.

16:44

@Kurosio

I have one question, why do all newfangled languages remove the post and pre-increment?

16:46

Is it just out of spite?

its too much advertisement for c++ they are scared to lose users

Or is it the rite of graduation. Something to say you are not C

murpi

set cl_show_votes_after_voting 1 and the vote window won't disappear after voting.

does not work for me

where did you type it

it works solely on the client side have not entered any flags or? (edited)

it's a client side command

I understand that this is a client command I asked how it is implemented

search the source code for ClShowVotesAfterVoting

16:50

(I don't know how it's implemented off the top of my head)

Oh and the languages that remove the ternary because their if-stmts are expressions. That's great for your language but it doesn't look pretty...

heinrich5991

search the source code for ClShowVotesAfterVoting

ok

17:01

That's different

Kurosio

does not work for me

u are probably talking about the menu vote window?

17:04

not the actual vote window?

Kurosio

about menu status

yes

yeah but that isnt clear enough, anyway there is menus_ingame.cpp

17:06

there will probably be the answer

17:08

UiCloseWindowAfterChangingSetting

17:08

or ui_close_window_after_changing_setting for f1

Deleted User

or ui_close_window_after_changing_setting for f1

ty

why is the zoom not working on the classic teeworlds server?

@loky it's considered a cheat there

aha ty

17:17

in ddnet it is possible to prohibit zoom?

17:17

on server

The server can send a GAMEINFOFLAG_ALLOW_ZOOM set to false to disallow zooming

oh ye at gamecontroller?

17:19

if I am not mistaken

yes

ty

loky

in ddnet it is possible to prohibit zoom?

You can also change it mid-game, done in my mod for example :)

fokkonaut

You can also change it mid-game, done in my mod for example :)

0.6 > 0.7