DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2021-05-29 00:00:00Z and 2021-05-30 00:00:00Z

[ddnet/ddnet] Pull request opened: #3860 Fix a woopsie in snapshot docs

Typodragon back in the game

applied

07:40

chellirdrogan

ChillerDragon nobo fix the other typo

wtf

Image attachment

did u get the git submodules

07:55

git submodule update --init --recursive

[ddnet/ddnet] Issue closed: #3859 Font renders red since #3798 (debian 10, gnome on xorg)

what other typo Ryozuki?

check your pr

smbd know how to check if i killed someone in client? i used to do it with killfeed but it not always works and if i turn killfeed off it doesnt work at all

ripozuki

09:10

yo can we get some more modding friendly notification api?

09:12

I would like to use CClient::Notify(const char *pTitle, const char *pMessage) in my custom ddnet client but have my own configuration if notfications are shown.

09:15

Since m_pGraphics->WindowActive() is only reachable from within CClient one has to call the CClient::Notify() method and can not implement a custom one without editing client.cpp which means the https://github.com/ddnet/ddnet/blob/e5e2e46da295cec9587c28a0b8a57a9494ff68fb/src/engine/client/client.cpp#L4104 cl_shownotifications check is forced. So if i want to see custom notifications i have to see ALL ddnet

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

09:15

notifications which i do not :( any idea how to add custom notificaton code without touching too much of ddnet code base. Or can we change the ddnet code to make it more customizable?

I mean it's fairly customizable as is, it's just that your odd usecase is... well odd

why odd?

You should probably just comment out all uses of Notify that you dont want to see, or add minimally intrusive filtering, e.g. an enum for notification types with NOTIFY_DDNET being the default notification type

09:25

Then you can add an if(Type == NOTIFY_DDNET) return;

Commenting out all notify use cases sounds very intrusive to me

09:25

it would be nice to have own configuration of which notfications are shown without touching any line in ddnet code base

I mean ddnet rarely uses notifications to begin with

ye liek 3ish places

09:27

but those create a bunch of notifications already

If we were using them left and right I would agree to add some config options to only enable specific ones.

09:27

Where are they used except for highlights and votes while you are logged in?

ye sure we do not need that yet

09:27

but it would be nice if custom clients could add config

09:27

without changing ddnet code

09:27

do you know what i mean?

[ddnet/ddnet] Pull request opened: #3861 Add SendNotifications for custom ddnet forks

Allows custom clients to implement own config system without touching ddnet notify api

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+...

just something like this

I mean the way I mentioned it would be only like 2 new lines 1 modified lines in client.cpp, 5 new lines 1 modified line in client.h

yes

09:29

thats waaaaay too much for me

I think that is clean enough that it would merge fine

if you add 5 lines here and there for that and then 2 lines here and then add another feature this client wont merge in 3 years anymore

09:30

i feel like notifications is something that should be easy to use as a modder dont u think?

Well I disagree with that. A single parameter added to a function and a new enum would never break anything

it can cause git conflicts

Notifications are easy to use though, it's the fact that you want to remove some of our notifications that's complicating things (they are also trivial to remove imo)

https://github.com/ddnet/ddnet/commit/8648b1a7dcf6711d1ca8c4dd1fc1adb552fd8411

Don't push notification when active · ddnet/ddnet@8648b1a

09:32

that commit for example would have caused merge conflicts then

It would cause an absolutely trivial one. You can't avoid those

well you could if #3861 was in place

I mean we can put code to disable parts of ddnet everywhere but that's just impractical

sure its impractical

09:34

and might not fit everywhere

09:34

but as i said notifications seems like a sane place doesnt it?

Does it though? It sounds like a solution to a problem that only you have

yes it does

09:35

i mean it is a problem only i have probably

ClShowNotifications is meant to disable ALL notifications. You turn it into "Disable DDNet Base notifications"

yes

I think that's just creating a loophole to then abuse. If we want to allow this weird configuration why not be explicit about it?

what do you suggest?

09:38

implement more complex configuration code into ddnet?

09:39

exposing m_pGraphics->WindowActive() would also work but that sounds even more hacky xd

If we have to have this in ddnet (I don't think we do since imo merge conflicts are just part of the deal), I stand by my initial suggestion. We add notification types

wait by We you mean ddnet repo?

09:41

sure merge conflicts are part of the game but wouldnt it be nice if they werent? :D

Yes. That's the explicit way of allowing this, not decapitating a config option

could you shoot a pr then? :)

Well I don't think it's necessary to begin with, so I don't think I will. Sorry, maybe the others think differently

doubt

09:44

veri sad

09:45

are there any c++ hacks how i can access private variables? :D that would also work

FWIW you calling NotificationsNotify yourself is waaaaaaaaay more hacky than just adding 2 lines to Notify

i dont mind hacky

Cutting through the abstraction is nono

well its no abstraction

09:47

ok maybe it is

chillerdragon: I have an idea for you, why don't you inherit from CClient and just override Notify?

09:50

It would just be like a 3k line patch

xd

09:51

if the 3k lines are in my own files that would be ok

09:51

but i feel like it would require to alter ddnet code

idk for me the 2 line merge conflict that actually probably will never happen because git-merge is quite smart is so acceptable that I can't really think of a fix that would make both you and me happy

09:52

CClient::Notify changing signatures would be the only way a merge conflict happens and that's also incredibly unlikely

git merge gets confused quite fast imo even when code around it changes

A separate if block almost never will trigger a merge conflict

i think i saw those quite often

btw WindowActive() looks like it's public, why can't you use it?

cuz im stoopid maybe

You just need to read it, right?

ye

and what do you have access to from your class? just CClient?

i can only get access to the IClient thing not to CClient

or IClient?

i want to access it from my class

09:56

so i dont alter cclient class

09:57

LMAO

09:58

i found something neat xxD

Just go through the kernel to get a pointer to IGraphicsBackend?

#define private public //This is the hack to access priviate variables of any class

09:58

make all vars public

09:58

with only 1 line of change

now that is absolute cancer

haha ikr

09:58

but not very intrusive

09:58

and covers quite some use cases

You also need #define protected public

ye

09:59

but wait

09:59

its private by default isnt it?

09:59

so i still need to add a public: at the top of all classes

09:59

ok crap

10:00

<twbridge_ "[ddnet] <Learath2> Just go throu"> yes something like that

10:00

sounds hacky and expensive but how hard is it?

10:00

https://github.com/Narasimha1997/DirtyPointer-Hack/blob/master/PrivateVariable.cpp

Narasimha1997/DirtyPointer-Hack

A hackaround on C++ private class members and methods to access them outside the class even though they are private. (GNU GCC compiler, Linux) - Narasimha1997/DirtyPointer-Hack

10:00

sounds like this

((IEngineGraphics *)Kernel()->RequestInterface<IEngineGraphics>())->WindowActive()

probably even more conflict prone when the offset changes due to member variables changing

here you go, your hack of the day

oh wait u mean tw engine kernel not linux kernel xd

lol you actually considered going through the linux kernel?

urs looks really neat

10:02

haha

10:02

im desperate

I mean you could probably using ptrace

i watched too many security yt videos xd

10:04

using tw engine is so smart

10:04

wew it compiled

FWIW if you don't mind being hacky you can just get any graphics interface pointer and reinterpret cast it to a pointer to the implementation

ok lets see

10:04

not bad

10:04

idk what that means but cool

IGraphics *m_pGraphics; IEngineGraphics *m_pEngineGraphics = reinterpret_cast<IEngineGraphics *>(m_pGraphics);

why is code format bugged

did u fail that or bridge?

I sent it in one line, didn't want to spam irc

i think only 1 line works anyways

10:07

otherwise u got ` in seperate messages due to irc

10:07

but here only one ` arrived so no format

10:07

sad

hm, I see two ` in quakenet

im sure ill get back to that cast one day

woot how

10:08

wtf

10:08

i see 1

btw we want to get out of freenode soon-ish

yikes

we have a new matrix bridge

ddnet also anti freenode cuz shitstorm

10:08

i still dont k what happend with freenudes

10:09

oh so a selfhosted bridge?

we don't host it no

ah

t2bot iirc

bot

10:09

:ban:

tl;dr on the freenode thing: freenode sold, richman said worry not I won't interfere, staff said k, richman interfered, staff left, richman started taking over channels that moved to other networks so we were justified in being worried

richman is a name or a male having much moni?

10:12

wait so freenode was bought with staff but then staff rage quitted? xd

male with money, his name is Andrew Lee, bitcoin millionaire

so freenode is now run by a male?

10:13

thats so fucked up

10:13

literally the worst gender ok when can we leave?

the fucked up part is that he is interfering with the day to day operations of the network

why does bitcoin millonaire always sound so negative? :D

10:14

like what exactly?

10:14

sorry to ask u all instead of doing reasearch

10:15

i very much appreciate ur tldr

well it all began with him wanting to inject his own people into the elected staff

i mean he bought it

10:15

so who can blame him?

well there is a bit of a story there, the old head of staff sold it unilaterally without asking, all of the volunteer staff was ready to quit right then

10:16

but richboi said worry not, I won't interfere with the day to day operations at all, and staff agreed to stay under that pretense

how much shit storm did the person get who sold it? :D

10:18

cashing out on freenode lmao

she deleted her twitter

oh lol so she was female?

yep

haha love it

10:18

poor her

10:18

she now rich gal but cant flex it on twitter

anyway, it is indeed mr richman's right to fill the staff with whomever he wants, he did buy the thing

learath go apply for staff

but the volunteer staff has no obligation to stay, nor do the people who sponsor the servers to the network

and all those ppl moved united to new network?

a sizable chunk of the volunteer staff set up a new network, owned by a swedish non-profit with bylaws that prevent this kind of thing ever happening again

do we stay on any irc?

we stay on quakenet as we always have, Ryozuki and I are holding #ddnet on libera.chat incase we want to use it

is libera the swedish stuff?

yes

alright

10:21

i feel so informed now

10:22

right... so how much to buy ddnet and intefer with daily operations such as notfication api?

most projects migrated to libera, some went to oftc, some are still staying on freenode

10:22

send 3 million euros in monero and I'll give you all the keys

oof yikes

10:23

but then u have to delete ur twitter

C'est la vie

learath ready to cash out leaked

I don't use it anyway

10:23

3 million euros I can use to buy nice anti ddos and make a new ddnet

hm

10:24

that freenode gal should do that

she probably wants nothing to do with any of this anymore

if she has money and free time maybe we can get here to play on ddnet :)

she got blasted when she first sold it, now that it all fell apart I don't think there is anyone that wants her to hold the keys to anything

i would share my save codes with her

simp

ye cuz she is female

10:25

and famous freenude owner

10:26

wait do we run into any risk now shit talking that mr rich guy?

10:26

since we do it on his network?

10:27

or is it not that bad?

there are some popular channels he was watching for his name and k-lining people but he stopped that after people spotted it

10:29

if you mention libera.chat in your topic and the channel is larger than a certain size the freenodebot will come and take over the channel and change your topic

oh yikers

10:31

Yo Andrew Lee i fan pls send bitcoin

10:31

i stay on freenude for u

OMAGAWD @Learath2 it works so good

10:43

pls marry me

[ddnet/ddnet] Pull request closed: #3861 Add SendNotifications for custom ddnet forks

@heinrich5991 you said in the pr " For servers not supporting the new serverinfo protocol, there is a 1/256 chance that a serverinfo is confused with another serverinfo that was requested by a different part of the code." Can't we remove the other code part? Ping 0 is still a big problem

12:31

i get it like 50% of the times btw

12:31

not 1/256

Hm, 0 ping shouldn't be a result of that tho, a random wrong ping would be the result I'd expect

yeah dunno, maybe ping is clamped or smth?

13:00

also had a lower than possible ping already

Hm I doubt the random result can be negative. But since 50% is a lot maybe you can try a conditional breakpoint?

13:01

If ping is calculated to be 0ms break and see wtf went wrong

i can try

13:05

m_CurrentServerCurrentPingTime equals time_get

13:06

client.cpp L1484

13:07

maybe we can just ignore the extended server details or split the ping pong into 2 ints

Hum, so time_get() - m_CurrentServerCurrentPingTime somewhere equals 0?

yeah

13:09

i assuem the client just tries to send another ping pong as soon as then extended server details come in or smth?

I'm not sure how this was implemented, I'll take a look

ah

13:12

when i ignore ping pong if either vanilla server details were found or extended it works

13:12

so dont allow it to happen twice

13:14

@Learath2 you should note that is for old servers

13:14

that send both server detail packages

such servers exist? L:D

kog, fng

I thought you either sent extended or vanilla

so 90% of my favorite list xd

(since extended is compatible with vanilla)

vanilla 0.6?

hm, actually no, we did break compatibility there and modified the request instead

13:16

but as soon as you get the request you know whether the client understands the extended protocol or not

13:16

why send them both at that point?

yeah, tho it does happen

@noby explain your goofery

and i guess ddnet 10 or smth still expects this

13:17

anyway, if we dont need vanilla server details, drop it

fng is based on ddnet 10.8 and the info reply code is changed abit because its using caching

13:17

do i need to fix something

its alot of servers

13:17

not only fng

13:17

its also my fng code btw

hm, maybe ddnet 10.8 behaved like that, I wonder why we even bother sending both

Deleted User

its also my fng code btw

i pasted alot of ur fng code into ddnet code base

13:18

and edited it

guess 4 years ago that was the way todo it

Is it okay that after i do SendKill(-1) in code it kills me after 5 seconds? I didnt make any delays or hard to calculate if statements

since i also just looked into ddnet source

hm, your fng2 code only seems to send legacy info, where do you send the extended one?

anyway if we get vanillla details, we can also just ignore the extended always(for ping pong=

13:19

wait but it does

you send inf3, I can't even find the constant iext in your code

13:21

(or I'm grepping wrong, it's possible)

u gotta switch to 0.6 branch

ah, found it, you send the legacy 64p serverinfo with fstd

13:21

not iext

https://github.com/Jupeyy/teeworlds-fng2-mod/blob/fng_06/src/engine/server/server.cpp#L1490

Jupeyy/teeworlds-fng2-mod

FNG mod for teeworlds, that advances the original FNG idea by golden spikes and other features - Jupeyy/teeworlds-fng2-mod

13:21

yeah

13:21

thats possible

But even back then we knew which to send to the client, did we really send both?

anyway, as the server is aware if the client supports 64p as soon as the client receives the vanilla ones it can ignore extended forever for the ping pong process

I'll checkout ddnet 10.8 to investigate

i guess the client just didnt send the extension required

13:24

like a extra bit that indicates it or whatever

13:26

i see it just uses a flag Packet.m_Flags & NETSENDFLAG_EXTENDED

Okay, the last time this protocol was used was in 9.3.2

13:27

But for connless both ddnet 9.3.2 and fng2 only send the correct one and not both

13:27

for ingame serverinfo both seem to send 2 indeed, god knows why

maybe it was that the client just sends 2 requests

13:28

cant remember

13:28

but somehow it ended up like this

I'd suggest you all adopt the actual new (been here since ddnet 10) extended protocol from #322

https://github.com/ddnet/ddnet/pull/322

Introduce new, vanilla-compatible server info protocol (also known ...

This means that we have a reliable and fast way to query for extended info, while also not wasting network bandwidth. The protocol is designed to be extensible, there's four bytes space for...

SERVERBROWSE_INGAME was how the double send was dropped, anyway the ping code needs to be fixed to cope with servers that can't upgrade, so let's create an issue

[ddnet/ddnet] Issue opened: #3862 Double serverinfo causes 0 ping

Prior to #322 while ingame servers sent both the vanilla and the old extended serverinfo packets. The double send causes a 0 ping in the new ping calculation. Reported by @Jupeyy

I think(tm) the serverinfo part of the code you can pretty much copy and paste into your own code fwiw. Hopefully I didn't code it too dirtily, it is a bit of a mess to keep a decades worth of compatibility around

Learath2

I'd suggest you all adopt the actual new (been here since ddnet 10) extended protocol from #322

i agree on that, but many servers wont update tho

13:40

ddnet also uses old code from me i think

old code? for serverinfo?

13:44

much of the serverinfo stuff was rewritten in the pr above and I rewrote a lot of it too to hack caching in there

nah i mean generally

13:44

outdated code

13:44

like not latest master

hm, I don't follow, you mean as in the official servers are not running master?

yeah they run like 1-2 years old code

ah you mean the fng servers, yeah we haven't really kept up

yeah i just mean, the ppl running servers might never update

13:46

as they dont care

13:46

just like kog never updated until avo joined kog

13:46

and imo the fix is ok client side

Learath2

I'd suggest you all adopt the actual new (been here since ddnet 10) extended protocol from #322

I said this for you and @noby. I know many hosters don't care

not too much trouble

13:47

yeah

13:47

thats why i wrote i agree on that

it's also less traffic for you

13:48

I wonder if we drop all compatibility and show just a "download a recent version to play" how many people we'd drop

13:48

like who even still plays with vanilla 0.6

i dont even fear client side

13:48

i fear that some mods wont work

13:48

and then ppl are like why is bomb mod not working anymore

13:48

smth like that xd

what do i have to change

@noby well idk what you are doing right now, but if it's what jupeyy is doing you should probably just take what we have in ddnet and bolt it on

it isnt

13:49

im using a modified version of ddnet 10 info reply

13:49

i just added caching and a few other small changes

so you are correctly sending iext packets and only sending a single type to people ingame?

im not sure id have to check

grep for SERVERBROWSE_INGAME if it's there you are fine

he does send all server packets xD

13:51

the https list is correct for his mod

13:51

but it still has ping 0 apparently

13:51

just like kog does rn

anyway, I'll go back to math

gl

I guess heinrich will fix the ping thing sometime and the servers can fix their serverinfo stuff if they feel like it

13:52

and when native http serverinfo support comes along we'll all be golden

i swear im gonna set a bounty on /swap fix

time for bounty hunting

14:41

monkalaugh

Image attachment

Learath2

Click to see attachment 🖼️

monkalaugh

(edited)

My professors are seriously all so annoying, why are they renaming everything? The guy calls a gated d latch a d flip flop

15:46

How am I supposed to follow this mans lectures when I have to correct his terminology in my mind all the time?

15:47

When you say d flip flop I think of a positive edge triggered d flip flop

if you get used to something, it's hard to leave it

There should be some regulatory body enforcing correct usage of terminology in lectures and maybe some standardized higher level mathematics courses

16:12

Everyone just picking and choosing terminology means we can’t browse the vast internet for extra knowledge, means we can’t ask for help easily

is it really that bad?

For math proofs I have to provide all the required definitions when asking for help because the author of this book decided to slighltly modify them

16:16

E.g. a region has to be G-Admissible for the gauss green theorem to be correct. Good luck finding the definition of g admissible anywhere on the internet

so only math is the problem, isn't it?

Well math is an example, as you see the computer architecture professor decided to define d flip flop as a gated d latch

but that's somewhat obvious i think

The ESTM professor likes to use SR NAND latches, the architecture guy SR NOR latches

Comrade

but that's somewhat obvious i think

How is it obvious at all? An edge triggered d flip flop can be implemented as two gated d latches in series

16:23

You can’t use the part and the whole interchangeably :d

it probably doesn't matter much unless you're going to design your own hardware

Why teach it at all then? The point of the course is to learn some computer architecture

16:25

If you don’t want to go that deep in your lecture then just give us blocks to put together

i think courses at uni are just too short to learn something in deep

16:27

and learning many different things at the same time isn't really helpful as well

sendhelp

Depends on the uni, Depends on your definition of deep

i'm glad I'm done with my degree

16:28

pepeH

I have to learn and keep in mind proofs for all the theorems I use in analysis 2, that’s fairly deep, not extremely deep but very deep

16:30

If you are going to lecture me about micro seconds of delay on a ripple carry adder I expect you to atleast keep the terminology unchanged from other sources so I can google shit without having to translate

TsFreddie

i'm glad I'm done with my degree

I would gladly pay someone to finish it up for me, whenever I start working on it I remember how useless it is

poggers

Pisses me off that the useless degree has so much influence on your life. What do we even study for to be honest? Being miserable for 4-10 years just so you can be a little less miserable at work

yes, it's weird

Post scarcity world when?

unis made sense in the dark ages when there was no internet, but today.... i think big update is needed

@Learath2 how old were u again?

23, approaching the 40~ years of uninterrupted misery quickly

oh so young

16:39

thought u older xd

Everyone thinks so for some reason. Is it my love for ancient programming languages?

guess its just bcs u always been here at ddnet

probably because you are a wizard

and normally these ppl are like 50 years old xd

16:40

and have 3 kids

16:40

and tsfreddie as wife

Lol, I think most of the long timers here are not that old

guess deen is around 30?

16:41

i mean its not old

16:41

but also not young

16:41

i can imagine he gets kids soon and wont be here alot anymore

Deleted User

and tsfreddie as wife

what does this supposed to mean

No idea, if any of us is around 30 it's deen

16:43

I think I coded my first line like 11 years ago, wasn't teeworlds though iirc

isnt heinrich the oldest

16:43

monkalaugh

TsFreddie

what does this supposed to mean

who knows xd

justatest

I wonder what my oldest teeworlds commit is

Ryozuki

monkalaugh

ttbh i assume he's from 1991

16:43

so probs around deens age

@Deleted User and u?

125 +- 100

25?

16:43

xD

maybe 225

16:43

who knows

Jupstar is 2021 years old, he personally saw jesus christ

im 0x15

I always had the impression that Heinrich is the same age as mine

so young

wtf

16:44

thats like kiddy

16:44

age

16:44

i bet tsfreddie is like 19

(21)

16:44

I wish

16:45

he's old af

16:45

49 weeb

16:45

plays kids game

actually, you nailed it, I'm 0x19

Heh

Teeworlds trolls added 50 years to my life so I'm 73 in reality

I tested my English vocab, I'm on par with a 5yo native speaker. So it might be hard to tell

16:49

With all these IRC logs, we are slowly doxing ourselves.

I mean I have a fairly unique name anyway, so I'm instantly doxed

poggers

hello people reading irc logs

16:51

if you are from the future

16:51

i may be dead

16:51

but i was here

16:51

16:52

imagine the internet in 2100

16:52

i wonder if even http itself changed

maybe it's a robot reading these, learning about teeworlds

or if C stiffness in the world still remains

an ancient relic of the past

Or we have all merged into a singularity and the irc logs exists in everyones mind

https://xkcd.com/1782/

xkcd: Team Chat

16:53

greenthing

Yes, ofc I'l connect with my irc bridge

i was never on the irc train. i don't really get it

its simple

16:54

thats why i like it

16:54

and its decentralized in its own way

16:55

its not p2p but better than 1 discord

16:55

and matrix is overly complicated and slow

16:55

but at the end u gotta use what everyone uses

16:55

or ur end alone

16:55

its sometimes fun to read some irc chats

16:55

its always about drugs

16:55

i swear

basically me trying to get my friends onto telegram

why telegram tho

18:51

sok

18:51

even signal is better than telegram

18:51

or whatsapp

telegram is fun

the good thing about telegram is the bot api

ye

19:03

and the stickers I guss

19:04

I literally use a telegram bot to manage my input method's dictionary

[ddnet:master] 2 new commits

68962e9 Fix a woopsie in snapshot docs - ChillerDragon a3661e4 Merge #3860 - bors[bot]

21:37

[ddnet/ddnet] Pull request closed: #3860 Fix a woopsie in snapshot docs

Exported 461 message(s)