DDraceNetwork - developer

[ddnet/ddnet] Issue opened: #3799 Projectiles not rendered correctly

Since b1051d23984bed5de37eb5339cd8bd1271213f2b Reproduce by going on LAN server shooting a wall, sometimes the trace isnt rendered correctly(with anti ping on) @TsFreddie

TsFreddie

[ddnet/ddnet] Pull request opened: #3800 Get rid of current tuning in predicted world

Missed a spot where the predicted world still returns current tuning. closes #3799

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBS...

just happened to get up

1

@Deleted User which kog server were you in. i didn't have jetpack prediction on kog

02:05

~~or i'm not getting how kog works~~

it does it on any

then that tuning fix probably fixed that too somehow.

i merged that fix

02:06

i dont get the projectile anymore

02:06

but still the kog thing

02:06

maybe undefined behavior somewhere?

i don't have it on my end it seems

02:07

i don't know how to run UBSAN for client yet.

02:07

since i'm on windows

xD

2021-05-01_04-08-02.mkv

7.03 MB

02:08

yeah i'll check

~~at least remux it~~

sadly ubsan doesnt detect non initialized stuff, gonna try with valgrind

me joining kogs be like 26/902 KiB (9.0 KiB/s)

ouch, guess kog should upload its map to the https map pool

also i don't get why do we have m_Tuning[2] in CWorldCore AND CGameWorld AND CGameClient

bcs dummy?

i get the [2] part

02:16

i don't get why do we need 3 copies of the same thing

ah ok xd

and not copying them all the time it seems

nope no undefined behavior, you sure u have antiping on?

i'm sure

02:18

otherwise i would notice since i'm on like 200 ping

i tried on kog chile but also get it there

02:18

+200 ping there

i'll try on chile

do you use MSVC? maybe its a compiler thing?`xd

bruh

02:19

but ye, i do use msvc

02:19

let me try on my mac

its probably unlikely tho that its a compiler thing

if pnglite/version didn't f me up

maybe we have a different config somewhere

does kog use ddnetcharacter?

i've no idea, kog uses ddnet 9.x

02:21

9.3.1

i think i got it

02:24

there are more dangling tuning stuff lying around in character.

emmm

02:32

i got timedout in kog because i paused my process, and i reconnected in the middle of the map

fixes it

02:36

weird

that these values ever existed, yes xd

well getting rid of redundant data is probably good whether there is a bug or not i guess.

"// if ddnetcharacter is available, ignore server-wide tunings for hook and collision"

02:39

do serverwide tunes not get altered by this?

i don't know what that does too

02:40

maybe some check in predicted char is weird

02:42

Also i feel like we should just get rid of m_Tuning everywhere. Uses tune zone and tune zone 0 for everything.

the commit for it fixed 2 issues:

02:42

https://github.com/ddnet/ddnet/pull/3276

Fix prediction of no hook/collision tile by trml · Pull Request #32...

I believe this fixes #3043 and #2510, but I haven't tested it extensively yet (and I couldn't reproduce the bug for no-collision tiles) Perhaps there should also be some further cle...

02:42

i'd say, discuss that with @trml

i'm not doing it tho

02:43

I don't want to break more things kek

xD

02:44

ddnet code in a nutshell i'd say

02:44

u move 1 line of code... u have a new game

~~and the only reason i'm fixing tune zone visuals for projectiles is pvp servers can use that~~

worth it

but i guess we can have maps with smaller tune zones too

wtf xd

but i guess the one of the reason of us needing tunezone locally now is that we get rid of velocity data in ddnetprojectiles

03:33

we got rid of*

03:38

that reminded me that I should test infclass with master branch probably

gamer client features, best xd

why tho

in gamer client u could use ^p to have purple, or ^b to have blue

03:40

its oldschool client which all pvp players used before ddnet

i know. but why tho. kek

nostalgia