Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2021-04-20 00:00:00Z and 2021-04-21 00:00:00Z
Avatar
Avatar
Ravie
can someone master ban fokkonaut server for this atrocity?
Actually not my fault, its because 0.6 laws are to NOT send bot players but to send the original slot count + player count
00:06
So dont ban me for that, ban 0.6 lawd :P
00:06
in 0.7 you can select Hide bots in the browser, they need to be marked serverside so the client can filter them out
00:07
So my mod will always show max_clients - botcount = 128-5 in this case
Avatar
Asked heinrich before doing this, he said that too, even tho I dont think anyone should care, because this is not vanilla 0.6 and vanilla clients also cant see that server
00:08
So this seems to be a DDNet rule too :P
Avatar
I meant that the heart icon is overlapped by text because your max player count is so fat
Avatar
ahhhh xD
00:09
why can you see the server btw?
00:09
Avatar
no I opened server browser and sorted by players
Avatar
what a cool video
01:42
@Skeith care to clean up this mess? :P
Avatar
@Deleted User You know better than to post such things, you'll be muted for a day.
Avatar
it's in all channels
01:44
btw
Avatar
Yea, make that a week
01:45
rip
Avatar
@lynn Thank you
11:14
11:14
Crime has been committed
Avatar
What does it do?
11:32
Because it looks similar to something I have done
11:33
I have forbidden tunings too :D Faking curvature or speed works :)
Avatar
just fake shotgun spread while still keep the owner info
11:35
If you use FillExtraInfo DDNet just assume all shotgun's speed is Tuning()->ShotgunSpeed. But vanilla shotgun is using m_Direction to affect each spread's speed.
11:35
But FillExtraInfo discards m_Direction's length...
Avatar
Oh, even with the new FillExtraInfo?
11:36
With the ddnet Packet
Avatar
idk. i'm using 15.3.2
11:36
is there a new one in 15.4?
Avatar
player info is networked in tw?
Avatar
Is there a DDNetProjectile in it?
11:36
Or is it shifted and hacked in the normal one?
Avatar
I shifted and hacked it in NETMSGTYPE_SV_EXTRAPROJECTILE
Avatar
Avatar
felek
player info is networked in tw?
i mean tee color, type etc
Avatar
let me check 15.4 just be sure
11:38
@TsFreddie
Avatar
nope, this discards m_Direction's length at line 363
Avatar
why dont you fix it instead?
Avatar
does int Data have extra bits?
11:40
by extra bits i mean unused bits
11:41
I can maybe put which spread is the current bullet in Data and use ShotgunSpeeddiff in client?
Avatar
i think theres unused
Avatar
or maybe I stuff a half precision float in Data? that way mods can still use m_Direction to control projectile's speed (with less precision)
11:49
i'll try to go with the half precision route.
Avatar
what is the issue here?
Avatar
they want to stuff more data into the projectile
11:51
instead, please fix that we cannot extend net objects
11:51
and simply add a field at the end
Avatar
If you want to learn how, refer to the billion times I referred to a decent idea by @heinrich5991 😄
Avatar
i just want my shotgun not be broken lol
11:54
is there a Projectile format with owner that doesn't discard the length of m_Direction that i can use right now?
Avatar
Why is shotgun broken?
Avatar
ddrace tried to stuff more data into the projectile
Avatar
shotgun bullets has m_Direction with length that isn't 1
Avatar
the m_Direction went away, and we got m_Angle instead
Avatar
A direction vector really doesn't need a length, unless we are using them very wrong, no?
Avatar
so we can have an owner instead
Avatar
shotgun bullets has been using it wrong
Avatar
if you want a speed vector, you need angle and length
11:56
(if the speed isn't known beforehand) (edited)
Avatar
to be fair the speed difference between bullets is known beforehand.
11:57
as in 'shotgun_speeddiff' tuning
12:01
sooooooo
12:01
what's the plan
Avatar
Avatar
TsFreddie
shotgun bullets has been using it wrong
So they use the length aswell?
Avatar
Ah, we get away with it because we don't use the spread at all, right?
12:05
so I was thinking adding the spread index and use shotgun_speeddiff or adding a 16-bit float somehow...
12:06
EXTRAPROJECTILE has 19 bits left in Data.
Avatar
Avatar
TsFreddie
i just want my shotgun not be broken lol
just dont use extrainfo for shotgun :) fixed
Avatar
👀 i still want owner tho
Avatar
wym?
12:09
ah
Avatar
@TsFreddie we have free bits left in extraprojectile?
12:22
anyway, I don't think you can fix this in a backwards compatible manner at all, and the proper way to fix it is making netobjects extensible
Avatar
Avatar
Learath2
@TsFreddie we have free bits left in extraprojectile?
I think we do unless I'm blind
Avatar
I thought that thing was jam packed, I'll take a look
12:24
maybe we left a couple bits for flags but 19 sounds too much 😄
Avatar
I'm probably blind then
12:25
I can just stick with my hack that is still usable for vanilla shotgun
Avatar
huh we do indeed have some space there
Avatar
I think it's a better idea to just let this weird relic of the past die tbh
Avatar
tee_thinking how or when do you want to kill it tho
Avatar
apparently holding arrow up while refreshing servers crashes the game
Avatar
cant reproduce xd
Avatar
maybe you need to spam refresh a bit, it doesn't always happen
16:41
or it just doesn't happen in DDNet tab
Avatar
i just hold it while opening the client and then it crashed indeed
16:42
yeah just hold while opening, ez crash xd
Avatar
for me it always happens when refreshing on Internet tab
Avatar
u can crash it as soon as the list is empty, so even if you put a random search string into it that doesnt find a server
Avatar
it does for me too
Avatar
yeah makes sense, since the DDNet tab is never actually empty
Avatar
Putting a search string that doesnt find any server, or hold Up key while loading the client, or switching tabs can cause a crash, bcs the server list is empty, but input signals, it was changed

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bou...
Avatar
Fast
Exported 110 message(s)