DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2021-03-11 00:00:00Z and 2021-03-12 00:00:00Z

[ddnet-maps:master] 1 new commit

1dac837 A Fiji - ddnet-maps

heinrich5991

who maintains the fng servers? @noby?

me

05:59

how can i fix this

if i knew the name i would straight up told you but i forgot it @heinrich5991 the folks from the minecraft paper community use it its some smaller self made thing but it aims to be fully featured

[ddnet/ddnet] Pull request opened: #3693 Bug rankcommand

Fixes the message for loop not sending all messages
Still calls SpamProtection method for each message to count towards users spam chat score

*** If the above isn't relevant, then the spam check can move outside the for loop

Tested with normal and a muted user

!image !image...

[ddnet:master] 3 new commits

877bd9a Merge pull request #3 from ddnet/master - houseme-kyle 6ed2b22 Added break on primary message while still processing subsequent - Kyle Bradley 9b17e52 Merge #3693 - bors[bot]

08:07

[ddnet/ddnet] Pull request closed: #3693 Rank not sending

[ddnet/ddnet] Issue closed: #1924 Telegun and Jetpack

09:16

[ddnet/ddnet] Issue closed: #2507 does /save not keep hook...

deen

db server cpu usage is quite low: https://ddnet.tw/stats/server/#db.ddnet.tw (2 CPU cores, usually at 1-2% usage)

Didn't know this existed - very useful to see the performance numbers. Alright so the load on the server isn't bad at all. Would then only help with latency.

deen

If you add another caching layer, how will you know when the data is out of date? This is tradionally the job of a database

You could have a distributed memcache, but very much an overkill here and doubt it is possible with the given infrastructure. Few options:

A flattened storage/table to track the more heavy queries. This will solve for consistency across servers.
A cache per server where you don't solve for real-time consistency:
Unlikely for certain queries to change minute-by-minute
Unlikely that two servers will be on the same map impacting the same query
Refresh cache after X period or other
Move database behind an API with external servers making queries to it. That said, none of the above options are worth it seeing that a relatively small server is handling the load fine.

(edited)

@Zodiac if you have some query that is slow on real server, we can check if some index or rewriting query differently helpßs

The show ShowTop can sometimes take a second or two. Noticed this when going around different servers to test it. My main concern was that the underlying database was taking strain - hence the suggestion. It isn't too slow so an index or change in the query could definitely help

Here's what the DB serverhas index-wise at the moment

8.69 KB

10:41

Do you do multiple round trips for your top 5? that might be a problem

10:42

Multeasymap has the most ranks, and /top5 is definitely under 1 second for me on GER (still running old state before your changes)

It does two. One for global and one for the region. I spent a bit of time thinking of alternative queries but came up blank

you can always combine two queries into one

10:42

but it might be a bit awkward

Could have been an anomaly then. I'll do some more tests and see how the responses are.

I still think it might be nicer to show the global top X and then the next best people from current server in some way

10:43

but not sure it's worth it, probably the best solution would be a new UI that shows all this info in scoreboard

Yeah, can see how it is received with the update. It isn't doing two calls when the region has a high score so for the bigger servers the command will function the same

A usual test would be to assess the feeling of it among the Chinese community. They have a significant representation, relatively new community with low rankings and tend to be patriotic / care more about their peers.

You can try asking on the kaiheila ddnet server

12:09

since Discord is blocked in China

@deen sorry for tag, but i have question about this 45° aim thing, it always set inp_mousesens to 200, shouldn't be same as previous inp_mousesens ?

Yeah, but we have no realiable way to find that out. Better to bind it yourself with the correct value

12:35

it will be removed in the next release

[ddnet/ddnet-web] Pull request opened: #119 add Deëivid! to ddrace staff

Zodiac

The show ShowTop can sometimes take a second or two. Noticed this when going around different servers to test it. My main concern was that the underlying database was taking strain - hence the suggestion. It isn't too slow so an index or change in the query could definitely help

This is most likely due to actual latency now that we have a single db server instead of the old replication circle we had

1

https://www.youtube.com/watch?v=VB_GWz25B3Q

Kurzgesagt – In a Nutshell

What if the World turned to Gold? - The Gold Apocalypse

13:12

poggers

I saw it 1 week ago

13:13

thats not possible

13:13

or are u a patreon or smth

It is

13:14

On Ger channel

tv?

https://youtu.be/9sf-3Q8EcAE

Dinge Erklärt – Kurzgesagt

Was, wenn die Erde plötzlich zu Gold wird? - Die Gold-Apokalypse

lel

13:15

well english best

unranked

poggers

Image attachment

@Zodiac you are forget the number in rank or you did delete ?

@Ryozuki it simply means you haven't finished the map in the RUS region

hussainx3

@Zodiac you are forget the number in rank or you did delete ?

Where are you referring to? The description of the command?

/rank

hussainx3

@Zodiac you are forget the number in rank or you did delete ?

You might be on a server with the old broken rank on it

15:14

Which server did you use it on? (edited)

how many players/tees it's unexist

Image attachment

Yeah, the server must still be on yesterday's version

GER1

15:15

ok get great day

Thanks for flagging though. Give it some time / try another server and it will work again

@Zodiac could always do local rank to where the map was finished irrespective of server, then display unranked if on a different server like the RUS example above. Just a small suggestion but dont want to complicate things.

/rank doesn't merge if spammed #3693

https://github.com/ddnet/ddnet/pull/3693

oops, wrong issue

16:21

I meant this

#2887

https://github.com/ddnet/ddnet/pull/2887

SPYRES

@Zodiac could always do local rank to where the map was finished irrespective of server, then display unranked if on a different server like the RUS example above. Just a small suggestion but dont want to complicate things.

that could work - will leave the feature to sit for a while before making changes though

[ddnet/ddnet-web] Pull request closed: #119 add Deëivid! to ddrace staff

17:05

[ddnet-web:master] 2 new commits

8cdd863 add Deëivid! to ddrace staff - murpii 0e7e618 Merge pull request #119 from murpii/patch-9 - def-

@noby check where you're generating the server info, and see what you're doing after the map name and before the map size. or send me hte relevant code somewhere and I'll fix it

[ddnet/ddnet] Pull request opened: #3694 Fix automapper crash (fixes #3675)

Thanks to bojidar-bg for the way to fix, verified locally

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memche...

[ddnet/ddnet] Issue closed: #3324 rcon tele

[ddnet/ddnet] Issue closed: #610 f1 console same color as the chat

@heinrich5991 ill dm u

[ddnet-web:master] 1 new commit

a76a6c4 Add GER3, Japan - def-

[ddnet-web:master] 1 new commit

8dad903 1868 - def-

Exported 71 message(s)