DDraceNetwork - developer

Was hoping those commits would be squashed

I've figured out the CLang-Format integration so that shouldn't be a thing going forward.

Yeah, I could have squashed it

def-

[ddnet-web:master] 1 new commit

97c4f98 Add donation by CyberPotato - def-

maybe do something about this

@I.K.U should be fixed in nightly already

@DDNet I lav yu

def-

[ddnet/ddnet] Issue opened: #3686 compression.cpp:58:31: runtime error: left shift of 104 by 27 places cannot be represented in type 'int'

``` /home/teeworlds/src/master/src/engine/shared/compression.cpp:58:31: runtime error: left shift of 104 by 27 places cannot be represented in type 'int' #0 0x65124f in CVariableInt::Unpack(unsigned char const, int) /home/teeworlds/src/master/src/engine/shared/compression.cpp:58:31 #1 0x6cca6b in CUnpacker::GetInt() /home/teeworlds/src/master/src/engine/shared/packer.cpp:105:15 #2 0x4a1587 in CServer::ProcessClientPacket(CNetChunk*) /home/teeworlds/src/master/src/engine/serv...

10:45

def-

[ddnet/ddnet] Pull request opened: #3687 Free Client.m_PersistentData

Caused by https://github.com/ddnet/ddnet/pull/3605 Found by ASAN: ``` ==11628==ERROR: LeakSanitizer: detected memory leaks Direct leak of 64 byte(s) in 64 object(s) allocated from: #0 0x4f36b3 in __interceptor_malloc (/home/teeworlds/servers/DDNet-Server-asan+0x4f36b3) #1 0x5536a7 in CServer::Run() /home/teeworlds/src/master/src/engine/server/server.cpp:2362:31 #2 0x562408 in main /home/teeworlds/src/master/src/engine/server/server.cpp:3594:21 #3 0x7f6ee56d209a in ...

10:46

def-

[ddnet/ddnet] Issue opened: #3688 Memory leak in CServer::ConAuthAdd

``` ================================================================= ==1213==ERROR: LeakSanitizer: detected memory leaks Direct leak of 64 byte(s) in 64 object(s) allocated from: #0 0x4f36b3 in __interceptor_free (/home/teeworlds/servers/DDNet-Server-asan+0x4f36b3) #1 0x5536a7 in CServer::ProcessClientPacket(CNetChunk) /home/teeworlds/src/master/src/engine/server/server.cpp:1392:5 #2 0x562408 in CServer::ConAuthAdd(IConsole::IResult, void*) /home/teeworlds/src/master/sr...

10:48

def-

[ddnet/ddnet] Issue opened: #3689 Memory leak in CMasterServer::SetDefault()

``` ================================================================= ==27444==ERROR: LeakSanitizer: detected memory leaks Direct leak of 64 byte(s) in 64 object(s) allocated from: #0 0x4f36b3 in interceptor_malloc (/home/teeworlds/servers/DDNet-Server-asan+0x4f36b3) #1 0x5536a7 in CServer::Run() /home/teeworlds/src/master/src/engine/server/server.cpp:2362:31 #2 0x562408 in main /home/teeworlds/src/master/src/engine/server/server.cpp:3594:21 #3 0x7fe37871c09a in l...

please do not

the bot is hackin justatest

ugly (top3) twice put (top) for one server or Collect them and put it (top) for both server fury

4

1

@Zodiac congratulations on your first controversial pull request

@Learath2 haha thanks

I did try it on GER servers and the duplication was noticeable.

hussainx3

ugly (top3) twice put (top) for one server or Collect them and put it (top) for both server fury

Good point, there might be improvements that could be made for repeats. I'll look into it.

✌️

14:21

I suggest you give it a couple more days. People usually get used to things in that timeframe

@Zodiac maybe we can even combine it in one list? Show the top 3 global players, followed by the next 2 best ranks from current server (but might be too confusing)

14:35

Then it would usually look as before on GER, but would still show the best players on other locations

I'll sit on it for a bit but there might be tweaks that could be made. @deen suggestion might solve for both. By using the global list but giving space to highlight where the top locals are in the global list

How about top5 global followed by top3 local unless the local times are duplicate

Yeah, something like that. Just can't take too much space. The above is about the limit

@Zodiac you could look into a ui change too. We've been looking into decreasing the use of server messages for a while now. Maybe a good idea to move this into it's own ui maybe next to the scoreboard or as a second tab to the scoreboard?

14:42

Or a replacement for the very meh hud element we have on the bottom right?

even at 16:10 I don't think we have space next to scoreboard

14:45

especially now that @Deleted User might it wider

A small widget - especially if it is temporary - could work. Just don't ask me to do it

I am terrible with UI dev. (edited)

Something like a second page on the scoreboard maybe?

Only saw the lengthy debate on general now. Does seem like some changes are needed.

Okay, in the interest of time. I thought the quickest fix would be to only show the local section if none of the top times are relevant to the region.

16:11

If any duplicates were found between global and local (edited)

16:13

No duplicates found (edited)

houseme-kyle

[ddnet/ddnet] Pull request opened: #3690 Feature localupdate

Feedback from the community. It will hide the local ranks if there are any duplicates so the larger communities, who were previously disadvantaged by the change aren't anymore.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexin...

I.K.U

maybe do something about this

ddrace scoreboard is ugly anyway xd

16:47

fng best

/ctrl c, /ctrl v - problem solved

https://github.com/raycar5/logicsim poggers

raycar5/logicsim

Composable digital logic simulation in Rust! Contribute to raycar5/logicsim development by creating an account on GitHub.

what mean ZAF?

south africa

7

1

Zodiac

No duplicates found (edited)

i think (global) it's enough alone i play in all servers why should be care about top in south africa or anyplace

hussainx3

i think (global) it's enough alone i play in all servers why should be care about top in south africa or anyplace

The recent change in the feature will mean nothing will change for you then. It is for those communities you don't care about and for them to see their peers time.

17:36

These servers being:

KOR
CHL
USA
ARG
CAN
POL
SGP
TUR
ZAF
IRN

Not chl

17:37

feature is so good but need new command

There is a potential update incoming - will see how that is received.

Just add new command and it will be fine

17:40

Noone will complain about it with new command

Yeah, it is possible a new command will solve it. However, vast majority of the complaints are people who play on the GER servers and/or compete on a global level. The potential update will mean that for those communities it will only show the global ranks i.e. act in the same way as it currently does.

top5 shows only top3?

17:49

@Zodiac

@<BµmM> I am aware of the complaint. I have addressed it in detail here: https://discord.com/channels/252358080522747904/342454474117218334/818862021583962172

17:52

There is a change pending that will mean that the local ranks aren't shown when there are duplicates i.e. GER servers will likely never see the local ranks (edited)

Noone will complain about a new command because no one will use it...

18:02

We have so many unused features because of this

but they would use it if it was a good command

Not if they never even hear about it

others would tell them its a good command

We need to have good defaults and not rely on word of mouth to get everyone to learn about a feature

18:05

This mindset of assuming everyone has to become a poweruser is why new players look at the game play a bit and just disappear

but is it a good default if most dont like it

Do most not like it or do the people that don't like it shout way too loud?