Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories โ€” IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2021-03-07 00:00:00Z and 2021-03-08 00:00:00Z
Avatar
GitHub BOT 2021-03-07 00:08:38Z
Author icon
heinrich5991
[ddnet/ddnet] Issue opened: #3678 Legacy serverinfo does not work with reserved slots, if num_players > 15
Claims to have max_clients=15, but sends more than 15 clients: ```json { "max_clients": 15, "max_players": 15, "passworded": false, "game_type": "DDraceNetwork", "name": "DDNet Turkey - Novice [19/64]", "map": { "name": "Multeasymap" }, "version": "0.6.4, 15.3.1", "clients": [ { "name": "BadGirl", "clan": "", "country": 792, "score": -9999, "is_player": true }, { "name": "Faymir", "clan": "ืงลณlsั”"...
Avatar
fokkonaut 2021-03-07 01:35:43Z
@heinrich5991 can you tell me where's the relation between the Snap items and the SnappingClient
01:36
How does the server know which snapitem belongs to which client? I dont see where or how the client id is passed while creating the snapshot
01:36
In CAnyEntity::Snap
01:40
Ohh, nevermind lol
01:40
I found it already, works as i thought
Avatar
GitHub BOT 2021-03-07 04:46:07Z
Author icon
kamillentee
[ddnet/ddnet] Issue opened: #3679 External noobfilters
The idea is to connect players to another server that exclusively hosts a noobfilter. Once a player finished it they will be autoconnected to the real map.
  • you don't have to deal with players that !absolutely! don't fit to the current difficulty level
  • I am fine with players who have a somehow lower level than the map requires so the noobfilter should be slightly easier than the map.
  • slots are not blocked by people who try the noobfilter or people who are afk even after map chang...
Avatar
GitHub BOT 2021-03-07 05:31:57Z
Author icon
ddnet-maps
[ddnet-maps:master] 1 new commit
03d7f9f A Slak - ddnet-maps
Avatar
Avatar
GitHub
Click to see attachment ๐Ÿ–ผ๏ธ
gerdoe 2021-03-07 09:27:09Z
waiting for multiworld xd
Avatar
GitHub BOT 2021-03-07 10:13:26Z
Author icon
def-
[ddnet/ddnet] Pull request opened: #3680 Fix legacy serverinfo with reserved slots and num_players > 15 (fixes #3678)

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
10:14
Author icon
def-
[ddnet/ddnet] Pull request opened: #3681 std::max -> maximum

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...
Avatar
GitHub BOT 2021-03-07 13:03:07Z
Author icon
Learath2
[ddnet-web:master] 1 new commit
1ab15c2 Add ano - Learath2
Avatar
Learath2 2021-03-07 13:12:52Z
@heinrich5991 is there a way to check teehistorian files for integrity?
Avatar
GitHub BOT 2021-03-07 14:23:10Z
Author icon
bors[bot]
[ddnet:master] 2 new commits
e5bcac3 std::max -> maximum - def- 41cb148 Merge #3681 - bors[bot]
14:23
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #3681 std::max -> maximum
Avatar
Learath2 2021-03-07 15:13:52Z
EU anti planned obsolescence law when? My phone keeps getting shittier and shitter each update :P
Avatar
Ryozuki 2021-03-07 15:29:48Z
@Learath2 buy a new one for 120~โ‚ฌ on amazon
15:29
xd
Avatar
jao 2021-03-07 15:34:43Z
more like 1000โ‚ฌ
Avatar
Learath2 2021-03-07 15:40:15Z
A 120โ‚ฌ phone would last even shorter and would have android from 1980
Avatar
Ryozuki 2021-03-07 15:41:19Z
@Learath2 ur wrong
15:41
i bought it for 130โ‚ฌ and has android 10
15:41
redmi 9
15:41
xd
Avatar
Learath2 2021-03-07 15:41:46Z
Or bring the chinese into my pocket :P
Avatar
Ryozuki 2021-03-07 15:41:49Z
xd
15:41
i mean
15:42
i only use my phone to play chess and whatsapp every now and then
15:42
u can always install a custom rom
Avatar
Learath2 2021-03-07 15:43:26Z
I take a lot of pictures with it when I can't take my camera for whatever reason, so I cant go too cheap
Avatar
Ryozuki 2021-03-07 15:43:54Z
ah
15:43
well then ye i guess
15:44
altho the camera i have is not bad
Avatar
Learath2 2021-03-07 15:44:11Z
How is the speed for the redmi 9 btw?
Avatar
Ryozuki 2021-03-07 15:44:19Z
i dont have any speed issues
15:44
i dont play consuming games
15:44
so idk
15:45
nowadays most phones work well for casual use
Avatar
Learath2 2021-03-07 15:45:09Z
I mean as in general ui responsivity, keyboard responsivity etc.
Avatar
Ryozuki 2021-03-07 15:45:19Z
its good
Avatar
Learath2 2021-03-07 15:45:43Z
With this "flagship" s9 I get random ui lockups, keyboard not responding/responding late
Avatar
Ryozuki 2021-03-07 15:45:57Z
hm this never happened to me xd
Avatar
Learath2 2021-03-07 15:46:14Z
Oh and does redmi come with MIUI or vanilla android?
Avatar
Ryozuki 2021-03-07 15:46:20Z
miui
15:46
it has some apps installed ye
Avatar
Learath2 2021-03-07 15:46:46Z
Do you get ads in your ui? Heard the chinese love to do that nowadats
15:46
Nowadays*
Avatar
Ryozuki 2021-03-07 15:46:56Z
no
Avatar
Learath2 2021-03-07 15:47:13Z
I saw a guy with an unskippable 30 second car ad on his tv on boot :D
Avatar
Ryozuki 2021-03-07 15:47:15Z
there is one stupid app tho
15:47
it check for virus when u install an app
15:47
and usually shows and ad there
15:47
xd
15:47
but thats all i found
15:47
but the add is not a unskipabble ad
15:48
i have to look into custom roms
15:48
i always wanted to try this
15:48
but im 2 lazy to fck it up and lose stuff
Avatar
Learath2 2021-03-07 15:48:14Z
That's fairly good. Pipe all your traffic through a vpn and filter out the beaconing and you get a decent phone at a decent price
Avatar
jao 2021-03-07 15:50:29Z
you should buy an iphone
Avatar
Learath2 2021-03-07 15:51:43Z
I considered that a lot. But while they respect your privacy (mostly) they also do planned obsolescence AND I've really gotten used to android, not sure if I want to go back now
15:53
+they removed the damn headphone jack....
15:53
I absolutely despise apple for even coming up with that stupid idea
Avatar
jao 2021-03-07 15:55:00Z
for what do you need headphone jack if you have airpods
Avatar
Learath2 2021-03-07 15:55:15Z
I don't :P
15:55
Why would I want airpods when I already have a collection of great IEMs the airpods could only come close to
Avatar
Ama 2021-03-07 16:00:32Z
you can get 10euro xiaomi bluetooth headphones
16:00
so its really your choice to keep the shitty cable
Avatar
louis 2021-03-07 16:10:43Z
removing the headphone jack was stupid
16:10
and then other companies started to do it
16:10
which is even more annoying
Avatar
jao 2021-03-07 16:15:14Z
its the future
16:15
in 10 years you wont have cable at all
Avatar
louis 2021-03-07 16:17:42Z
like i can see why they remove usbs on the macbook, it makes it a lot more slick
16:18
they kinda removed headphone jack rly early tho
Avatar
jao 2021-03-07 16:18:51Z
they didnt remove it entirely
16:18
u still have the adapter
Avatar
louis 2021-03-07 16:20:52Z
m true
16:21
forgot abt that
Avatar
Ama 2021-03-07 17:01:03Z
i mean its a premium phone its for people with money
17:01
just because normal people buy it its not meant for them
17:01
if you have a newer car you will have bluetooth in your radio
17:02
if not you dont buy an iphone which is probably nearly worth the same money as the car
Avatar
louis 2021-03-07 17:04:25Z
lol
17:04
in america theres like an apple "cult following"
17:04
with all the memes abt android vs apple
Avatar
Ama 2021-03-07 17:05:08Z
iphone is a really good phone
17:05
and i really think its probably better then all android phones
17:06
but do you really need that phone if you just a normal person
Avatar
Cristian 2021-03-07 17:06:17Z
iphone sux
Avatar
louis 2021-03-07 17:06:46Z
ye its good but not relative to price
17:06
i just dislike apple in general a bit
Avatar
Ama 2021-03-07 17:14:07Z
if you cant afford something its not the products fault
Avatar
louis 2021-03-07 17:17:39Z
its not abt that
17:18
they just do stupid things and everyone still buys their stuff cuz its apple
17:18
like they try to stop ppl from repairing their phones cuz they are greedy
Avatar
jao 2021-03-07 17:30:25Z
thats capitalism
Avatar
SPYRES 2021-03-07 18:15:39Z
@Learath2 ur ref for ano's profile is broken forgot to add the / before players
Image attachment
Avatar
Avatar
Ama
if you cant afford something its not the products fault
talesTitan 2021-03-07 20:20:32Z
lol Nice point of view
20:20
twinbop
Avatar
heinrich5991 2021-03-07 21:28:12Z
@Learath2 have heard apple is doing quite a bit better than android for obsolescence
21:28
@Learath2 there's no checksum or so for teehistorian files, sorry
21:30
you could run through them and see if it parses
21:32
@Learath2 what do you want to achieve?
Avatar
Learath2 2021-03-07 21:33:18Z
I have a feeling I synced some incomplete ones
Avatar
GitHub BOT 2021-03-07 21:43:22Z
Author icon
heinrich5991
[ddnet/ddnet] Pull request opened: #3682 Automatically use HTTPS compression if the server supports it
Our typical HTTPS answer is reduced by 85% by this. Our JSON seems to compress really well.

Checklist

  • [x] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change wi...
Avatar
deen 2021-03-07 21:49:09Z
@SPYRES thanks, fixed
๐Ÿ‘ 1
Avatar
GitHub BOT 2021-03-07 21:49:13Z
Author icon
def-
[ddnet-web:master] 1 new commit
7fe0bd2 Fix ano - def-
21:54
Author icon
bors[bot]
[ddnet:master] 2 new commits
d6097cb Automatically use HTTPS compression if the server supports it - heinrich5991 aaf5b61 Merge #3682 - bors[bot]
21:54
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #3682 Automatically use HTTPS compression if the server supports it
Avatar
heinrich5991 2021-03-07 21:57:17Z
btw did you know that you need to pass --compression to the curl command line if you want compression for the response?
21:57
I thought stuff like that would be automatic
21:57
--compressed*
21:59
apparently wget also doesn't automatically request compression ๐Ÿ˜ฎ
Avatar
Kurosio 2021-03-07 22:05:58Z
https://github.com/ddnet/ddnet/blob/master/src/engine/server/server.cpp#L56-L58 Guys, how is this even supposed to work?
ddnet/ddnet
DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet
Thumbnail
22:06
If it is short
Avatar
Deleted User 2021-03-07 22:06:59Z
whats so special about it?
Avatar
Kurosio 2021-03-07 22:07:07Z
https://github.com/ddnet/ddnet/blob/master/src/engine/server/server.h#L46
ddnet/ddnet
DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet
Thumbnail
Avatar
Deleted User 2021-03-07 22:07:41Z
16k is ok for short
Avatar
Kurosio 2021-03-07 22:08:37Z
So this is correct? To assign a value to a short that exceeds what it can have?
Avatar
Deleted User 2021-03-07 22:08:51Z
it doesnt exceed it
Avatar
heinrich5991 2021-03-07 22:08:56Z
MAX_IDS is 16384, the maximum value of short is 32767
Avatar
Deleted User 2021-03-07 22:09:16Z
short in c++ is 16bit
22:09
dunno if its not somewhere else
Avatar
heinrich5991 2021-03-07 22:09:37Z
the standards people are about to hunt you ๐Ÿ˜‰
Avatar
Deleted User 2021-03-07 22:09:40Z
atleast on our architectures ๐Ÿ˜„ (edited)
Avatar
Kurosio 2021-03-07 22:10:04Z
Okay then, no question, but that's what clang-tidy is swearing at xD
Avatar
heinrich5991 2021-03-07 22:10:19Z
can you post the output of clang-tidy?
Avatar
Kurosio 2021-03-07 22:10:25Z
Then it would probably be correct to specify short instead of int
Avatar
GitHub BOT 2021-03-07 22:10:30Z
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #3677 Tell MSVC that main is still entry
22:10
Author icon
bors[bot]
[ddnet:master] 2 new commits
06dd469 Tell MSVC that main is still entry - Jupeyy 0ca7f8f Merge #3677 - bors[bot]
Avatar
Kurosio 2021-03-07 22:12:38Z
I use clang-tidy as a supplement to ReSharper together with the Visual Studio add-in in Windows. I think it should probably be short instead of int
Avatar
Deleted User 2021-03-07 22:13:28Z
does it maybe fail to include the header and just assumes a wrong value or smth?
22:13
or does it actually say like 16k is too much
Avatar
heinrich5991 2021-03-07 22:14:13Z
maybe it complains about assigning an int to a short?
Avatar
Kurosio 2021-03-07 22:15:15Z
Well, I'm picky about code in general and in case I needed to increase the value if I were a newbie, I wouldn't even look in the direction of what's short xd
Avatar
Deleted User 2021-03-07 22:15:42Z
i'd suggest to use sized datatypes if possible anyway
Avatar
heinrich5991 2021-03-07 22:15:50Z
Well, I'm picky about code in general
you're going to have a fun time with ddnet code
Avatar
GitHub BOT 2021-03-07 22:16:17Z
Author icon
def-
[ddnet-web:master] 1 new commit
5f1a092 kor -> kor2 - def-
Avatar
Kurosio 2021-03-07 22:16:18Z
xD
Avatar
GitHub BOT 2021-03-07 22:27:46Z
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #3667 fix controls for deepfly / 45 deg angle
22:27
Author icon
bors[bot]
[ddnet:master] 3 new commits
fb8f689 Remove deepfly binds (fixes #3667) - def- 9ea88f1 Remove 45° aim too - def- 4925d43 Merge #3668 - bors[bot]
22:27
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #3668 Remove deepfly binds (fixes #3667)
Avatar
Avatar
Deleted User
does it maybe fail to include the header and just assumes a wrong value or smth?
Kurosio 2021-03-07 22:34:50Z
It complains about the conversion and the last element xd (32767 - 32768)
22:37
Okay, those are my changes sry xD
22:37
then only conversion
Avatar
Kurosio 2021-03-07 22:59:09Z
By the way, there is a dead code. https://github.com/ddnet/ddnet/blob/master/src/base/vmath.h#L124. If need save the logic there, probably need to use type_traits
ddnet/ddnet
DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet
Thumbnail
Avatar
heinrich5991 2021-03-07 23:00:45Z
looks like a mistake from this commit: https://github.com/ddnet/ddnet/commit/5d0bb4cf3c9fede8247f37da31e45d291dac9f7e
Backport vector functions cleanup from the upstream · ddnet/ddnet@5...
Keep closest_point_on_line() as-is. (commit 6b69f94dc8601050d727feaeb6aac7d999e9f19c)
Thumbnail
23:00
feel free to fix it ๐Ÿ™‚
Avatar
GitHub BOT 2021-03-07 23:57:58Z
Author icon
bors[bot]
[ddnet/ddnet] Issue closed: #3678 Legacy serverinfo does not work with reserved slots, if num_players > 15
23:57
Author icon
bors[bot]
[ddnet:master] 2 new commits
b1ed91b Fix legacy serverinfo with reserved slots and num_players > 15 (fixes #3678) - def- 75e9b20 Merge #3680 - bors[bot]
Exported 151 message(s)