DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2021-03-01 00:00:00Z and 2021-03-02 00:00:00Z

[ddnet/ddnet] Issue closed: #3653 `/mapinfo` time of 00:00.00 displayed when map not finished

00:01

[ddnet/ddnet] Pull request closed: #3658 Fix /mapinfo displaying a time when not having finished

00:01

[ddnet:master] 2 new commits

9f41b5d Fix /mapinfo displaying a time when not having finished - heinrich5991 a6aa74f Merge #3658 - bors[bot]

heinrich5991

https://nee.lv/2021/02/28/How-I-cut-GTA-Online-loading-times-by-70/

This has to be intended. No one could miss this

00:48

We wouldn't miss this, I can't possibly believe a massive studio like R* can't even use a profiler

00:49

heck you probably couldn't get me to merge json parsing with sscanf in it

I have heard that software written in huge studios can be horrible

00:50

maybe it was fast enough™ while developing, because the json was smaller

Ah, that could make sense

00:51

Still who even bothers rolling their own json parsing except for lulz?

00:51

rapidjson and nlohmann::json both work extremely well

00:52

much better optimized than I could ever hope to get an implementation

How does Server Exploration system works? What information is exposed to non joined servers?

[ddnet-maps:master] 1 new commit

86dfba5 M New Generation II - ddnet-maps

ok i have a great idea

05:35

require everyone to solve a ddrace part captcha before joining a brutal or insane server troll

troll

noobfilter

your ip is exposed i guess. Im not sure but i assume every server registeres on the master server with its ip. Then when a client refreshes the server browser it gets the list of server ips and then asks every server about a info packet containing slots/gametype/playercount/name etc so at least the client ip is sent I am not sure if anything more is sent.

lmao at gta

[ddnet/ddnet] Pull request opened: #3659 Fix Insecure temporary file

Check out https://docs.python.org/3/library/tempfile.html#tempfile.mktemp

found this thanks to codeql monkalaugh

monkalaugh

[ddnet:master] 2 new commits

6e76c46 Fix Insecure temporary file - edg-l 020d8c8 Merge #3659 - bors[bot]

08:40

[ddnet/ddnet] Pull request closed: #3659 Fix Insecure temporary file

+1 ChillerDragon, Well when you refresh your server you're doing a "request for information" (fstd/gie3) to each server from the list that master servers returns to you (edited)

Oh, so that's how they sniff legitimate IPs to ddos using ip spoofing?

ye

10:24

dont click the internet tab

10:24

its all shit servers anyway

troll

Deleted User

mh interestingly i had a locked mouse(if we mean the same) with #3577 it was bcs when loosing focus the mouse mode was changed, which caused the mouse to be locked for an unknown reason in windows What was the reason you told him to use old mouse, was it some experience?

There was someone with the same issue a week ago https://discord.com/channels/252358080522747904/745926398140612678/811497319321174066 and yes, I had this aswell.

u can always use status.tw

ChillerDragon did a lot of users also spam u on freenode?

10:26

Embedded image

10:26

xd

10:26

they are bots, and they say some rly weird shit

[ddnet/ddnet] Issue opened: #3660 Matchmaking

Feature* A way to match yourself with strangers to do a map together based on perceived skill level. Suggested Implementation

/matchmaking command that flags that you are interested
Once two or more trigger /matchmaking you enter into a 30-second pooling countdown
After the countdown, tees with the closest ranks are matched and put into a team

Depending on popularity, the algorithm behind this can be improved Reason**

Encourages new players to participate and...

GitHub

Click to see attachment 🖼️

wtf

12:08

how do you know who has same skill?

points

so if you finish all moderates you have 3601

[ddnet-web:master] 1 new commit

de03471 Update frontpage video - def-

and for all insane 1494

murpi

There was someone with the same issue a week ago https://discord.com/channels/252358080522747904/745926398140612678/811497319321174066 and yes, I had this aswell.

so the mouse only doesnt work at start?

13:00

@Ryozuki what was the reason IgnoreLine in chat.cpp is checked so late?

?

its a boolean

13:01

that stops the repeating lines

13:02

but it doesnt return directly, it only checks for that late inside that function

13:02

well it says for the log

13:02

but it also allocates the line

13:02

(the new line)

13:03

to make it concret, if you press U for showing all text and make a dublicated message, the message appears twice

13:03

once in the repeated line and once at the top of all chat messages

@Deleted User afaik deen changed that for the log

13:11

maybe he knows

ok @deen ^

no Ryozuki but murii from ##oodnet is

https://wiki.ddnet.tw/wiki/Versions

13:40

i generated it with this script https://wiki.ddnet.tw/wiki/Talk:Versions

13:40

monkalaugh

13:40

js hacker

[ddnet/ddnet-web] Issue opened: #115 libtw2: Packet7 is missing

Clicking on Packet7 in the index on the left gives a 404.

14:28

[ddnet/ddnet-web] Issue opened: #116 libtw2: Cross-doc links don't work

Clicking on "teeworlds variable-width integer" in the teehistorian docs goes to https://ddnet.tw/docs/libtw2/teehistorian/int instead of https://ddnet.tw/docs/libtw2/int

14:35

[ddnet/ddnet] Issue opened: #3661 Consider removing console on windows as default setting

As already described in #3403 Not allocating the console on windows makes the windows focus mouse input behavior much less triggerable(at starting), I'm not sure what exactly triggers this weird behavior in windows, and why there is seems no fix for it. But it seems to be a problem with windows not liking that the windows loosing focus and then grabs the input, just as described in #3577 But at startup this is kinda mandatory, because windows doesnt minimize the window, even if it lost th...

14:36

[ddnet/ddnet] Pull request opened: #3662 Don't allocate the windows console default

fixes #3661

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresss...

@deen or @heinrich5991 do you know where is the script that generates https://ddnet.tw/settingscommands/

14:44

?

14:44

i want to modify it to add it to the wiki too

idk, have you checked ddnet-web, ddnet-scripts?

@Ryozuki I just run create.sh from here https://github.com/ddnet/ddnet-scripts/tree/master/client

ddnet/ddnet-scripts

The magic scripts that make DDNet run. Contribute to ddnet/ddnet-scripts development by creating an account on GitHub.

https://github.com/ddnet/ddnet-scripts/blob/master/client/commands.py

ddnet/ddnet-scripts

The magic scripts that make DDNet run. Contribute to ddnet/ddnet-scripts development by creating an account on GitHub.

15:06

this looks related

15:06

ah i see

15:06

thanks

@Soreu Do you still use WinXP? Can you please test https://github.com/ddnet/ddnet/pull/3662 I can send you the build if you can't access it directly

Don't allocate the windows console default by Jupeyy · Pull Request...

fixes #3661 Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test if it works s...

15:06

(or anyone else who still has WinXP access)

do u run create.sh from the ddnet base dir?

yes

i think soreu wont be active anymore

15:21

i tag him a while ago too, and he didnt respond

ok, too bad

1. Can moderator see player IPs 2. If 1 is true, can someone see what IPs that moderator watched?

Yes, they can. We have logs for 1 day of moderator actions, but if a mod runs status with a previous show_ips 1 they will see all IPs

@deen @heinrich5991 https://wiki.ddnet.tw/wiki/Settings_and_Commands

Settings and Commands

15:43

yay!

[ddnet/ddnet-scripts] Pull request opened: #31 add script for wiki settings and commands

But should we have duplicated information?

15:45

Sorry, I should have said that when you asked for the link already

i think it fits more to be in the wiki

15:46

but i dont mind

Every mod will use status, so I assume so

15:47

If you have a problem about a mod, then report it privately to an admin

personally i think the wiki should aim to have all the possible info

15:48

less the maps and ranks

[ddnet/ddnet-scripts] Pull request closed: #31 add script for wiki settings and commands

15:50

[ddnet-scripts:master] 2 new commits

39708e2 add script for wiki - edg-l 0906a27 Merge pull request #31 from edg-l/pr_wiki - def-

15:50

[ddnet/ddnet] Issue closed: #3646 Browser unwanted hover effect in player list

hello how i can add blue color on the test gametype?

Image attachment

its client side, so only by changing client

@heinrich5991 what about adding an entry m_Color to the serverinfo for the gametype

16:43

could maybe be done while doing the tokens for serverinfo

16:43

just a colorcode that could be sent

next up server icon gif support :D

nah

16:43

Not teeish

https://wiki.ddnet.tw/index.php?title=Main_Page&useskin=material

DDraceNetwork (DDNet) is an actively maintained version of DDRace, a Teeworlds modification with a unique cooperative gameplay. Help each other play through custom maps with up to 64 players, compete against the best in international tournaments, design your own maps, or run your own server. The official servers are around the world. All ranks m...

16:45

omg

16:45

look at this skin

16:45

the most modern wiki ever

16:45

xddd

16:45

(its a preview)

16:46

justatest

Image attachment

1

16:48

its a bit buggy tho

[ddnet/ddnet] Pull request opened: #3663 Fix chat repeated messages

Pressing "U" to show all chat messages and make a message to appear repeating while holding U, makes it to create 2 instances, bcs another Line is allocated, when not returning for the log.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds a...

deen

(or anyone else who still has WinXP access)

not anymore haha

1

@Headshot

auto &&FChatMsgCheckAndPrint = [=](CLine *pLine)

18:17

and ppl say rust syntax is uglier than c++

18:17

monkalaugh

the rust syntax is the reason i dont really want to learn it xd

18:25

but yeah some of the newer c++ stuff looks really weird

18:25

but plain c syntax is pretty clean, there its more about design choices xd

C has quirks too, e.g. due to the way they specify types

i guess the best example is java vs kotlin

18:27

kotlin looks weird and i dont see the sense in it over java

18:28

also google wrote a converter to convert kotlin to java

kotlin had closures before java I think

yeah it probs has other advantages too

18:30

the google android examples are always in both languages

that's not an advantage anymore; they just forced java to become a better language

and i always feel like kotlin looks weird xD

that's a good end result, I think

ah ok

i actually dont see whats wrong with rust syntax

18:32

it is concise while also removing useless stuff like () in if statements that dont need it

I could guess the ' for lifetimes

and stuff like that

18:32

well the lifetimes is a new addition that other languages dont have

18:33

loop vs while(1)

18:33

while let if let etc

18:33

i think the let stuff didnt exist before

18:33

so its an improvement

I'd think "weirdness" means "stuff I don't know yet". with this definition, I can totally see how 'a (unclosed single quotes) can look weird

18:35

I mean some editors will even highlight it incorrectly, because it's so uncommon in programming languages to have unclosed single quotes

ah i guess

18:35

the editor makes it not look weird

18:35

i never even thought about it

yeah the unknown and the explicity

explicity is good imho

like adding all the let mut, fn etc

fn?

18:38

let mut is cuz variables are immutable by default

yeah i know

what the issue with fn?

deen

(or anyone else who still has WinXP access)

i have a vm

its very explicit as said

18:39

in c u just type the return type

18:39

and if its void u type void

fn x() {
}

18:39

in rust if its "void" u dont type anything

yes

18:39

fn x() -> bool ...

18:39

in c bool x()

well i think this is a matter of taste

indeed

I don't think this is particularly weird, it's just C-style vs say pascal style

yes

18:40

i learned pascal in school xd

I'd even go so far as to say C is the outlier here

poggers

well depends

18:41

since java and c++ are kinda c like

Has anyone noticed this chat render bug yet?

Image attachment

@Learath2 just fixed it in my last pr

yay

yay

18:42

@Deleted User who was the blame

18:42

deen or me

18:42

git blame

monkalaugh

i dunno, idc xD

pepeH

maybe it was a mix from all

i guess

maybe the new chat system changed smth, that made this case obv

18:43

i dunno if it also happened with the old one

18:44

why does macos always fail btw xd

18:44

how is that even possible

this was on linux btw

no

18:44

i mean my pr failed to build

18:45

and for some reason macos is broken often xd

18:45

the github action builds

[ddnet/ddnet] Pull request opened: #3664 Add initial delay to talking in chat

This adds a delay before one can chat. It should help mods in situations where people are spamming chat

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[x] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[x] Considered possible null pointers and out of bounds array indexing
[x] Changed no physics that affect existing maps
[ ] Tested the ch...

Amazing description for the failure

Image attachment

verbosity level: me

[ddnet/ddnet] Pull request opened: #3665 Add a way to block people from chatting on vpns

Another tool that should help moderators

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.co...

i guess i should atleast try to use rust for stuff, where OOP isnt needed, to get used to it for future xd

u can use rust where u would use oop

19:00

its data oriented

19:02

apart from the book this is also good https://rust-unofficial.github.io/too-many-lists/

Introduction - Learning Rust With Entirely Too Many Linked Lists

Learning Rust With Entirely Too Many Linked Lists

19:03

well, oop is a rly broad word

19:03

you can implement traits for structures

19:03

which is kinda like interfaces

Ryozuki

you can implement traits for structures

yeah i've seen that somewhere before

@Learath2 about your initial delay. I'm considering whether it would be a better idea to make this a command that temporarily sets this until the server becomes empty

19:04

alternatively, to do it similarly to the map votes, that people joining an otherwise empty server are not affected

19:04

your PR is probably still good, even without hte improvements

@heinrich5991 is that not over complicating it?

which part? the latter?

19:05

the latter would help with globally setting it on all servers

Both, it's such a tiny cute patch right now, maybe we can do some config trickery to make sure this gets disabled?

@Deleted User i think rust does oop to, but in its own way

19:06

idk

It'll become a mess if I add the auto-disable

https://doc.rust-lang.org/book/ch17-01-what-is-oo.html

Characteristics of Object-Oriented Languages - The Rust Programming...

@Learath2 there's GameServer()->m_NonEmptySince that lets you implement the latter thing in a relatively easy way

Rust takes a different approach, using trait objects instead of inheritance.

well I'm not good enough to judge if this has drawbacks, or is just as good

19:08

but good to know atleast

@Learath2 is dnsbl ban not on by default?

[ddnet/ddnet-web] Pull request opened: #117 Include Packet7 documentation and fix update_libtw2 script

Fixes #115

19:09

[ddnet/ddnet-web] Issue closed: #115 libtw2: Packet7 is missing

19:09

[ddnet/ddnet-web] Pull request closed: #117 Include Packet7 documentation and fix update_libtw2 script

19:09

[ddnet-web:master] 1 new commit

0a1a739 Include Packet7 documentation and fix update_libtw2 script - Zwelf

heinrich5991

@Learath2 there's GameServer()->m_NonEmptySince that lets you implement the latter thing in a relatively easy way

Why do we even keep such an odd variable?

for the map vote thing

what is the map vote thing even?

so people joining an empty server can start a vote, but people joining a full server can't immediately start a map vote

Hm, I see

19:12

I think that's really not what I want here

19:12

I don't like this kind of conditional complex behaviour

19:13

Feels like this warrants a CFGFLAG that means the option gets reset on reload

that sounds more overkill to me than making it a command that sets a variable that gets reset on reload

Pf, fine

but before implementing

19:14

why do you consider the other behavior complex?

19:15

"if you join an empty server, you can talk. if you join a non-empty server, you can't talk for 100 seconds"

It's conditional, conditional behaviour is hard to reason about for a player, it looks magical

it worked fine for the map votes

Besides, it's not really what is wanted either but rather a workaround that sort of achieves the same thing(maybe)

I doubt anyone has even noticed it

For map votes we literally wanted people to be able to vote on empty servers

19:16

Here we want this setting to not persist

coming from this point of view, I understand your opposition

Actually no, what if you want it always on? I don't want to make this change

you could also say that you want existing players to be shielded from join→chat spam, but there's no sense in protecting an otherwise empty server from it

fokkonaut

@heinrich5991 what about adding an entry m_Color to the serverinfo for the gametype

if we don't want to change net code, we can make another json file for gametype colours (edited)

but isnt that a downgrade?, having all mods in a signel color makes it easier to differenciate between them

19:21

or do you mean client side?

@heinrich5991 https://github.com/ddnet/ddnet/pull/3664/commits/3b55d5b07057cf114c1e45d045b01626b82de7e2

@fokkonaut I'd also be concerend about the lack of uniformity

[ddnet:master] 2 new commits

7e00407 Fix chat repeated messages - Jupeyy b2d4fd5 Merge #3663 - bors[bot]

19:27

[ddnet/ddnet] Pull request closed: #3663 Fix chat repeated messages

@Learath2 https://github.com/ddnet/ddnet/pull/3664/files#r584989463

Deleted User

or do you mean client side?

yeah, i guess player can decide what does he prefer

why most of the zcatch server not accesable on ddnet client but only on 0.7 ?

they are 0.7 servers

and there is no way to acces them from ddnet client?

no

I think I'm done for the day, I wanted to do #2990 to finish up my other PR but it's just so annoying to work with UI code now

https://github.com/ddnet/ddnet/issues/2990

Area over skin selector sometimes also selects skins · Issue #2990 ...

gerdoe reported on Discord, has a video. I also got it once.

It's stuck in some confusing state where we have some stateful, some stateless UI, some only graphically cached sort of stateless UI. I guess we finally managed to create the worst of both worlds

[ddnet/ddnet] Pull request closed: #3665 Add a way to block people from chatting on vpns

20:10

[ddnet:master] 2 new commits

5f50d1d Add a way to block people from chatting on vpns - Learath2 7be0f30 Merge #3665 - bors[bot]

Learath2

It's stuck in some confusing state where we have some stateful, some stateless UI, some only graphically cached sort of stateless UI. I guess we finally managed to create the worst of both worlds

i fixed that today locally, but for some reason it only works for themes and skins, not for the player list in server browser

[ddnet:master] 2 new commits

f1af68d Add initial delay to talking in chat - Learath2 8e4e494 Merge #3664 - bors[bot]

20:20

[ddnet/ddnet] Pull request closed: #3664 Add initial delay to talking in chat

Deleted User

i fixed that today locally, but for some reason it only works for themes and skins, not for the player list in server browser

https://github.com/Jupeyy/ddnet/commit/e023ff1bbb059512080c1d205f06b3ec58ebb847

20:22

but dunno when it doesnt work, atleast for skin i coudnt reprod the bug anymore (edited)

This isn't really completely the correct fix but I guess it sort of works

yeah its a mathematical fix, but not really nice xd

Well it's good enough I think, maybe PR it

well it doesnt work for player list in server browser

Ah

but maybe it uses a different list

Yep

we have like 2 lists xd

We really need a lot of UI patches for cleanup

20:37

Scrollregion and Listbox would be great abstractions to have

the editor also has quite alot of dublication, bcs it doesnt use the UI code

20:38

#3395 is fixed for normal gui, but not editor gui, even tho its the same function(just that it doesnt share the same impl anymore) xd

https://github.com/ddnet/ddnet/issues/3395

Infinite loop in editor · Issue #3395 · ddnet/ddnet

when you open editor and set Width to 500 and press right mouse Height it crashes I can reproduce this: 0x00005555556593f2 in CTextRender::TextEx (this=0x7ffff7fa9010, pCursor=0x7fffffffb460, pText...

I was really hopeful with the editor2 branch on 0.7 but LordSk is really slow with it

0.7 is slow in general

Image attachment

20:43

its a professional setup

20:43

nice how fast it starts xd

Shutting down my computer with systemd for the last time

Image attachment

20:46

Been waiting for like 3 minutes on systemd-udev to quit but it's the final time I'm going to have to suffer through it so I'm cutting it some slack

20:47

In an hour or so I'll finally have glorious eudev

are u on some unstable system?

yes, "systemd"

i sometimes have it when a packet is broken

heinrich5991

yes, "systemd"

Stole my joke

you wouldn't copy a joke!

I'm thinking of going btrfs this time around

tell me how it works out

Can't believe it's going down in flames for it's last shutdown

Image attachment

weed

1

20:49

It's like poettering programmed it to detect it's about to get deleted and hang onto life with all it's might

nice rolling papers xd

noby_on_coke

4

noby

nice rolling papers xd

Haven't smoked in so long those are probably crumbling at this point

lolol

Learath2

It's like poettering programmed it to detect it's about to get deleted and hang onto life with all it's might

I think I might have to put it out of it's misery with sysrq

rq

20:52

lol what does sysrq mean

God bless REISUB

louis

lol what does sysrq mean

It's a key on the keyboard

oh

20:53

never had one of those

hey, can someone help me with cl_download_skins? My cl_skin_download_url is set to https://skins.ddnet.tw/skin/ and cl_download_skins is 1 but the client doesn't seem to download any skins. How is this supposed to work?

it only downloads on demand

21:33

so only if its used ingame by anyone

ah i see, i thought it would sync my folder with the skin database. thanks for the reply :)

Learath2

Can't believe it's going down in flames for it's last shutdown

is that rly a systemd problem

I mean it's all components of systemd that's holding the shutdown up, I can't find anyone else to blame

device or resource busy monkalaugh

monkalaugh

Is the DNSBL stuff a library?

22:02

Or how does it work (did not look into it at all yet)

https://en.wikipedia.org/wiki/Domain_Name_System-based_Blackhole_List

Domain Name System-based Blackhole List

A Domain Name System-based Blackhole List, Domain Name System Blacklist (DNSBL) or Real-time Blackhole List (RBL) is a service whereby with a simple DNS query mail servers can check whether a sending IP address is on a blacklist of IP addresses reputed to send email spam. Most mail server software can be configured to check one or more of such l...

ik what it is, i mean how is it implemented in ddnet?

it makes a dns request with the IP address

23:03

to a dnsbl server

which server?

which server we use is a secret, so it's not so easy to circumvent

understandable

23:07

Thought that, but was still wondering bcs I might want to add stuff like this to my server

heinrich5991

which server we use is a secret, so it's not so easy to circumvent

Well technically it's not secret which server we use, we host our own with a script that I did make public iirc

Exported 328 message(s)