Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2021-02-23 00:00:00Z and 2021-02-24 00:00:00Z
Avatar
Learath2 2021-02-23 01:52:03Z
@deen is it normal that on the funding page sponsored servers appear as if not completely covered?
Avatar
Ryozuki 2021-02-23 08:24:36Z
@jao
Image attachment
08:24
this doesnt look right
08:24
tee_thinking
Avatar
jao 2021-02-23 08:37:14Z
wdym
08:38
@Ryozuki
Avatar
Ryozuki 2021-02-23 08:38:32Z
@jao see the second rank
08:38
it compares it to a min 7 rank
08:38
but previous is 5:42
Avatar
jao 2021-02-23 08:38:49Z
because they beat their own rank
Avatar
Ryozuki 2021-02-23 08:38:53Z
ah
08:38
xd
Avatar
jao 2021-02-23 08:38:54Z
only 1 teamrank per team is saved
Avatar
Ryozuki 2021-02-23 08:39:03Z
i didnt see it, cuz their names are in different order for some reason
08:39
🥴
Avatar
GitHub BOT 2021-02-23 08:40:35Z
Author icon
12pm
[ddnet-web:master] 1 new commit
1392e29 remove Skeith - 12pm
Avatar
deen 2021-02-23 09:26:54Z
@Learath2 yeah, some people didn't pay the full amount to sponsor a server
09:27
mostly they just pay the difference that is still shown as unpaid, but this leads to rebalancing the funding to other servers
Avatar
fokkonaut 2021-02-23 11:23:18Z
@Learath2 teamstate in ddnetplayer when
11:23
xd
Avatar
Avatar
deen
mostly they just pay the difference that is still shown as unpaid, but this leads to rebalancing the funding to other servers
Learath2 2021-02-23 11:48:44Z
Huh, I thought we showed directed donations specifically
Avatar
Avatar
fokkonaut
@Learath2 teamstate in ddnetplayer when
Learath2 2021-02-23 11:49:13Z
When heinrich or I have time to figure out the upgradable netobjs
Avatar
Ryozuki 2021-02-23 15:15:50Z
https://github.com/rui314/mold
rui314/mold
mold: A Modern Linker. Contribute to rui314/mold development by creating an account on GitHub.
Thumbnail
15:15
poggers
Avatar
louis 2021-02-23 15:22:27Z
good pfp
Avatar
GitHub BOT 2021-02-23 18:22:27Z
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #3637 Remove fifo file on shutdown
18:22
Author icon
bors[bot]
[ddnet:master] 2 new commits
7f9110b Remove fifo file on shutdown - def- 0c1f4cb Merge #3637 - bors[bot]
Avatar
heinrich5991 2021-02-23 18:28:08Z
anyone know where the modauth.html page went?
18:29
ah found it
Avatar
GitHub BOT 2021-02-23 18:32:07Z
Author icon
bors[bot]
[ddnet:master] 9 new commits
ef6282d Replace remaining int64_t by int64 for the sake of consistency - Kaffeine a9bc619 CGameControllerDDRace: Add Score() getter - Kaffeine a6bdda6 GameController: Add OnPlayerConnect() like in the upstream - Kaffeine b0c0fb3 Get rid of gamemode.h with confusing definitions - Kaffeine 688f11e Move DDRace-specific player initialization code to the Controller - Kaffeine dfc7580 CGameContext::SendVoteStatus: Hide the trick for 64 clients - Kaffeine 2790270 Adopt upstream refactoring: Mark several functions as 'const' - Kaffeine 6b49bf1 Make spectators stay specs on map changed - Kaffeine 908646e Merge #3605 - bors[bot]
18:32
Author icon
bors[bot]
[ddnet/ddnet] Pull request closed: #3605 Adopt some more refactoring from upstream
Avatar
Learath2 2021-02-23 19:26:39Z
@heinrich5991 here?
Avatar
deen 2021-02-23 19:31:36Z
@Learath2 well, these donations were directed at the specific server. Basically "Hey, here's 40 € to fully cover the rest of GER1"
Avatar
heinrich5991 2021-02-23 19:35:15Z
@Learath2 here!
Avatar
Learath2 2021-02-23 19:36:23Z
@heinrich5991 (void)Uninitialized; // We need a reference for the next line. why is this needed?
Avatar
heinrich5991 2021-02-23 19:37:45Z
because compare_exchange_strong takes a reference
19:37
ah
19:38
because it was causing an unused variable error
Avatar
Learath2 2021-02-23 19:39:12Z
That's concerning, if that dbg_assert is getting optimized/compiled out the code isn't correct, is it?
Avatar
heinrich5991 2021-02-23 19:39:40Z
uhm, is dbg_assert optimized out?
Avatar
Learath2 2021-02-23 19:40:02Z
It shouldn't be, so it shouldn't ever trigger the unused variable error
Avatar
heinrich5991 2021-02-23 19:41:28Z
I assumed it wouldn't get optimized out
Avatar
Learath2 2021-02-23 19:42:09Z
I think we atleast talked about making it no-op in release mode
Avatar
heinrich5991 2021-02-23 19:42:29Z
https://github.com/ddnet/ddnet/blob/908646eea54c3a551263dbb192f9118dd938092d/src/base/system.h#L49-L53
ddnet/ddnet
DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet
Thumbnail
19:42
you're right
19:42
ouch
19:42
how much wrong code have I pushed to the repo? ^^
19:43
https://github.com/ddnet/ddnet/commit/a6e144ea72be5892490ecfe7b6137888f04b39dc
Let's not crash the client and server on dbg_assert · ddnet/ddnet@a...
Thumbnail
19:43
I don't think this is a good idea 😦
Avatar
Learath2 2021-02-23 19:43:52Z
Me neither
Avatar
heinrich5991 2021-02-23 19:43:57Z
asserts are there because things are in an inconsistent state
19:44
if you continue, bad stuff will happen
Avatar
Learath2 2021-02-23 19:44:42Z
but it's common enough to disable asserts that I wonder what the counterargument is
Avatar
heinrich5991 2021-02-23 19:44:52Z
"speed" "less crashes"
19:44
I'd guess
Avatar
Learath2 2021-02-23 20:20:26Z
@heinrich5991 I think I'm okay with your mysql PR if you fix the asserts
Avatar
GitHub BOT 2021-02-23 21:34:22Z
Author icon
heinrich5991
[ddnet/ddnet] Pull request opened: #3638 Revert "Let's not crash the client and server on dbg_assert"
This reverts commit a6e144e.

Checklist

  • [ ] Tested the change ingame
  • [ ] Provided screenshots if it is a visual change
  • [ ] Tested in combination with possibly related configuration options
  • [ ] Written a unit test if it works standalone, system.c especially
  • [ ] Considered possible null pointers and out of bounds array indexing
  • [ ] Changed no physics that affect existing maps
  • [ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddne...
Avatar
deen 2021-02-23 23:14:09Z
Anyone got an idea how to make this query faster? select distinct r.Name, r.ID, r.Time, r.Timestamp, n.Server from (select distinct ID from record_teamrace where Map = 'Multeasymap' ORDER BY Time limit 20) as l left join (select * from record_teamrace where Map = 'Multeasymap') as r on l.ID = r.ID inner join ((select distinct Map, Name, Time, SUBSTRING(Server, 1, 3) as Server from record_race) as n) on r.Map = n.Map and r.Name = n.Name and r.Time = n.Time order by r.Time, r.ID, r.Name;
23:14
Explain for context: | id | select_type | table | type | possible_keys | key | key_len | ref | rows | Extra | +------+-------------+-----------------+------+------------------------------------+--------------+---------+---------------------------------------------------------------+--------+-----------------------------------------------------------+ | 1 | PRIMARY | <derived2> | ALL | NULL | NULL | NULL | NULL | 20 | Using temporary; Using filesort | | 1 | PRIMARY | record_teamrace | ref | PRIMARY,Name,Map,ID,MapID | ID | 532 | l.ID,const | 1 | Using where; Using index | | 1 | PRIMARY | <derived4> | ref | key0 | key0 | 70 | teeworlds.record_teamrace.Name,teeworlds.record_teamrace.Time | 10 | Using where | | 4 | DERIVED | record_race | ref | Map,Map_2,MapTimestamp,MapNameTime | MapTimestamp | 514 | const | 161796 | Using where; Using index; Using temporary | | 2 | DERIVED | record_teamrace | ref | PRIMARY,Map,MapID | PRIMARY | 514 | const | 20044 | Using where; Using index; Using temporary; Using filesort |
23:15
Ok, I think I got it myself 😄
23:16
Got from ~20 s to 0.01 s, seems good enough for now: select distinct r.Name, r.ID, r.Time, r.Timestamp, SUBSTRING(n.Server, 1, 3) from (select distinct ID from record_teamrace where Map = 'Multeasymap' ORDER BY Time limit 20) as l left join record_teamrace as r on l.ID = r.ID inner join record_race as n on r.Map = n.Map and r.Name = n.Name and r.Time = n.Time order by r.Time, r.ID, r.Name;
pepeH 2
nouis 1
Exported 61 message(s)