DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2021-01-31 00:00:00Z and 2021-02-01 00:00:00Z

[ddnet/ddnet] Issue opened: #3564 Dummy Copy + Hammerfly dummy enables you to spam hook/hammer

How to: Turn on dummy copy, then hold down hammerfly dummy. You can hold hook if you wish to. Video: https://user-images.githubusercontent.com/60477660/106377259-2e6ee680-639c-11eb-85d1-a438b64da957.mp4

07:18

[ddnet/ddnet] Issue closed: #3443 add_foe by clan tag only

Ryozuki: rust addict lul. Yea no github drawings planned this year.

07:58

2018 was a good year :3

since CHINA is biggest playerbase now. Where is the chinese content? Are there some ddnet maps made in china already?

Discord is banned in China, so you won't see the Chinese player base here

08:24

They have their own IM channels

I can't wait for the 99 edgehooks in a row maps either, super excited

bit is an old Chinese mapper: https://ddnet.tw/mappers/bit/

Yun Gu are such awesome drag maps

[ddnet/ddnet] Pull request opened: #3565 Add Arabic language translation by .Yukki

!screenshot-20210131@093216

Checklist

[x] Tested the change ingame
[x] Provided screenshots if it is a visual change
[x] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[x] Considered possible null pointers and out of bounds array indexing
[x] Changed no physics that affect existi...

Woah

Thanks @xx !

Is it visually correct too

ye

08:37

u can check it

awesome.

08:38

Did you write them backwards and used some special shaped characters?

ye (edited)

[ddnet-scripts:master] 1 new commit

8ebc191 Build Discord rich presence support on Windows & Mac OSX - def-

oh true i forgot u cant submit maps without having discord. Yikes so no new chinese maps :/

09:13

any idea how i can get the currently pressed keycode in the client? I only find Input()->KeyPressed() bool functions

09:15

ah sure hook into OnInput and read it out of the event

09:15

i see

09:15

yikes im not in a component tho

09:16

ah i guess ima call GetEvent() my self then if one has a nicer solution on how to get currently pressed keycode in editor lemme know

09:22

oh nice that went surprisingly uncomplicated

[ddnet:15.3-devel] 8 new commits

a49c620 add discord rich presence - edg-l f8791e4 Put the Discord stuff into its own file - heinrich5991 e113917 Version 15.3 - def- 6920ec3 Fix Windows Discord build - def- c7c40e3 Log duplicate messages in console - def- 7dc1836 Don't highlight us if we have no name - def- 27ae07a Add Arabic language by .Yukki - def- 6b1cf5d Update Polish translation - def-

09:27

[ddnet:master] 4 new commits

96db08b add discord rich presence - edg-l c2b28f1 Put the Discord stuff into its own file - heinrich5991 6fbc818 Fix Windows Discord build - def- 697d03e Merge #3500 - bors[bot]

09:27

[ddnet/ddnet] Pull request closed: #3500 Add Discord rich presence

[ddnet/ddnet] Pull request opened: #3566 Use map download url from info2.ddnet.tw (fixes #3546)

which info2.ddnet.tw provides using a geolite db to provide a better server for players in China

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the chan...

yikers esc closes the editor :/

10:23

i guess to avoid people getting trapped in there

[ddnet/ddnet] Issue opened: #3567 Crash when closing client during skin download

``` Program terminated with signal SIGSEGV, Segmentation fault. #0 0xffffffff41000000 in ?? () [Current thread is 1 (Thread 0x7f117388c640 (LWP 208853))] (gdb) bt #0 0xffffffff41000000 in () #1 0x00005581cdfcd2d2 in CGetFile::OnCompletion(int) (this=0x5581d03fcd90, State=-1) at src/engine/client/http.cpp:307 #2 0x00005581ce0b501b in CSkins::CGetPngFile::OnCompletion(int) (this=0x5581d03fcd90, State=-1) at src/game/client/components/skins.cpp:35 #3 0x00005581cdfcc5c5 in...

10:33

[ddnet:15.3-devel] 1 new commit

f99bd5c Use map download url from info2.ddnet.tw (fixes #3546) - def-

[ddnet-web:pr-15.3] 1 new commit

3fcac8d DDNet 15.3 (WIP) - def-

10:41

[ddnet/ddnet-web] New branch created: pr-15.3

10:42

[ddnet/ddnet-web] Pull request opened: #112 DDNet 15.3 (WIP)

I'll be afk a few hours, someone want to write up the changelog?

@Im 'corneum the editor feature you requested like 1 year ago is now in chillerbot-ux if you still care https://zillyhuhn.com/OpenTube/video.php?t=chillerbot-ux_editor_text.mp4

virus

Cute idea, why did you not pr it for ddnet? :P

nice

ChillerDragon whats opentube

11:18

ChillerDragon why u dont use a federated video platform

11:21

ChillerDragon ah u made opentube

11:21

u could atleast not make it so scuffed

11:21

the design i mean

this is epic... but i dont have a use for it atm

@Learath2 yea idk it was a request for my "bs" client so i quickly hacked in there im not sure if ddnet actually declined it already since offset is not fixed but sure if it has a chance i can pr

11:26

Ryozuki: i sok at designing web pages xd

11:28

its nice since the editor class is almost completley public i was able to make this code and edit only 1 line in editor.ccp and editor.h

ChillerDragon want me to pr

design?

ye

if it stays simple and easy to read and overwrite with a custom.css sure would be awesome

11:29

also maybe not too modern css since i server it raw so it supports enough devices

??

11:31

ChillerDragon ur current design doesnt support devices at all

11:31

just desktop

11:31

xd

11:31

Embedded image

11:31

got my noby cdn set up

11:31

kek

11:31

discord ppl cant see the url

11:31

rip

omg

11:39

ur web skills suck

11:39

ChillerDragon

11:40

ChillerDragon ur thumbnail script fails

11:40

image2 @ 0x55fff4e1f240] Could not get frame filename number 2 from pattern 'thumbnails/.png'. Use '-frames:v 1' for a single image, or '-update' option, or use a pattern such as %03d within the filename.

11:41

av_interleaved_write_frame(): Invalid argument

[ddnet-discordbot:master] 1 new commit

5cc7c6f bump pps thresholds - 12pm

ChillerDragon ur dev.sh script suks too

11:45

it detects my vim intellisense is running and doesnt start the dev server

11:46

ok this is not worth my time xd

Ryozuki: https://github.com/ddnet/ddnet/pull/3557

Log duplicate messages in console by def- · Pull Request #3557 · dd...

As reported by fokkonaut Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Written a unit test...

14:35

a review from you was requested

14:35

if you don't want to do it, I can also do it

14:35

@Learath2 https://github.com/ddnet/ddnet/pull/3492 I think the final verdict was that this is fine to go into 15.3? can you bors r+ it?

Support F-Client and replace non-extended extension messages by hei...

This continues what #3439 started, and also replaces non-extended messages that are DDRace extensions with extended messages. The DDNet server still sends the old message to old clients and the DDN...

[ddnet:15.3-devel] 2 new commits

f8061c0 Update Polish translation - def- e648ba8 Use map download url from info2.ddnet.tw (fixes #3546) - def-

14:37

[ddnet/ddnet] Issue closed: #3546 Let gameserver tell client which http server to use for http map download?

14:37

[ddnet:master] 2 new commits

b3c93b0 Use map download url from info2.ddnet.tw (fixes #3546) - def- a404be6 Merge #3566 - bors[bot]

14:37

[ddnet/ddnet] Pull request closed: #3566 Use map download url from info2.ddnet.tw (fixes #3546)

i see

rage quit Ryozuki yea seems like the ffmpeg command needs some tuning whats the issue with the dev script?

ChillerDragon for some reason u check if there is a php script running

14:43

and assume that if there is any, its urs

14:43

and its not

14:43

i had vim open and it fired up LSP for php

14:43

so there was a php process

14:43

nobo

what is LSP

language server protocol

14:44

it helps autocompletion goto and other stuff

ah and the process contains php or runs w php

ye

14:44

why u even check for that

u can also manuall execute php -S instead of dev.sh

14:45

its just a wrapper

i know

14:45

bad wrapper

then do not use it

14:45

or fix it

no

14:45

i realized no one will use this anyway

i use it

u dont care about design anyway

14:45

xd

i actually do

14:45

i would appreciate if you make it nicer

maybe some day

14:46

im making my own web nicer rn

[ddnet:master] 10 new commits

9940a80 Support for F-Client - fokkonaut 0d916e2 Remove F-Client-specific messages - heinrich5991 9784726 Replace remaining non-extended extension messages - heinrich5991 43998ce Replace projectile hack with a new extended snapshot object - heinrich5991 af8b306 Don't highlight us if we have no name - def- cd407a0 Fix teehistorian PLAYER_INPUT message position - Zwelf 04e8ce5 Record exact tick where load/save result is returned - Zwelf 80df59b Clarify teehistorian code - Zwelf 9c5b5ce Add Arabic language by .Yukki - def- 2b5723c Merge #3492 #3559 #3561 #3565 - bors[bot]

14:46

[ddnet/ddnet] Pull request closed: #3561 Fix input message position in teehistorian files

14:46

[ddnet/ddnet] Pull request closed: #3559 Don't highlight us if we have no name (alternative fix for #3554)

14:46

[ddnet/ddnet] Pull request closed: #3492 Support F-Client and replace non-extended extension messages

14:46

[ddnet/ddnet] Pull request closed: #3565 Add Arabic language translation by .Yukki

server 128tees

f4

A lot of work for no gain. 128 tees is just a spamfest with an unreadable scoreboard

what about proper infinite slot support then? :p

1

Learath2

A lot of work for no gain. 128 tees is just a spamfest with an unreadable scoreboard

128 tees= more blockers

the more tees the better

1

1

1

Even 128 tees is asking too much of our poor O(n^2) collision code

Embedded image

14:56

yay my script works

script?

bindsym --release $mod+o exec maim -i $(xdotool getactivewindow) --format=png /dev/stdout | xclip -selection clipboard -t image/png -i
bindsym --release $mod+u exec $HOME/scripts/upload_img.sh

14:58

# Upload a image to the server and copy link to clipboard
cur=$(date +%s)
xclip -selection clipboard -t image/png -o > /tmp/clipboard.png
scp /tmp/clipboard.png ryo:/snip/${cur}.png > /dev/null 2>&1
echo -n "https://cdn.noby.world/${cur}.png" | xclip -selection clipboard

14:58

greenthing

noby.world

my domain

lmao

we can try open server with 128

my domain for stupid stuff

if we get 100tees =good idea

like this

if we not we can stop

[ddnet:master] 2 new commits

487bd18 Log duplicate messages in console - def- 8be462a Merge #3557 - bors[bot]

15:03

[ddnet/ddnet] Pull request closed: #3557 Log duplicate messages in console

15:09

[ddnet/ddnet] Pull request closed: #3433 Update Polish translation

15:09

[ddnet:master] 2 new commits

6c5af58 Update Polish translation - def- aa6c6ed Merge pull request #3433 from def-/pr-polish2 - def-

15:10

[ddnet:15.3-devel] 1 new commit

5cb3c6b Version 15.3 - def-

nice Ryozuki welcome to the selfhostet image service gang

15:26

also thanks for sharing reactions with it they do not reach mi poor irc user

[ddnet-web:pr-15.3] 1 new commit

bf0c853 DDNet 15.3 - def-

GitHub

Click to see attachment 🖼️

were translations generated or should i make it manual?

?

one moment

16:45

https://discord.com/channels/252358080522747904/757720336274948198/801802492215296000

@deen

Image attachment

16:58

wdym by on windows and mac os x

16:58

only test it there?

16:58

it should work on linux too

[ddnet/ddnet] Pull request opened: #3568 Get rid of the MySQL C++ connector as a dependency and disable C++ exceptions

We now use the C API directly. This has the advantage of using one obscure dependency less, as the C++ connector also used the C API. Also remove exceptions from database code. The equivalent code with return codes is a human-assisted mechanical translation of the old code, no attempts to improve correctness were made. This allows us to enable the -fno-exceptions flag.

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[x] Tes...

@Ryozuki details in the PR, on linux there's the problem that the shared library requires a recent version of glibc, not available on all distributions

@Ryozuki how is rich precense supposed tow ork

@deen what changed, that some ppl cant move (their cursor) while in spec (edited)

17:11

seems to be server related

@louis you activate it in discord i guess

well it says playing DDRaceNetwork

17:22

is it supposed to say the map or smth

@deen it might be related to some packet drops, one of them has no best time in scoreboard, and after connecting their dummy it worked for the dummy(only)

17:25

(maybe some capabilities, like the zoom feature ^^)

heinrich5991

@Ryozuki details in the PR, on linux there's the problem that the shared library requires a recent version of glibc, not available on all distributions

hmm

17:30

what about steam

17:30

steam requires ubuntu 18

17:31

iirc

17:31

we should use steam requirements for steam releases

17:31

i made this for linux

17:31

this sux if my steam ddnet client cant have this

@deen 45.88.109.25:8333 client id 0 and 1 cannot move cursor in spec (edited)

@deen https://github.com/ddnet/ddnet/pull/3500#issuecomment-769270013

Add Discord rich presence by heinrich5991 · Pull Request #3500 · dd...

Continued the work of @edg-l. Supersedes #3472. Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration option...

17:33

this is not fair

17:33

i want to use the steam release

17:33

and i dont want to replace my binary every time

ryozoozki is it supposed to show the map

17:33

im on steam beta and cant see anything

what

for rich precense

17:34

ah nvm i got it

17:35

it only works on rc, not beta for some reason

Image attachment

17:39

ew

17:39

im disgusted by myself

17:39

if i knew ddnet steam linux wouldnt have a feature windows does i wouldnt have done it

17:39

i helped a corporation today rip

mad boi

@deen only happens on that server and only for client id 0 and 1

Image attachment

17:44

on other servers m_Active is true

https://writing.kemitchell.com/2016/09/21/MIT-License-Line-by-Line.html

The MIT License, Line by Line

171 words every programmer should understand

[ddnet/ddnet] Issue opened: #3569 add "community skins" download option

people complain about not having old funny skins like "tank" due to it not fitting teeworld's artstyle adding these types of skins back into the database isn't the best option because download skins is on by default, meaning people would see unteeish skins. this is bad because the game should have a uniform art style by default. a possible solution is to add another "community" database where the only guidelines for skins is to be not explicit and not trolls (invisible skin, a 256x128 i...

[ddnet/ddnet] Issue opened: #3570 Feature suggestions

Im 'corneum suggested to add keyboard typing support for font mapres (https://github.com/chillerbot/chillerbot-ux/issues/12) I quickly hacked it together and its somewhat working in my custom client. https://zillyhuhn.com/OpenTube/video.php?t=chillerbot-ux_editor_text.mp4 @Learath2 suggested to pr it against ddnet so I decided to open this issue first to discuss if this is wanted. Its basic and there are still some issues:

no number support
no special character support (like...

ChillerDragon: teeworlds texture cli xd

? @gerdoe

autocorrection when :D

autocorrection in tw chat? xd

18:49

and smart word suggestions

18:49

also voice chat pls

in font mapres

does ddnet discord rich presence work when you build it yourself

-DDISCORD=ON

does that enable the option in cmakelists.txt

18:51

i already turned that on

make sure to pull ddnet-libs

yeah i did that too

[ddnet-web:pr-15.3] 1 new commit

fddc3da DDNet 15.3 - def-

I just converted my 60° swivel monitor stand to 360° swivel by removing this tiny pice of cast aluminum with just a box cutter and a nail file. Took me 20 minutes

Image attachment

nice u building killer robots?

wut? what gave you that idea?

[ddnet/ddnet] Issue opened: #3571 sometimes when i resize it gets cut off at bottom and top

@Jupeyy Can you take a look? louis reports on Discord # bugs:

sometimes when i resize it gets cut off at bottom and top going to borderless in this state also makes the top part of the screen (white bar in pic) just become transparent instead of take up whole screen hm couldnt reproduce it easily also it's a little unrelated but playing around between borderless/windowed makes my game do the freeze glitch thing

19:28

[ddnet/ddnet] Pull request opened: #3572 Fix sizing in graphics menu

As reported by louis !screenshot-20210131@202748

Checklist

[x] Tested the change ingame
[x] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no ...

19:30

[ddnet/ddnet] Pull request opened: #3573 DDnet -> DDNet

As reported by Ravie

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#u...

@timakro what else would one do with swivel monitor... oh wait

19:36

what is that? like for pc screens? xd

19:36

i thought or back to ur drone projects and u add some 360 cameras for better hooman tracking vision

[ddnet/ddnet] Issue opened: #3574 color picker clips off the screen in some cases

as reported by louis !screenshot-20210131@202748

19:37

[ddnet/ddnet] Issue opened: #3575 u cant press buttons now after using color picker

step 1. go to some color picker step 2. choose some color step 3. press esc to leave menu while still holding mouse on the color picker step 4. u cant press buttons now as reported by louis

For my pc monitor haha

boring

Now i can easily rotate it to watch movies from my bed haha

but still cool u improved it by breaking off parts

19:38

dont watch movies in bed its unhealthy

19:38

go out do some sport

lol

2

Pff shut up, breaking of that piece of metal was enough sport

xd

19:43

oh wow didnt know editor is full of shortcuts like for example ctrl+right which opens images and sound tab o.O

19:43

too bad i wanted that shortcut for word jumping :/

19:43

maybe a shortcut of ? and a ui items to show all shortcuts would be nice if those keep evolving

19:44

u know like the meta shortcut "?" that shows shortcuts

[ddnet/ddnet] Issue opened: #3576 color picker missing for Tee colors and UI color

@Banana090 could you add this? as reported by louis

ChillerDragon: that's just left/right, not ctrl+right

@deen so should fullscreen and borderless (options) give borderless fullscreen or "real" fullscreen current behaviour is real fullscreen else should borderless always be borderless fullscreen or just borderless

(edited)

20:09

i try to change it rn, but dont want to break anyhting

@deen debian 10 uses 2,28

20:13

ubuntu 20.04 latest lts uses 2.31

20:13

i still dont know why we support old distros

20:13

if u want to game its expected to have a modern system

20:13

distro*

@Learath2 ever thought about implementing a dropdown menu?^^

oh true deen didnt notice

20:37

https://zillyhuhn.com/cs/.1612125428.png

20:37

what happend here

20:37

oh woot what happend with my screen

20:38

nobody knows

20:38

Embedded image

Deleted User

@Learath2 ever thought about implementing a dropdown menu?^^

yes

20:57

rich presence woooorks \o/

[ddnet/ddnet] Pull request opened: #3577 Differenciate better between window modes

Yeah no idea, without dropdown it looks weird xd, so more of an idea: hopefully fixes #3571 by making it clear what borderless is intended to be(not fullscreen) !screenshot_2021-01-31_21-55-43

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a u...

Learath2

rich presence woooorks \o/

rip

21:24

im actually angry about this

21:24

feelsbadman

@Ryozuki because people actually use those LTS distros

does steam tell u?

No, every time I try upgrading glibc people complain

21:24

that they can't run DDNet anymore

they can compile their ddnet

21:24

or download from ddnet.tw

21:25

i only want the steam c lient

21:25

client

21:25

with the discord sdk

The people who know how to compile source code don't run 15 year old glibc versions usually

they also probs dont use steam

21:25

so i dont see the problem

21:26

i rly want to meet one of those ppl

21:26

"hey i run a 10 year old distro and i want to play a game thats being continuously updated, they even use c++11!!!!"

Did you check the glibc versions here? many distros affected

ur link is outdated a bit

21:26

and the steam requirement is latest ubuntu lts

21:27

20.04

21:27

it has glibc 2.31

Ubuntu 16.04 LTS is still supported until 2024

but steam doesnt support that

21:27

it supports the latest lts

ah

21:27

can you give me some requirements for Steam Linux?

21:27

Maybe we can do it for Steam version then

thats what ive been saying all time

21:28

Image attachment

21:28

https://support.steampowered.com/kb_article.php?ref=1504-QHXN-8366

Steam Client Troubleshooting on Linux - Linux Issues - Knowledge Ba...

Article "Steam Client Troubleshooting on Linux"

21:29

they only offer support for the latest ubuntu lts, so we can assume those are the requirements

Hm, maybe we should check what glibc version steam uses internally

https://github.com/ValveSoftware/steam-runtime

ValveSoftware/steam-runtime

A runtime environment for Steam applications. Contribute to ValveSoftware/steam-runtime development by creating an account on GitHub.

21:30

maybe its somewhere here

21:30

@deen apparently u can compile games

21:31

using the steam runtime?

21:31

smth like that

I'll check the symbols in the binary later

This release of the steam-runtime SDK marks a change to a chroot environment used for building apps. A chroot environment is a standalone Linux environment rooted somewhere in your file system.

[ddnet/ddnet] Issue opened: #3578 /pause stopped working

as reported by louis, can reproduce locally. Caused by:

commit 0d916e2ef6a18e76bca60cad27b23360ac4c1b6c
Author: heinrich5991 
Date:   Sun Jan 10 17:23:00 2021 +0100

    Remove F-Client-specific messages
    
    The PLAYERFLAG_AIM can now be set directly on DDNet servers via the 0.7
    bridge and will be sent to clients identifying themselves as DDNet
    clients.
    
    Add a new extended message that mirror the old `Sv_TeamsState`.

@heinrich5991 Any idea?

ok i have no idea

Seems to be glibc 2.14

21:41

So it seems like steam works on lots of older distributions. Steam actually uses Ubuntu 12 as a runtime for running games

21:42

An alternative would be to link discord lib at runtime if possible, and otherwise not use it

21:43

Something like the example in here: https://linux.die.net/man/3/dlopen

dlopen(3) - Linux man page

dlopen() The function dlopen() loads the dynamic library file named by the null-terminated string filename and returns an opaque "handle" for the dynamic library.

@Ryozuki I don't like shipping non-linux-only features, I'd like to fix this in the future

same

@heinrich5991 using the dlopen-approach or how else?

idk yet, not even if dlopen would work

I think it would work

maybe you'd need to have non-lazy dynamic linking for that

21:47

I think lazy dynamic linking is the default, so you only notice the missing symbol once it's called, then it's tool ate

RTLD_NOW

21:48

?

yes

21:48

sth like that

If this value is specified, or the environment variable LD_BIND_NOW is set to a nonempty string, all undefined symbols in the library are resolved before dlopen() returns. If this cannot be done, an error is returned.

21:48

looks like it

Hm, do we know if the specific functions in glibc are even required for the calls we do?

we wouldn't need to if the linker tried to resolve it at dlopen time

Is it possible to dynamically link only the part of the shared lib we need?

i dont know about this stuff

21:49

i never used dlopen myself

21:49

xd

that's the case rn, I think @deen

21:50

(with lazy loading)

@heinrich5991 only dlopen the discord lib if glibc is the correct version maybe?

[ddnet:master] 2 new commits

f49e8b0 DDnet -> DDNet - def- 292b263 Merge #3573 - bors[bot]

21:55

[ddnet/ddnet] Pull request closed: #3573 DDnet -> DDNet

might work

21:55

or even just calling discord's functions in that case

idk what really happens if we try to load a lib linked to a glibc higher than the current glibc

boom

but boom when

21:56

it the loading boom, or is calling functions in it ub

Boom at dlopen with missing symbol I expect

boom on function call AFAIK

[ddnet:15.3-devel] 1 new commit

a4d0bda Version 15.3 - def-

ok, that's annoying

does linux default to lazy loading like mac?

i mean u have to pass a flag

21:58

to dlopen

21:58

RTLD_LAZY or RTLD_NOW

21:58

so i dont see how there can be a "default"

21:58

22:00

If the same library is loaded again with dlopen(), the same file handle is returned.

22:00

a subsequent call with RTLD_NOW may force symbol resolution for a library earlier loaded with RTLD_LAZY.

hm, that might work

it has to be dlclose'ed as many times as it has been opened too

(we could also get away with only calling discord functions if glibc is new enough)

yeah i would go for that

(but I guess dlopen might be saner, if not a little more complicated)

hm

I think I got it to build

22:06

-Wl,--unresolved-symbols=ignore-all, but should probably still check if it runs

22:09

./DDNet: error while loading shared libraries: ddnet-libs/discord/linux/lib64/discord_game_sdk.so: cannot open shared object file: No such file or directory

hmm

Other than that it seems to work

"other than that it seems to work"? elaborate

22:13

does the client start after this error message?

No, I just copied the discord_game_sdk into that directory

22:13

and then it runs

ah

ah

so we just need to fix the path for the .so

ye

22:13

i guess this is some cmake magic

rpath

@Ryozuki can you check https://ddnet.tw/DDNet-nightly-linux_x86_64.tar.gz ? Does Discord work? (I don't have the application)

test

22:15

Image attachment

22:15

works

Nice

how did you query the glibc version?

I just opened the binary in vim and looked around a bit ^^

monkaS

22:18

Image attachment

22:18

monkalaugh

22:19

__GLIBC_MINOR__ 27

22:19

im a hacker!!!!

[ddnet/ddnet] Pull request closed: #3572 Fix sizing in graphics menu

22:26

[ddnet:master] 2 new commits

32f7a79 Fix sizing in graphics menu - def- e2c7c81 Merge #3572 - bors[bot]

22:30

[ddnet/ddnet] Pull request opened: #3579 Work around old glibc version in Discord Linux linking

Strangely on Debian I'm getting an error with this: CMake Error at CMakeLists.txt:2613 (target_link_libraries): Object library target "engine-shared" may not link to anything. Not sure how to resolve the rpath issue best. @heinrich5991 any idea?

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system....

[ddnet/ddnet] Pull request closed: #3579 Work around old glibc version in Discord Linux linking

22:47

[ddnet/ddnet] Issue opened: #3580 Add runtime Discord support for Linux x86-64

Using dlopen: https://linux.die.net/man/3/dlopen

a subsequent call with RTLD_NOW may force symbol resolution for a library earlier loaded with RTLD_LAZY.

feelsamazingman

Image attachment

22:49

Discord rich presence finally

@deen I got it to build with the bundled MySQL libs, but it crashes on startup for me (as with mysqlcppconn). could I just drop these libraries, requiring users to use the system libraries for this?

yes

23:02

eh, can't believe the C libs are also broken

23:02

but system libs in Debian 10 are also broken for example

system C libs?

no, mysqlcppconn

23:13

C lib directly I haven't tried

[ddnet-web:pr-15.3] 1 new commit

7f3849c 1760 - def-

23:22

[ddnet-web:master] 1 new commit

b577f4e 1760 - def-

is the rich presence image not transparent?

looks transparent to me, when clicking on louis

yeah I guess the guy above's screenshot is messed up

23:32

apparently images for discord need to be dilated as well xD

[ddnet/ddnet] Pull request opened: #3581 Simplify top-points query a bit

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

ah, found the bug

23:56

quickly testing and then I'll send the PR

Great

Exported 394 message(s)