DDraceNetwork - developer

[ddnet/ddnet] Pull request opened: #3535 Fix a possible race in load code

Previously, a save could possibly be loaded twice given enough latency discrepancy between servers. The server only verified that it deleted some save with the given password, not the save it is trying to load. This is fixed by also checking the SaveID column that is random and globally unique (except for the old NULLs). Since users can't create new saves with NULL SaveID, these pose no problem. Also change the default UUID for saves without save ID to something nonzero, so we ca...

bors[bot]

[ddnet/ddnet] Pull request closed: #3535 Fix a possible race in load code

10:27

bors[bot]

[ddnet:master] 3 new commits

3539f2b Allow ParseUuid to report errors and add tests - heinrich5991 7b0b1c4 Fix a possible race in load code - heinrich5991 14e7050 Merge #3535 - bors[bot]

def-

[ddnet/ddnet] Issue opened: #3536 Eye emotes stopped working

As reported by Astramast on Discord. ``` f0e34c9c3690fbae4408facebff475351f1bb71e is the first bad commit commit f0e34c9c3690fbae4408facebff475351f1bb71e Author: Alexander Akulich Date: Tue Jan 12 22:15:10 2021 +0300 Move DefaultEmote logic into CPlayer src/game/server/ddracechat.cpp | 20 ++++++++++---------- src/game/server/entities/character.cpp | 2 +- src/game/server/player.cpp | 17 +++++++++++++++++ src/game/server/player.h | ...

def-

[ddnet/ddnet] Pull request opened: #3537 Fix condition for eye emote (fixes #3536)

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[x] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[x] Considered possible null pointers and out of bounds array indexing
[x] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

Can we please get this without the debug mode like in the screen? people play in entities so they dont care if it doesnt look super good in the first way. Its optional anyway

I wonder how many people play in entities, probably the top 5-10% of the players

except the new steam ppl probs around 70%

13:26

atleast in gores i rarely heard that someone played in design

f3 for making the weak and strong hook unrelated from debug mode it is really spamming my debug interface

13:35

i dont play entities but i play a lot in debug mode and its so polluted by weak and strong now

ill vote for button combination to enable weak/strong indicators

f3 for just removing weak hook

4

3

Back to a billion ui options we’ve been trying to move away from ;/

13:46

I guess we could add it like the client ids or maybe atleast put it in the dbg_ group of config options

12pm

[ddnet-discordbot:master] 2 new commits

e72aca9 say when a global ban expires - 12pm c6b2585 remove unwanted moderator pings - 12pm

def-

[ddnet/ddnet] Pull request opened: #3538 Improve error messages when you can't join team

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[x] Considered possible null pointers and out of bounds array indexing
[x] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

14:48

12pm

[ddnet-discordbot:master] 1 new commit

467d0f5 format expire timestamp - 12pm

press ctrl+shift+g 3 times and then ctrl+shift+h to activate strong/weak ids xd

bors[bot]

[ddnet/ddnet] Issue closed: #3536 Eye emotes stopped working

15:03

bors[bot]

[ddnet:master] 2 new commits

4eeb14d Fix condition for eye emote (fixes #3536) - def- a176990 Merge #3537 - bors[bot]

15:03

bors[bot]

[ddnet/ddnet] Pull request closed: #3537 Fix condition for eye emote (fixes #3536)

Zwelf

[ddnet/ddnet] Pull request opened: #3539 Inform player about possibility to keep the hook when loading

Message is displayed when saving with an active hook

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[x] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https...

anyone here expirienced with socket.io ?

not me

yo btw

16:21

where does git adapt the short form of the hashes based on collision?

16:21

didnt know thats a thing

16:22

@heinrich5991

16:29

i guess ill try to get a custom suffix then if the prefix is a issue

that sounds better, thanks

@Deleted User is there a way for me to render everything with the colors multiplied for a while?

17:16

e.g. I want to tint everything rendered inside a block

interesting

I have a feeling the answer is no

17:17

but I'll still ask just in case

well you could alter the shaders

17:19

i created a black white shader for fun xd

we aren't using the shaders for gl1 at all though, no?

yeah

I need it to work everywhere, hm

but thats only a minority, if u dont want an important feature xd