DDraceNetwork - developer

ddnet-maps

[ddnet-maps:master] 1 new commit

2ff89f1 A Drip Dry, M [SI] LAVITA - ddnet-maps

petition to make ddnet client not lose focus when you run server in main menu?

06:40

very annoying

def-

[ddnet-web:master] 1 new commit

0091b34 Update frontpage video - def-

def-

[ddnet/ddnet] Issue opened: #3525 make ddnet client not lose focus when you run server in main menu

07:40  [ddnet]  petition to make ddnet client not lose focus when you run server in main menu?
07:40  [ddnet]  very annoying

Probably on Windows only. I'm not sure what the best way is though. I guess we can't tell Windows to put the cmd window in the background instantly? If not, then we have to find the right moment to force client to top.

08:44

def-

[ddnet/ddnet] Pull request opened: #3526 Run server in background on Windows (fixes #3525)

https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-showwindow

Displays a window in its most recent size and position. This value is similar to SW_SHOWNORMAL, except that the window is not activated.

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered po...

def-

[ddnet-web:master] 1 new commit

6b1ffd2 Add GER3 location - def-

@Ama Can you check Polish translations? https://github.com/ddnet/ddnet/pull/3433

Update Polish translation by def- · Pull Request #3433 · ddnet/ddnet

Anonymously contributed, will need someone with Polish language to check Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly re...

bors[bot]

[ddnet:master] 4 new commits

bad2d71 Add ExecuteUpdate to database interface reporting affected rows - Zwelf 4375bc1 Don't depend on table locking for savegame load/save synchronization - Zwelf cf80ace Remove locking from database interface - Zwelf bdb19cd Merge #3524 - bors[bot]

09:55

bors[bot]

[ddnet/ddnet] Issue closed: #3522 Recover mysql db when lock stays acquired

09:55

bors[bot]

[ddnet/ddnet] Pull request closed: #3524 Remove sql locks

@deen for #3504 why doesn't HAVING work?

https://github.com/ddnet/ddnet/pull/3504

Display median time instead of average (fixes #3399) by def- · Pull...

Do we want average too or just median? Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configuration options Writte...

Ah it's not over an aggregate property

09:57

I think just a LIMIT 1 is cheaper than grouping and filtering

Would still need to filter, or how else do you get the correct Map to be the first in list?

yeah, I'm just saying we can get rid of the grouping

without the group by we would get the median of each finish

09:59

which is just the finish time itself

10:00

hm, or not?

Um, I don't think that's how partitions work

10:00

You are taking the median over the entire window iirc

oh, my group by is totally wrong then

I mean it will work out due to the fact that all the values are the same and mysql reaaaally wants to fix your mistakes, but yes I think so

fixed

\o/

bors[bot]

[ddnet:master] 2 new commits

b3062d0 Fix median calculation - def- 29fbadd Merge #3520 - bors[bot]

10:17

bors[bot]

[ddnet/ddnet] Pull request closed: #3520 Fix median calculation

10:24

Learath2

[ddnet-web:master] 1 new commit

7fc6026 New staff - Learath2

10:25

def-

[ddnet/ddnet] Pull request opened: #3527 Prevent OpenSSL SIGPIPE (fixes #3513)

by making libcurl handle the signal itself See https://curl.se/libcurl/c/CURLOPT_NOSIGNAL.html

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the chan...

Learath2

[ddnet-web:master] 1 new commit

4b355b3 Remove inactive people - Learath2

def-

[ddnet/ddnet] Issue opened: #3528 Can't use save code

On map Joyride I tried /save foo, but got a 3-word save instead. When I try /load foo it shows no save code. My expectation would be that either I have used this save code already or can use it.

bors[bot]

[ddnet/ddnet] Pull request closed: #3502 Some (mostly backported) refactor

bors[bot]

[ddnet/ddnet] Pull request closed: #3526 Run server in background on Windows (fixes #3525)

11:13

bors[bot]

[ddnet/ddnet] Issue closed: #3525 make ddnet client not lose focus when you run server in main menu

11:13

bors[bot]

[ddnet:master] 2 new commits

8edb561 Run server in background on Windows (fixes #3525) - def- 0b2c457 Merge #3526 - bors[bot]

Patiga

[ddnet/ddnet] Issue opened: #3529 File name sanitization

File names are not sanitized, leading to different behavior on different platforms. Examples:

map names can stop players from joining a server
image names in maps can block the extraction of them
saving demos, rendering demos can fail unexpectably due to the file name

See https://en.wikipedia.org/wiki/Filename#Comparison_of_filename_limitations

Hey, I have moved my 0.6 whisper part in my mod to PreProcessMsg(), no logic change, just changed the place where the whisper is split into parts and where we get the message out of the /w command. https://github.com/fokkonaut/F-DDrace/commit/cb5622b612da54c43e0ab2ba2a96c67d2e74f133?w=1 somehow, on the way from preprocessmsg to onmessage again, the m_pMessage gets (invalid utf8), and i dont know why

11:35

i checked that even at the end, right before the retrun of the s_aRawMsg the m_pMessage still includes the right string

11:35

directly in OnMessage its broken already

@deen send me the list then i can check

@Ama https://github.com/ddnet/ddnet/pull/3433/files

Will have to fix like 3-4 lines

12:37

Rest is fine

didnt do ddnet dev in a while what is this whole clang format all about

14:13

i mean i kinda get it what its about but any setup instructions anywhere?

14:13

maybe a how to run it in the readme would be nice

clang-format -i <file>

yea also found that i guess i have to either script something or go over the files i edited manually

15:54

ok well it works kinda well actually

16:02

not too conviced by the style yet :D

def-

[ddnet/ddnet] Pull request opened: #3530 Improve ClShowDistance a bit

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

scripts/fix_style.py ah i see

[quakenet] ChillerDragon

Click to see attachment 🖼️

xddd

yikes how dangerous is it to run a system with full disk space? I feel like linux is handling it pretty well but the amount of warnings give me the impression the machin wont survive a reboot

ChillerDragon: don't. programs fail in funny ways