DDraceNetwork - developer

fokkonaut

[ddnet/ddnet] Pull request opened: #3422 Add option to zoom ingame cursor

Closes #3421

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addres...

@Learath2 can it be that extended net messages differ in their uuid?

01:12

because i cant seem to send a ddnet client the capabilities msg

01:12

and i cant seem to receive the show distance msg from a ddnet client

01:12

(it worked before, i dunno why i cant receive it)

i am out of ideas, for real :D

ofc not

01:52

the uuids stay the same

ye i mean

01:59

idk xd

debug what exactly you receive on the client when you send it e.g. capabilities

02:19

I'd print a hex dump dbg_msg

Why won't you just send ddnet version as one number, so check if it's greater then X, then it supports something

@Дядя Женя because we want to support other mods

What do you mean by mods

modifications

Banana090

[ddnet/ddnet] Pull request opened: #3423 Set default refresh rates

Since my english is pretty bad I can't clearly describe why is this important, but thrust me - it is. You should never set the default game refresh rate to infinity, it leads to some hardware problems. 500 for default should be just enough (I'm playing on 333 and everything is smooth and OK). If the player wants it - he can set it to infinity by himself if he knows what he's doing

def-

[ddnet/ddnet] Pull request opened: #3424 Fix dragger being shown (fixes #3414)

Still doesn't seem to work with different team and /showothers 1, but maybe that has always been the case

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested...

Anyone here got an idea how people rename themselves from one name to the same? They trigger the message '$name' changed name to '$name'. This is printed in gamecontext.cpp:2183 if WouldClientNameChange returns true. That function returns str_comp(m_aClients[ClientID].m_aName, aNameTry) != 0. So I'm confused. The names are printed exactly the same in logs (verified with hexdump), not just similar.

but it also returns true somewhere else doesnt it

No

09:08

only if the Set parameter is true, which it isn't for WouldClientNameChange

i see the opposite

09:09

or better

09:09

i see it true when setclientname is set

what is setclientname?

a function that is called by the gamecontext on player mconnect mesage

But we only call that when WouldClientNameChange was true

not when NETMSGTYPE_CL_STARTINFO is set

ehm, we don't check that startinfo has been set already?

so you can only change the name by this packet?

ah, we do. first line is if(pPlayer->m_IsReady) return;

but maybe the name was set before

09:12

or is that impossible?

09:12

NETMSGTYPE_CL_CHANGEINFO does not check for ready

09:13

but i also not 100% into this whole code

could they keep renaming? I don't get it

maybe they have some bot client that changes skins or smth like that and spam the info directly

09:14

idk

09:15

as said i dunno how sensitive the server is with packets, bcs im not too much into it

09:15

but thats something i could imagine xd

def-

[ddnet/ddnet] Pull request opened: #3425 Remove redundant check for pPlayer->m_IsReady

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

the server doesnt care about NETMSGTYPE_CL_STARTINFO

09:25

if(m_aClients[ClientID].m_State == CClient::STATE_READY) is outside of the return true

09:25

so i guess this is possible

ok it does check it indeed

@deen you mean the 'nameless tee' -> 'nameless tee' log messages right? Spammed all over the place by a few tees. As far as i remember those are usually clan or skin change binds bound to a and d for example

ChillerDragon: Yes, but why would a clan/skin change show up?

09:54

I can't reproduce it or understasnd how

yeah me neither now xd

Would be much easier if our professional pentesters also reported how they did their cheats

haha the front :D

10:14

hm i can also no longer reproduce it but i remember seeing my clan bind in my logs at some point

10:15

I really would love to see a nice pdf by pink rat documenting ddnet map skips :D

ok, got it

def-

[ddnet/ddnet] Pull request opened: #3426 Don't print name change message when trying to change to banned name

Introduced in https://github.com/ddnet/ddnet/pull/3095/files?w=1

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's...

just wow

def-

[ddnet/ddnet] Pull request closed: #3423 Set default refresh rates

I'd like to deploy 3426 quickly. Someone got time to review?

Okay, I've taken a look.

thanks

bors[bot]

[ddnet:master] 2 new commits

7260dec Don't print name change message when trying to change to banned name - def- 7a48c06 Merge #3426 - bors[bot]

11:03

bors[bot]

[ddnet/ddnet] Pull request closed: #3426 Don't print name change message when trying to change to banned name

bors[bot]

[ddnet/ddnet] Issue closed: #3414 Laser puller is not shown pulling in client anymore

11:12

bors[bot]

[ddnet:master] 2 new commits

bdfb8bb Fix dragger being shown (fixes #3414) - def- c13eef8 Merge #3424 - bors[bot]

11:12

bors[bot]

[ddnet/ddnet] Pull request closed: #3424 Fix dragger being shown (fixes #3414)

bors[bot]

[ddnet:master] 2 new commits

7eb26c6 Remove redundant check for pPlayer->m_IsReady - def- 8d4e1a8 Merge #3425 - bors[bot]

11:20

bors[bot]

[ddnet/ddnet] Pull request closed: #3425 Remove redundant check for pPlayer->m_IsReady

@deen here???

@Roci sometimes

@deen apparently their server broke while hosting a tournament, he was asking whether we could host gctf for them again

guys can any1 help out with servers? we need 4 servers, else we will cancel the tournament

ping deen

I got it set up, was going to do it but I didn't have access on the computer I was on

@Roci sure i can help w servers

Learath2 already did

oh

Sorry, I wasn't home

The format of today's AoC looked 100% like a DCG, so I just used sed+prolog to run it: https://github.com/def-/adventofcode-2020/blob/master/day19.pl

whats this magick

https://www.metalevel.at/prolog/dcg

Prolog DCG Primer

Introduction to Prolog Definite Clause Grammars (DCGs)

18:36

an easy way to define a grammar in prolog. You could do it without that, but it's a bit more syntax

Maybe I should consider this my sed-solution

if u want a challenge program it for a GPU

I think this explains it better actually: https://en.wikipedia.org/wiki/Prolog_syntax_and_semantics#Definite_clause_grammars

18:40

I don't, I've gotten lazy and am searching for the easiest solutions now

i also got lazy pepeH

I have some multiprocessing languages on my list, but felt like it's too stupid to split up these small problems into chunks

I actually had this grammar stuff in first semester.. too bad I already forgot everything

20:49

But I still remember the name of the algorithm

20:49

It's called CYK

20:50

We had to do the algorithm by hand in table form for the exam (edited)