DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2020-11-23 00:00:00Z and 2020-11-24 00:00:00Z

[ddnet-maps:master] 1 new commit

ce1ff60 M Tribute 1, A Iris - ddnet-maps

What is this pr for? https://github.com/ddnet/ddnet/pull/3325

Add ball effects, even for invalid projectiles by Jupeyy · Pull Re...

@pure-luck-999 can you test, if this is already enough? fixes #3323 Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related ...

09:46

Because these "ball effects" are also possible by just snapping a projectile with m_Type = WEAPON_HAMMER

09:47

and in the current ddnet version i am not able to see those white balls anymore

09:47

with 15.1.3 i can see them.

09:47

@heinrich5991

09:48

I am using these balls in my mod, and now they are not visible anymore.

09:48

Without this pr, or with 0.7 clients, or any other client it works, so dunno, @Deleted User ?

are you sure the problem is not in the earlier commit that pure-luck openend an issue about?

10:04

(that is linked in the PR?)

mh, i dont know tbh

10:04

i just noticed that after 15.1.3 they dont show up with type hammer

10:05

that shouldnt be hard to find, do you have ideas what happened?

@fokkonaut we released a new version with that pr inside

10:21

and pure luck said it worked again, so dunno

ok, will checl

10:25

check*

[ddnet/ddnet] Issue opened: #3351 Allow binding to Escape

Example use case

bind Escape say bye
bind Escape +scoreboard

[ddnet/ddnet] Pull request opened: #3352 Add benchmarking section to README

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--u...

@deen are you sure the result of the benchmark is calculated correctly? The frametimes in the log are correct, but the test suite shows different results

Do you have an example?

https://openbenchmarking.org/result/2011232-FI-DDNETJ17015

12:44

ingame it showed around 1400fps, and the log also shows frametimes that say this

If the frametimes we print are correct, then pts does the calculation wrong?

well probably

12:47

i dunno who, or when it gets calculated

https://github.com/phoronix-test-suite/phoronix-test-suite/blob/master/pts-core/objects/pts_test_result_parser.php#L1053

phoronix-test-suite/phoronix-test-suite

The Phoronix Test Suite open-source, cross-platform automated testing/benchmarking software. - phoronix-test-suite/phoronix-test-suite

12:48

if($frametime > 2000) seems weird

12:49

we use libframetime-output

thats really weird

12:50

so it only took my laggs and the game start xD (edited)

I want to create a crossplatform UI that can be shared as as single executable

13:18

preferably <30MB or so

13:18

also in python, if that's remotely possible

13:22

I tried: hello world pyqt5 program bundled with pyinstaller, about 70MB in size

13:23

currently installing wxwidgets to see if it is any bit smaller in size

13:25

it seems that the pyqt thing include libicudata twice(!)

@heinrich5991 i used tkinter last time I did that with Python, should fix the 30 MB, but looks bad.

13:51

gtk should be a bit smaller than qt too

13:52

maybe just use a local webserver and open a link to it in the user's browser? That works on every platform and everything is a website nowadays anyway

@heinrich5991 rust links most libs statically and u can use gtk-rs

14:01

u can try https://github.com/hecrj/iced

A cross-platform GUI library for Rust, inspired by Elm - hecrj/iced

14:02

a gtk program i made in rust, it doesnt have much but u can see its size is rly small

Image attachment

14:02

poggers

managed to shrink the pyqt5+pyinstaller to 20MB by stripping stuff

14:37

I guess the webserver thing is the way to go…

14:38

@Ryozuki can I see the program's source code somewhere?

14:42

oh, ddnet increased in size quite a lot

14:42

the win64 zip is 40M these days

its the chinese font

oh, 17MB of that is the font

14:44

yea

14:44

fine I guess

Not home rn sry

chinese bad

Ye

vanilla just took in a 19MB font as well

14:49

font sux

14:49

just kill all asians

English is more optimized than chinese, you can say more with less

你tm在逗我

14:50

这长度你能比？

therefore chinese ppl are all artists xd

24 characters is all u need

@Ryozuki is that so? in less bytes?

14:50

ah, in fewer letters (edited)

alphabet is overrated

14:51

speaking of bytes

14:52

16 bytes can only fit 4-5 chinese chars

14:52

so you want an extension?

vanilla got one.

14:53

so maybe

could also just go decoded utf8

not really sure yet. but 16 glyphs would be nice

and compress the network stuff

you can also just have a protocol extension for only names and only send those when names changes

or just give 0.6 a deadline

14:54

and drop the old protocol soon

0.8 would be a nice deadline. but that would take a few years

14:55

ppl really want 0.8 to be good enough for porting. but i doubt it

well 0.8 will probs already contain different mapfiles etc.

14:55

if vanilla maintainer dont block it

with the water stuff probabaly

that too

14:56

redix should just get greenlight

14:56

then vanilla can finally improve they stuff

but i think we did talked about a built-in map converter in server

they should break compability to themself xd

redix isn't available for the rest of this year iirc

thats what i say to myself every day

thonk

actually how do you think of the vanilla sux for mod mentality.

@deen Take a look at your commit https://github.com/ddnet/ddnet/commit/a4f13ed4a85a4a2b2e901342a9f4341c779e883c#diff-472b2e75e6cbd3e80ec9ec50e60d8b0dc61c4b9aa81f67ae395cc5d375875a0eL557 The MAPITEMTYPE_ENVPOINTS item is part of the map format and holds the number of envelopes in the map. You changed this so it is only saved if there is at least one envelope. I think this might be a bad idea. The Python tml library can't read those maps anymore, there might be implications for other map related software. You could change this back or I could fix this in the tml lib.

Fix clang-analyzer-optin.portability.UnixAPI · ddnet/ddnet@a4f13ed

and mark some false positives /media/ddnet/src/engine/client/backend_sdl.cpp:329:30: warning: Call to 'malloc' has an allocation size of 0 bytes [clang-analyzer-optin.portability.UnixAPI]

15:00

@Tezcan

@TsFreddie yeah, why do they hate mods so much XD, they should use protected and virtual much more

thonk

interesting

@timakro changing this back is fine, but we'd want to avoid a zero-sized malloc there

15:02

so allocate min(1, PointCount) instead

Deleted User

@TsFreddie yeah, why do they hate mods so much XD, they should use protected and virtual much more

Yes

@TsFreddie when first try implemented fng2 (on 0.6 vanilla), i indeed tried to not modify any files and overload as much as possible, but it was a mess

(edited)

15:03

i ended up copying the same stuff(that was private:) all over again

thonk

i've made fng before

15:03

ye

if it was just "protected:" it would have been much more easy

but that might be a different concern that i normally think about

15:04

maybe there're just way too many problems

well i mostly care about the server impl as mod ofc

but i love how ppl just drop-in and expect client support for their server.

even tho a nice client base would be cool too

15:05

well yeah, but you could arguee that this is a different game then, upto some point

15:06

ddnet for example is mostly simple stuff added, prediction and so on

ye.

but if it would add real different weapons, i'd say it gets a new game

well vanilla's adding (water) weapon now. but probably still vanilla only.

15:06

i wonder how much stuff will be cut

15:07

(probably most)

but i personally think thats good, but they should break every compability

15:07

vanilla always acts like it has to support ddnet

huh?

do they?

didn't seem so for 0.7

well 0.7 is soo similar

ye. i didn't get that vibe as well

i don't really see a huge difference

that's just because nothing got changed in vanilla

it's probably not a ddnet thing

not because they tried to stay compatible with ddnet

[ddnet/ddnet] Pull request closed: #3335 Rescue works on any type of freeze now

well ok, but for me that sounds similar

15:09

but i saw on vanilla discord arguments like "it would break current maps"

15:09

that sounds like they want to stay downward compatible

well they probably means all 0.6 maps or 0.7 maps so far

yeah but if it comes hard on hard, write a external unrealted converter

15:09

no need to do this inside the code

thonk

i think hosters want map converter more. vanilla probably wouldn't do it if they never think about it.

but what mod except race, even has sooo many maps

15:11

for fng i'd say, if they like 0.8 converting these 5maps isnt the big issue (edited)

i think they just think about it regardless the userbase

@Deleted User that's e.g. due to the tileset reordering in 0.7

15:11

which broke tons of community maps

but now I'm pretty sure vanilla gives out different vibes to different ppl, which is cool

yeah, but its not really an issue, embedd the vanilla images and finished

15:12

if the map is 200kb or 20kb doesnt matter

https://heinrich5991.de/teeworlds/maps/maps

15:12

tell me which maps use 0.7 tilesets and which 0.6

15:12

then we can start embedding

15:12

unfortunately it's 50k maps

15:12

and 49.999 of them are 0.6 xD

A script could do that?

if you find a good way to find out which maps expected 0.6 and which 0.7, yes

xd

I was thinking about doing some ML for it, but never got around to it

ofc, automapper

15:14

if the mapper didnt force some broken stuff, the automapper should output smth similar

15:15

or better: define what looks right

hey, I'm actually in favor of having such a script

15:15

if you can put something together, that'd be really nice

15:15

if not, you found the problem why they now care about backwards-compatibility

15:15

it's just such a PITA

15:15

to not have it

but lets be honest

15:15

for 99% maps it will work

give me the tool

its just for the 1%, and they can be fixed manually

I'm fine for 99%

@Deleted User do it now!

(and no, can't be fixed manually, you'd have to know where the tool goes wrong)

15:16

@TsFreddie well, 0.7 is out for years, this is still an unsolved problem

15:16

showing that backwards-compatibility would have been a good thing

i disagree

why?

how is it good to have all maps working for ever

how is it bad?

thonk

actually, didn't 0.7 had some map structure change?

15:17

or did that happen later than tileset changes

well if you wouldnt have accepted 0.6 and 0.7 maps at one repo(e.g. bcs they arent even compatible) we could easily convert them

@Deleted User can't have that, teeworlds doesn't save those to separate folders

but 0.6 upto 2 weeks ago added crc and sha

ddnet

or just crc

0.7 also added crc in the beginning

15:18

sha256 was a change AFAIR

yeah but thats the 1% case again

oh come on

nobody used 0.7 before release

i can try making some rules for tileset checking.

@Deleted User wasn't it actually after release?

15:19

also please stop making numbers up

but i don't know the map structure like at all

say "very few" instead

but yeah i think you can detect always all broken maps by analyzing the tiles and define what should look correct to human eye

15:19

just like a automapper

"can"

15:19

I haven't done it in years

15:19

please do it, I'll gladly accept the tool for the archive

15:20

as long as it just "can" be done

15:20

it's as good as if it's not possible

as i said, it wont work for every case

ghosty

but it works for enough to be relevant

then give me the thing that works good enough

15:20

I'd be happy with that

15:20

we're going in circles already

why should i waste my time with that now xD

like map with intentionally broken tiles

ye, see?

yes i see it

so with backwards-compatibility this would never have been a problem

thonk

i have time

if vanilla 0.8 has a different file format its detectable easier

we wouldn't be here discussing it

15:21

I outlined a way to make it compatible in the teeworlds issue tracker

if it would just break compability ;D

edit: I have wastable time

e.g. 0.7 could have just added a version of the exporter(editor)

15:22

all problems solved

15:22

but they used 0.6 file format instead

15:22

so a broken downward compability

1

ye, that would have worked

tbh why they didn't thought of that when updating tilesets is beyond me

15:25

seems like such an obvious thing to do.

ironically i'd say, bcs in the end 0.7 was rushed xD

15:25

even if it took liek 10 years

~~microsoft buy us plz~~

do you want DOS support or what? XD

no we want microtransactions and dropped linux support and closed src

and payed staffs

minecraft doesn't have any of that

15:30

except paid staff ^^

15:30

ah, closed source

15:30

but it was closed source before that

and microtransactions

well minecraft does have microtransactions

oh really?

a shit ton

15:30

bedrockredition

yes, the bedrock one

I didn't know. I even played it recently?

they have 2 minecrafts java and c++

oh, you mean some fake minecraft that isn't the java edition? ^^

u probably played the linux compatible version

i think the skins and resource packs are payed

i mean the official minecraft by microsoft

but tbh the c++ version works much much better xD

15:31

just no good mod support

i doubt it runs on linux

ye, the bedrock version runs really well

yes sadly

and i'm actually glad they kept both version somewhat in sync

also didnt ms drop linux supprot on skype

in terms of features

do they have crossplay?

no

hm

ms bad

is anyone actually playing that version? ^^

they have different redstones and weapon system

yes chinese

I don't think anyone I know plays it

but at least the blocks are mostly there for both version

europeans stay in java edition

wdym chinese

i thought bedrock is big in asia or something

indeed alot of PS4 and XBox and tablet users use the mobile version, but i guess in the end most ppl are still more interested in modded minecraft

i'm offended

Tw adding water guns? What happened about following the KISS principle like fanatics? aPES_WTFEyes

aPES_WTFEyes

vanilla minecraft is useless

15:33

vanilla minecraft cant handle more than 8 players online at the same time

it gets boring fast, yes

also something ms introduced

huh?

not it just doesnt have basic performance

minecraft always scaled badly

15:34

but I think with beefy servers you can go beyond 8 players

Microsoft will force u to make ur mojang account a microsoft account

server kills it self because it runs too slow on a 3.6ghz 8 core machine when 8 players play at the same time

i think the C++ version of minecraft is using playfab which ms bought as well

they made java version perform so bad to force people to buy windows and bedrock edition

https://www.minecraft.net/en-us/article/java-edition-moving-house

Java Edition is moving house

Same Minecraft, new and improved account!

15:35

Worst

ah yeah, heard that too

15:35

annoying af xd

Now just to be clear, migrating from Mojang to Microsoft accounts is mandatory. If you don’t make the move, in several months you won’t be able to log in anymore – which means you won’t be able to play either. But no need to worry, because we’ll give you detailed and clear instructions on how to do so. You’ll get the information you need through this site, an FAQ on our support page, videos on our YouTube channel, and even emails straight to your inbox.

15:35

I think ishould be able to sue them

15:36

I have the right to the product i bought

wat i lose my mc accs if i dont convert huh didnt know

Yep

wtf

15:36

can i get them back later?

probably

15:36

you can't play until you converted though

~~mojang account isn't really feature complete with basic authentication options~~

Microsoft in a nutshell: extend embrace extinguish

ye EEE classic

~~but yeah they could've made it better instead of nuking it~~

I don't think EEE applies. EEE is about standards IIRC

so pls dont sell to ms

to describe its strategy for entering product categories involving widely used standards, extending those standards with proprietary capabilities, and then using those differences in order to strongly disadvantage its competitors.

we can get paid staff via donations instead :D

thonk

~~imagine closing donations~~

well ms had the data before this move, but its annoying to always get intetgrated into some eco system

[ddnet/ddnet] Pull request opened: #3353 Alternative fix for malloc of size 0

Since a4f13ed4a85a4a2b2e901342a9f4341c779e883c doesn't work with tml

Checklist

[ ] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[ ] Tested the change with [ASan+UBSan or valgri...

suggestion greenthing

greenthing

making dummy Shared feelsamazingman

feelsamazingman

to players able to move it more than a player

‍

2

8

damt

Good that you asked before implementing it

1

really or you kidding saddo

saddo

really. it's a waste to implement a feature that no one wants

again a crash when someone joined a server

22:55

i wonder if its related to the decompress issue

22:58

can i run an executable with automatic crash dump, without any huge perf loose? i have debug symbols on

what do you mean by automatic crash dump? I get a core file if something crashes, 0 performance impact

how do i enable that

https://wiki.archlinux.org/index.php/Core_dump

ok thx

23:00

hope i get something useful next crash

The existing ones should be in /var/lib/systemd/coredump already

yeah sadly empty

cleared after 3 days

it happened 20minutes ago xd

Exported 320 message(s)