DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2020-11-18 00:00:00Z and 2020-11-19 00:00:00Z

The devil is interfering with your illegal ban of a brother

00:28

That's sooo odd tho, hm I don't see how it could happen

@Learath2 lol, ye same, maybe the client is trying to decode it as ascii when its utf8?

Doesn't look like it

is your character position always available when you /pause

02:47

like even when your camera goes out of range.

No

05:22

Not if you hack something in :D

05:22

/showall would work for example

05:22

but only on ddnet

i want a "You are here" arrow at the edge of the screen

05:26

when you are pausing

@noby do they work in chat?

@TsFreddie dont think thats possible in a good way

05:42

The local character is not even set when you are pausing

05:43

would maybe be possible to reach it through the snap array but then again it only works within the range or with /showall

05:43

https://github.com/ddnet/ddnet/blob/f8b07f705ef5b8f35d05511163ee54bec44cbae5/src/game/client/gameclient.cpp#L1482

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

maybe we can change the range detect a bit and always include the current player's snap

06:15

/pause is a ddnet feature anyway.

[ddnet/ddnet] Pull request opened: #3327 Check skin/sprite images for correctness

I hope this helps with downloading things at wrong resolution again. Note that this commit is smaller than it seems, bcs of renaming files and moving code to it. Also this requires new translations. In the skin database are invalid skins too: !screenshot_2020-11-18_07-51-02 ![screenshot_2020-11-18_07-51-05](https://user-images.githubusercontent.com/6654924/99495410-e7fc1500-2972-1...

Do I need to check anything special while doing virtual functions and base and child classes?

08:30

If I call a function from the base class the overridden function wont get called

08:30

i dont understand, because I did it basically the same way as entities do it in tw or the gamecontroller

are the parameters the same type? try adding override to the child class' function to get a compiler error if it isn't

parameters are the same, yes

08:33

class CFoo : public CBar

08:33

CFoo is the child, right?

08:36

it doesnt give errors with override

08:37

but also doesnt work :D

yes

yea, doesnt work

08:37

i dont get it

make a minimal example

c++
class CPerson
{
  int m_Age;
  virtual void SetAge(int Age) {};
}

class CWorker : public CPerson
{
  virtual void SetAge(int Age) { m_Age = Age; }
}

08:39

something like this maybe? :D

08:40

i also tried not declaring the CPerson's function without virtual, also doesnt owrk

08:40

It's basically the same as teeworlds' CEntity stuff, but in my case the base classes function is called

08:40

i checked that with a dbg msg

08:41

ah, forgot in the example: of course i call the CPerson's function, so basically m_pPerson->SetAge(Age);

You are supposed to actually try the minimal example to figure out the problem, and not leave that to me

08:42

Works fine for me: https://gist.github.com/def-/2a748ad06913cf1ab39e4912fc1ca2f1

mh, doesnt work for me in the teeworlds code? ...

08:43

wtf :D

Try making SetAge public

both is public for me

08:43

in both classes

If your minimal testcase works it's not a minimal testcase

08:44

Are you maybe calling the function through a pointer to the baseclass?

yes

08:45

Is that a problem?

08:45

CEntity does the same

Not really, it's fine I just wanted a better image

maybe you call SetAge in base class (CPerson) constructor?

So you added override to the child class method and the compiler didn't complain?

@Comrade nope, calling it from CGameContext

08:50

@Learath2 yes

and are you sure that m_pPerson is pointing to CWorker instance?

what do you mean? :D

08:54

its pointing to the CPerson class, calling a function, which i think should be overridden by the CWorkers function

08:54

But appearently its just calling the CPersons function

Well just show us a diff? I'm out of ideas, if it doesn't complain with override, it overrides correctly

well, if it points to CPerson object, then everything works as expected (edited)

The only thing that remains is that you are not creating a CWorker but a CPerson instead

well

08:56

that could actually be it lmao

08:56

yeah thanks alot man

08:56

wtf

Lol

yes

08:56

big lol

happens

haha :D

08:59

@Learath2 Thanks, but how did you get that thought? xD

Well as I said, if override doesn't complain, then you are overriding correctly

08:59

You said you have a pointer to CPersom

09:00

And you are not doing the call in a constructor

09:00

So the only thing that remains is that the pointer doesnt point to a CWorker at all :P

aye

09:02

Great, thanks alot

@fokkonaut make the destructor virtual in ur base class

[ddnet/ddnet] Issue closed: #3322 Infinite loop when entering too long ping filter

to avoid problems

09:03

in the future

09:03

https://www.geeksforgeeks.org/virtual-destructor/

Virtual Destructor - GeeksforGeeks

A Computer Science portal for geeks. It contains well written, well thought and well explained computer science and programming articles, quizzes and practice/competitive programming/company interview Questions.

I wont need a destructor, but yes, you are right

if ur base class destructor is not virtual it will never get called

09:03

wait

09:04

ur chiuld destructor wont get called*

09:04

child

09:04

*

xD

my english xd

@deen would be nice if you could ping @ChillerDragon in such an issue so i do get a mail and dont create a dupe https://github.com/ddnet/ddnet/pull/3311 and next time i wont listen to heinrich :p

No infinite loop in TextEx by def- · Pull Request #3311 · ddnet/ddn...

Happens when writing 4 digits in Maximum ping field in filter. This in turn causes a clamp to 3 digits. The Length in TextEx is fixed to old str_length apparently. Maybe there is a better way to fi...

thats a pr

09:05

i think u made a issue

09:05

so its fine

ah ye true

09:05

im so brainded xd

monkalaugh

still didnt see and a ping would be nice so i dont create a issue after the pr :D

ChillerDragon

09:06

there pinged

09:06

troll

ye githubs ping system is not as fleek as irc tho

I assume people here see PRs. And heinrich explicitly told you to only create an issue if the problem stil occurs (that means in the current master state)

i looked at git history and did not see any fix cuz im blind

09:08

ja was fail

09:08

but pls use an @ if you do something that could interest em :)

09:08

me*

166 bytes skin xd

Image attachment

09:33

looks cool ingame xd

Image attachment

reason=stars is broken as well

11:04

at least on CHN

11:04

just tried on GER, not working

I know

11:05

I have a fix open, but waiting for review

thonk

oh

https://github.com/ddnet/ddnet/pull/3319

Fix random map vote reason to set stars by def- · Pull Request #331...

Caused by the hotfix for solo cheat As reported by maggi323 Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configur...

i see

[ddnet/ddnet] Issue closed: #1969 /save internals improvements

@deen in #3319 why does str find and endswith fix the issue even? I couldn’t really make sense of it

https://github.com/ddnet/ddnet/pull/3319

Fix random map vote reason to set stars by def- · Pull Request #331...

Caused by the hotfix for solo cheat As reported by maggi323 Checklist Tested the change ingame Provided screenshots if it is a visual change Tested in combination with possibly related configur...

probably because the command is no longer at the beginning of the vote command

11:44

still just piling another hack onto the existing hack ^^

Wait why?

how I imagine this works:

What is at the start of a command now?

probably something like sv_reset_file solo.cfg

11:45

(note that this is still all speculation on my part, I haven't looked into it)

Oh, no really? ;D

hence https://github.com/ddnet/ddnet/issues/3317

Drop default configs for gametypes and put them into the maps inste...

I'm talking specifically about stuff like sv_solo_server, which should be inside the map. That would allow the map to be hosted independently, and prevent bugs like the non-solo game settin...

This is kinda awful ngl, butI guess 3319 should still be merged in the meanwhile

[ddnet/ddnet] Pull request opened: #3328 Unlimited texture names

Checklist

[x] Tested the change ingame
[ ] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[x] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existing maps
[x] Tested the change with [ASan+UBSan or valgrind's memcheck](https://github.com/ddnet/ddnet/#using-addresssanitizer--undef...

Just an idea: if someone would port ninja indicator bar from 0.7 to DDNet codebase would it be merged?

11:56

I mean with both UI and netmessage support (didn't researched which is needed there)

11:57

on good news, i already load them into memory @Deleted User

[ddnet:master] 2 new commits

c3f6d89 Fix random map vote reason to set stars - def- b4f8f79 Merge #3319 - bors[bot]

11:57

[ddnet/ddnet] Pull request closed: #3319 Fix random map vote reason to set stars

so it should be ez to implement probably

I would like to see that yes, but I still think we should get upgradable netobjects before this

@Deleted User you mean only GUI is needed and ninja start time is already got from netmessages/snapshots?

I really don’t want to start introducing things like ddnetcharacterv2

11:59

Though I guess the data is already on the client, maybe you don’t need any new netobject

@Deleted User i dunno how 0.7 implemented them, but i added a few 0.7 sprite capabilities already

12:00

client data from 0.7

@Deleted User yes

12:02

the rendering of arabic characters in chat isnt entirely correct, but at least the characters show up and i hear they are readable

12:02

vs the ban reason where they are unreadable

send the arabic string pls

12:02

i ban myself now to test xd

للتجربة

str_sanitize_strong(aStr);

12:07

but dunno what this does

yea, it does that

12:07

it mangles the string

12:07

nice

12:07

who invented this function

12:07

anyway its in CNetConnection::Feed

12:08

dunno if we want to fix it

is it being mangled in the client or the server

client

we should at least fix that it's being mangled instead of replaced by ??? or so

is there a chance that it can be fixed so that messages appear the same in ban reason as they do in chat

yes

its a commit from matricks 9 years ago xd

12:11

11*

got the screenshot again? @noby

Embedded image

12:11

this?

[ddnet/ddnet] Issue opened: #3329 str_sanitize_strong mangles UTF-8

Dunno if we should get rid of this function entirely or fix it in a way so it replaces non-ASCII bytes by ?. Causes ban reasons to be mangled: https://cdn.discordapp.com/attachments/293493549758939136/778401637466898472/unknown.png Apparently caused by this ban reason: للتجربة.

thanks

[ddnet:master] 2 new commits

f38e4e1 Unlimited texture names - Jupeyy 00247f0 Merge #3328 - bors[bot]

12:27

[ddnet/ddnet] Pull request closed: #3328 Unlimited texture names

[ddnet:master] 2 new commits

c989cd6 Check skin/sprite images for correctness - Jupeyy 078247d Merge #3327 - bors[bot]

12:36

[ddnet/ddnet] Pull request closed: #3327 Check skin/sprite images for correctness

12:42

[ddnet/ddnet] Issue opened: #3330 Rescue (/r) doesn't work with heart

Everything is in the title. I believe it does'nt work because heart have 1.5 tile radius while rescue check only 1 tile radius so it thinks im not on a freeze tile. !image

Wait, so do we want to just send any utf8 ban reason? I don't see any reason to limit it

@deen yes that would be the best thing

ok

[ddnet/ddnet] Pull request opened: #3331 Allow utf8 ban reasons (fixes #3329)

!screenshot-20201118@143227

Checklist

[x] Tested the change ingame
[x] Provided screenshots if it is a visual change
[ ] Tested in combination with possibly related configuration options
[ ] Written a unit test if it works standalone, system.c especially
[ ] Considered possible null pointers and out of bounds array indexing
[ ] Changed no physics that affect existin...

poggers

awesome thx @deen feelsamazingman

feelsamazingman

@Deleted User I found something odd

14:21

I set gfx_opengl_major 2 and minor 3, which should probably break since that's not a real thing, but it launches fine, doesn't output anything about the opengl version it launched with and if you go into the console and just type gfx_opengl_major it crashes

it clamps the values

14:22

to existing GL versions, if major is < 4

14:22

also cant reprod the crash :/

14:23

it doesnt output anythign for SDLs default

14:23

so 2.1

I can do it with a clean config, I set opengl3.3 in the settings. I restart, I set major to 2, I restart. It crashes when I want to check the value of major

are u on release mode?

It's the release on ddnet.tw so probably yeah

linux?

windows

oh, ok

oh it also broke my visual studio when I tried to attach it

14:25

great platform this windings, I'm so glad a lot of people use it and provide it's parent company a monopoly

cannot reprod on linux, so would be nice if u debug it, if u got time for it

Ah yes, the kind that disappears when you attach a debugger

14:29

lovely

well it could be a compiler bug ofc

14:29

asan and ubsan doesnt show anything for me

It's gone now, happened like 10 times in a row and now it's gone...

14:31

Another bug lost to time I guess

did u try a clean config the last 10 times? xd

the first 2 were dirty, then I reproduced it 8 times in a row with a clean config

reading the variable should be the same as any other config variable

it could also just be unlucky timing

14:33

timing bugs are the most horrible

timing with the graphics thread?

yeah

14:37

or sound

14:37

dunno what happens during startup

14:37

had atleast 2 persons under windows that had double sound once, unreproducable xD

[ddnet/ddnet] Issue opened: #3332 Create a DDNet test case for Phoronix Test Suite

I want to see some performance numbers on different hardware. I can probably do it myself. The idea would be to play back a representative demo of reasonable length and measure the fps meanwhile.

ddnet benchmarks

15:57

soon every benchmarker uses them

hm, some tests use binaries, some build from source. I guess building from source is better, so will do that

[ddnet/ddnet] Issue opened: #3333 Move 'Show name plates' thread to the 'HUD'

'Show name plates' is HUD part, imo. It isn't very comfortable to enable/disable whole HUD with tab changing.

17:40

[ddnet/ddnet] Issue opened: #3334 Move 'bezier.h' and 'bezier.cpp' to 'src/game/client'

bezier.h and bezier.cpp are part of client only. Why should it stay in shared directory?

after 20 minutes of gametime my client suddenly only outputs half the fps, and it starts showing. only fix is a client restart. known problem? sometimes changing to a server with fewer tees helps/delays it but not always

what client version?

15.0.3 i should update probably

yes

18:00

we had a bug in that version

haven't checked for new updates since it's not in the bottom anymore, thank you

yeah we have a homescreen now, it should show a green symbol when there is news or update

18:01

top left in the server browser

suka

wos kevin

[ddnet/ddnet] Issue closed: #3332 Create a DDNet test case for Phoronix Test Suite

[ddnet/ddnet] Issue closed: #3329 str_sanitize_strong mangles UTF-8

23:34

[ddnet:master] 2 new commits

d99f1b9 Allow utf8 ban reasons (fixes #3329) - def- a74af25 Merge #3331 - bors[bot]

23:34

[ddnet/ddnet] Pull request closed: #3331 Allow utf8 ban reasons (fixes #3329)

[ddnet/ddnet] Issue closed: #3323 Particle traces are not always drawn after 15.1.3

23:43

[ddnet:master] 2 new commits

2a7ba8f Add ball particles, even for invalid projectiles - Jupeyy 38d0bf3 Merge #3325 - bors[bot]

23:43

[ddnet/ddnet] Issue closed: #3323 Particle traces are not always drawn after 15.1.3

[ddnet:master] 3 new commits

81bb7e6 Improve list box behaviour, make it more consistent - def- cfd3f84 Found some more times with mins, use hours for consistency - def- b138c40 Merge #3304 #3310 - bors[bot]

23:52

[ddnet/ddnet] Pull request closed: #3304 Improve list box behaviour, make it more consistent

23:52

[ddnet/ddnet] Pull request closed: #3310 Found some more times with mins, use hours for consistency

Exported 240 message(s)