






















































































































D:\a\ddnet\ddnet\src\engine\client\graphics_threaded.h(26,31): error C3861: 'aligned_alloc': identifier not found (compiling source file D:\a\ddnet\ddnet\src\engine\client\backend_sdl.cpp) [D:\a\ddnet\ddnet\debug\DDNet.vcxproj]




| m_pData = (unsigned char *)aligned_alloc(alignof(std::max_align_t), m_Size);
| ^~~~~~~~~~~~~
| _aligned_malloc
or better... its trolling




note: include ‘<stdlib.h>’ or provide a declaration of ‘aligned_alloc’
61 | #include <shellapi.h>
+++ |+#include <stdlib.h>
62 | #include <stdlib.h>
mingw top troll xd [-Werror,-Wunguarded-availability-new]
maybe just disable the warning? are we shipping the libs in macos statically?



























The pointer returned if the allocation succeeds is suitably aligned so that it may be assigned to a pointer to any type of object and then used to access such an object or an array of such objects in the space allocated (until the space is explicitly freed or reallocated).m_pData doesn't have any alignment requirement. It's the things we allocate inside m_pData that needs alignment from what I understand











































































CFGFLAG_TEST and made CFGFLAG_GAME imply that you cannot execute it with rcon permissions unless testing cmds are enabled













sv_testing_cmds





















40ca3d8 Make clan plates fit & only show when name plates enabled - def-










f94d476 Don't divide by 0 in LoadSkin - def-
7e297af Don't pass null pointer into mem_copy in CServerBrowser - def-
e6b0283 No null pointer to mem_copy in SendControlMsg - def-
346853e Signed overflow is undefined in CSnapshot::Crc - def-
47299e8 Out of bounds access in CMenus::RenderGame - def-
3d76010 aPastIndecies -> aPastIndices - def-
60f4e07 Out of bounds access in RenderPlayer - def-
23db49d Server browser: Don't access friends out of bounds - def-
6680ec3 Reset CCharacterCore at start - def-
476a912 Fix CRaceDemo + CGhost out of bounds access - def-
ae1a266 CCharacterCore::Tick caused out of bounds - def-
91619b9 Merge #3051 - bors[bot]






















CPPFLAGS="-D_FORTIFY_SOURCE=2"
CFLAGS="-march=native -O3 -pipe -fno-plt -flto"
CXXFLAGS="-march=native -O3 -pipe -fno-plt -flto"
LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now"


CFLAGS='-flto' CXXFLAGS='-flto'





minimum(static_cast<int>(sizeof(Item.m_aName)), str_length(pName) - 4) should never be 18446744073709551615, though, no?





.demo before












static_cast<int>(minimum(sizeof(Item.m_aName), (size_t)str_length(pName) - 4)));





yay and it didnt yeet 100 updates at me





















CPPFLAGS="-D_FORTIFY_SOURCE=2" CFLAGS="-march=native -O3 -pipe -fno-plt -flto" CXXFLAGS="-march=native -O3 -pipe -fno-plt -flto" LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now" cmake .. -DCMAKE_BUILD_TYPE=Release -GNinjaCPPFLAGS="-D_FORTIFY_SOURCE=2" CFLAGS="-march=native -O3 -pipe -fno-plt -flto" CXXFLAGS="-march=native -O3 -pipe -fno-plt -flto" LDFLAGS="-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now" ninja












scan-build cmake -DCMAKE_BUILD_TYPE=Release -GNinja .. && scan-build ninja
scan-build: 40 bugs found.




























clang-tidy -checks=clang-analyzer*















[*] '/opt/teamspeak3/ts3client_linux_amd64'
Arch: amd64-64-little
RELRO: Partial RELRO
Stack: Canary found
NX: NX disabled
PIE: No PIE (0x400000)
RWX: Has RWX segments
RPATH: b'$ORIGIN/lib/:/usr/local/Qt-5.12.1/lib'
FORTIFY: Enabled