DDraceNetwork - questions

yo, is there still a command like "grenade_me 10" ?

what is 10? if u have a ddnet server launched with sv_test_cmds 1 then u can f2 grenade

that was a command for the strength of a grenade

https://ddnet.tw/settingscommands/ scroll to the bottom tune explosion_strength 10

or a command that u can shot grenades multiple times, like jetpackgun

tune grenade_fire_delay 0 (?)

yeah exactly, thank you bro

np

what is the normal delay ?

u can see the normal values at the bottom of that page

15:39

500 delay 6 strength

alright, thanks bud

15:40

and for rainbow ?

afaik it is only a thing in other mods like xxlddrace not ddnet

ahh okay

15:42

https://ddnet.tw/settingscommands/ is this the list of all possible commands =?

15:42

ahh, nvm, i see tune_grenade isnt there ?

at least most of them, idk if its kept upated

do you have a list of all possible commands ?

tune is there

found it, thx

commands are everything with console()->register() or chain() https://github.com/ddnet/ddnet/blob/master/src/game/server/gamecontext.cpp#L2936 https://github.com/ddnet/ddnet/blob/master/src/engine/server/server.cpp#L3378 also everything with CFGFLAG_SERVER https://github.com/ddnet/ddnet/blob/master/src/engine/shared/config_variables.h https://github.com/ddnet/ddnet/blob/master/src/game/variables.h

thank you a lot (edited)

np

Thanks @noby monkalaugh

whats the difference between register and chain

@plsplsplslol chain registers an additional function to run when the command is executed

so it runs 2 functions in 1 command

yes

15:56

I think the chain function is responsible for calling the actual function though, not sure

15:56

check an example to see what they do

ok

like Console()->Chain("sv_rcon_password", ConchainRconPasswordChange, this); because sv_rcon_password is a varaible but a function must be called when it is changed (to log ppl out if they are authed with that password for example)

oh so sv_rcon_password changes the variable and runs the function

ye

and if it was register it would only change the variable

register is for functions that arent associated with a variable atall

15:59

if its just a variable and no function then it goes in one of the variables .h files (edited)

15:59

ie

    Console()->Register("kick", "i[id] ?r[reason]", CFGFLAG_SERVER, ConKick, this, "Kick player with specified id for any reason");

so register only runs the function

adds it as a thing in f2 that, when u type it, yes only calls a function

ok

From https://github.com/ddnet/ddnet/blob/22294ec9b0484b53c8b68c064836f25d4fdb8644/src/engine/server/server.cpp#L3323-L3327:

c++
void CServer::ConchainRconPasswordChange(IConsole::IResult *pResult, void *pUserData, IConsole::FCommandCallback pfnCallback, void *pCallbackUserData)
{
    ((CServer *)pUserData)->ConchainRconPasswordChangeGeneric(AUTHED_ADMIN, g_Config.m_SvRconPassword, pResult);
    pfnCallback(pResult, pCallbackUserData);
}

(edited)

the real question is why we have two .h files for variables

@plsplsplslol you can see that it still needs to call the original function manually

I don't remember, can we chain multiple times?

pfnCallback(pResult, pCallbackUserData)

16:03

@Learath2 yes AFAIK, it simply replaces the function, you're responsible for calling the original caller

// TODO: remove this
#include "././game/variables.h"

lol

yup @ multiple times

16:04

it's a single linked list

16:05

singly*?

There is much work to be done in the console btw, if anyone is interested, it's actually decently fun to work with that part of the code

it's a bit weird how it conflates parsing commands and the execution engine IMO

16:06

leads to our weird TempCommands thing

Hm I dont remember what TempCommands was

what kind of work

@Learath2 it's for registering the commands the srever sends in the console

16:07

instead of keeping it in a different data structure that both the execution engine and autocompleter use

Ah, I see what you mean

(not high-priority to fix though, the code works)

@noby well one thing that has been on my todo list for a decade is the validation

ah

validating what

the console pretending it validates arguments

16:09

and it does not

16:09

you specify yo uwant an integer argument

and u type in a letter and it just reads it as zero?

the console doesn't yell at you for providing a string

16:09

yes

yeah true

Also erroring out should be offloaded to the console code too

16:10

All our commands are littered with error checking and error printing

for things like bounds checking, u mean doing it like variables.h where a max and min are given in the definition?

Bounds checking would be tough, but if I were to do it I'd integrate it into the usage bracket

"i[value(0, 100)]" ?

16:14

idk how to make it look not ugly

Another thing rotting in my todo list that is semi related to validation is handling for victim to allow things like the teename to be used as victim

instead of the id?

Y

what if someone uses the playerid of another player as a name

If a string completely parses into a number, treat it as an id first

@noby raises an interesting point

No that sounds wrong, sorry walking and thinking

seems abusable

That sounds very wrong

If the string matches a name always use the name?

would probably be better to require making it clear

16:17

i.e.

when you name yourself "noby" you suck so people cant whisper you justatest

allow something like kick name=12 and kick id=12

ye

Or that yeah

and require it if it's ambiguous

or using quotes in ur name yes

Kick name=name=name

or using the name name=name=id

Quotes in the name we can just escape

or if its ambiguous then require confirmation "you are about to kick "23" (id 12), confirm? y/n"

kick name=noby=nobo

no u

16:20

requiring confirmation for bans/especially range bans might not be a bad idea in the first place

Or we can just keep ids, it was just an idea

ban_country murica

3

2

1

fv

Console is not interactive enough for confirmations, maybe that could be looked at

isnt it

currently it doesn't have state

You can hack around it by keeping state yourself and parsing all the arguments yourself

register y and n as commands xd

16:22

and then keeping the state in cserver or something yeah

or is that not the proper way to do it / would it be cleaner to add statefulness to the console itself

16:22

You probably want state in CPlayer tho

oh yeah right

Oh making the console aware of multiple users would be great too

currently it's just a "global" variable that gets set ^^

Currently we hack around the issue with a global yeah

which is a global variable

Or maybe a CConsole instance per user?

Thst would be cool

Idk, anyway, many things about the console are crude hacks

Its fun to spam status

3

2