Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2020-09-20 00:00:00Z and 2020-09-21 00:00:00Z
Avatar
a09be98 Revert "Revert "Implement on-demand skin downloader (fixes #1166)"" - def- 1d868fe Revert "Revert "Fix skin prefix search crash"" - def- 8ef6a0d Revert "Revert "Fix clang-format"" - def- 591dfb0 Revert "Revert "Remove non-free skins by Lappi (fixes #2547)"" - def- 61f8953 Clean up skin downloader code a bit - def- dfa0723 Fix skin lookup - def- 4e157c6 clang-format fix - def- c2f388a Merge #2882 - bors[bot]
00:42
a09be98 Revert "Revert "Implement on-demand skin downloader (fixes #1166)"" - def- 1d868fe Revert "Revert "Fix skin prefix search crash"" - def- 8ef6a0d Revert "Revert "Fix clang-format"" - def- 591dfb0 Revert "Revert "Remove non-free skins by Lappi (fixes #2547)"" - def- 61f8953 Clean up skin downloader code a bit - def- dfa0723 Fix skin lookup - def- 4e157c6 clang-format fix - def- c2f388a Merge #2882 - bors[bot]
Avatar
Revert revert revert
Avatar
revert all 11k ddnet commits
01:15
some day, when some ultra intelligent robots analyze the human race, they'll just think, why do humans do so many mistakes
01:16
and when they hear of "love" they explode.. too much computing required to understand
Avatar
[quakenet] ChillerDragon BOT 2020-09-20 01:48:45Z
love how you relate love to reverting commits
Avatar
@heinrich5991 dunno if u wrote the bridge, but it broke some day even harder https://discord.com/channels/252358080522747904/293493549758939136/755427759919988851
Avatar
@Soreu is there smth like a "commonly used abbreviations" for tw on the ddnet wiki
Avatar
is cl_mouse_max_distance relative to the screen width?
@[freenode] b3z#0000 back to this. Is it actually? Because mouse distance is quite weirde on widescreens?!
06:51
anyone know why there are so many players on the china server with names like this
06:51
is it some kindof new default name system
06:52
its not a flooding thing since ive seen alot of them actually playing
06:52
( @Learath2 @TsFreddie )
Avatar
ᶰ°Konͧsti 2020-09-20 07:06:35Z
Its their population number
troll 5
Avatar
[quakenet] ChillerDragon BOT 2020-09-20 07:17:47Z
@Jupstar thats the bridge https://github.com/42wim/matterbridge
bridge between mattermost, IRC, gitter, xmpp, slack, discord, telegram, rocketchat, steam, twitch, ssh-chat, zulip, whatsapp, keybase, matrix, microsoft teams, nextcloud and more with REST API (mat...
07:18
oh wait or are we talking about tw bridge? xd
Avatar
@louis idk, about wiki you'd have to ask @Ryozuki I guess
08:07
I have been on it once only to see how entities explain is ported
Avatar
no i dont run the current wiki
08:08
ask patiga or zwelf
Avatar
@deen you sure we want to remove the discord link? It's like the only hub we have. We could moderate it more strictly if you want
Avatar
Nah, it was a spontaneous idea yesterday. In the end it's not just my decision
Avatar
Well there is a bit of an undermoderation issue in the discord, so I kinda understand
Avatar
@noby QQ ids probably. It's an ICQ clone that is still popular in China
Avatar
ohh makes sense ty
Avatar
Have you experienced crashes on 60 players on ddnet?
08:32
In SixUp proto on cache clear
08:32
It's not affecting me now as my mod is not that popular, but I think that would be interesting for you at least
08:32
@Learath2
08:33
I've tried bots to make a load test today and it crashed immediately on 60th bot connect.
08:33
Though I haven't tried it with vanilla ddnet code yet but I haven't changed anything in Sixup protocol. (edited)
08:34
Not requesting any help with it atm, just curious if you have experienced something similar.
Avatar
ddnet has constantly servers with 63 ppl
08:35
maybe its related to the bot
Avatar
Maybe. I can test it with vanilla ddnet.
08:36
And bot is chillerbot's pentest headless ddnet client.
08:36
So it doesn't do anything unusual.
08:42
Cannot reproduce it on vanilla ddnet.
08:42
It seems that it's somehow related to that ddnet doesn't uses rounds/matches.
08:42
but I am not sure
08:43
ok, thanks
Avatar
is memory getting corrupted elsewhere and not causing the crash until then
Avatar
Maybe. But it's clear that I don't yet have expertise to investigate that. I will when it will be a problem in my mod.
08:47
Also it doesn't seems to be a problem for a DDRace too.
08:49
In my mod a round is restarted after first 10 seconds (warmup end). DDRace don't have warmups or round ends.
08:49
So it's not a problem for it.
Avatar
Anyway I HOPE it will be my problem... I mean dealing with 60+ players
09:44
bb2be60 Ask for confirmation before placing border tiles (fixes #2823) - Fireball-Teeworlds d4c1450 Merge #2883 - bors[bot]
Avatar
the github cli makes testing pull requests ez
10:02
gh pr checkout 2880
10:03
greenthing
Avatar
You can do that without the github cli thing btw
Avatar
i know
10:07
but its more bothersome
10:07
ref pull blabla
10:07
i can also review from the terminal
Avatar
I have fetch = +refs/pull/*/head:refs/remotes/ddnet/pr/* in my config
10:08
so it's just a git checkout ddnet/pr/2880
10:08
does it take lot of space
Avatar
Not that much more given ddnet/teeworlds are absolutely massive repositories 😄
Avatar
u can always clone from a certain point
10:09
and it wont take that much space
10:09
git clone --shallow-exclude=included-libs https://github.com/ddnet/ddnet
Avatar
a99b673 Some browser improvements - def- 5cc826d edit box: only highlight x when hovering it - def- 15292cd Merge #2880 - bors[bot]
Avatar
@Learath2 do u know a way to make submodules automatically update
10:10
when syncing
Avatar
I shallow clone when I'm building it on a server or sth
Avatar
i always do the following git fetch upstream git merge upstream/master git submodule update
Avatar
Nope, I usually do git fetch ddnet; git reset --hard ddnet/master; git submodule update
10:11
10:11
greenthing
10:11
super modern commands
Avatar
What does EXPORT_COMPILE_COMMANDS do?
Avatar
compile_commands.json
10:12
generates this
10:12
which u symlink to base dir
10:12
it allows vim to autocomplete
Avatar
Ah, helps coc
10:13
@Learath2 coc and any other c++ language server
10:13
youcompleteme etc
10:13
clangd
10:13
coc uses clangd
Avatar
I had a very heated discussion about IDEs a couple days ago
Avatar
im waiting so much for neovim 0.5
10:14
it adds native support for LSP
Avatar
It's really odd how far people can go trying to defend these proprietary, slow behemoths
Avatar
and tree sitter
Avatar
LSP is so nice to have
Avatar
An incremental parsing system for programming tools - tree-sitter/tree-sitter
10:15
Tree-sitter is a parser generator tool and an incremental parsing library. It can build a concrete syntax tree for a source file and efficiently update the syntax tree as the source file is edited.
10:15
this is rly important
10:15
most awaited feature of neovim
Avatar
@Learath2 merge my pr rooEZSip
Avatar
@Learath2 cuz rn most of the time u gotta save to update the syntax higlighter, specially if it highights with info from the LSP
10:16
aka semantic highlighting
10:16
Vim plugin for C/C++/ObjC semantic highlighting using cquery, ccls, or clangd - jackguo380/vim-lsp-cxx-highlight
10:16
greenthing
10:19
lemme try the bot
10:19
#2872
Avatar
add it to this sv pls
10:20
feelsbadman
Avatar
if u merge my pr
Avatar
ur pr is fine but it would make me look self interested now if u do it xd
10:21
if i*
Avatar
who cares how u look
Avatar
me myself and i
10:22
bluekitty
Avatar
i told my friend bors to merge it
10:23
ty boris
Avatar
boris lmao
10:23
bors should have this as picture
10:23
xD
10:26
#-1
Avatar
onby spammer monkalaugh
Avatar
its just a test
Avatar
f3bef49 mention rules - 12pm aa18dc1 remove for more info - 12pm 4cbcde0 Merge #2872 - bors[bot]
Avatar
there is no ready to use method to find the last word in the string if words separated by whitespaces ?
Avatar
str_next_token
10:37
the way to do it probs
10:38
str_in_list
Avatar
I dont see how str_in_list can help here
10:41
not sure about str_next_token, feels like it is better to write method I need from the scratch, i.e. some overhead while I still have to write some code around this method (edited)
Avatar
The last word would just be strrchr(pLine, ' ')
🆒 1
👍 1
Avatar
im glad i documented the split functions
11:10
otherwise i would have spent 10 more mins doing this shit
11:11
scrollbar on auto rule
Avatar
Nicely done
11:18
Do you also have auto width?
Avatar
i still have to figure out how to actually use the scroll value
Avatar
Did you not use a scroll region?
Avatar
the width for autorule names is 120
11:19
since ever
11:19
@Learath2 do u have an example usage in code
Avatar
Ah do we even have scroll regions in 0.6?
11:19
let me check
Avatar
i dont think so
Avatar
Yeah, we don't
11:21
Maybe we should take that. CScrollRegion is veeery easy to use
11:21
much cleaner than the manual scrolling we do
11:21
scroll code is a pain
11:21
xd
Avatar
Why almost every of my team message is doubled if my dummy is also in the team? ._.
11:49
11:50
regular chat is not affected, only team chat
11:50
and it's only if I write team message when in /pause
Avatar
yay i did it
11:53
thats a known bug
Avatar
I was quite sure it was fixed already
11:53
same as that weird random "(unknown) do you know someone who uses a bot?"
Avatar
( @Learath2 @TsFreddie )
@noby their QQ number
11:55
ppl use that
11:55
it is kinda stupid, but they do use that
Avatar
new ddnet client is shutdowning for 5 seconds is so annoying
Avatar
ye deen guessed it
11:55
wouldnt have thought
Avatar
@Soreu do u have a image with rules that exceed 5
11:57
aka with a shitload of automapper rules
Avatar
mind's mapres
Avatar
send pls
Avatar
wait, trying to find the files xd
Avatar
nvm ill just add myself more rules
12:00
there you have his crazy artwork
Avatar
!image It doesn't show a scrollbar when there aren't more than 5 rules.
12:02
@Learath2 review if u have some time thanks
12:03
oh rip style
12:04
oh
12:04
i have to apply fix styles before commiting? rip
12:05
oh
12:05
i know now
Avatar
Put the style commit separate tho
Avatar
./scripts/fix_style.py --base 2587328aa4b1b8e0e2afc39e8632a700a1a77ef8
12:06
rip
12:08
ok i get how it works now
12:08
@jao nobo why u comment i was fixing it already
Avatar
Starting DDNet with SDL_VIDEODRIVER=wayland ./DDNet worked perfectly fine until a07e9ac2cf5f4a1856a58749caf9f5afc85022d2. I've used git bisect to find this exact commit. ``` [2020-09-20 12:23:52][binds]: ... [2020-09-20 12:23:52][client]: starting... [2020-09-20 12:23:52][sdl]: SDL version 2.0.12 (compiled = 2.0.12) [2020-09-20 12:23:52][gfx]: out of ideas. failed to init graphics [2020-09-20 12:23:52][client]: couldn't init graphics [Thread 0x7ffff5fcb700 (LWP 29774) exited] [T...
Avatar
@Deleted User ^
Avatar
@Deleted User did you run a server inside client? that's the only change i can imagine causing that.
12:45
what system are you on?
Avatar
Why ping me. Not my fault Wayland or SDL is buggy xd
12:57
ah true
12:57
i wonder whats the status about sdl and wayland
Avatar
but you are the wizard
12:57
CLOSED NOTABUG
12:58
monkalaugh
Avatar
[quakenet] SnowFox BOT 2020-09-20 12:59:33Z
Hello world. I just reported #2885 and will be on here if anyone wants to discuss here instead of on git. https://github.com/ddnet/ddnet/issues/2885
Starting DDNet with SDL_VIDEODRIVER=wayland ./DDNet worked perfectly fine until a07e9ac. I've used git bisect to find this exact commit. [2020-09-20 12:23:52][binds]: ... [2020-09-20 12:23:...
12:59
GitHub*
Avatar
You can report it to sdl
Avatar
i dont get a segfault
13:01
instead it tells me this
13:01
[2020-09-20 15:01:21][gfx]: unable to init SDL video: wayland not available [2020-09-20 15:01:21][gfx]: out of ideas. failed to init graphics [2020-09-20 15:01:21][client]: couldn't init graphics
13:01
ah
13:01
i guess i dont have wayland installed
13:01
im dumb
13:02
actually i have it installed
13:02
so idk
13:02
10 extra/wayland 1.18.0-2 (130.2 KiB 751.8 KiB) (Installed)
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:02:48Z
Ryozuki: It might need you to use wayland? Maybe try https://swaywm.org ?
13:03
It is basically a rewrite of i3 for wayland.
13:03
At least you get the error if not the segfault.
13:03
Note I got both
Avatar
im on i3gaps rn
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:04:55Z
Then sway should feel right at home :)
Avatar
how is wayland support for 144hz?
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:05:17Z
Maybe run DDNet in gdb first?
Avatar
i remember it being locked to 60
13:05
i was running it in gdb
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:05:25Z
No idea.
13:05
Hm
Avatar
[ 09/20/2020 15:05:43.315 session_init FATAL ERROR ] Another composite manager is already running
13:06
kek
Avatar
did you run a server inside client? that's the only change i can imagine causing that.
what do you mean?
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:07:34Z
You may want to be careful with running sway if you don't have systemd or don't SUID it or have $XDG_RUNTIME_DIR set (as needed) but point to a non-existant directory. Fail these and it may lock up. ;)
13:07
I don't use systemd so had to SUID sway.
13:08
If you have systemd, then it should be fine.
13:09
Totally unrelated. THANK YOU FOR ADDING AUSTRALIAN SERVERS. <3
Avatar
ye i use systemd
13:10
the mouse controls look cool
13:10
but im rly lazy to change
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:12:37Z
lazy to change to test or to perma switch?
Avatar
test and switch i guess
13:13
i would need to configure lot of stuff
13:13
also does polybar work with it out of the box?
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:13:17Z
At least to test you'd only need to start sway from the tty
13:13
I don't use polybar
13:13
I haven't used i3 but my understanding is that sway will adopt your i3 config directly.
Avatar
i dont know why, but laser cant be rendered
13:27
only if the dot where it ends or bounces in necessary distance
Avatar
@snowfox, you can try valgrind and see if smth inside our code breaks, else its probs related to wayland or sdl
13:30
oh and @snowfox, u can edit the ddnet_settings,cfg config and add gfx_opengl_major 2 gfx_opengl_minor 1 that defaults to the SDLs default
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:33:04Z
Jupstar: The configs changes didn't fix it, downloading+building valgrind now.
Avatar
are u on gentoo?
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:34:37Z
Source based Linux distribution with deterministic package management and decentralized workflow.
13:36
Avatar
cant access http sites xd
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:37:40Z
Eh?
Avatar
i have strict https rule
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:38:01Z
Easy to make an exemption
Avatar
i prefer not to
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:38:23Z
Fair. Curious, Tor Browser?
Avatar
nope
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:38:50Z
You can curl it, just a raw paste.
13:38
Otherwise I can gist it
Avatar
ty
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:41:07Z
BTW: I first read the "cant access http sites xd" as if I copied ddnet failing to reach the map download servers because my network settings block all network by default. I use groups to route my traffic over tor or clear and forbid LAN access. Had to double check my log before you elaborated. :P
Avatar
only interesting could be the conditional jump the rest looks like deep inside SDL
13:42
wow thats alot of work, generally cool, but tor is too slow for me xd
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:43:57Z
Can stream 1080p videos from YouTube. If I use aria2c it averages at 1MiB but can do over 10MiB/s. Latency really isn't that bad, especially these days.
13:44
And not a lot of work at all. A small shell script to generate the iptables rules.
Avatar
well u can try starting valgrind with --trace-children=yes --track-origins=yes to get the line number of the conditional jump (i hope that these were the commands :D)
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:46:11Z
refresh for the update
13:46
GitHub is where people build software. More than 50 million people use GitHub to discover, fork, and contribute to over 100 million projects.
13:46
Very unhelpful diff with pids on every line :P
Avatar
strange that it doesnt display the line numbers xd
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:48:14Z
heh, whoops
13:49
reload for debug build
13:49
Not sure that changed anything
13:50
yes it did
Avatar
are u at the first commit after the fail?
13:50
or current source
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:50:20Z
yes
Avatar
ok
13:51
well i think i'd have catched any conditional jump with the current source, so very likely a wayland bug :/ strange that GL 2.1 didnt fix it
13:52
ah wait
13:52
libwayland uses EGL?
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:52:32Z
I believe so
Avatar
that explains alot xD
13:52
well you can try setting major to 1 for now, the opengl shaders aren't ready for EGL yet
13:53
also GLEW isnt supported in EGL i think
13:53
there is actually alot of issues with EGL
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:54:11Z
[2020-09-20 13:53:57][sdl]: SDL version 2.0.12 (compiled = 2.0.12)
13:54
[2020-09-20 13:53:57][gfx]: Created OpenGL 1.1 context.
13:54
[2020-09-20 13:53:57][gfx]: out of ideas. failed to init graphics
13:54
[2020-09-20 13:53:57][client]: couldn't init graphics
Avatar
yeah maybe bcs it still tries to call opengl functions in glew
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:54:35Z
still segfaults
Avatar
i think that won't work, does wayland provide a opengl backend=
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:55:01Z
No idea
Avatar
sadly EGL is also stricter with NPOT textures and stuff like that, so its not an easy change, best bet would be to force the OpenGL context somehow, or write a small patch for EGL
Avatar
Why is wayland a thing even?
Avatar
[quakenet] SnowFox BOT 2020-09-20 13:59:17Z
Learath2: Many great reasons including security, performance, and simplicity.
Avatar
I guess it is more secure if nothing works with it, it is more performant if you can't run anything and it is indeed simpler if you are not compatible with anything
Avatar
[quakenet] SnowFox BOT 2020-09-20 14:00:40Z
I've had many more issues with X than wayland...
Avatar
Why does Wayland use EGL? EGL is the only GL binding API that lets us avoid dependencies on existing window systems, in particular X. GLX obviously pulls in X dependencies and only lets us set up GL on X drawables. The alternative is to write a Wayland specific GL binding API, say, WaylandGL.
Avatar
Isn't there a glew shim somewhere that makes wayland compatible?
Avatar
i can understand their point, but EGL wasnt built for embedded systems for a reason xD
14:01
most stuff is compatible tho, its really just the initialization that needs a fix
14:01
and maybe default to opengl es 3.0
Avatar
Ah, freedesktop.org, not surprised they are the ones peddling this
Avatar
[quakenet] SnowFox BOT 2020-09-20 14:03:59Z
On the prior version btw;
14:04
[2020-09-20 14:03:42][sdl]: SDL version 2.0.12 (compiled = 2.0.12)
14:04
[2020-09-20 14:03:42][gfx]: Created OpenGL 3.0 context.
14:04
4.0 works too
Avatar
[quakenet] SnowFox BOT 2020-09-20 14:04:47Z
It is something in this commit
Avatar
Did you find the exact commit that breaks it?
Avatar
yeah probs bcs before that i didnt call glew
14:10
glew is an arugment against opengl
14:11
EGL garantuees u that the function exists.. opengl requires loading them
14:11
(atleast on most systems)
Avatar
[quakenet] SnowFox BOT 2020-09-20 14:11:49Z
So.. a simple fix?
Avatar
well not really easy, but u can try removing the glew code and default to opengl 1
14:12
i'd need to add EGL support at compile time already
Avatar
[quakenet] SnowFox BOT 2020-09-20 14:13:32Z
I don't know what to change there and should really just be sleeping. Is there anything you'd like me to check before I call the night? If you can give me instructions to try in the morning, I'll try them.
Avatar
i just post it on the github issue, gn
Avatar
[quakenet] SnowFox BOT 2020-09-20 14:14:14Z
Okay, thanks Jupstar!
Avatar
Do I port the huffman code to C or do I write a C interface for the huffman class?
Avatar
@Ryozuki should probably render repeated a different way
Avatar
i guess
Avatar
I thought it was the client id looking at your screenshot
Avatar
i dont have time rn so throw ur best ideas there
15:29
i gtg outside
15:29
to the real world
15:29
xd
Avatar
there is something outside?
Avatar
just meeting some friends
15:29
xd
Avatar
something like this on the left maybe?
15:30
friends?
Avatar
ye i wanted it on the left
15:30
but the rendering made me kys
15:30
kym
15:30
*
Avatar
Yep, rendering anything there is cancer, I learned there in the heart PR
15:31
you mean kms
Avatar
yeah that
15:31
xd
Avatar
hey, stolen pic
15:47
Pls don't report me to the authorities
Avatar
vanilla did it by passing a textcursor, and just render in the cursor so the player name naturally follows
15:48
although, I nuked that code in my rework since textcursor doesn't work like that anymore doggo_lol
Avatar
noooo, I was sooo close
15:53
The huffman decompression broke when I copied it over 😦
Avatar
do you have the initialization?
Avatar
Yeah, I think I added an extra & somewhere
15:54
I'll look it over again
Avatar
how do you save to another server again? (edited)
Avatar
in libtw2, I used the official files and gave them a C API
Avatar
@NeXus you don't need to anymore, all saves can be loaded everywhere
Avatar
sec
Avatar
@heinrich5991 I was thinking of doing that, then I thought I'd be clever and steal it from 0.5
Avatar
0.5 is C++, no?
15:55
Some Teeworlds stuff in Rust. Contribute to heinrich5991/libtw2 development by creating an account on GitHub.
15:55
for reference, if you need it
Avatar
0.5 still has it's engine in C, oddly
Avatar
huh?
15:55
interesting
Avatar
@heinrich5991 how does huffman::decompress handle the bolted on token at the end?
15:57
is the token compressed along with everything?
Avatar
yes, and it's madness
15:57
We really should redesign this mess
Avatar
idk who keeps coming up with these
15:57
token should just have been added to the header ^^
Avatar
Hm, it was either you or east who added the ddnet token protocol
Avatar
not me
Avatar
Where would you add the token in the header? we have like 2 bits + 3 bytes lying around, that's about it
Avatar
I'd make the header larger
15:58
we need to know whether the token is there either way
Avatar
Wouldn't that break vanilla compat?
Avatar
also with this position
15:59
no
15:59
we can't send the token to vanilla servers/clients this way either
Avatar
@mind old vs new
15:59
f3 1
Avatar
so we already know whom to send these to
Avatar
Oh, TKEN is already broken for vanilla
Avatar
so only use this header for ddnet clients/servers (like we do now with the weird position)
Avatar
Now I'm curious who came up with it, git blame time
16:01
eeeee 😄
Avatar
I mean it worked, and that was better than all other proposals 😉
Avatar
I wonder why he did it this way though
16:01
I guess easier to implement?
Avatar
originally we sent the token to all clients
16:02
but that was broken
16:02
so easier to implement I guess
Avatar
@Deleted User is dilate even needed with the new renderer?
Avatar
I think it's still needed, given it's a blending issue dilate fixes and we didn't change the blending
Avatar
0.7 doesn't need it
Avatar
Sure?
Avatar
Cuz 0.7 uses 3d textures
Avatar
What's with the very odd shape for the circles btw? A circle seen from an angle should be a perfect ellipse
Avatar
Or smth like that
Avatar
Well I wouldn't know if 3d textures blend alpha differently
Avatar
0.7 renderer is better in several ways
Avatar
Jupstar knows i guess
Avatar
Ah I guess someone did say 0.7 uses premultiplied alpha, so the effect would be muuuuuch much less noticable
16:07
@Ravie is it? I thought we caught up most of the way with the latest renderer
16:07
We just used texture arrays instead of the 3d texture hack 0.7 went with
Avatar
0.7 uses pre calculated alphas
16:07
we already had this discussion xD
16:08
oreo explained in great detail what it is xD
Avatar
And I remembered said discussion and already stated this fact when I remembered said discussion
Avatar
I was messing around with some seamless textures recently and noticed the ddnet renderer makes little cuts between tiles, while 0.7 doesn't
Avatar
I even pointed out the fact that my rememberence was oddly sudden, with an "Ah"
16:08
Thought it was pretty clear
Avatar
@Ravie "Ravieheute um 18:06 Uhr 0.7 renderer is better in several ways" tell me more
Avatar
Already did ^^
Avatar
well it looks better and doesn't need dilate, that's it
Avatar
it doesnt do mipmaps
16:10
u just like crisp textures for some reason
Avatar
well who would like blurry textures?
Avatar
who likes wrongly displayed linear interpolated textures?
Avatar
maybe 0.7 looks just a little too sharp but it looks the closest to what I see in inkscape
Avatar
ᶰ°Konͧsti 2020-09-20 16:10:46Z
We need more switchable tiles for switch layer
16:10
So as unfreeze, teles, switches itself etc
Avatar
@Deleted User can't we bias the lod choice a bit depending on the zoom level?
Avatar
we could adapt pre calculated alpha values, but that requires modification of the texture on runtime
16:11
so for 1024 * 1024 its aroujnd 4mb of image processing
16:12
@Learath2 we can do alot of things. in 3.3 i can do almost anything xd if the drivers would just work fine on this world
Avatar
I don't think we need to bother with premultiplying, dilate works just fine
Avatar
@Deleted User sorry for off-topic, but does ddnet render high detail skins? like 2048x1024?
Avatar
ah btw @Deleted User I noticed when zooming, the new renderer has much worse performance and looks worse than your old algorithm lol
Avatar
@Deleted User well within which context can't we bias? just broken 3.3 drivers? what happens if you try?
Avatar
@gerdoe probably yes, but might create artifacts
Avatar
okey, will test
Avatar
@Ravie then u forgot to enable 3.3
16:14
@Learath2 i think it already works in 2.1, but only if the driver works well
16:14
i remember someone wiith NVIDIA card had problems with broken mipmaps one day here
16:14
and he had onen of the newest NVIDIA cards
16:15
it was a broken modern driver
16:15
so i dont want to imagine old ones xD
16:15
nvidia just tries to cheat too much with mipmapping
Avatar
oh it's actually fine with the blurry shader but terrible with the sharp one
16:16
but the old renderer did everything well xD
Avatar
its bcs gl 3.0 and lower dont support instanced rendering
Avatar
I have 3.3 enabled tho
Avatar
i could enable it with extension, and might also do it, but currently i am happy we dont have problems with the new renderer xd
Avatar
did you have 3.3 enabled before the upgrade? I don't think 3.3 changed that much
Avatar
@Ravie strange, then ur pc is struggling or smth
16:17
yes it only changed a bit visually(but for FULL HD too much sadly, bcs less "sharp" textures)
16:18
all renderers(except 1.x) use 3d texture or texture arrays now
16:18
thats the whole magic
16:18
i have in fact a bit more fps with the new renderer, probably bcs we have less opengl shader state changes now
16:18
bcs we dont calc mipmap our own and dont need to care about texture coordinates
Avatar
well the new renderer either looks blurry on default zoom or terribly pixellated when zooming if you "fix" it
Avatar
It should never look blurry on default zoom imho
Avatar
no
16:21
then smth is wrong in ur setting
16:21
zooming lookks SOOOO MUCH better now
16:21
in 3.3
16:22
16:22
open in new tab
16:22
its so perfect even when zooming out far
Avatar
also looks blurry
Avatar
it has great detail, less loss like with linear interpolating
16:24
ok bad map to show this
16:25
and yes its bit blurrier
Avatar
apparently the bugged skins affected also me
Avatar
well the old 3.3 looked perfect both in default and zoom, performance was good too
Avatar
#2452
Avatar
Client Version: 14.0.1 Person said, he hasn't deleted any files in data Appeared mid-gameplay He had screensharing activated in discord I guess? Screenshot: (Thanks for uploading ekidoxx)
Avatar
after doing the shader fix to make it not blurry, zoom looks like this
Avatar
i know, bcs it doesnt calc any mipmap anymore
16:26
so it will get to a point where it just samples the images zoomed
16:27
you have to change the param of textureLOD(..., 1) to 1
16:27
or higher
16:27
@Ravie in your driver there must be an option like "Rendering perforamnce vs image quality"
16:28
anyway, if someone wants to implement the old mipmap calc, i have no problem with it, i just dont want todo it rn
16:29
but default it to off
16:29
@Soreu u still have the broken client open?
16:32
@Ravie u had nvidia?
Avatar
nah it's just an integrated
Avatar
mh ok
16:33
in nvidia drivers u can apply a load bias
16:33
maybe that works for intel too, or amd
Avatar
yes @Deleted User
16:37
how can I help you with it
Avatar
is it only for downloaded skins @Soreu ?
Avatar
nope, I have had those two since long time
16:38
one of them is the one I'm currently usng
Avatar
ah @Ravie opengl has a function for that
Avatar
PsychoGod & PsychoWolfe are "shown" on the screenshot
Avatar
i'll just implement it, and u need to test if it works 😄
16:39
@Soreu ok, but the wolf is working everwhere else?
16:39
only in the selection not
16:41
removed search string, and typed it back again, and no visual bugs anymore
16:41
.-.
Avatar
ok, but doesnt sound like a huge bug
16:44
like #2452 .. would really like to know if he had that problem again
Avatar
Client Version: 14.0.1 Person said, he hasn't deleted any files in data Appeared mid-gameplay He had screensharing activated in discord I guess? Screenshot: (Thanks for uploading ekidoxx)
Avatar
45454cb Update brazilian_portuguese.txt - rffontenelle b3307dc Merge #2886 - bors[bot]
Avatar
@Soreu wanna create an issue, maybe deen wants to fix it tell him its rare bug when using the skin selection
Avatar
hello, please back thing in new ddnet 15.0 leave from the game ctrl+shift+q (edited)
Avatar
@Ravie
17:02
Avatar
the second one looks good
Avatar
yes
17:03
u can now do it as u want
Avatar
[quakenet] ChillerDragon BOT 2020-09-20 17:26:01Z
does someone use or know what whatsapp business is? And why i got a code for that even tho i have no whatsapp installed?
Avatar
someone uses your phone number for spamming ig
Avatar
[quakenet] ChillerDragon BOT 2020-09-20 17:28:12Z
ah so i guess everyone can apply for that and enter any number hm
Avatar
Rafael Fontenelle 2020-09-20 17:32:49Z
Should "run server" button (in the client) be working? For me it is saying server executable was not found, but I have /usr/bin/DDNet-Server installed.
Avatar
For Ravie, and others that want the old renderer opengl 3.3 feeling back xd
Avatar
@Ravie u can then try the artifacts, when its built ^
17:37
gfx_opengl_texture_lod_bias -1000 would be one mipmap level higher
Avatar
and use the default shaders ravie, not the modified ones
Avatar
looks good
18:03
with -1000 there was still some distortion at some zoom levels but setting it at -100 somehow made everything look perfect
Avatar
strange, -1100 would have made more sense, but ok xd
Avatar
well no -100 probs makes sense
18:45
the driver is only off a bit not alot
Avatar
@Rem1x bind ctrl+shift+q quit in f1
Avatar
In the main menu, "Run server" button, won't start server instance, even though it is installed in /usr/bin/DDNet-Server. Environment: Arch Linux 64, [ddnet] 15.0.4 (AUR) [ddnet]: https://aur.archlinux.org/packages/ddnet/
Avatar
@deen i think we have quite some feature prs now, you mentioned about agreeing with making RC, when do u think the first one should come?
Avatar
Definitely not before they are merged 😄
Avatar
maybe in about a month, people are tired of having this many new versions
18:55
im trying to test every pr that comes anyway
18:55
well atleast the ones i can test
Avatar
the ddnet logo is 1024*293 XD worst image dimensions ever
Avatar
ᶰ°Konͧsti 2020-09-20 19:04:06Z
wtf
19:04
i cant even set that resolution
Avatar
doesnt the logo get stretched in the menu
19:08
justatest
Avatar
lol its not monitor resolution
Avatar
[quakenet] SnowFox BOT 2020-09-20 20:21:17Z
Morning
Avatar
@gerdoe did it work btw?
Avatar
@Deleted User what's wrong with the dimensions?
Avatar
its not directly wrong, its just a strange number
21:04
293
Avatar
just made the width round and assumed height doesn't matter
21:08
dimensions are the same as on website logo
Avatar
@Deleted User will we get your rounded-edge-removal change btw? I liked the look
Avatar
@deen yes, but we need to consider a few things.. e.g. ingame items should still be a bit round, too much edges looks weird too
21:23
in menu is looks better tho
Avatar
Should we have a vote on that on Discord first?
21:23
before you spend too much effort and maybe others don't like it
Avatar
People I'm a bit retarded or smth, help me find main server game cycle please
Avatar
while(m_RunServer < STOPPING) in server.cpp?
Avatar
OOf
21:25
thanks
21:25
I read this line like 3 times
21:25
@deen yeah, i just make 2 screenshots, and u say something like, do you "generally" like too have less edges or smth
Avatar
People I'm a bit retarded or smth
I noticed last night 😄
Avatar
@deen are the skins downloaded from a different database than the one we're cleaning up?
21:26
@Ravie but they might be cached by cloudflare, I can clear the cache
21:26
preferrably once when you're done with cleaning up
Avatar
I noticed last night 😄
@deen At nights I'm starting doing weird shit but don't go to sleep untill I get black outed
21:26
oh btw @deen before i forgot: https://discord.com/channels/252358080522747904/293493549758939136/757276232684667060 its only in the skin selection tho.. not ingame, nowhere else
Avatar
there's no problem I was just curious why one skin that I deleted keeps getting downloaded in game
Avatar
cloudflare has pretty agressive caching for graphics I think
21:27
and I don't want to lower it since most skins won't change I guess
Avatar
few weeks ago I literally send my dickpick to few random people on discord
Avatar
@Deleted User ok, interesting that that still happens. Yesterday I also figured that the fix we found wouldn't fix this problem
21:28
@Deleted User did you guys find out what might be causing it?
21:28
@Deleted User yeah, don't do that in the future please or you're not welcome here
Avatar
@deen havent looked into it, did other stuff today 😄
21:29
just made sure its just the selection
21:29
not anywhere else
21:30
Do you use cloudflare for CDN only?
Avatar
@Soreu could you send me your settings_ddnet.cfg privately? Want to make sure it's not just caused by config
21:30
yes, and works surprisingly well
Avatar
How much payment they do require
Avatar
nothing, it's for free
Avatar
Free CDN, epic
Avatar
if u quickly want to test the not round things @deen i have a branch hack_no_roundings
Avatar
I saw that branch, that's why I'm asking 🙂
Avatar
@murpi thx for your map as background, looks really good 😄
👍 2
21:42
that looks so cool. Are the stars not too bright when there's text?
Avatar
yeah but its also a map he uses ingame
21:43
i just made it a theme for testing
21:43
and actually like it 😄
21:43
somtimes a planet flies by, really nice 😄
Avatar
@murpi nice map
Avatar
This is Pulsars background :D
21:50
and map
Avatar
ok then credit to him 😄
Avatar
It's from his map called Orion, really pretty indeed
Avatar
@Deleted User i think ingame it looks fine without rounded edges too
Avatar
mh ok, i think it's mixed.. scoreboard looks bit strange when its so edgy, but im also just used to it
Avatar
the button shadows are basically invisible tho
Avatar
maybe we need less transparency for the dark maps anyway
21:53
jungle night is also very dark
Avatar
i was so confused "omg murpi made a map?" then i looked it up and didn't find it
Avatar
murpi ghostmapper
Avatar
Its hard to clean up the map folder (I have a lot of "testmap", "partIdea#136", etc) or find a map without their name. Loading each map taking a lot of time... Can we show a map preview - picture of the map ? Most likely will need setting to turn this feature off.
Avatar
@BannZay i really like that idea, also thought about this(not for editor tho)
21:57
now that i cleaned up the map stuff, we can actually display many maps anywhere
👍 2
Avatar
btw @Deleted User are you planning to update the editor rendering as well?
Avatar
im a sheep
🐑 4
Avatar
@Ravie maybe some day xd
21:59
but i'd just adapt 0.7's rendering
Avatar
it can be a little annoying to have to actually host a map to see how it "really" looks
Avatar
yes i know
Avatar
@Learath2 Could you check if this can be extended to also find the DDNet-Server executable on Mac?
Avatar
@Soreu another victim
Avatar
u have to ping deen, looks like some other buffer overflow @deen
Avatar
well this is still the unofficial release
Avatar
the one from my pr?
Avatar
yeah but I guess this bug is in the official as well
Avatar
@Ravie got a settings_ddnet.cfg?
Avatar
yes
Avatar
I'll pm u @deen
Avatar
and does it happen all the time or just randomly?
Avatar
nah just this time
22:22
but soreu had this bug before so I guess it's not that rare
Avatar
the only suspicious thing I see is that skin prefix is activated. @Soreu you have it on too?
Avatar
he had it off i think
22:34
22:34
no prefix rendered atleast
Avatar
his skin names disappeared, mine were replaced with gibberish
Avatar
yeah almost looks like a static localize again xD
Avatar
I'm wondering if the PNG might be loaded in an unexpected format? We write into Info.m_pData (skins.cpp) before checking the image format
22:36
But I just tried loading all skins from skin db locally, and valgrind is not complaining
Avatar
well libpng warned about some broken/old chunks, i dunno if pnglite can fail with it, but this isnt the problem here anyway
22:37
his skin top left should be in the selection too
22:37
Psychowolfe
Avatar
Hm, so you guess it's rather a bug in the skin menu, not the skins themselves
22:38
Oh, I see some static s_paSkinList
22:38
because skins used to be static, but now they are not anymore...
22:38
when we download more get added
Avatar
there are quite a few people with custom skins on the server, could it be caused by something like one skin having a different bit depth or so? (edited)
Avatar
@Ravie @Soreu if the problem happens again, it probably disappears after toggling "Vanilla skins only" twice
Avatar
I think it disappears after doing anything that refreshes the skin list
Avatar
ok, that confirms my suspicion
Avatar
I also had this weird bug, I guess I reported first
Avatar
easy to fix, great that we found it
Avatar
static (some regular expression to find localize) ;
22:42
or was it the last xd
Avatar
nono, it wasn't localize
Avatar
oh ok
Avatar
@Deleted User but before fixing it I still want to understand it better
Avatar
sure
Avatar
s_paSkinList is static which is wrong there, but why do we access outside of it?
Avatar
btw a neat trick I found, not sure if this is intended: you can grab any skin from the database by using player_skin in f1
Avatar
i know, seems ok to me
22:49
I use that all the time for testing 😄
Avatar
maybe it could be made into an actual feature so people don't have to download from the database and manually move the file
Avatar
would need to be a bit more fancy to get a list of all available skins
Avatar
I mean it's enough to look at it in the browser I guess
22:50
it's just faster to grab it ingame
Avatar
a text field wouldn't be hard, yeah
Avatar
perhaps a link to the database
Avatar
Ha, I got the bug
22:51
locally, with valgrind running
22:51
Avatar
funny how only one got a custom color
Avatar
ah
22:55
yeah
22:56
What is valgrind?
22:56
the most useful tool for memory debugging
Avatar
@Deleted User you understand the issue?
Avatar
mhh not 100%
Avatar
@Deleted User something you can use for finding undefined behavior in C
Avatar
I don't understand why LoadSkin is freeing m_pData, seemingly always
22:57
and yet we mostly access it fine
22:58
but I'm not so familiar with the graphics stuff
22:58
Will check again tomorrow morning, good night
Avatar
Stale pointer to an array that grew?
Avatar
good idea actually
22:59
yes
22:59
+1 for @Learath2
23:00
@deen the static init uses the pointer of CSkin
23:00
which is later increased by downloaded skins
23:00
the cskin array is the dynamic list
Exported 708 message(s)