Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2020-09-07 00:00:00Z and 2020-09-08 00:00:00Z
Avatar
Description says "Turns testing commands aka cheats on/off" But handler does not change its state. Update either description or behavior.
Avatar
[freenode] b3z BOT 2020-09-07 01:22:54Z
is there acually someone working on a skinfetcher?
Avatar
And discord presences?
Avatar
Seems to work on first try, I'm somewhat surprised :D Future ideas: I haven't checked how the performance impact is of a new skin joining, might want to move the loading to a separ...
Avatar
by ordering names in binary collation, consistent with C++ std::sort Required since the official DDNet DB uses utf8mb4_general_ci default collation
Avatar
Does anyone have a friend working in google or sth? Their stupid geolocation is so convinced that my very german ip is in fact an ip in the united arab emirates and support doesn't even understand the concept of ip
Avatar
Im not sure if this has been reported before but there is a bug with the website
08:16
When you look at the last finishes for novice,moderate,brutal or the other types it shows the last finishes for every server type and not that specific one you clicked on
Avatar
^ True lol
08:19
It shows the same ranks but without server type prefixes
Avatar
oops, my bad
Avatar
45457b6 Bundle FFmpeg for everything - def- b45f3c8 Merge #2749 - bors[bot]
09:30
e7c701d Try bundling more ffmpeg - def- 2ae1357 Merge pull request #12 from ddnet/pr-ffmpeg2 - def-
10:10
d492d6d Fix duplicate teamranks (fixes #2405) - def- f1145fb Update ddnet-libs - def-
10:14
a2b5d63 Fix duplicate teamranks (fixes #2405) - def- 31776c4 Merge pull request #2774 from def-/pr-collation - def-
Avatar
28cd437 Document which commands only work in initial config (fixes #2773) - def- b1c808d Merge #2775 - bors[bot]
Avatar
@deen what the point of cheating by admin using "sv_test_cmds" if he can easily modify database, modify binaries and so on. Additionaly why would not just save the flag, add to logs data about using this command
10:45
I dont understand the reason to disable this command completely 😦 (edited)
Avatar
@BannZay this was introduced in a time where admin cheating was common
10:46
it helped with that
Avatar
but we have rights system nowadays "mods, helper"
Avatar
had that back then as well
Avatar
so deen was cheating and you introduced it LMAO
Avatar
it helps in the case "ah, we failed. well, might as well enable sv_test_cmds"
10:47
there are more servers than just ddnet's official servers
10:47
in fact, that setting is older than ddnet itself, I think
Avatar
so we need kinda "super admin" ?
10:48
I dont understand, I need full control over my own app
Avatar
you have it
10:48
just restart the server
10:48
or fork ddnet if you absolutely have to
Avatar
this is ridiculous
Avatar
okay
10:48
I told you what it helped with, why is it still ridiculous?
Avatar
it is ridiculous that we preventing admins from cheating in the middle of the race
10:49
but if he restarted the server - go ahead
10:49
do cheat
10:49
what the point?
Avatar
I told you the point above
10:49
we achieved a clearer distinction of servers where people use cheats and where people don't use them
10:49
we didn't have that before
Avatar
so to be able to cheat admin should use /save then restart and the load?
Avatar
ᶰ°Konͧsti 2020-09-07 10:50:31Z
its good that there is no way to abuse cheat commands in a run
Avatar
if you so desire, yes, you can do that
Avatar
cool anticheat
Avatar
why do you think it's an anticheat?
10:51
I told you five lines above what problem it helped with
10:51
it's NOT to prevent admins from cheating
10:51
[12:49 PM] heinrich5991: we achieved a clearer distinction of servers where people use cheats and where people don't use them
10:52
please argue against that point, and not some made up one
Avatar
but wait, to cheat you had to have acess to rcon
Avatar
yes
Avatar
so if you admin why you should not be able to control this setting?
Avatar
[12:51 PM] heinrich5991: [12:49 PM] heinrich5991: we achieved a clearer distinction of servers where people use cheats and where people don't use them
Avatar
in the middle of the game
10:53
by people you mean admins?
Avatar
yes
10:53
btu that doesn't really matter to the users
Avatar
ᶰ°Konͧsti 2020-09-07 10:53:37Z
because it would encourage "hmm this fail was so unfair ill help in this case but oooonly in this"
Avatar
yes, what konsti says
10:53
it creates some friction
Avatar
i also cant think of a good reason not to add it
10:54
prevents u from accidentally pressing ur rcon up bind as well
nobyisthebiggesttroll 3
Avatar
ᶰ°Konͧsti 2020-09-07 10:54:20Z
like u on fng
Avatar
I mean let it be
Avatar
no proof
nobyisthebiggesttroll 3
Avatar
I was talking about a possibility to change this setting without a need to restart the server
mmm 4
wtf 3
facepalm 1
f4 1
Avatar
then it would be useless, lol
Avatar
ᶰ°Konͧsti 2020-09-07 10:55:08Z
lmao
Avatar
definitly not
zoozer 1
10:55
just fork and do it on ur server
Avatar
if it is ur server then u can just leave test commands enabled always
Avatar
ᶰ°Konͧsti 2020-09-07 10:56:23Z
noby is a big tester too
Avatar
tbh i have test commands enabled on fng
Avatar
definitly not allow changing it mid game*
Avatar
ᶰ°Konͧsti 2020-09-07 10:56:38Z
I KNOW
Avatar
@Ryozuki why?
Avatar
ᶰ°Konͧsti 2020-09-07 10:56:49Z
u choted urself in wall to troll me
Avatar
why should u need to
Avatar
it was explained by heinrich and konsti perfectly
Avatar
@Ryozuki just dont give admin pw to untrusted persons
Avatar
its open source so if u want it and we dont want to add it you can fork
10:57
and do it
Avatar
this is not about untrusted persons @BannZay
10:57
it's about every admin
Avatar
why do u need ddnet to add it? u are not admin
10:57
u wouldnt care less
10:57
add it for ur own fork
Avatar
ᶰ°Konͧsti 2020-09-07 10:58:13Z
if an admin is untrustworthy he dont need test commands, he can just insert ranks in the database
Avatar
indeed
Avatar
it's about the friction it creates
Avatar
@BannZay sometimes I feel really bad if I watch a team fail. So I removed the possibility for me to just help them quickly after they failed at 3 am while no one is watching
👍 5
Avatar
ᶰ°Konͧsti 2020-09-07 10:59:01Z
Thats what i thought at
Avatar
omg deen is untrusted admin pls remove
nobyisthebiggesttroll 3
nouis 4
Avatar
ᶰ°Konͧsti 2020-09-07 10:59:12Z
u dont know Where is the border to help
Avatar
Of course I can work around it and cheat with the DB, edit the memory directly to allow cheats, etc. But that's harder and then I think about if I actually should do that
Avatar
but yes exactly this
Avatar
u feel more guilty editing the database xdd
troll 3
10:59
eh konsti
10:59
troll
Avatar
ᶰ°Konͧsti 2020-09-07 11:00:01Z
not if u let others do it
Avatar
isnt this the same guy who tried to submit a pull request to add cheating features to ddnet client
11:01
obvious troll
Avatar
I dont know, it makes some sense but to me its like "hello bank service, could you please take out my rights to use my money because when I walk across the street I want to help to poor people but I should not do this"
11:06
I feel like admin should have full control
Avatar
in a bank, the people at the top do not have full control either
11:07
in fact, in security systems, they usually don't
👍 4
Avatar
admin rcon already doesnt give full control, since it doesnt allow u to modify the files on the server or make hardly any persistent changes to the config
Avatar
i think you can change gravity?
11:10
with admin rcon
Avatar
that sounds right that tune isnt counted as a test command for some reason
Avatar
[freenode] b3z BOT 2020-09-07 11:15:25Z
yes but tune isn't a test command in my opinion.
11:17
/join #politics
11:17
lul since when is this escaped :$
Avatar
how isnt it
Avatar
If there are default tunes, why would you change them while racing?
Avatar
Because some maps have different default tunes set
11:29
and we would break those maps if we disable it
Avatar
do the map settings have the same permission level as admin
Avatar
would it be abusable if they had higher permissions so tune could be a test command
Avatar
you mean so that map can turn on cheats? 😄
Avatar
i guess so lol
12:06
but doesnt someone look at the map settings before any map is released
Avatar
they might forget
12:06
we have a whitelist of allowed commands for maps
Avatar
could tune be added
12:06
or not without enabling cheats
Avatar
I think it wouldn't work if you add it but remove it for admin
12:07
the way we overwrite those for admin is by binding a new function that only returns the value, but can't set
Avatar
hmm i see
Avatar
I find the econ console quite ugly after implementing most of it. Not sure we should even have it. I put it here in case someone wants to fix it up. Currently can't even connect, not sure why.
Avatar
I think it wouldn't work if you add it but remove it for admin
@deen seems like CFGFLAG_GAME | CFGFLAG_CMDFLAG_TEST stands exactly for this case
Avatar
I don't think that would work right now
13:45
needs some implemenmtation
Avatar
as well I suggest to introduce CFGFLAG_READONLY to avoid doing "binding a new function that only returns the value"
Avatar
and we would break those maps if we disable it
@deen just disable modification by client side if cheats are not enabled?
Avatar
@m!ki @BannZay sure, please refactor the code for that and make sure everything keeps working
Avatar
@Deleted User so far no complaints about graphics bugs in 14.6.2. Good job 👍
Avatar
@deen ur econ pr has commits from ur other prs too xD
14:36
14:38
or is it intended
Avatar
Yeah, it depends on them
14:40
didn't want to rip it out cleanly
14:40
But if you want to work on it and get it fixed, I can later extract it
Avatar
I don't think github allows for one PR to depend on another, right?
Avatar
@deen can you say how to connect via econ?
14:55
idk how to test it
Avatar
@deen github doesnt allow it, but other platforms do
Avatar
@Ryozuki you can fork them and use
Avatar
@gerdoe
Currently can't even connect, not sure why.
15:33
so he most likely won't help
Avatar
https://ddnet.tw/client/, dead link. Idk what its even supposed to represent
Avatar
i thought he tried to connect but it didnt establishe
15:35
i can do nothing with this econ
15:35
client just have it
Avatar
@ScReeNy All of the skins with 0s as prefixes
15:38
Banana Brothers Clan skins in the database
🍌 2
Avatar
Okay, link is refering on some external dead site tho
Avatar
why sv_team_lock is map controlled?
15:46
why do we need this setting at all?
Avatar
ᶰ°Konͧsti 2020-09-07 15:46:36Z
wat
Avatar
what does it do? @BannZay
Avatar
7d1c6d8 Remove outdated client info - def-
Avatar
allows you to use /lock
Avatar
hm, not sure why it would be map controlled
Avatar
ᶰ°Konͧsti 2020-09-07 15:50:20Z
nobys favorite feature
lol 2
Avatar
sounds like some "fun" map setting. But idk if it will be ever used
15:51
can we search across maps and maybe remove map controlled or maybe completely?
Avatar
can probably remove map controlled, and probably even completely
Avatar
@BannZay sure, you can download all maps and use config_retrieve to get all map configs
Avatar
in libtw2 you can find a tool that can output settings of multiple maps to stdout
15:53
might be a bit faster
Avatar
@deen thx, I`ll try
Avatar
1e94118 Add generic_unhookable by mind - def- 219d53f Merge #2777 - bors[bot]
16:04
Avatar
is not IConsole::m_cheated prevent any team on server from being scored if admin use any cheat command? Or am I missing something?
Avatar
What was not done: Not possible to read value marked by CMDFLAG_TEST. Can not find not ungly solution related to #2773
Avatar
@BannZay it only marks the player that cheated, not those he helped
Avatar
sounds like my fault
18:20
only tested on linux obviously 😦
Avatar
same @jao nouis
Avatar
@jao is it live rn?
18:20
or just nightly
Avatar
steam? ddnet.tw?
Avatar
ddnet.tw for me
18:21
i got same
18:21
just pressed update in client
18:21
what now
Avatar
@deen does the package on ddnet.tw contain an up-to-date steam_api.dll stub?
Avatar
ah, i have to update that every time?
Avatar
every time I add more functions, yes
Avatar
sorry, missed that
18:31
that's the danger with shared libs
Avatar
fair
Avatar
so any fix ideas so far?
Avatar
downgrade for now
Avatar
@twistandflex just download 14.7 from ddnet.tw
18:32
@Twike ^
Avatar
can I just use the ddnet.old file and rename it to exe or does that not work?
Avatar
yes
Avatar
that works
18:34
@heinrich5991 alternatively we could automate the update creation
18:35
oh, and it's weird that this didn't fail in wine...
18:35
I even tested the upgrade in wine
Avatar
linux supports late binding of symbols
18:35
this symbol is never called
Avatar
perhaps wine inherits this property
Avatar
now the autoupdate should be fixed
Avatar
what do you need for the autogeneration?
18:36
just a tool to diff two trees?
Avatar
look on ddnet.tw's /var/www-update5
18:37
we could just override all the files I guess. And then I need an updated update.json
18:37
At the moment what I do is look at https://github.com/ddnet/ddnet/compare/14.6.2...master and enter everything in data/
DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet
18:37
but that obviously fails for shared libs
18:37
(but I see the libs in ddnet-libs, except for steam_api)
Avatar
would it work to generate it from two subsequent release zips?
Avatar
k, that sounds like a doable thing. will try to do it
Avatar
I guess there are some annoying corner cases though, like only a dll in win32 updated
Avatar
?
Avatar
was just a typo
18:42
he meant smone else ;D
Avatar
@deen i got the logfile when my ddnet client says update failed, but it actually worked. (not steam ofc)
19:06
Avatar
@n000b that looks like bad permissions on your directory
19:08
updater failed to overwrite most files
Avatar
Why did all teamranks >80 disappear on the website?
19:12
Is it intended?
Avatar
@deen maybe it is because i deleted those files XD
Avatar
ᶰ°Konͧsti 2020-09-07 19:15:17Z
i opened DDNet on steam and it fucked up my settings on my normal client and why the hell does it make mouse_follow_factor 60??? peperage
Avatar
but the updates always work. but it says it failed so i thought i let you know
Avatar
bcs there's nothing wrong with exe file probably, it's just doesn't works properly
Avatar
@Ruh wait what?
19:30
@n000b if it fails to write most files that were updated that doesn't count as "working"
19:32
19:32
They are cut off like they don't exist
19:33
Check any profile u can't find teamranks >80
Avatar
Zwelf: Turns out our number of players has grown quite a bit, /points is slow now. If I limit it to Points > 10 it's quite fast though 😄
19:35
Ah I think I know how I can optimze this
19:35
Ha, down from 3 seconds to 0.003: SELECT Rank, Points, Name FROM (SELECT RANK() OVER w AS Rank, Points, Name FROM record_points where Points >= (select Points from record_points where Name = 'deen') WINDOW w as (ORDER BY Points DESC)) as a WHERE Name = 'deen';
poggers 1
Avatar
sql god
19:36
poggers
19:37
time to search what OVER does
19:39
ah i see
Avatar
[freenode] b3z BOT 2020-09-07 19:39:29Z
its like GROUP BY but the windowed aggregate function version :D
19:39
or am i wrong
19:39
it allows non aggregate and aggregate values
19:39
if i read correctly
Avatar
[freenode] b3z BOT 2020-09-07 19:40:56Z
@deen what was the previous query?
Avatar
Legion, an Entity Component System in Rust, has released version 0.3.0 which includes major changes, greatly improving ergonomics and speed.
Avatar
ᶰ°Konͧsti 2020-09-07 19:42:52Z
lmao
19:43
Why does writing play teetris in f1 kick u
Avatar
play is for demos right
Avatar
ᶰ°Konͧsti 2020-09-07 19:44:20Z
Thats dumb that play command kick u
Avatar
well u cant watch demos in game
Avatar
ᶰ°Konͧsti 2020-09-07 19:45:32Z
well it shouldnt work when ingame
19:46
trolls are writing to players they should write play teetris in f1
Avatar
if we go there, we might as well unbind f1 by default
19:53
there's quite a few things you shouldn't enter there
Avatar
ᶰ°Konͧsti 2020-09-07 20:07:59Z
how to bind f1 if u cant open console then
20:08
justatest
Avatar
settings
Avatar
ᶰ°Konͧsti 2020-09-07 20:08:14Z
xd
20:08
Ik
Avatar
oh, i realesed that CCharacter fully depends on CPlayer
Avatar
b3z: The same but without where Points >= (select Points from record_points where Name = 'deen')
Avatar
Worst case seems to be same performance, best case 3 ms instead of 3 s previously
Avatar
@deen what's the "client": true, "server": true in the update json?
Avatar
whether to update client and server
21:36
client could be removed, it's always true
21:36
we can also autoenable server i guess, most releases change it
Avatar
9bbd7f6 Improve performance of /points - def- a147361 Merge #2779 - bors[bot]
Avatar
I was just killed by switch weapon on pickup
22:07
enabled by the update 😄
Avatar
we should distinguish "default" and "not set" value. As user might explicitly chose default value so on update we should not change his value
Avatar
idk how to implement that in a nice way
23:47
we change variables in CConfig all over the place, it's not clear whether it's the default value or the explicitly chosen default value
Exported 314 message(s)