DDraceNetwork - off-topic

DDraceNetwork

DDraceNetwork / off-topic

Any languages allowed

Between 2020-09-04 00:00:00Z and 2020-09-05 00:00:00Z

hi @Learath2 ! Any ideas on how to speed up 0.7 clients downloading maps? 0.6 clients are downloading instantly but sixup has a limit of 10KB/s it seems and window size doesn't seems to affect sixup (edited)

08:30

I've turned on http support for 0.6 already and maxed downloading window

08:31

it works fine wit 0.6 client

I can take a look after breakfast

bon appetite

bone apple teeth

Image attachment

Олды здесь? Смотрите кого встретил

Image attachment

Кого?) Мамбу ?)

what map

10:32

justatest

@Deleted User looks like we already implement the fast download thing for 0.7 clients

11:16

Not sure why it doesn't seem to work

in ddnet we have

sv_map_window

in 0.7 we have

sv_map_download_speed

but those are not same

11:28

I've maxed sv_map_window but didn't get any speedup on sixup clients

11:29

it's still capped to 10KB/s

11:29

looks like we already implement the fast download thing for 0.7 clients

is that UDP or HTTP version? looking to the config options it seems that only ddnet supports http to download maps (edited)

11:32

There is

sv_fast_download

but I don't know if it works on sixup clients. I don't recall where but there was a comment (in code? on website?) that only 0.6 use them. But I cannot find it again (edited)

11:36

@Learath2

@Deleted User the 0.6 fast download should essentially be the exact same thing as 0.7

12:16

You just reply to chunk requests with many chunks instead of one

hmm... maybe you're right and 0.6 just uses maps from maps/ instead of downloadedmaps/

12:16

I will retest it thanks!

Ah I remember

12:17

I disabled it because it was breaking something

12:17

Can you try something for me?

I think it's right, using maps from maps/ is counterintuitive

12:17

np, what?

Can you remove the if block at server.cpp:L1420

12:18

The one checking if the client requesting the map chunk is sixup

my server is modified, I will look into github ddnet

12:20

you mean to remove the whole if block starting with else if(Msg == NETMSG_REQUEST_MAP_DATA)

12:20

right? @Learath2

12:20

https://github.com/ddnet/ddnet/blob/f00cab1b5585858117e2d815e3be0ed738475356/src/engine/server/server.cpp#L1420

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

12:21

or have you meant this instead? https://github.com/ddnet/ddnet/blob/f00cab1b5585858117e2d815e3be0ed738475356/src/engine/server/server.cpp#L1425

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

@Deleted User that second block

on 1425 right?

if(m_aClients[ClientID].m_Sixup)

12:29

yep

yeah

12:29

ok I will test it

12:29

in 10 mins (edited)

12:33

it stalls after first chunk

12:34

and it's ok when I uncomment it

Can you add some logging on the server and client?

SvFastDownload doesn't affect both speed and stalls

dbg_msg("dbg", "Requested %d", Chunk); inside else if(Msg == NETMSG_REQUEST_MAP_DATA)

12:37

dbg_msg("dbg", "Sending %d", Chunk); inside CServer::SendMapData

12:38

dbg_msg("dbg", "Got %d", Chunk); inside else if(Msg == NETMSG_MAP_DATA) client.cpp

12:39

That should be enough to see why it's getting stuck

https://gist.github.com/pure-luck-999/1c65ac0372fec79de0851b78b58b0c46

12:40

client side is not interesting [2020-09-04 15:39:18][datafile]: loading. filename='downloadedmaps/infc_thelaststand_a_34f02f32.map' [2020-09-04 15:39:18][datafile]: could not open 'downloadedmaps/infc_thelaststand_a_34f02f32.map' [2020-09-04 15:39:18][datafile]: loading. filename='maps/maps06/infc_thelaststand_a.map' [2020-09-04 15:39:18][datafile]: allocsize=3700 [2020-09-04 15:39:18][datafile]: readsize=3228 [2020-09-04 15:39:18][datafile]: swaplen=3248 [2020-09-04 15:39:18][datafile]: item_size=2728 [2020-09-04 15:39:18][datafile]: loading done. datafile='maps/maps06/infc_thelaststand_a.map' [2020-09-04 15:39:18][client]: map differs from the server. found = d2523dc7bd16a6c35797ddff2fcf6a547952d60beb613d974891806713006bf1 wanted = ba7c75d658847c78cfab8f7a5a0e30c5bf30d254f81b9fe550c2f3f18b7837fc [2020-09-04 15:39:18][client/network]: starting to download map to 'downloadedmaps/infc_thelaststand_a_ba7c75d658847c78cfab8f7a5a0e30c5bf30d254f81b9fe550c2f3f18b7837fc.568997.tmp'

12:41

wow, that was F-Client 0.7.5

12:41

I've tried vanilla 0.7.5 and it stalls at 253/471 KB (edited)

12:46

https://gist.github.com/pure-luck-999/df5bd429c3d6212b06a3f0023c7d9c3e

12:46

that's for vanilla

12:47

differences: F-Client requested 57 times, vanilla 263 before stalling (edited)

@Fr1leo ворчуна же

@Learath2 didn't added Got %d to client

That window looks massive

How was your breakfast?

great, had 2 eggs, fried, with cheese

Like some grated cheese ontop?

tomatoes on the side and a buttload of tea

Nice style with the tomatoes on the side

I prefer slices of cheese around the yellow, it creates a puddle of melted cheese that sticks/combines with the whites

Interesting, haven't seen that before. I may have to try it!

Obviously try a cheese that melts well, and one that you'd like with eggs

But do you have bread with it? Just 2 eggs seems kind of incomplete you know?

[2020-09-04 16:06:10][dbg]: Got chunk size 896 [2020-09-04 16:06:10][dbg]: Got chunk size 896 [2020-09-04 16:06:10][dbg]: Got chunk size 896 [2020-09-04 16:06:10][dbg]: Got chunk size 896 [2020-09-04 16:06:10][dbg]: Got chunk size 896 [2020-09-04 16:06:10][dbg]: Got chunk size 896 [2020-09-04 16:06:10][dbg]: Got chunk size 896 on the client

I love the tomato season, it's such a shame you can't get ones this good year round

13:07

@Blade oh yeah, definitely without bread it's a sad breakfast

I'm growing my own cherry tomatoes, i'm so lucky to have them straight from the plant

cherry tomatoes are the only tomatoes that are good year round

1

Yeah mine are still going, they don't seem to stop growing though O_o

13:07

one is 3m (or more) tall

@Deleted User I'm more interested in the chunk# not the chunk size

but there is no Chunk variable?

13:09

ah m_MapdownloadChunk

13:09

but it just increments with ++

Oh they changed it in vanilla :/

so it is not useful

0.7*

Image attachment

13:10

yeah

can you print which chunk it's requesting next?

on client or on server?

on client

13:11

I'm wondering why it keeps asking for chunk 0

Image attachment

@Blade which kind are you growing? red?

there is no chunk number parameter

13:13

it seems to expects a server to know which will be the next chunk (edited)

Ah I'm a goof

13:13

I forgot it doesn't send the chunk number

13:13

that's what's wrong

13:14

Try something like int Chunk = m_aClients[ClientID].m_Sixup ? m_NextMapChunk : Unpacker.GetInt();

13:14

on the server that is

one sec

@Learath2 Yes red ones, they aren't doing too well as it's got some virus.. living in the city and near nature causes quite a few terrace gardening problems

Ah, city problems :/

But they just keep growing, they go brown near the base but green at the tops

Yeah I tried growing things aswell but the city is quite cruel

13:16

Only basil and mint seem to survive

13:16

Trooper plants

God I'd love to grow my own basil, best herb imo. Why have I not yet actually, hm..

It just needs some sunlight, very trivial to grow

Nice

it works, but the speed is the same

13:18

I will try to increment NextMapChunk

Wait

13:18

Show which chunks it's sending

oh no

Ah I know what's wrong again

it's stalling

13:19

I've used remote server not local last time

13:19

https://gist.github.com/pure-luck-999/f717a96057dc93b5cfd354f6b65ef316

Yeah this won't work so easily

13:20

The ddnet code relies on the client asking for the next chunk of what you send

13:20

The 0.7 client no longer does that

13:21

In void CServer::SendMap(int ClientID) there is a 1 I'm adding to the message, it means the client only expects one chunk per request

13:21

I'll fix it in a minute

These lines of code that you're talking about, what programming language is this?

13:25

(sorry if that's dumb question lol)

C++

ty

what the crap @louis

18:35

i dont deserve to talk to you anymore

18:35

this is adieu

nouis

we're not on the same level anymore

nouis

= mod

wth @Anxton dont say that

weirdchamp

Imagine deserving the right to talk to someone by playing ddrace

BoolinJAM

btw congratulations

@louis ur the beeest

heartw

1

Fuck nice

19:35

The electricity went down in the whole house

19:35

And I was working on that bonk track

fursuit furries worst

The electricity turned off because of them 100%

feelsamazingman

1

ctrl+s

Image attachment

@Learath2

22:49

someone hacked a bot

22:49

in python discord

22:49

test

?

sec

22:50

it flood discord so much

22:50

cuz it has 100k users

22:51

everyone typing it ratelimited my client lmao

22:51

Image attachment

22:51

xdd

22:51

this is the bot @Learath2

22:51

justatest

oof

https://discord.gg/python

Invite to join a server

welcome

22:52

justatest

Exported 161 message(s)