DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2020-07-09 00:00:00Z and 2020-07-10 00:00:00Z

dont merge

00:02

its wrong

00:04

maybe this guy only wants to appear in the credits

@Ryozuki if you can take the time, could you say why it is wrong (and if you assume that he's still using gtranslate, perhaps tell him that translations using that are mostly useless)

no i wont, i dont want to teach spanish

00:10

ill simply correct it tomorrow

00:11

any sane spanish speaker can clearly see this is wrong

00:12

"Restablecer arma deseada en muerte" -> "Restablecer el arma deseada al morir"

00:12

its so wrong

I've never taken a spanish class, I really can't tell

00:12

sorry

00:12

then just close the PR and tell him one wrong grammar usage

well its mostly missing articles and correctly conjugatin the verbs

00:13

hm

00:13

idk if articles is a word

articles is a word

00:13

the word class of "the" in english

00:13

and "a"

ye

@Ryozuki 1- about the merge. I just follow the instructions on the ddnet page. I have no idea how to use github so I created another pull request to fix the errors in the grammar. 2- How many errors were there? (edited)

[ddnet/ddnet] Pull request closed: #2481 Update spanish 08/07/20

Fix updating mapinfos like mapper

what's wrong with mapinfos?

@deen you sure that it was correct to delete the cldefaultzoom stuff in camera::onreset?

07:28

just by looking at the code it seems like it should be still broken

07:29

but mh, it seems to work

07:29

but defaultzoom - 10 is -1 in my case, my default zoom is 9

@deen tried updating ~3 times a mapper name through django it never worked (edited)

@fearxito please only update languages that you speak fairly well

08:42

it's annoying to have to go through all strings to check whether the grammar is still okay, whether they fit the context and whether they fit into the space allocated for them

Maybe set default zoom to 9 on fng

08:44

Hehe

omg

08:46

@deen

08:46

@heinrich5991

08:46

his french translations are also rly wrong

08:46

idk if u pulled it already

08:46

Image attachment

08:46

he basically changed "mouse sens" to "mouse direction"

https://github.com/ddnet/ddnet/pull/2473

Revert "Update french 07/07/20" by heinrich5991 · Pull Request #247...

I don't speak French well, I can only say a few sentences. But it was enough to recognize that almost all of the changes made the translation worse. French puts a space before punctuation, ...

aight

08:47

and the "grammar" mistakes he fixed are also wrong

https://github.com/ddnet/ddnet/pull/2473/commits/4e2ea9753147de0d2d0b5b9c9d61df5e6cedd2bc you could judge whether my imperfect french skills were okay enough for this one change

i.e he removed every space before punctuations

08:47

but in french we actually have space before these..

ye, I know, that's how I realized something was off

Sens. de la souris could work, but wouldn't fit either

yeah its not perfect but it makes sense (edited)

08:48

the . shows the word isnt "sens"

08:48

but yeah at that point just write the entire word "sensibilité"

Doesn't fit anyway, and omitting "de la" there shouldn't matter much

08:50

Well I'm no native speaker, so I wouldn't touch any of the translations anyway

@Learath2 @heinrich5991 i made some changes to my own bridge server, including learaths repackmsg function, but that also removed the packing in message.h, which is now failing my ex.cpp test (by heinrich)

09:13

what should i do about it? just remove the test like ddnet?

09:13

https://github.com/fokkonaut/F-DDrace/runs/853167159

@Learath2 :/ why did you remove the test? ^^

well if it fails

@heinrich5991 i think its gone since a long time already

10:00

yea i dont know, i just noticed there is no ex.cpp

Can you take a look at how to fix the test tho?

hm. it seems there never was a src/test/ex.cpp(?)

10:13

git log -- src/test/ex.cpp shows nothing

lol

10:14

then you didnt add it to ddnet xD

10:14

i got it from cherry picking your commit you did to ddnet7

10:14

will you add the test to ddnet?

I know how to make better ddos protection. Just use better internet. Not 1GiB/s.

@heinrich5991 i removed a test?

no

no

10:21

sorry

@TortiLeq the teeworlds networking code cant deal with 1 gbit of traffic either

just throw better nonexisting cpus at it

heinrich, will the ex test be added?

10:22

or why did it not exist?

We could deal with it if we utilized extra cores better

One of our first GER server was 10 Gbit/s, but they kicked us out because of DoS attacks anyway

I love how they let u have 10gbit as long as you dont use it all

10:22

Thanks my man

did you add the non-reflection measures back then?

no

otherwise we might have been kicked off because we were DoSing others

nono, it was because of the incoming traffic causing problems for other customers

ok

10:23

hm

the 10 Gbit/s was shared, not exclusive for us anyway

Ah

I noticed some hosters have 4.5 GHz CPUs, might be less work to switch to something like that instead of using multiple threads for netcode

@fokkonaut probably not because I don't want to port the test right now

ok

10:26

if i want to remove it, can i just delete the ex.cpp file?

yes, and delete it from CMakeLists.txt

ye

@Patiga https://discordapp.com/channels/252358080522747904/293493549758939136/730723604303577188 congratulations, you predicted the outcome

2

@deen i wonder if we would benefit from the extra single core speed

10:37

I guess we would as we probably arent having a bottleneck in the kernel yet

sometimes we do get a kernel bottleneck

10:38

when there is a large attack with many small packets on a single server

10:38

recvmmsg helps a bit

Yeah the kernel can only do so many packets per second per core, I'm not sure if that scales well with the core speed

10:39

We should get a high performance networking enthusiast hooked on ddnet :D

10:41

It'd also be nice if we could have access to a high powered firewall where we can drop things with ebpf filters before it even reaches us

[ddnet/ddnet] Pull request opened: #2482 Only write non-defaulted config values to settings_ddnet.cfg

As a consequence changed defaults in an update will be respected instantly if the player hasn't changed the value.

10:42

[ddnet:master] 2 new commits

defe243 Add cl_smooth_zoom_time - def- 56ef688 Merge #2467 - bors[bot]

10:42

[ddnet/ddnet] Pull request closed: #2467 Add cl_smooth_zoom_time

@deen one problem with #2482 is that you cant explicitly set values to default

https://github.com/ddnet/ddnet/pull/2482

Only write non-defaulted config values to settings_ddnet.cfg by def...

As a consequence changed defaults in an update will be respected instantly if the player hasn't changed the value.

I implemented it the same way, then I implemented it with an extra bool inside the config but that doesmt work with the direct way we modify configs in the settings menu

@snail u need to rename mapper in other places too, not only django

[ddnet/ddnet] Pull request opened: #2483 fix some spanish translations

@TortiLeq the teeworlds networking code cant deal with 1 gbit of traffic either

@Learath2 so we cant make teeworlds more safer for ddos (edited)

yo @deen trafilaw told me you know what this wordlist.txt is

11:00

how does it work what does it do and who loads this file?

When you save and the save code exists or you have an empty save code, 3 words get used

11:00

to generate a new save code

and the other question: grep -Fr wordlist.txt src/

ok thanks so its in ddnet code and for /save code

11:05

https://github.com/ddnet/ddnet/blob/6da2f117cf7db7531211997f7b1db5579c33235e/src/game/server/score/sql_score.cpp#L167

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

11:05

yikes hardcoded so it has to be in the path where the server is launched from .-. well i guess its fine

It just has to be in a storage path

ah true

11:06

ok nice i can move it to ~/.teeworlds then huh?

11:06

so it does not annoy me in the binary directory

I don't particularly like that you can't launch a server without this either

11:06

Yeah it can go into data too

what is so problematic about this file? @Learath2

how dangerous is it to move the file while the server is running?

not at all

its only used at server start right?

yes

ok awesome

11:07

and server wont start without?

@heinrich5991 idk it's a rather large text blob only used for an optional feature

oh optional

soon, we'll have save codes without mysql, too

Oh yep. Sqlite3 is exciting

[ddnet:master] 2 new commits

a5e8fc5 fix some spanish translations - edg-l 45476e4 Merge #2483 - bors[bot]

11:09

[ddnet/ddnet] Pull request closed: #2483 fix some spanish translations

@snail for french i can check and correct if needed

11:17

After i've readed .. I think there are plenty of correction i need to to x)

11:18

I will do that this week

[ddnet:master] 2 new commits

5e7a45a Set smaller default area for what distance to show - def- ac35b49 Merge #2479 - bors[bot]

11:18

[ddnet/ddnet] Pull request closed: #2479 Set smaller default area for what distance to show

We could compile the wordlist in, but not sure if that's better

11:29

seems cleaner the way it currently is

[ddnet:master] 2 new commits

2e8faac Don't send zoom level while zooming (fixes #2470) - def- 5cc6a08 Merge #2471 - bors[bot]

11:31

[ddnet/ddnet] Issue closed: #2470 Verify that client sends server "zoom level" at correct time, depending on zooming in vs out, now that we have smooth zoom

11:31

[ddnet/ddnet] Pull request closed: #2471 Don't send zoom level while zooming (fixes #2470)

anybody else getting synflooded by 185.166.24.0/22? might be related to the last days ddos

nope, haven't noticed

well it's low throughput so it's hard to notice if you aren't looking for it

11:40

the curious thing is that i don't even serve a proper website (syns on port 443)

checked a tcpdump on ddnet.tw, nothing from that address

aight

[ddnet:master] 2 new commits

3729629 Only write non-defaulted config values to settings_ddnet.cfg - def- 0bf10ca Merge #2482 - bors[bot]

11:42

[ddnet/ddnet] Pull request closed: #2482 Only write non-defaulted config values to settings_ddnet.cfg

emails to the abuse contact for that network bounce...

12:14

fantastic

meh, probably nothing will come of it, cybercrime isn't a crime if you aren't hurting the bottomline of a company

12:15

I guess maybe if you sound srs enough the hoster might be scared you'd actually bother with it

i wasn't expecting much, best case they enable ingress filtering

12:17

i figured bottomline or not, some sysadmin might not like the idea of someone spoofing his whole address space from within

fstd: how do I check if i get flooded by this ip

ChillerDragon: tcpdump -i eth0 -nl 'src net 185.166.24.0/22'

12:20

if your network interface is 'eth0' that is

is it rn?

12:20

yy ik

well i'm still receiving, although not much

12:21

20 packets per sec or so

12:21

which is why i'm assuming i'm not the only receiver

did not get any traffic

12:24

so its unlikley tw related

but my webserver doesn't serve anything

12:25

literally just https://www.pr0.tips/

oh so its web requests?

"foo bar www"

12:26

it's SYNs on the https port, yes

12:26

no actual requests though

i get so many crazy requests on my pstd server

fstd: I don't get anything either on any server I have

hm that's so weird

fstd: do you also get these? https://paste.zillyhuhn.com/LV

12:29

looks like bugbounty hunters :D

nah that's just people probing for known vulnerabilities in certain web apps

12:30

and yeah i get those a lot (but paste.pr0.tips is running over at Learath2's)

oh

12:30

i thought u host that

pstd_server can't make sense of a lot of those requests due to the way it (does not) implement http

y

i could actually move it back to my server these days, yeah

12:31

oh wait, no

btw does econ still work in ddnet6? or am i stoopid?

12:32

if i connect via econ to ddnet6 i just crash the server

12:33

ah ok nvm using netcat it worked

I buy a cake tin online that looks like it's one piece, turns out you can remove it's bottom... Why can't I just get a solid one piece cake tin?

12:37

At this rate I'll have to get a normal one and have it welded....

tf is a cake tin?

the thing you bake a cake in

removable bottom sounds like a useful feature then

12:41

to get the cake out

12:42

without messing it up

Unless you are baking custards like cheesecake which need to be baked in a waterbath. Then a removable bottom is the perfect place for the water to get in and give you a sad soggy bottom

i see, lol

12:43

fortunately cheese cake tastes like ass so nobody should ever have a reason to make one :P

Just because you never had a good one

did you just call my momma a sub-par cheesecake maker?

Okay, then you just don't like cheesecakes

xD

fstd: heh, I also got that for abuse contacts a few times. that's when you know they don't give a shit

14:58

Learath2: Post some cake photos next time

https://rushter.com/blog/github-profile-markdown/ bah

How to track and display profile views on GitHub

GitHub has introduced READMEs for profiles that allow to display profile views

[ddnet/ddnet] Issue opened: #2484 Add `Sv_TeamsState` for 0.7

F-Client has an implementation of it.

[5:06 PM] fokkonaut: @deen yea. could you look into making Sv_TeamsState work for F-Client? its an extended net message in my Client/ddnet7

https://github.com/Deen/mangos the deen on github did some wow server reimplementation stuff

Source patched the various patches, the full list will be soon published. An overall objective this fork is addition of new functions of a kernel and more convenient use. - Deen/mangos

well, he forked it and did a single change 10 years ago

what is a "wordlist.txt"

it's a list of words for random savecodes

15:14

git log -- data/wordlist.txt

ah i guess i just need to copy it to my serverdir for the server to start again :)

ah, yes

[ddnet/ddnet] Pull request closed: #2454 Add basic XDG support (fixes #2431)

Cheesecake is good kek

kek

@Learath2 can we take https://github.com/ddnet/ddnet/pull/2433 in?

Fix votes for sixup by Learath2 · Pull Request #2433 · ddnet/ddnet

I think this looks sane but I haven't tested it at all for idk how to even test this locally/alone

@deen there are still a couple double messages that need to be masked

[ddnet/ddnet] Pull request opened: #2485 Find available port

Same as https://github.com/ddnet/ddnet/pull/2419 but rebased so that you can actually look at the diff. @MikiGamer

[ddnet/ddnet] Issue opened: #2486 safe /c after map change

^

[ddnet/ddnet] Pull request closed: #2419 Find available port

quite a few people on old clients, thats since yesterday

Image attachment

16:45

(older versions than 10 didn't access https://info.ddnet.tw/info

Cuz they faked version number to not get shit timer

[ddnet-web:master] 1 new commit

d4cbdd6 Update index.php - snailx3

17:02

[ddnet/ddnet] Issue opened: #2487 Rotated stoppers are not equivalent to mirrored ones

In old client versions rotated stoppers did nothing, now they stop you, but later than mirrored ones. Not sure if we can just change this, physics is always high risk.

lol @jao still uses ddnet 1.8.7 kek

kek

Image attachment

wowo jao murderer

justatest

@heinrich5991 sorry, I don't have idea that the spaces were okay on the french translation sorry about that. My bad

17:27

@heinrich5991 Spanish is my native language and I speak a little english (edited)

2

Can someone help me add sqlite to cmake? I can compile https://github.com/ddnet/ddnet/pull/2465 without any errors locally, but the Github CI isn't satisfied.

Sqlite3 support and prepared statements by Zwelf · Pull Request #24...

This PR changes the abstraction layer of the score backend to thin abstractions over the MySQL and SQLite3 library. It executes all Queries in one worker thread making it easier to use the ddnet th...

Zwelf: Did you forget to git add the cmake/FindSQLite3.cmake file?

18:21

do we need the sqlite3ext.h btw?

No need for the sqlite3ext.h, I don't plan to use sqlite3 extensions.

Zwelf: Can we reenable /practice btw? I heard something was broken and thus it's disabled

[ddnet-libs:master] 1 new commit

6ae3275 Remove sqlite3ext.h since we don't need it - def-

18:29

[ddnet/ddnet] Pull request opened: #2488 Remove sqlite3ext.h since we don't need it

@heinrich5991 thanks for all the reviews btw, you're very proactive and giving good feedback

18:29

and I know that reviewing is less fun than writing own new code, so it's much appreciated

Can be enabled again if #2446 is deployed. Was related to the ClientID = TeamID change on solo servers.

thanks

18:30

I'm okay with doign reviews. I sometimes worry that I'm making PR authors work too much

ok, I'll reenable practice then

[ddnet:master] 6 new commits

6a87278 find available port - MikiGamer beaadca switch, limited tries & sv_port 0 - MikiGamer f7eda38 changes for auto port - MikiGamer 6da220d default port - MikiGamer a34c725 Some minor improvements to sv_port 0, make it default - def- af17e25 Merge #2485 - bors[bot]

18:31

[ddnet/ddnet] Pull request closed: #2485 Find available port by MikiGamer

so far it's been reasonable I think with the work you asked

yes, didn't write a FindSQLite3.cmake yet.. those look a bit scary, but can try to copy a simple one and modify it

[ddnet:master] 3 new commits

6b7e1f5 Send zoom status for dummy too - def- f4344dc Use (u)int64 from system.h instead of (u)int64_t from cstdint - def- c4d5c8d Merge #2478 #2480 - bors[bot]

18:38

[ddnet/ddnet] Pull request closed: #2480 Send zoom status for dummy too

18:38

[ddnet/ddnet] Pull request closed: #2478 Use (u)int64 from system.h instead of (u)int64_t from cstdint

[ddnet:master] 2 new commits

b2b664b Don't reset chat on map change (fixes #2451) - def- d7a0a91 Merge #2460 - bors[bot]

18:49

[ddnet/ddnet] Issue closed: #2451 Keep chat string across map changes

18:49

[ddnet/ddnet] Pull request closed: #2460 Don't reset chat on map change (fixes #2451)

[ddnet:master] 2 new commits

fb7114b Remove sqlite3ext.h since we don't need it - def- 9492eaa Merge #2488 - bors[bot]

18:57

[ddnet/ddnet] Pull request closed: #2488 Remove sqlite3ext.h since we don't need it

while player is sitting in editor and getting mention, ddnet's icon on panel doesnt pulse

yeah, but you get a message in editor i think

yes, but im in another program atm

19:23

so i cant get that someone mentioned me

@deen can you compile sqlite3 with SQLITE_OMIT_LOAD_EXTENSION (CFLAGS=-DSQLITE_OMIT_LOAD_EXTENSION ./configure) and rename sqlite to sqlite3 for consistency

19:49

Currently there are linking errors to ld (using the .so would work as well)

[ddnet/ddnet] Pull request opened: #2489 Update French translations (by SunnyPistache & Pipou)

21:09

[ddnet-scripts:master] 1 new commit

64f2260 Build sqlite without extensions - def-

21:11

[ddnet-libs:master] 1 new commit

685f961 Rebuild sqlite without extension, rename to sqlite3 - def-

Zwelf: done

[ddnet:master] 1 new commit

8e1b951 Rebuild sqlite without extension, rename to sqlite3 - def-

Thanks

[ddnet/ddnet] Pull request opened: #2490 Don't request IUpdater interface when built without updater

Fixes warning: [kernel]: failed to find interface with the name 'updater'

[ddnet:master] 2 new commits

3585d83 Don't request IUpdater interface when built without updater - def- 1a79644 Merge #2490 - bors[bot]

22:34

[ddnet/ddnet] Pull request closed: #2490 Don't request IUpdater interface when built without updater

[ddnet:master] 2 new commits

59243c0 Update French translations (by SunnyPistache & Pipou) - def- 9a4fbc4 Merge #2489 - bors[bot]

22:42

[ddnet/ddnet] Pull request closed: #2489 Update French translations (by SunnyPistache & Pipou)

Exported 278 message(s)