DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2020-06-14 00:00:00Z and 2020-06-15 00:00:00Z

[ddnet-maps:master] 1 new commit

37dcb17 A Casa der Merde - ddnet-maps

@deen very odd that a part of the code I never touched broke, it seems stuck in a utf8 byte next loop

How did this even work before is beyond me

ea7f3f0a624247006fbfbd8638435e2e3c32324c fixed that endless loop, I just need to rebase

09:13

but that's not the only issue, MaxWidth of DoLabelScaled ends up as the Length parameter of TextEx which puts the pEnd and pBatchEnd waay outside the string

Yeah the only reason this doesn't leak heap is because Text() handles MaxWidth correctly but TextWidth() doesn't

[ddnet/ddnet] Pull request opened: #2260 Fix out of bounds read

@Jupeyy I'm not completely familiar with the text rendering code but I think it needs a large rework. The code isn't concise or easy to read, the interface is horrendous. e.g. That MaxWidth parameter is an integer and it's used completely wrongly leading to a out of bounds read.

[ddnet:master] 2 new commits

8d25592 Fix out of bounds read - Learath2 18f5ae4 Merge #2260 - bors[bot]

09:49

[ddnet/ddnet] Pull request closed: #2260 Fix out of bounds read

@fokkonaut do you know what changed between 0.7 and 0.6 about colors?

10:38

undoing the usual clamping leads to an overly bright tee in 0.7

?

In 0.6 we clamped L to be between 0.5 and 1.0 so tees are never too dark

10:42

If I send the clamped color to 0.7 the tees look dark

10:42

if I unclamp it before sending tees look too bright

you cant get the color perfect

10:44

i believe

10:44

well, if its a custom color you cant

10:44

0.7 has white skins, which can be colored

10:44

so also the default skins are white, and in a json file it gets its values

meh

lmao found a cheater on stackoverflow https://stackoverflow.com/questions/11293206/xdotool-ignores-target-window

xdotool ignores target window

A window named Teeworlds is my target window to send mouse clicks. xdotool search --class Teeworlds click --repeat 30000 --delay 20 1 However, these mouse clicks aren't sent just to the window, ...

[ddnet-web:master] 1 new commit

82037b7 remove inactive mods - 12pm

where is onion?

12:17

greenthing

[ddnet-web:master] 1 new commit

62a9b05 update testers - 12pm

@deen does the player-cache thing break when we rename players?

12:33

see https://ddnet.tw/players/Porphi/ for example

12:34

https://ddnet.tw/players/murpi/ is his new name

[ddnet-web:master] 1 new commit

568ee21 update murpi - 12pm

@jao oh yeah, I forgot about renames

13:44

so I need to keep track of all names that I updated and delete all others, will think of a good solution

[ddnet/ddnet] Issue opened: #2261 replace front.png for editor with front.png with Turn off entities tile

In front.png there is no Turn Off entities tile even though its much more usefull there than in gamelayer Anyway it works if you just place the unused tile where turn off entities should be placed. So the fix is very easy by just adding this front.png to the client instead of the old one. Just added the Turn Off entities tile at correct position !front Of course the ID numbers 190 an...

1

13:51

[ddnet/ddnet] Issue opened: #2262 Crash with super

Thanks to jao & Lady Saavik for the report, working on a fix: ``


Core was generated by

../DDRace64-Server_sql -f servers/test2.cfg'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x000055db789c8562 in CGameContext::ConSuper (pResult=0x7ffd5c20bd10, pUserData=0x7f75c2916010) at /home/teeworlds/src/master/src/game/server/ddracecommands.cpp:109 109 pSelf->m_World.m_Core.m_apCharacters[pResult->m_ClientID]->m_Super = true; [Current thread is 1 (Thread 0x7f75c4f1...

13:56

[ddnet/ddnet] Pull request opened: #2263 Fix /spec + super bug

14:01

[ddnet/ddnet] Pull request opened: #2264 Add Entites off sign to front layer (fixes #2261)

feelsamazingman

2

@deen are you familiar with template magic?

a bit, why?

[ddnet/ddnet] Pull request opened: #2265 add sv_tele_others_auth_level

@Learath2 merge pls

@deen I'm looking for a way to mark the net message structs in the protocol7 namespace so native netmessages don't get translated

16:06

I'm thinking of inheriting from an empty base class and using std::is_base_of but wondering if you knew a better solution

16:06

@jao hm what is this for? doesn't access level already cover this?

so people dont annoy us on test server by teleporting us away

Ah you want to allow some levels to just teleport themselves?

y

As soon as CI passes

ty

16:15

@Learath2 why capitalized? i copied it from few functions below where it isnt capitalized either

16:15

Console()->Print(IConsole::OUTPUT_LEVEL_STANDARD, "votemute", "vote mute array is full");

oh just reflex

16:18

now it's inconsistent

[ddnet:master] 1 new commit

01092a3 add sv_tele_others_auth_level - 12pm

16:21

[ddnet/ddnet] Pull request closed: #2265 add sv_tele_others_auth_level

[ddnet/ddnet] Pull request closed: #2254 add tele2

@jao thx this is really helpfull

Konsti says it's helpful, big red flag

17:12

what did you break @jao ?

justatest

troll

17:44

nah its biggest annoying to have to super through complete maps if they dont have tele

Did you hear github is renaming the master branch to main because apparently it's offensive

what

19:10

rly?

19:10

the world is fucked

19:10

everything is offensive

19:11

ups i said fucked

19:11

hope i didnt offend anyone

19:11

feelsbadman

19:12

instead of this they should make a dark theme

19:12

they make a website forr developers

19:13

The Internet Engineering Task Force (IETF) points out that "Master-slave is an oppressive metaphor that will and should never become fully detached from history" as well as "In addition to being inappropriate and arcane, the master-slave metaphor is both technically and historically inaccurate." There's lots of more accurate options depending on context and it costs me nothing to change my vocabulary, especially if it is one less little speed bump to getting a new person excited about tech.

19:13

omg

19:13

i want to kill myself

19:13

https://www.hanselman.com/blog/EasilyRenameYourGitDefaultBranchFromMasterToMain.aspx

19:13

i find main offensive

19:14

troll

19:14

https://tools.ietf.org/id/draft-knodel-terminology-00.html#master-slave

Terminology, Power and Oppressive Language

This document argues for and describes alternatives that shift specific language conventions used by RFC Authors and RFC Editors to avoid oppressive terminology in the technical documentation of the RFC series. Specifically, this document details two sets of terms that are nor...

Github and IETF has done it tbh, personally every time I saw master, I thought of slavery. With this move they have finally destroyed racism

19:18

Racism is no more

yep

19:20

we can live in peace now

19:20

@Learath2 remember when the linux code of conduct controversy

19:20

sjw with an agenda

19:21

this is the same

19:21

stackoverflow did something like this too

19:21

u had to use pronouns for special ppl

19:21

or u would get banned

19:21

even if u didnt do it on prupose

19:22

https://itsfoss.com/linux-code-of-conduct/

Linux Has a Code of Conduct and Not Everyone is Happy With it - It'...

Linux kernel has a new code of conduct (CoC). Linus Torvalds took a break from Linux kernel development just 30 minutes after signing this code of conduct.

19:22

Oh and the best part is, if you complain about this, you are a racist

19:24

Just update all your scripts and your muscle memory, duh

lets add a CoC on ddnet

19:25

you must use pronouns for konsti

19:25

bruh how tf does master relate to slavery

19:32

especially when it's used in the context of coding lmfao

It's literally as in "master record", i.e. the original copy

https://www.youtube.com/watch?v=t6KFfYdNPh8

Master Boot Record

MASTER BOOT RECORD - INTERNET PROTOCOL

19:38

offensive music

Oh I'm definitely reformatting my disks with GPT

yea ofc everything else would be condsiderd racism @Learath2 :D

19:40

maybe its because im not a native but i could never even come up with things like "master branch" being offensive wtf

19:41

society is such a meme

I'm going to submit a proposal to the C++ standards committee soon. I think it's extremely offensive that we talk about "ownership" semantics. Who are we to own objects really.

19:44

Don't get me started on the exec syscall and the kill command

19:45

Honestly, I don't really care what the branch is named... I just find it disappointing that we keep finding ourselves in this situation every year

rust has the biggest ownership scheme, they are big offenders

Like why is this even a discussion? It's obvious what is meant by "master" in this context

19:47

Remember a couple years ago when they broke thousands of gems renaming "FactoryGirl" to "FactoryBot"?

gems

19:47

ruby

19:47

never used it

Like who really sat in front of their computer and thought, gee this library is extremely offensive

Probably the same people because of who there had to be added labels like "Warning! HOT" on coffee cups

[ddnet/ddnet] Pull request opened: #2266 Reset hook & collision in prediction after kill

Thanks to Pipou for reporting

@Ryozuki thats how github solves racism

Image attachment

@Learath2 why didn’t u tell me about ur @DDNet pr

I think I did, didn't I?

idk i think i saw it for the first time now tee_thinking

tee_thinking

21:16

I was pretty bummed out when I learned you can't embed multiple things in one message

21:16

Maybe I just tried forgot in all that sadness

21:17

.s/tried//

embed multiple things?

21:20

i think u can send up to 10 embeds

21:20

in 1 msg

I wanted to do embeds for each of the issues, but one message can have one embed from a bot

21:20

from a hook you can do multiple

ah

21:20

well that would be spam lol

21:21

imagine whole screen with embeds xd

21:23

i’ll merge it tomorrow or so but i’ll clean it up a bit

It definitely needs cleanup, I'm not very good with writing clean python

you can use some tricks to make it cleaner

@Learath2 i guess inheritance sounds fine for that. alternatively some constexpr bit with "if constexpr" in the translation

21:35

@jao fixed

nice ty

@deen I used https://github.com/ddnet/ddnet/pull/2256/commits/6db9ce2b7f851e5bdf2c2e134f6aaca9941127a0#diff-cdd5bae6f9e976c607a2966f78596bd4R118-R132

21:39

I have another one that I couldn't figure out though, I want to override a template function for types that satisfy this "trait" do you know how I could pull that off?

21:39

It works with two enable_ifs with one that has the same condition negated but that's just ugly

I wanted to change the url that client gets servers and news from it and I uploaded the json but it looks like it doesn't works. I got that the client adds ?name=<S.TH> to the url and I got that when it adds that to ddnet info url it's data changes. How can I fix the problem? It doesn't get news from my link and I have warns: F:/Code-Edit-Room/DDNet/src/engine/client/client.cpp: In member function 'virtual void CClient::RequestDDNetInfo()': F:/Code-Edit-Room/DDNet/src/engine/client/client.cpp:4172:2: warning: this condition has identical branches [-Wduplicated-branches] 4172 | if(s_IsWinXP) | ^~ At global scope: cc1plus.exe: warning: unrecognized command line option '-Wno-nullability-completeness'

your line has the same check in the if condition twice, fix it

@deen well lmk if you come up with anything, I'll sleep on this one

@Deleted User stop using sash client

feelsamazingman

2

1

Exported 147 message(s)