DDraceNetwork - developer

ddnet-maps

[ddnet-maps:master] 1 new commit

5286c82 M Flow Fever - ddnet-maps

d3fault

[ddnet/ddnet] Issue opened: #2244 Might as well let players join a team in /practice mode even after starting line

...because why not? (both the tee wanting to join the team, and the team being joined, can be already passed the starting line) Usual lock/invite rules still apply tho ofc...

bors[bot]

[ddnet/ddnet] Pull request closed: #2236 Fix team rejoin logic for sv_team 3

10:33

bors[bot]

[ddnet:master] 3 new commits

d3b6df9 Fix team rejoin logic for sv_team 3 - def- 88b65b6 Newly joined player should not immediately be subtracted from team 0 - def- 3cd35de Merge #2236 - bors[bot]

def-

[ddnet/ddnet] Pull request opened: #2245 Stop playing map sound when demo player is paused

Noticed on Shooting Range map

def-

[ddnet/ddnet] Issue opened: #2246 Map Sound keeps looping when paused in demo viewer

Noticed on Shooting Range map

11:57

def-

[ddnet/ddnet] Issue closed: #2246 Map Sound keeps looping when paused in demo viewer

Hi All, is there any reason why smart pointers aren't being used for KillCharacter method in player.cpp (edited)

smart pointers aren't really used in general in Teeworlds code

13:45

in KillCharacter, where would you use a smart pointer? the function is pretty short

I guess he'd have a unique_ptr owning the character, which is actually not really correct. With ddnet7 I tried moving towards better ownership semantics, but it's hard to decide who owns an entity

13:51

Usually the only owner of an entity is the world, however the character is owned by the player too, so maybe shared ownership semantics would be better, but that's extra overhead for every other entity that doesn't need shared ownership

13:53

Overall the way teeworlds is designed isn't really great for this kind of thinking, entities kinda own themselves at this point but they are tied to the lifetime of the world. It's like someone wanted entities to be independent but then decided it'd be too much work in the middle of coding it

Thanks for the long detailed explanation

I'm still learning so was just wondering. Makes sense thanks @Learath2

Zwelf

[ddnet/ddnet] Pull request opened: #2247 [WIP] Thread safe SQL interaction

This PR intends to make the database interaction thread safe and optimizes some SQL queries. This is still a WIP, but since it is a rather big PR I wanted to get feedback early on. Benefits: