DDraceNetwork - developer

[ddnet/ddnet] Pull request opened: #2205 Clarify the /help lock text

Hm, now that I think about it I guess I agree

15:35

Idk what we should do about enablecheats, maybe something like kill protection?

15:35

because it's essentially killing the run

/lock /unlock triple times more user friendly IMO. Does kill protection affects teams in case its locked and somebody died? If no, it would be nice to have

@BannZay nope, and I don't think that's possible since it would mean stopping the server until the team decided

15:48

@BannZay i guess the idea was that with lock/unlock you can't have a single bind for both uses

@BannZay I added it now

15:56

(in the same pr)

thx, deen, it should make life of new players easier. I just has this problem at the begining

@Learath2 too late, now I renamed it to practice mode, because cheating is never ok (or something like that)

I like "practice"

@heinrich5991 i added the voting btw

I just saw it in the diff

15:59

thanks

@deen , about kill protection for team, could we keep died players in spectactor mode till team decides/timer ends? If it technically possible

that's a thing that should probably be implemented for normal mode, too – tees that get killed after finish should die and go to spectator mode

16:01

(currently they don't die from death tiles, but from out-of-world kills, resulting in botched finishes because some tees exit the map too quickly causing the team to die)

[ddnet/ddnet] Issue opened: #2206 kill protection for team, could we keep died players in spectactor mode till team decides/timer ends?

BannZay: @deen , about kill protection for team, could we keep died players in spectactor mode till team decides/timer ends? If it technically possible heinrich5991: that's a thing that should probably be implemented for normal mode, too – tees that get killed after finish should die and go to spectator mode heinrich5991: (currently they don't die from death tiles, but from out-of-world kills, resulting in botched finishes because some tees exit the map too quickly causing the team to...

sounds fine, I made an issue since i won't work on it

1

thanks

That was a quick implementation of voting, would have taken me atleast 2-3 hours

16:09

Thanks deen, I think it looks good from a feature point of view now

16:10

I think m_WishesPractice needs to be reset to false when changing teams

[ddnet/ddnet] Pull request opened: #2207 Silence GCC warning

src/game/editor/auto_map.h:47:9: warning: ‘((void)& NewConf +16)’ may be used uninitialized in this function [-Wmaybe-uninitialized] I don't think it's an actual problem

Also one more thing I can think about is someone leaving the team. E.g. we have 7 people 3 wishes practice, if 2 people leave now a majority wants practice but it still won't pass

it will pass once one of them types /practice again

Ah

sounds better than automatic passing, even

@Learath2 true

16:15

Btw, why do I get the "Do you know someone who uses a bot?" message when joining my dummy

16:15

never got it before

it's in full servers where the id mappings are not the same between dummy and main, I think

hm, I don't see any commits that'd break that

i thought so too but the server wasn't full, only had 40 players

Why would id mappings be different ever? we do support 64 players

>16 would trigger it

16:17

*can trigger it

ah, you mean because the server doens't know yet if i have ddnet client

yes

i see

heh, the early version thing would help

my thoughts exactly

indeed

It is quite an extensive change though, I constantly feel like I'm missing something while going through it

the idea was simple

With the way we use the version all over the place, it couldn't ever have a small footprint

I still save the version in only one place at least, nothing can get out of sync

Sometimes I wonder maybe we should start dropping a bit of this compatibility

16:20

Like the old extended serverinfo protocol, are there even any surviving clients using that?

probably ddnet.tw/status is using it

Or VERSION_DDNET_WHISPER = 217 do we ever see a version older then this anyway?

16:22

even 707 is probably quite rare to ever be spotted in the wild

16:23

The crashmeplx stuff

[ddnet/ddnet] Pull request closed: #2207 Silence GCC warning

16:26

fd67259 Silence GCC warning - def- 8c5bf3e Merge #2207 - bors[bot]

I think m_WishesPractice needs to be reset to false when changing teams

@Learath2 Done

Gave you a review

[ddnet/ddnet] Pull request opened: #2208 Implement /save without params to show some info

about your existing saves. Not the code of course, but only how many saves you have and when you last saved on this map.

would be cool if holding jump allowed you to autojump without using dj

For that one Konsti might actually put a hit out on me

lol why

Btw, how about disabling the message of who killed team in case you're in solo team?

@Soreu how to trigger that message?

19:49

because i don't see it when playing with 1 player

[ddnet/ddnet] Pull request opened: #2209 singular player in team start message

19:57

[ddnet/ddnet] Pull request opened: #2210 Fix name schema for char-arrays

@deen Sorry, seems that I yet again mistook that some things works same way on DDNet & KoG servers >.>

looks liek KoG changed something in this case, np

ye, on KoG when you join team, pass startline and kill you get *** Everyone in your locked team was killed because you killed.

20:07

@qshar fix it ^ xD

@Soreu can you write me in PM the problem, I'll try to fix

was so lazy that just pinged you there xd

we have a different source, so ye - there might be some big difference

20:10

ye, I see it

[ddnet/ddnet] Pull request closed: #2210 Fix name schema for char-arrays

20:12

a412773 Fix name schema for char-arrays - def- a1f405a Merge #2210 - bors[bot]

[ddnet/ddnet] Pull request closed: #2209 singular player in team start message

20:20

7c966be singular player in team start message - def- 5cddef7 Merge #2209 - bors[bot]

20:26

c45995a Implement /load without params to show some info - def- f18c42c Merge #2208 - bors[bot]

20:26