DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2020-04-11 00:00:00Z and 2020-04-12 00:00:00Z

@Fexa you're not the first to report that, my guess is that hetzner (our ger2 hoster) has bad peering to some isps. @heinrich5991 any plans to shut down ger2?

@heinrich5991 fixed the /players/ issue. reload of the data now takes 0.5 s instead of the previous 5-10 min. Each individual page loads in 0.1 s, similar to before. Memory usage is down to 120 MB from 1000 MB. Seems good enough for now. Was also extremely easy to do with diskcache: http://www.grantjenks.com/docs/diskcache/

06:57

Basically just put the players dict on disk:

with Cache('/home/teeworlds/servers/players-cache') as cache:
  for player, value in players.items():
        cache[player] = value

And replaced all data['players'].get(name) with cache.get(name). Should've done this much earlier I guess

@louis is your GPU intel and your laptop lenovo?

@Learath2 what happened to ddnet7 master? Why doesnt it build? Can you fix it?

09:11

what or who caused it?

Ive come here to say big thanks for new version of DDNet. Compared to previous version it loads at least 2 (might be 3 or 4) times faster. No idea who did it, but it is very very cool! Thank you, dear devs ❤️ (edited)

nani

@fokkonaut idk, idk, idk, idk

@Trafalgar Law master branch is currently broken, needs a fix (that was recently pushed to teeworlds by Ryozuki and to ddnet by deen)

@heinrich5991 . @fokkonaut

ddnet7 doesnt have that?

it looks like the freetype issue, there is a commit fixing it in both ddnet and teeworlds

Can you fix it?

done

[ddnet/ddnet7] Pull request opened: #94 Fix Freetype warning

@deen oh wow, awesome optimizations

10:54

thanks!

hmm

10:57

ubuntu wavpack version doesnt have WavpackCloseFile?

10:57

https://github.com/ddnet/ddnet/pull/2128/checks?check_run_id=573556917

Fix memory leaks and related. by Ryozuki · Pull Request #2128 · ddn...

Don't merge yet. I want to use this pr to fix several leaks and stuff, if you find something you can report it here. valgrind-out.txt

10:57

Image attachment

10:57

it compiles for me

why does ubuntu doesnt install wavpack CI

Image attachment

11:05

libwavpack-dev

it should also compile without installing wavpack

11:06

we have a bundled wavpack for that case

what version is bundled

11:06

update it to atleast v5 pls

no, it's a stripped down old version

11:06

there are no newer versions of the stripped down one

why use a stripped one

http://www.wavpack.com/downloads.html

11:07

search for "tiny"

11:07

because we don't need more functionality than that, I guess

we nee dto close the context

11:08

or we are leaking xd

11:09

is there a way to check if a function exists

11:09

i would want to fix it atleast for sane people who install wavpack library

it looks like you don't have to free in the tiny library

11:11

(reading the source for a sec)

11:11

@Ryozuki add a line above check_symbol_exists(WavpackOpenFileInputEx wavpack.h WAVPACK_OPEN_FILE_INPUT_EX)

does tiny have WavpackGetLibraryVersion

11:11

oh

in CMakeLists.txt

ok i did it

11:15

Image attachment

@Ryozuki can you rebase to master btw, then the CI will at least complete for non-mac

y

11:17

done

@Ryozuki for snapshot storage, add a constructor that calls Init and a destructor that calls PurgeAll. that should fix it

ok

11:35

@heinrich5991 do i remove the calls to init then?

11:35

or maybe not

11:35

i think no

not needed, no

pushed

11:38

@heinrich5991 github still marks it as a X and it triggers me xd

Image attachment

^^

11:38

need a fix for mac CI ^^

@heinrich5991 is there a way we could get verbose builds in the CI? I want to see the way the compiler is invoked

make VERBOSE=1

11:42

@Ryozuki you started the client at least once and connected to a server?

11:42

and it's ready for merging, right?

ye

11:43

and map sounds works

11:44

[2020-04-11 13:43:23][chat]: *** DDraceNetwork Mod. Version: 0.6.4, 13.0

11:44

is the server not at 13.0.2?

11:49

i guess that sv didnt restart

I don't know if we automatically update the servers

[ddnet/ddnet] Pull request closed: #2128 Fix memory leaks and related.

11:51

[ddnet:master] 8 new commits

c6731c7 Fix uninitialized m_LastProgramID - Ryozuki cde63e2 Fix TexEx UB - Ryozuki 09b7970 don't check, use dbg_assert - Ryozuki b4f072f some valgrind suppressions - Ryozuki 7d51a09 fix memory leak on sound decoding - Ryozuki 5f565a5 check for WavpackCloseFile - Ryozuki 588f8a8 Fix snapshot storage leak - Ryozuki 58f763c Merge #2128 - bors[bot]

@heinrich5991 why does your test fail for me? https://github.com/fokkonaut/F-DDrace/runs/578923569

fokkonaut/F-DDrace

F-DDrace is a server mod for Teeworlds 0.7 developed by fokkonaut. - fokkonaut/F-DDrace

12:08

Your newly added datafile test in 0.7

did you apply the patch that goes with it that fixes the datafile size thing?

Ryozuki: were there any server relevant changes? I didn't recompile official servers

I'm compiling ddnet for macOS in a docker container, in a linux vm, on a mac

12:28

inception

the darwin.toolchain file references darwin15 but that's dependent on the SDK version we are using

12:32

darwin15 is 10.11

12:39

@deen how do you build curl with osxcross?

@Learath2 of course

@Learath2 https://github.com/ddnet/ddnet-scripts/blob/master/ddnet-lib-update.sh#L193

ddnet/ddnet-scripts

The magic scripts that make DDNet run. Contribute to ddnet/ddnet-scripts development by creating an account on GitHub.

@deen how did you fix that SSLContextCreate thing btw? you still seem to target osx 10.7 which doesn't have that api

you told me to set --without-ssl, that worked

heh, didn't work at all for me

the make clean might not work

13:28

i always deleted directory to retry

gotta love weird clang builtins introduced only for macOS

well, clang was mostly developed at apple

huh, didn't know

they bought chris lattner, who started llvm+clang+clang++ as his phd thesis

13:32

and then he kept developing it there

13:38

Nice conversation with him I watched a few days ago: https://www.youtube.com/watch?v=yCd3CzGSte8

Chris Lattner: Compilers, LLVM, Swift, TPU, and ML Accelerators | A...

@Deleted User razer laptop intel iGPu

is there a need for spoof protection in tcp based games?

no

cool

13:45

thanks

@deen what is the video about?

just a chat about his work, compilers, more an overview, nothing really in-depth

13:58

but i liked it anyway, puts a face on a name

@louis tried to update your GPU driver?

oh thanks for sharing the video deen

i will try

why do they have to break compatibility in every single version of xcode? they just had to rename that symbol to __isPlatformVersionAtleast and implement it in some other library

@Learath2

16:05

U know code of blue color on teeworlds?

which blue? team blue?

no

16:07

in binds

binds are blue?

:I

16:12

11403008

16:13

16776960

16:14

12582656

oh, you want the teeworlds color code for blue?

its a colors

16:15

yes

give me the color in hex and I'll give you the teeworlds code for it

16:16

or r, g, b

16:16

whichever

i was find

16:18

what me need

there are infinite tones of blue, what kind of blue do you want?

16:19

light blue?

16:19

dark blue?

16:19

very darkblue??

I think they found the solution already

16:20

i was find what me need

what kind of color code use tw?

16:21

hex? rgb?

HSL, with a twist

16:22

ddnet supports colors without a twist too

16:22

you can do player_color_body blue and it'll work

16:22

or player_color_body r0000FF

16:22

I think it was r, might be $ too I don't remember

16:24

@deen is it okay if we bump the min mac os version to 10.8 or 10.9?

16:28

The __isOSVersionAtleast issue stems from you not having compiler_rt built, it works fine with that

16:28

the function works dynamically so there is no problem with statically linking compiler_rt

16:29

that allows us to also get rid of the ugly lazy linking fix

16:29

Actually, I'll make a PR and you can test, see if everything works fine

@heinrich5991 I want to set https://cmake.org/cmake/help/v3.14/variable/CMAKE_OSX_DEPLOYMENT_TARGET.html

16:45

could you help me give it an absolute minimum? e.g. don't allow the user to set something lower then 10.8 e.g.

@Learath2 what do you want to do?

17:02

let the user decide on a value of that, but you want to throw an error if it's lower than 10.8?

yes

17:16

but it has to happen pretty early as that needs to be set before the project call

if(CMAKE_VARIABLE VERSION_LESS 10.8) @Learath2

Much wowo data science I compiled a list of all vote reasons we collected on laws ddnet7 servers in the last 5 months if anyone is interested what people think is a valid reason to move a player to spec or kick from the server (no option votes) https://paste.zillyhuhn.com/uU

17:39

(might include insults lmao)

lowercase the strings maybe

yea thought about it

17:42

but i think case is interesting to see the mood of the voter

maybe normalize case except for all uppercase words?

when i try to start a server rn, i get

/bin/DDNet-Server: error while loading shared libraries: libantibot.so: cannot open shared object file: No such file or directory

that's bad

17:45

where did you get ddnet from?

(havent restared my computer since the update, hope that shouldnt help?)

17:45

from the aur

17:45

the non-git package

@Rafael Fontenelle ^^

17:45

packaging problems

17:46

(for packaging problems, contact the packager)

@heinrich5991 does make install install libantibot?

17:48

did u modify cmake install

( @Patiga you can solve the problem by either not compiling with -DANTIBOT=ON or installing libantibot.so

17:48

)

17:48

did not

@Learath2 ok

dunno how to install libantibot.so, but compiling should be done in a sec

@heinrich5991 antibot should be off by default

yes, I saw the packager add -DANTIBOT=ON

ok, otherwise we coud also enable it and ship the empty one

the empty one is compiled if you have -DANTIBOT=ON

im also a packager btw

ah

17:50

then @Ryozuki

https://github.com/ddnet/ddnet/blob/master/CMakeLists.txt#L1480

DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet

17:51

so there is no install there right?

yea, looks like it

i think thats why

17:51

its not at all the aur fault more the cmake setup :P

pff

17:52

if the packager adds an option and doesn't check it's working, it's also the package's fault

well yeah

ye, it works *fine without -DANTIBOT=ON (edited)

rafael probably didnt check

hmm but it also works with -DANTIBOT=ON when i compile it o.o

ofc

17:54

ur running it without installing

17:58

i wonder if libantibot.so is a good library name

17:58

its too generic i think @heinrich5991

17:58

libtwantibot might be a better name

18:00

@Patiga update ddnet, i disabled antibot

2

1

[ddnet/ddnet] Issue opened: #2134 CMake install libantibot.so and probably change its name.

I think libtwantibot.so is better, less generic. CMakeLists.txt should have install directives for this library too.

@Learath2 you here?

Yep

oh we don't even require cmake 3.0?

18:55

@heinrich5991 can we?

@Learath2 requiring cmake 3.0 on non-linux is a non-issue

what ancient version of centos ships with cmake 2.8?

CentOS 6, CentOS 7

19:02

CentOS 7 EOL 2024-06-30

as always, shipping ancient software, supporting it for an eternity

19:02

@heinrich5991 is there a cmake best practice for not setting a variable if the user is setting it?

wdym?

I want CMAKE_OSX_DEPLOYMENT_TARGET to be set to 10.8 if the user doesn't pass anything, if the user does pass something I don't want it to be smaller then 10.8

check CMAKE_BUILD_TYPE

19:05

we set it to Release if the user doesn't specify anything

is that really the best way to handle this? I was sure there'd be some shorthand

ah, maybe there is something

19:06

but I don't know

19:06

check set(CACHE or something

19:08

set(<variable> <value> CACHE STRING <docsting>)

set CACHE indeed seems to be it

@heinrich5991 one more thing, just because you already dug into this: I need to set rpath on macOS builds, specifically to include @loader_path/../Frameworks

19:27

That should allow us to remove the usage of install_name_tool from our builds

that would be nice

as soon as you tell me a good way of setting rpath while building on macOS

19:28

I mean I could just pass -Wl,-rpath but that's just ugly, and I have a feeling it'd interfere with the antibot

there's probably a target setting

19:37

BUILD_RPATH or so

19:38

man cmake-properties @Learath2

I know as much, but BUILD_RPATH is only available cmake 3.8 on, not only that but you are already setting it for ANTIBOT=ON.

I'm fine with requiring cmake 3.8 on non-linux

can anyone tell me how the data of quadlayers is stored?

22:10

im sorta stuck again and figured someone here might be able to speed this up

hm @Patiga what do you want to know?

in the map files each quadlayer points to a data_item (bytes array) for its content, and i dont understand how the content of the data item is constructed

23:13

constructed as in which bytes describe which values

Ah, it's just raw CQuads (not very portable now that I think about it)

oh i totally missed that one

how did anyone think this was a good idea? no serialization whatsoever

23:19

atleast the points are not floats, that definitely would have been a mess

thanks tho

Exported 236 message(s)