DDraceNetwork - developer

@Learath2 from the official libsdl.org site

05:28

Same issue here I guess: https://github.com/bvschaik/julius/issues/386

Travis: macOS-related problem trying to bump SDL to 2.0.12 · Issue ...

I'm trying to update SDL to 2.0.12 in travis. Everything is working except for mac OS, which throws the following error during make install: CMake Error at /usr/local/Cellar/cmake/3.15.5/sh...

def-

[ddnet/ddnet] Pull request opened: #2121 Try to fix SDL2 hidapi rpath on MacOSX

Following SDL 2.0.12 update

def-

[ddnet/ddnet] Pull request closed: #2121 Try to fix SDL2 hidapi rpath on MacOSX

06:29

def-

[ddnet:master] 2 new commits

ae330bb Try to fix SDL2 hidapi rpath on MacOSX - def- 724f292 Merge pull request #2121 from def-/pr-mac-hidapi - def-

@noby @Learath2 can you try again on mac osx?

06:50

(i fixed the 13.0.1 release on osx)

ok ill try

Did you upload the dmg?

Identifier: org.DDNetClient.app Version: 13.0.1 Code Type: X86-64 (Native) ... Crashed Thread: 0 Exception Type: EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Termination Reason: DYLD, [0x1] Library missing Application Specific Information: dyld: launch, loading dependent libraries Dyld Error Message: Library not loaded: @rpath/hidapi.framework/Versions/A/hidapi Referenced from: /Users/nobody1/Desktop/DDNet.app/Contents/Frameworks/SDL2.framework/SDL2 Reason: image not found

06:54

Binary Images: 0x10ff4a000 - 0x110287fff +org.DDNetClient.app (13.0.1) <F0B0E60D-540B-396A-81D2-CA5F8986284F> /Users/USER/Desktop/DDNet.app/Contents/MacOS/DDNet 0x110541000 - 0x11062efff +libfreetype.6.dylib (24.1) <FF599A1F-62D1-3478-83B6-54282A253C8B> /Users/USER/Desktop/DDNet.app/Contents/Frameworks/libfreetype.6.dylib 0x11064d000 - 0x11078efff +org.libsdl.SDL2 (2.0.12 - 2.0.12) <3E6D5145-6DE8-3734-95A7-AE31ED09A1A9> /Users/USER/Desktop/DDNet.app/Contents/Frameworks/SDL2.framework/SDL2 0x11747e000 - 0x1174c8acf dyld (551.4) <8A72DE9C-A136-3506-AA02-4BA2B82DCAF3> /usr/lib/dyld

@deen didn't work for me either

06:58

The hidapi rpath is wrong in SDL2 itself, not the client

06:58

last argument of install_name_tool should be sdl2

ah, too bad...

06:59

so we have to overwrite the rpath in SDL2 directly

Yeah, they should be the ones doing it tbh, but we can for the time being

def-

[ddnet/ddnet] Pull request opened: #2122 New try for hidapi SDL2 rpath

Should I merge and try another build or can someone test locally? ^

Wait for a second for CI to build and I can test that

07:05

I think in this case executable path would be SDL2 not DDNet but ill try

oh

I'm not completely sure, let me try first

07:07

Mach-O binaries are weird sometimes

07:11

dyld: Library not loaded: @executable_path/../Frameworks/SDL2.framework/SDL2/Versions/A/Frameworks/hidapi.framework/Versions/A/hidapi
  Referenced from: /Volumes/DDNet-13.0.1-osx/DDNet.app/Contents/Frameworks/SDL2.framework/SDL2
  Reason: no suitable image found.  Did find:
    /Volumes/DDNet-13.0.1-osx/DDNet.app/Contents/MacOS/../Frameworks/SDL2.framework/SDL2/Versions/A/Frameworks/hidapi.framework/Versions/A/hidapi: stat() failed with errno=20
    /Volumes/DDNet-13.0.1-osx/DDNet.app/Contents/MacOS/../Frameworks/SDL2.framework/SDL2/Versions/A/Frameworks/hidapi.framework/Versions/A/hidapi: stat() failed with errno=20
Abort trap: 6

oops, I also had a wrong path in there, pushed again

07:17

so we don't know where executable_path points to yet?

Not sure :/

Hi

It should be tho, how else could you link a library to a library?

I think executable_path will be the path to DDNet.app

Then this should work

07:25

I wonder if we can mount and run the dmg on the CI

would be great

07:26

can you try the version I pushed again?

yep, it works

ok, thanks

def-

[ddnet/ddnet] Pull request closed: #2122 New try for hidapi SDL2 rpath

07:26

def-

[ddnet:master] 2 new commits

18aec44 New try for hidapi SDL2 rpath - def- 392412b Merge pull request #2122 from def-/pr-hidapi-sdl2-rpath - def-

@deen there is a patch I got into sdl, but it wasnt released on a version yet, you think we should apply that to the macOS ddnet sdl?

I'm not building my own sdl2 for mac

07:27

do we need it?

Oooooh, maybe you should be compiling with the 10.14 or 13 sdk then

07:27

I forgot about that

too late!

on binaries linked on 10.15 there is a new check enabled in AppKit which crashes on launch

07:28

if you compile on older AppKit compatibility disables the asserts

so we're crashing?

def-

[ddnet:13.0.1] 4 new commits

ae330bb Try to fix SDL2 hidapi rpath on MacOSX - def- 724f292 Merge pull request #2121 from def-/pr-mac-hidapi - def- 18aec44 New try for hidapi SDL2 rpath - def- 392412b Merge pull request #2122 from def-/pr-hidapi-sdl2-rpath - def-

Yeah, at launch it hits an assert

so I should downgrade to 10.13 sdk and we're fine?

Yeah I think so

07:32

Or you apply my sdl patch

07:32

But compiling sdl on our own for mac too is just a pain

exactly, so I'll downgrade sdl

We can upgrade sdk when the patch is in a stable sdl

good to know

Its broken on old sdl too, you need old sdk

do i need to recompile libs?

I never tried, mach-o binaries should be forward compatible though

def-

[ddnet-scripts:master] 1 new commit

a98818a MacOSX SDK 10.15 -> 10.13 - def-

@deen lmk when you have a build, I can test

@Learath2 available now

I'm sad to report that that didn't work