DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2020-04-02 00:00:00Z and 2020-04-03 00:00:00Z

[ddnet/ddnet] Issue opened: #2105 spectate_closest is buggy when /showall is disabled

I think it's because the server isn't sending player info for players off screen when /showall is disabled? idk though

Embedded image

10:45

why i dont like tw and i like more ddnet in a single comment

Even worse then that, in the vanilla realm it all depends on getting on Oy's good side, I spent hours trying to convince them to adopt 64p, no budging

all the leaders of tw dev think they are all mighty and just right

I forgot whom but someone else convinced oy with like the equivalent of "lol let's just add it bro"

@Learath2 i guess being friend of them makes it easier to model the game the way you want

I do kinda agree with lordsk on not adding sliders for everything but I'm not against ui options being hidden in the console

why even hide them

10:49

it doesnt hurt anyone to be able to customize it in a easy way

10:49

the way you want

well limited ui space is one issue

that guy jsut wants to treat people like 11y olds

10:49

u can add a scroll

10:49

and just scroll down

yeah but is that really good ui?

for me yes

10:50

the more options the better

10:51

this is what factorio sound options are

Image attachment

10:51

want to know what sound options tw has?

10:51

1

10:51

its not overkill to add 4 options for chat sounds

10:51

they are just overexagerating

It is good user experience to actually have the options, sure. But I'm not sold on having scrollbars for all the ui elements

10:51

Yeah the sound thing was ridiculous

10:52

Maybe a checkbox somewhere that enables extra settings?

10:52

It'd keep the default ui retard friendly like the vanilla people want and we can get more options

https://github.com/teeworlds/teeworlds/pull/2277

Add more sound options for chat by Ryozuki · Pull Request #2277 · t...

I noticed a lack of sound options so I added them.

oh shit can we finally change weapon volume

can we make ryos sound options a meme pls?

15:57

I think thats even worse https://github.com/teeworlds/teeworlds/issues/2525

Quote player names with spaces in commands · Issue #2525 · teeworld...

When using player name auto completion it should quote names that have spaces. That is useful for custom commands using names not as the last argument. Also it would improve the vanilla whisper UX ...

poggers

"we wont fix bugs because there are other bugs as well"

dune is a special child

15:59

he is usually 90% the one who says bloat this bloat that

15:59

@ChillerDragon

yea my propsoal is not bloat

16:02

its a bug fix

16:02

could solve spying on whisper for example

16:03

if you name ur self "namless" you can spy on all whisper msgs sent to "nameless tee"

chillers bug fixes usually cause more bugs

lol

1

troll

1

rude

troll

16:03

he didnt make the bugfix

16:03

he just opened a issue

16:03

so it has no relation jao

16:03

he didnt code anything

i saw some bug fixes from him

16:05

https://github.com/ddnet/ddnet/pull/1624

Refactor mute and vote mute code by ChillerDragon · Pull Request #1...

Fix enum name for VOTE_MUTES break out earlier in mutes loop. And using goto to make the code more readable o.O

16:09

didnt it solve 2 issues at once?

@heinrich5991 Hey, can I bug you because of vanilla tokens again? It seems like there are really only two places where a server needs to send connless packets instead of responding and those are the mastersrv heartbeat and the mastersrv count request. I want to try to get around implementing a token cache and packet cache (to wait on requested tokens). Do you happen to know if I can use a token multiple times and if i can rely on the token only refreshing when i request one via the control message?

17:45

I would try only getting a token before the count request and just sticking with that until a full reconnect occurs after 60 minutes (edited)

17:49

Also are old tokens still valid immediately after a new token is announced via the control message? It should be like this to account for a situation where the token control message has not yet arrived when a connless packet is sent by the other party, right? (edited)

@Learath2 what does validate_size do here? or why is it important? https://github.com/ddnet/ddnet/commit/ca03ab6337cc14858e2577c8c177b6f3245f8641#diff-4c1480841d96bf73e07b29e10fbd394b

Address Learath2's comments · ddnet/ddnet@ca03ab6

That object can be any size depending on version iirc

@timakro tokens are valid for 10 seconds

@heinrich5991 https://pabloariasal.github.io/2018/02/19/its-time-to-do-cmake-right/ cool read

It’s Time To Do CMake Right

Not so long ago I got the task of rethinking our build system. The idea was to evaluate existing components, dependencies, but most importantly, to establish a superior design by making use of modern CMake features and paradigms. Most people I know would have avoided such ente...

interesting, will read

20:12

concerning ddnet though: @Ryozuki https://github.com/ddnet/ddnet/pull/2085

ugh

20:14

i would bump it

github downish

RIP github

@heinrich5991 When i request a new token, is the old token still valid for some time?

token validity has nothing to do with whether you request tokens

21:52

it only has to do with timeouts

21:52

the server changes the token every 10 seconds (or so)

are always 2 tokens valid then?

yes

ahh

Exported 71 message(s)