DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2020-03-23 00:00:00Z and 2020-03-24 00:00:00Z

Is it normal that there are almost daily ladybugs in my room?

[ddnet-maps:master] 1 new commit

a6f1b98 R ThereIsNoTruth - ddnet-maps

@fokkonaut be glad it arent boybugs

@fokkonaut quite common, I had also had that a few years ago, they found a way in through the shades

i only have bugs in my code

[ddnet-libs:pr-curl] 1 new commit

7a52f1a Update curl stub - Learath2

11:42

[ddnet/ddnet-libs] New branch created: pr-curl

woot first SDL contributions now curl?

11:48

when fix linux kernel @Learath2 ?

when it causes a bug in ddnet or teeworlds I guess

@deen I dont want a nest in my room xf

12:18

xd*

[ddnet/ddnet7] Issue opened: #85 Chat is bugged for users who use vanilla teeworlds

https://www.youtube.com/watch?v=-mCvEpW5FKk You can't use commands without pressing escape

14:06

[ddnet/ddnet7] Issue closed: #85 Chat is bugged for users who use vanilla teeworlds

@heinrich5991 can you also merge the accompanying branch in ddnet-libs?

[ddnet/ddnet] Issue opened: #2094 AntibotDestroy crashes on nullpointer

Happens on all official DDNet servers, hopefully only while shutting down: ``


Core was generated by

./DDRace64-Server_sql -f servers/8316.cfg'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007fe16bfc87e4 in _IO_new_fclose (fp=0x0) at iofclose.c:48 48 iofclose.c: No such file or directory. [Current thread is 1 (Thread 0x7fe16b6d2dc0 (LWP 5357))] (gdb) bt #0 0x00007fe16bfc87e4 in _IO_new_fclose (fp=0x0) at iofclose.c:48 #1 0x00007fe16c43fc2f in Antibot...

14:20

[ddnet-libs:master] 1 new commit

7a52f1a Update curl stub - Learath2

@noby ^ crash

14:21

I count 141 crashes on RUS in 1 week alone

@deen in case there's a problem, you can rm libantibot.so; ln -s libantibot-null.so libantibot.so btw

14:21

in the servers/ directory

as long as it only happens on shutdown I don't mind much

14:22

but should be fixed in a few days

yes, looking into it

@heinrich5991 just a null check before the fclose is needed i think

14:25

Actually I see no way that's NULL :/

AntibotShutdown gets called twice

14:26

that's the root problem

huh, why would the destructor get called twice?

ah

14:29

OnShutdown calls the destructor and then calls constructor again (via Clear)

14:29

and then the destructor gets called again because CGameContext is destroyed

14:30

i.e. Antibot needs to handle its shutdown from a function that is called in OnShutdown I guess?

Or you could have the antibot have a initialized flag, if the flag isn't set the destructor is a no-op?

that sounds more like a hack to me

Well the destructor and the constructor are shortcomings of the OOP pattern as an incomplete object can be constructed

ive never seen crash on shutdown on my servers :o

@noby yes, glue code strikes again

oo

14:35

which file is even opened

/dev/null

14:35

quality crash

lol why

@heinrich5991 I agree that first one was meh, but I think the 2 acceptable solutions is to either check that the resources exist before deallocating them (to handle the incomplete object case) or as you said call antibot destroy onshutdown instead of the destructor

or remove opening dev null file

14:35

and either output to a real file

@noby double call to the destructor

or remove that code entirely

14:35

oh

@fokkonaut ladybugs are actually pretty usefull animals

[ddnet/ddnet] Pull request opened: #2095 Fix `AntibotDestroy` being called twice

The resource deallocation needs to happen in symmetry with the allocation, otherwise we get unmatched dealloctions leading to crashes. Allocations happened in CAntibot::Init, but it was not guaranteed that this was called before the destructor.

14:40

[ddnet/ddnet] Pull request closed: #2082 SDL 2.0.8 -> 2.0.12 (fixes #1997)

@deen anything against merging https://github.com/ddnet/ddnet/pull/2071?

Add an option to only start a new demo when connect while automatic...

Origin auto demo recording of ddnet will generate lots of demo files especially when playing in mods which have shorter rounds, such as infclass. I added a new option to open a new demo file only w...

[ddnet/ddnet] Pull request closed: #2089 Output library versions

14:47

[ddnet:master] 2 new commits

060d60f Output library versions - Learath2 6919ed3 Use updated stub, switch around versions - Learath2

@heinrich5991 nope, good to go

[ddnet:master] 2 new commits

50b980e add an option to only start a new demo when connect while automatically record demos - sirius1242 bf821fe Merge #2071 - bors[bot]

16:43

[ddnet/ddnet] Pull request closed: #2071 Add an option to only start a new demo when connect while automatically record demos

[ddnet/ddnet] Pull request closed: #2070 Fix demo recording with broken maps

17:04

[ddnet:master] 2 new commits

c52bbb6 Fix demo recording with broken maps - Learath2 048ca9f Merge #2070 - bors[bot]

[ddnet:master] 8 new commits

9e0f6d2 Move global configuration out of client interface - ChillerDragon f679fbf Allow editing multiple tile layer props - Learath2 ce8987c Missing include - Learath2 a50e59d Allow editing colors, add warning - Learath2 f210388 Add shift by, fix id overlap - Learath2 d2498f2 Stateful editing - Learath2 efb3106 Fix AntibotDestroy being called twice - heinrich5991 6e78deb Merge #2069 #2076 #2095 - bors[bot]

17:13

[ddnet/ddnet] Pull request closed: #2095 Fix `AntibotDestroy` being called twice

17:13

[ddnet/ddnet] Pull request closed: #2076 Allow editing multiple tile layer props

17:13

[ddnet/ddnet] Pull request closed: #2069 Move global configuration out of client interface

17:14

[ddnet/ddnet] Issue closed: #2094 AntibotDestroy crashes on nullpointer

17:15

[ddnet/ddnet] Pull request closed: #612 DDNet Tutorial

something is wrong about ger2, i am getting very different pings between servers

19:40

Image attachment

19:40

Image attachment

19:40

somehow packets delays constantly

@nori yeah, that's a rather common problem. some ports get prioritized

21:48

@heinrich5991 does it make sense to maybe stop GER2?

Yeah, I don't think it's performing up to the expectations

21:49

no point spending money on it

yea, we can stop it

22:22

https://arstechnica.com/information-technology/2020/03/attackers-exploit-windows-zeroday-that-can-execute-malicious-code/

Windows code-execution zeroday is under active exploit, Microsoft w...

There's no patch available now. Here's what to do until Microsoft issues one.

servers crash everytime i want to vote

@<BµmM> which server? which port?

all servers

tell me one where you tried

ger and usa

^

port

22:50

?

server doesn't crash, just client gets disconnected

ger2 8305

22:50

ye

22:51

ger 8328

usa 8304

looking into it, thanks

@heinrich5991 if u wanna check it in game, join me

no, thanks, can see it locally

ok

@eNJi is it fixed?

it's fixed on usa, thanks @heinrich5991

great

heartw

@Oblikumquat join

Exported 98 message(s)