DDraceNetwork - developer

@fokkonaut so apparently Send does not trigger

yep

m_ClDummy is probably 0 there

why

00:48

its for both

well, you want to send input for both client and dummy, right?

it works, but delayed

but m_ClDummy only has one value

?

m_ClDummy is either 0 or 1 (unless you switch tees), right?

yea, i do have all the dummy input stuff from ddnet in there...

00:49

check the commit where i added dummy

there is a problem, right?

00:49

something is wrong

00:49

so we try to debug it

00:50

you can't say "but everything is right" because something is clearly wrong

the problem is that the when not manually setting Send = true, the hammer for the dummy is delayed

00:50

so too slow tfor hammerfly

do you agree with me that m_ClDummy is only one value there?

ofc

okay, so send is only true when the main client's input changes

00:51

that's bad for dummy hammer fly

y

so the next step is to find out how the input is sent in the original source code

00:52

if you have a link, I can help you step through it too

a link to the repo?

a link to the similar source in the ddnet 0.6 source code

00:53

*to the similar context

what do you mean

where does ddnet send its dummy hammer?

no idea

?

me neither

01:18

how I'd try to progress here: add some debug statements in the source code in ddnet to see why it gets sent there (and not only on timeout)

The entirety of that code looks janky...

10:06

The execution leads to CControl::SnapInput if we have !Dummy thus setting Send there shouldn't really be changing all that much

yea

fokkonaut

[ddnet7:master] 1 new commit

d47e276 Send afk state to the client - fokkonaut

for: https://github.com/fokkonaut/F-Client/commit/2ac7798264099eec645d3d47121dd84a3f049100

fokkonaut

[ddnet7:master] 1 new commit

6ca49a4 Allow hook collision - fokkonaut

https://github.com/fokkonaut/F-Client/runs/493335941 @heinrich5991 send help

12:15

shall i just sue NULL?

@fokkonaut please move the AIM flag to ExPlayerFlags. As 0.7 tends to do slight protocol changes for adding new features, having it in PlayerFlags might lead to collisions in the future

thought about that too, but it would be more work. But I'll do it, sure

12:17

how do i activate c++11?

@Learath2 what would be the best way to send the aimline using explayer?

12:23

creating a new netmsg, like CL_ISDDNET?

12:23

or somehow getting it in the input?

@fokkonaut add a new flag for it in ex playerflags? I think we already have the entire thing implemented, you just need to add the flag

before it was a playerflag, playerflags automatically get sent to the server

12:25

and back

12:26

but now we dont want it in there anymore, so i need to send it to the server differently

12:26

not using m_PlayerFlags

@fokkonaut are you on dnet7?

i am on ddnet7 and my client, yes

@fokkonaut in ddnet6 we have ExPlayerFlags, didn't you port that aswell?

i have it in, yes

12:31

for the afk state

12:31

but all the flags from explayer are sent by the server

12:31

i just want a way to send the server that we press s now

12:31

xd

12:32

shall i do it using a netmsg, like CL_ISDDNET, or somehow get it into the Input (not sure how well that works)

oh yeah we never made that two way

12:33

gimme a second, let me stash my changes and take a look

12:35

No you can't tack it into input

okay

Okay, you add a new extended netmsg, let the client send ExPlayerFlags aswell, but only let the server trust the ones we allow the client to send

12:38

e.g. the new one

so only aim

12:38

because afk is sent by the server

for now only aim, but we could let the client suggest AFK aswell, but that's another issue

nah, then everybody will run around with the bubble

I think we had an issue open for the client setting afk, but we never resolved it so just let it be AIM for now

12:39

@fokkonaut There are ways around that, e.g. we could ban people who move with the afk bubble to discourage that

so i need protocol_ex_msgs.h for this right?

yep

@Learath2 shall i send CL_EXPLAYERINFO at all time, or only on updates from theclient?

12:50

just on updates i think? when we start, and stop pressing s

12:56

where should i send it? from controls::onrender?

12:56

or from onnewsnapshot?

12:56

guess that one

12:56

CGameClient::OnNewSnapshot

12:56

thats where the ddracemsg and the showothers msg in ddnet are handled

@Learath2 what would be the best to also handle it for the dummy? (for copy moves)

@heinrich5991 could you be here by some miracle?

13:08

@fokkonaut just send it when we update it, no need to bother otherwise

ok

I think you should send it after we handle input

where would that be

13:09

in onsnapinput it works pretty nice

yep that should work

13:09

Make sure it's after we consider CControls tho

sure

@fokkonaut do you happen to know about teeworlds/teeworlds #2135?

link pls

https://github.com/teeworlds/teeworlds/issues/2135

64 players: ServerInfo might be too big · Issue #2135 · teeworlds/t...

The ServerInfo packet size can be greater than the the max allowed packet size. Basically, a ServerInfo packet is composed by : - header (18) - packet flags (1) - client token (4) - server token (4...

13:10

I fixed it but I need to test it, not sure how to trigger it though

you need dummies?

I need to fill a server up to the brim

sure

13:11

come to my server

It's a server and client patch

13:11

so I need my server to be full

13:11

do we have a debug command to fill a server?

oh

13:11

we have dbg_dummies

on the server? and how many dummies does it add?

you can configure it

13:12

set it to 63

13:12

*requires debug compiling + reload

do those show up in server info tho

60% messages from fokkonaut, 39% messages from learath2 and 1% from other monkaS

[2020-03-08 16:13:49][assert]: ../src/engine/shared/network_server.cpp(288): errornous client id

13:14

amazing that's also broken and it's not fixed by my commit

xd

and they don't show up on serverinfo

13:16

...

https://github.com/fokkonaut/F-DDrace/commit/20e80de089288621c42a7c6d443d0cd58f1ba334 https://github.com/fokkonaut/F-Client/commit/f17c6731f4599521765b75fb0a9db39ebbeae920

13:17

can you take a look?

Always add flags after old ones, or you'll break compatibility

?

You added AIM before AFK, AFK moved to being the second flag, now old clients will use AIM for AFK

i know, but i just added all of this 1 hour ago

13:21

no one has one of those clients/servers yet

AFK too?

y (edited)

looks good to me then

13:22

if it works that is

fokkonaut

[ddnet7:master] 1 new commit

81406d1 Move AIM to the ex player flags - fokkonaut

it does work, yes

13:24

@Learath2 how do i activate c++11? nullptr is not available in my client repo

13:24

github actions says that

check ddnets CMakeLists

13:24

or d7's I think I have it there aswell

yes

13:24

but what do i need to look for xd

@Learath2 I would put the aim flag into PlayerFlags

13:29

otherwise it won't be shown on servers that don't know about it

it wont like this too

13:30

since vanilla disallows it

13:30

https://github.com/teeworlds/teeworlds/blob/master/src/game/server/player.cpp#L146

13:30

its fine like this heinrich

ah well

13:31

vanilla blocked their own future-compatibility

xd

then put it into explayerflags I guess

like now

yes. sorry

or we remove it from vanilla?

13:33

@Learath2 can you help me with c11

13:38

https://github.com/fokkonaut/F-Client/runs/493394794

it's hard to debug mine and help you with it

wym

I'm trying to fix a bug

13:43

@fokkonaut https://github.com/ddnet/ddnet7/commit/2c85554d30aad8fbe082e163697886a6450f8d73

Use C++11 · ddnet/ddnet7@2c85554

13:43

I told you to take a look at d7, it was even the last commit on CMakeLists...

lol

13:44

i looked there, well nvm, thanks

amazing conditional breakpoints are broken on macOS lldb

13:55

@heinrich5991 can you help me track down an uninitialized value?

13:55

lldb is not up to the task and macOS can't do valgrind

I thought valgrind is fine?

It refuses to run

@heinrich5991 any ideas regarding the dummy hammer?

well, i compared, ddnet and my client get through the if (!Send) return; the same amount

14:53

no idea whythis doesnt work

14:54

oh

14:54

i think i have it

14:55

yup xd

14:56

ddnet: https://github.com/ddnet/ddnet/blob/master/src/engine/client/client.cpp#L494-L521

14:56

https://github.com/fokkonaut/F-Client/commit/aebbc871ffbc08a1af42c184113170faa73bbebe

heh

bump

bump yes

16:32

might be hard to implement tho

16:33

idk

Idea acknowledged, create an issue for it and someone might get to it

i dont know how to create an issue @Soreu maybe you know?

trafilaw

[ddnet/ddnet7] Issue opened: #79 sv_team don't work in cfg & sv_kill_delay has no effect

If you try to change sv_team in cfg it don't work And if you set sv_kill_delay to 1, it has no effect ~Law

@Learath2 @Boci literally doing that right now ^^

Ekidoxx

[ddnet/ddnet] Issue opened: #2080 Feature request: "Visible" players in /spec

As said by Boci#1337 on discord (link):

i have a great idea when someone goes spec, you would see his ghost, of where he went spec like if he were in freeze, but like 40% opacity

6 other people, including me, seem to like the idea, so there is graphical representation of possible solution by using new skin, let's say x_spec | Skin | | :---: | | ![x_spec](https://user-images.githu...

^ there u go @Boci

ur a god @Soreu

16:55

thanks for the credit u really didnt need to do that :p

I had to. And by the way when I started thinking about such feature, you were already in middle of writing your message about it ^^