DDraceNetwork - developer

ChillerDragon

[ddnet/ddnet] Pull request opened: #2069 Move global configuration out of client interface

why? @ChillerDragon

It’s a mess to put Config() there because it’s a interface

11:05

Anyways big guru Heinrich said it’s bad code.

11:06

If we get the new 0.7 Config system to ddnet6 we can also add starting servers from client

@ChillerDragon I don't see a good reason for this one

For what @Learath2 ? My refactor? Ox’s refactor? Server from client?

12:22

Oy*

Your PR

Well it’s a Config in a Interface that will be ugly with the new config system

12:23

But there is probably a better way of doing that. If you know one pls feel free to fix or explain it and I can try

We probably will never migrate to the new config system on ddnet6 anyway

Learath2

[ddnet/ddnet] Pull request opened: #2070 Fix demo recording with broken maps

Apparently there are maps out there with broken headers advertising the wrong map size. This allows demos to be recorded on those. Example of such a map is ctf4_old_d668e9fa_2f472051b26b6bffaa4af8990cf882cafd6364e00e1333b77762cb9911e49464.map Hosted on Allround Network Reported by teini94 on discord

@Learath2 yea I was afraight someone will say that there won’t be the new cfg sys in ddnet. Will make copying code more annoying then :/

12:44

Well but this has to be solved somehow for the 0.7 client because currently I am not able to use my dummy •.•

12:58

gold

@noby here?

+

Can you help me get old versions of ddnet compiling on macOS?

what is the error

there is no -lGl on new macOS and our cmakefile doesn't do frameworks

13:15

so I need to use bam

yes i use bam to compile

but with bam I get issues with "CarbonSound/CarbonSound.h"

@ChillerDragon ?? it is the same as before, why shouldnt dummy worj

Seems new macOS deprecated some of the carbon framework

mm

13:16

dont remember if i fixed anything in here

bam.lua

25.46 KB

other/sdl/sdl.lua not found

other/sdl

sdl.zip

2.87 MB

I'm missing a lot of things in other/

13:18

which version is this bam.lua from?

1062

13:21

what else r u missing

did you rip parts of the newer bam?

i dont think so

13:24

if its changed at all then its just to fix dependencies

I'm only missing -lcrypto now after messing around with the carbon include

sounds like something else that i mightve fixed in that bam.lua? or its not installed

it definitely is installed, hmm

13:32

ye no this isn't working, I can't be assed with fixing an ancient build system

13:37

which parts are still missing

already nuked it

rq

@Learath2 why compile old version ?

trying to find a performance issue

13:52

@deen do you remember how you compiled ddnet10 on macOS?

@fokkonaut well since Oy introduced the new config system I had to comment out the config in client.h to get it working

13:53

Compiling* but that killed the dummy

13:54

Did you set the environment variables for crypto @Learath2 ?

What do I need to set?

Brew should tell you

13:54

After installing it

I have OPENSSL_ROOT_DIR set I think

13:54

That's it

Try reinstalling OpenSSL or what ever it was and maybe brew will give you a hint

13:55

Or what is your current error message?

I stopped trying

rq

maybe tomorrow I'll give it another go

13:56

but it was first complaining about the SDL includes, which end up being wrong when you are using the framework

Ye classic

after fixing those it gave issue with deprecated carbon interfaces

Is there a macOS performance issue ?

@ChillerDragon no?

13:56

why

after fixing those it gave issue with -lcrypto

What why

comment out

after fixing that it gave issue with -lopusfile and I just rq

Because I do not have access to a Config there @fokkonaut :/

You need a config instance now

you dont need it there chiller

In a Interface?

13:57

Wouldn’t that be ugly

just place the { return } stuff in the cpp file

You can't have a config instance there

and use Config() there

yeah you need it in the implementation

Well

13:57

Hm

fixed

https://discordapp.com/channels/252358080522747904/293493549758939136/679687807576702996