DDraceNetwork - developer

@fokkonaut whats with all the buffer issues in 0.7? What did they change?

not sure if they changed much, except the info changes

09:32

as mentioned above, Rainbow is bascially impossible

09:32

Does ddnet have a special system for sending the votes, like rcon cmds?

09:32

If yes, then that explains why it causes the issue in 0.7

09:33

Because i cant remember adding such a thing for 0.7 ddnet

09:38

ok yea, seems 0.7 doesnt have it

09:38

gonna add it

09:41

yep, thats the issue. as vanilla doesnt allow many vote options but ddnet has ?i guess 8k?

fokkonaut

[ddnet7:master] 1 new commit

01dc689 Send vote options balanced - fokkonaut

Can anyone test this? 0.7 and 0.6 again have differences here, so not sure whether this works, cant test right now.

10:16

added my sources to the description of the commit

10:20

@ChillerDragon

10:21

and someone should check this out: (also in ddnet6) https://github.com/ddnet/ddnet7/commit/01dc689c5ba14898f199c0203c3837f797864797#diff-a2df712cfb938eda9a173f36c865c2ccR837

fokkonaut

[ddnet7:master] 1 new commit

d1f0322 Fix build - fokkonaut

Oh I totally forgot about the limits we had

What do you mean?

I was wondering why you had trouble with the votes

11:07

Forgot we did aswell

https://github.com/ddnet/ddnet/commit/e871fbbaad8e7f4fbed3f8ec7f5630d646794cc0

Try to prevent network spamming issues · ddnet/ddnet@e871fbb

1

12:52

Ddnet does not drop the clients when the connection is out of buffer

ChillerDragon

[ddnet/ddnet7] Issue opened: #68 Crash on server start in network_server.cpp:287 (errornous client id)

It depends on some config option. I did not find out yet which exactly caused it. ``` [2020-02-11 12:56:02][engine]: running on unix-linux-amd64 [2020-02-11 12:56:02][engine]: arch is little endian [2020-02-11 12:56:02][storage]: couldn't open storage.cfg [2020-02-11 12:56:02][storage]: using standard paths [2020-02-11 12:56:02][storage]: added path '$USERDIR' ('/home/chiller/.teeworlds') [2020-02-11 12:56:02][storage]: added path '$DATADIR' ('/usr/share/games/teeworlds/data') [2020...

good job @fokkonaut the out of buffer on server type change is solved ❤️

13:21

@deen would be nice if official servers could run on latest commit again

@redix ddnet6, yes. which is technically stupid

13:21

Because the client glitches out then

It only does when there actually is a lost packet. But yeah... This behavior is questionable

Well, probably for timeout protection(?)

13:26

So, that even if client glitches, it can reconnect

13:26

and gets back its tee

About your rainbow thing: you most not send new skin change packets while the server is resending packets. But right now there is no function for checking this from the game part

ay

13:28

Can you help there?

13:28

Maybe pr it :)?

I can look into it. But probably not before next week. Kinda busy right now =\

Okay

Oh that might be the thing that got me stuck on timeout protection @fokkonaut

or we can just move the playerinfo back into the snap

I'd hope so

ChillerDragon

[ddnet/ddnet7] Issue opened: #69 Crash in game/server/gamecontext.cpp:920 CPlayer::GetTeam() 0x0 segfault

``` Thread 1 "multimap_srv_d" received signal SIGSEGV, Segmentation fault. 0x00005555555d06d6 in CPlayer::GetTeam (this=0x0) at /opt/twserver/git/ddnet7/src/game/server/player.h:31 31 int GetTeam() const { return m_Team; }; #0 0x00005555555d06d6 in CPlayer::GetTeam (this=0x0) at /opt/twserver/git/ddnet7/src/game/server/player.h:31 #1 0x00005555555e00e4 in CGameContext::OnClientEnter (this=0x7ffff5ab7010, ClientID=7) at /opt/twserver/git/ddnet7/src/game/server/gamecontext.cpp:920 #2 ...

im struggling to build ddnet with the demo rendering enabled on windows

16:55

the relevant error seems to be:

Could NOT find FFMPEG (missing: AVCODEC_LIBRARY AVFORMAT_LIBRARY AVUTIL_LIBRARY SWSCALE_LIBRARY SWRESAMPLE_LIBRARY AVCODEC_INCLUDEDIR AVFORMAT_INCLUDEDIR AVUTIL_INCLUDEDIR SWSCALE_INCLUDEDIR SWRESAMPLE_INCLUDEDIR)

(edited)

@Patiga hi. Do you have ffmpeg installed?

i tried to, but couldnt figure out how to properly do it

that's also what I don't know

16:57

and what's probably the problem

16:57

are you trying to use visual studio or mingw?

first i tried it via the official ffmpeg site, where i got a zip with the relevant binaries

16:58

via visual studio

16:58

i think i managed to get them into path, but that didnt seem to help

16:59

next i searched for some ffmpeg installer, found one for audacity, however that didnt work out for me either

16:59

i did manage to build ddnet without the demo renderer

does the official ffmpeg even support CMake?

17:00

i think the regular build is easier since we ship the libraries

17:00

but we don't ship ffmpeg. maybe I should just try building ffmpeg for windows?

that would be great

17:01

i dont quite know how the entire build system works, so i dont actually know what it would require me to do (to get the ffmpeg system to work)

i don't know how cmake works either :D

https://discordapp.com/channels/252358080522747904/293493549758939136/676834985277390898 would i need to dive into the ddnet source in order to do this manually?

17:03

(i assume what you propose would fix the issue)

let me make a pr for you to try

ty!

def-

[ddnet-libs:pr-ffmpeg] 1 new commit

ac64e95 Try adding Windows FFmpeg - def-

17:09

def-

[ddnet/ddnet-libs] New branch created: pr-ffmpeg

17:09

def-

[ddnet/ddnet-libs] Pull request opened: #3 Try adding Windows FFmpeg

For Patiga.

17:09

def-

[ddnet/ddnet] Pull request opened: #2060 Try to get Windows FFmpeg working

For Patiga. Do not merge. Depends on ddnet-libs being in state https://github.com/ddnet/ddnet-libs/pull/3

https://github.com/ddnet/ddnet/pull/2060 & https://github.com/ddnet/ddnet-libs/pull/3

Try to get Windows FFmpeg working by def- · Pull Request #2060 · dd...

For Patiga. Do not merge. Depends on ddnet-libs being in state ddnet/ddnet-libs#3

Try adding Windows FFmpeg by def- · Pull Request #3 · ddnet/ddnet-l...

For Patiga. Do not merge. Corresponds to ddnet/ddnet#2060

fokkonaut

[ddnet7:master] 1 new commit

2b8b654 Fix #66 - fokkonaut

17:10

fokkonaut

[ddnet/ddnet7] Issue closed: #66 Crash CServer::UpdateClientMapListEntries

17:15

fokkonaut

[ddnet/ddnet7] Issue reopened: #66 Crash CServer::UpdateClientMapListEntries

17:17

def-

[ddnet/ddnet] Pull request closed: #2058 Fix GCC 9.2.0 compilation

17:17

def-

[ddnet:master] 2 new commits

598ec52 Fix GCC 9.2.0 compilation - def- 5929517 Merge pull request #2058 from def-/pr-fix-compilation - def-

17:18

ChillerDragon

[ddnet/ddnet7] Pull request opened: #70 Revert "Fix #66"

This reverts commit 2b8b6543b7be8c6f383d33089d6fffe0d0194ecb.

@deen i switched to your branch, but the error seems to persist

does the fix bundle ffmpeg?

17:57

when i do -DPREFER_BUNDLED_LIBS=ON on linux, ffmpeg isnt recognized as bundled

17:58

(neither on windows)

why is new ht liek 3 tiles?

18:12

which one to use?

https://github.com/ddnet/ddnet/issues/2031

Hookthrough Combo Tile Pointless (Entities) · Issue #2031 · ddnet/d...

The hookthrough combo tile (index 5 in the game layer) ddnet/src/game/mapitems.h Line 103 in 7d7b510 TILE_THROUGH_CUT, is used to create hookthrough tiles. It does that by placing a unhookable bloc...

i just used the tile next to the old one

@Patiga also switched ddnet-libs?

how do i do that?

there should be a ddnet-libs subdirectory

18:21

check out my branch in it

oh yeah, that looks promising

18:29

sadly the same error again

18:30

it still doesnt recognize it as bundled

18:31

would the cmake logs help?

you could post them somewhere

18:37

maybe someone else can understand

1

CMakeOutput.log

9.54 KB

18:37

2

CMakeError.log

4.25 KB

fokkonaut

[ddnet/ddnet7] Pull request closed: #70 Revert "Fix #66"

18:42

fokkonaut

[ddnet/ddnet7] Issue closed: #66 Crash CServer::UpdateClientMapListEntries

18:42

fokkonaut

[ddnet7:master] 2 new commits

9e4fe3e Revert "Fix #66" - ChillerDragon e219a7e Merge pull request #70 from ChillerDragon/pr_rev_66 - fokkonaut

18:43

fokkonaut

[ddnet/ddnet7] Issue reopened: #66 Crash CServer::UpdateClientMapListEntries

[2020-02-11 19:44:54][server]: client dropped. cid=9 addr=<{unknown type 0}> reason='Error sending data'

18:45

i wonder why it does not show the ip

seems like its invali

19:15

d

19:15

otherwise it would Show ip or xxx

19:15

no, in log it would Show ip, in f2 xyx

19:15

xxx

19:15

i added the show ips thing to 0.7

But it shouldn’t be invalid huh?

Learath2

[ddnet7:d7_pr_chatcom] 9 new commits

5987063 Clean up chat commands - Learath2 b99d51e Decrease dynamic allocations - Learath2 0cf09aa References are cleaner - Learath2 385770c Make the UI capable of n-commands - Learath2 f23c6bc Add a scrollbar - Learath2 865ce50 Show scrollbar when needed - Learath2 2341fb2 Comment out examples - Learath2 a797832 Fix merge artifact - Learath2 c504218 Register old commands - Learath2

20:32

Learath2

[ddnet/ddnet7] New branch created: d7_pr_chatcom

@Learath2 cool that you use my executechatcommand thing and the /%s %s :)

20:43

why didnt you push to master?

I don't like the %s %s

20:45

I'll make another one

Yea

20:47

I did that to support old chat commands too