DDraceNetwork - developer

@heinrich5991 https://github.com/Learath2/teeworlds/commit/165ab18cd230a1450832bef11835234d1627094f if/when you have a minute

00:21

Well a couple minutes, but not more then the amount of minutes you can count on two hands

2

@Learath2 style as well?

I haven't really combed over stlye, but anything you catch would be useful

https://github.com/Learath2/teeworlds/commit/165ab18cd230a1450832bef11835234d1627094f#diff-4c1480841d96bf73e07b29e10fbd394bR465 m_aName etc., one tab too many

Oh, I wasn't quite sure how to name those properly

00:25

it leads to a generation of a const char * field, which should be m_pName

huh, then m_p

but other Netobjs used without the p

oh rly

00:25

hm

00:26

not all of them though

00:26

it differs

00:26

NetArray(NetStringStrict("m_apSkinPartNames"), 6),

00:26

not sure what to do

I guess network.py needs a once over

you have a dynamic allocation in there

@heinrich5991 you mean m_pFilter?

ye

It's one I couldn't figure out how to avoid

01:04

If you have any divine inspiration, I'd love to hear it

it's the size of the amount of commands, right?

Yes, but the amount of commands can change

you could use an array<bool> and use set_size there

01:11

that would get rid of most of the allocations

Oh, that'd be great

@heinrich5991 do you think I should sort the commands btw?

dunno\

I'm still unsure about this being it's own system and not just being hooked into the console but I guess I'll make the UI n-command capable and PR this

Great

def-

[ddnet-web:master] 1 new commit

a5b08ea Update frontpage video - def-

Ekidoxx

[ddnet/ddnet] Issue opened: #2055 Bug with skin custom colors

Take for example the PsychoWolfe skin, because it is truly white. With custom colors disabled, of course both the body and feets are white. But if you enable custom colors, and drag all three sliders to the max... body becomes grey for some reason, while feets stay white as they should | Custom colors disabled | Custom colors enabled | | :---: | :---: | |...

I wrote worlds most inefficient scrollbar