DDraceNetwork - developer

DDraceNetwork

Development / developer

Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet

Between 2020-01-19 00:00:00Z and 2020-01-20 00:00:00Z

[ddnet-maps:master] 1 new commit

c8d6693 M The Tower - ddnet-maps

[ddnet/ddnet] Issue opened: #2036 Possible to walk while paused or chatting

When holding a or d, then pressing chat or pause bind you will continue to walk.

[ddnet/ddnet] Pull request opened: #2037 fix walking while paused or chatting (fixes #2036)

09:53

[ddnet7:master] 3 new commits

940d59c Remove unused var - fokkonaut a65902b Merge branch 'master' of https://github.com/ddnet/ddnet7 - fokkonaut 2c5c8fe Fix walking while paused or chatting - fokkonaut

uhm

dont fix it

09:57

its a feature (edited)

[ddnet/ddnet7] Issue closed: #53 Unpredictable behaviour when holding input and hitting an unfreeze

10:05

[ddnet7:master] 1 new commit

f806ca8 Fix freeze inputs (also closes #53) - fokkonaut

10:06

[ddnet7:master] 1 new commit

ab8acac Fix walking while paused or chatting with m_SavedInput - fokkonaut

10:08

[ddnet7:master] 1 new commit

0d00478 Fix automatic shooting after unpausing when clicked mouse in pause - fokkonaut

10:09

[ddnet/ddnet7] Pull request closed: #55 Add GitHub actions

10:09

[ddnet7:master] 10 new commits

b5f05ac Add github actions workflow - axblk f2322fa Fix macos package name - axblk bf51f5f Add pkg-config for github actions build - axblk 12bb436 Fix sdl2 cmake module - axblk e67fc7d Remove travis, appveyor and circleci - axblk b561876 Use make and visual studio instead of ninja - axblk 7b21c74 Test cmake 3.5 on older ubuntu version - axblk 44722bc trigger workflow on pull request - oy 35f6d28 Adjust github actions to fit ddnet - ChillerDragon 8bb5f30 Merge pull request #55 from ChillerDragon/pr_github_actions - fokkonaut

10:09

[ddnet/ddnet7] Pull request closed: #57 Add access_level

10:09

[ddnet7:master] 2 new commits

d88b512 Add access_level - ChillerDragon f89e3d5 Merge pull request #57 from ChillerDragon/pr_access_level - fokkonaut

10:10

[ddnet7:master] 1 new commit

85b3093 Fix team change delay for client - fokkonaut

[ddnet7:master] 4 new commits

55279fd Add AuthManager - Learath2 2d59f48 Make AUTHED_ enum accessible everywhere and use GetAuthedState - fokkonaut 3e4e2f2 Add helpers - Learath2 5a6a4ff Fix helper - fokkonaut

Can anyone help with the build error?

[ddnet7:master] 1 new commit

b0b9be4 also set core id here - fokkonaut

10:42

[ddnet7:master] 1 new commit

87458ce Do spectator leave msgs - fokkonaut

10:49

[ddnet7:master] 4 new commits

4a8c49d Implement show_ips to protect accidental leaking of IPs - def- e62b3f3 output level standard - fokkonaut 9cae91e Persist show_ips setting on map changes - def- 225c69d Fix show_ips to show regular formatting - def-

10:53

[ddnet7:master] 1 new commit

38fba5b Fix command spam - fokkonaut

11:00

[ddnet7:master] 1 new commit

988b223 Print messages to everyone in the console, fix public command spam (fixes #56) - fokkonaut

11:00

[ddnet/ddnet7] Issue closed: #56 Add anti spam commands

Can anyone check the linking error that occurs in ddnet7 for the client since the authmanager commit from me?

[ddnet/ddnet7] Issue closed: #52 Add sv_rcon_helper_password

[ddnet7:master] 1 new commit

e9527df add announcements - fokkonaut

11:31

[ddnet7:master] 1 new commit

a9c7810 add sv_welcome - fokkonaut

Fokkonaut spam banhammer

banhammer

U

@deen could you please deactivate all ci's for ddnet7 again

12:12

its now replaced by github actions

[ddnet7:master] 1 new commit

650a909 add missing includes - fokkonaut

[ddnet/ddnet7] Pull request opened: #58 Fix client json dependencys

12:34

[ddnet/ddnet7] Pull request closed: #58 Fix client json dependencys

12:34

[ddnet7:master] 2 new commits

d284db5 Fix client json dependencys - ChillerDragon 9a42061 Merge pull request #58 from ChillerDragon/pr_fix_json - fokkonaut

12:36

[ddnet7:master] 1 new commit

bf8a2fe Fix test - fokkonaut

12:38

[ddnet7:master] 1 new commit

6b8b70a Fix newline and spaces - fokkonaut

@fokkonaut Leider geht access_level noch nicht wie erwartet. access_level <cmd> 2 sollte ein cmd für spieler freischalten die sich mit dem sv_rcon_mod_password einloggen

ja nein ja

Vielleicht hat @ChillerDragon da etwas nicht richtig gemacht

Er hat den Pull Request erstellt

Hab’s getestet bei mir ging es so @timakro

huh

Could you please provide the exact commands you execute so I can try to reproduce

it's strange, what is used by the trashmap code is access_level <cmd> 2

13:51

but description of access_level says 2=helper

so whats wrong now?

on the 0.6 ddnet servers this works: 1. sv_rcon_mod_password 123 2. access_level up 2 3. login with password 123 4. run up

13:53

on 0.7 it says access for up denied

for me it works

13:54

access_level up 2, allows up for helper and mod

you're right, must be another issue

13:59

5.26 KB

13:59

I pass those access_level commands to the server via command line arguments

14:00

it seems like at the point in time they are executed the commands are not yet registered or smth

14:00

some of the commands at least

sv_test_cmds 1 (edited)

There is no helper in 0.7

14:19

Oh wait Fokko added it

@fokkonaut the cmdline look smth like this ./DDNet7-Server "exec init.cfg;access_level up 2"

14:19

init.cfg has sv_test_cmds 1

well, that definitely is about test cmds

14:19

no idea

14:19

those commands are all marked with test

14:20

(the ones that say no such command)

14:20

well, i think this is my fault

14:20

let me fix it

thanks, would appreciate it

@timakro

[ddnet7:master] 1 new commit

9edeff2 Try to fix execution of access_level on init - fokkonaut

can you try again?

@fokkonaut Same problem

mh

can't you reproduce?

w8

14:56

well

14:57

for me it works

14:57

pull again

14:58

i put access_level super 2 in the autoexec.cfg, then started the server and it worked

14:58

the output when starting shows that it got set

[ddnet7:master] 1 new commit

6d81f10 Use vanilla race time support - fokkonaut

[ddnet7:master] 1 new commit

0d88a4d Use vanilla chat command support - fokkonaut

16:10

[ddnet7:master] 1 new commit

c244bb2 clamp access levels corrcetly - fokkonaut

16:14

[ddnet7:master] 1 new commit

dd1b0de remove unused variable - fokkonaut

[ddnet7:master] 1 new commit

4c09979 Remove conflict marker - fokkonaut

16:25

[ddnet7:master] 1 new commit

b3dc4fd remove team balance setting - fokkonaut

@fokkonaut It's very easy to reproduce. sv_test_cmds is not connected to the problem. It's just that some commands are not yet registered when the commands passed as command line arguments are executed. It's probably that some initialization order changed very lowlevel in server.cpp where the command line args are parsed. I'm not sure if it is trivial to change this to the way 0.6 ddnet works or if there are bigger architectural changes in 0.7. This is a very simple test to reproduce the problem without needing a client at all: ./DDNet7-Server "access_level up 2" results in the output [2020-01-19 17:36:27][console]: No such command: 'up'.

well, you are right. Maybe execute it from an autoexec.cfg file (edited)

16:38

that worked for me

the problem is it's dynamic in the trashmap case

wym

i could write a file before i start a server and pass it that ofc

16:42

@fokkonaut Same for autoexec.cfg btw

for me that worked :/

autoexec.cfg is executed before cmdline args even

lol

16:43

well, no idea, sorry

16:43

feel free to pr

[ddnet/ddnet] Pull request opened: #2038 Overkill optimize editor code runs 200 fps faster

why is Checked even a int

16:57

ah do button ex takes a int nvm then

16:58

used like a bool tho maybe its a c artifact idk

[ddnet/ddnet7] Pull request opened: #59 Move command registrations to OnConsoleInit like in DDNet6

xd DDNet6 looks odd

dunno about the vanilla cmds but i dont think it hurts to register them earlier

should be fine ye

(like this they can also be used with access_level, although kinda useless)

especially when it was like this in ddnet for years it should make no problems

the vanilla commands were neither in OnConsoleInit nor OnInit

17:01

i guess thats a vanilla 0.7 thing

[ddnet/ddnet7] Pull request closed: #59 Move command registrations to OnConsoleInit like in DDNet6

17:03

[ddnet7:master] 2 new commits

078bf54 Move command registrations to OnConsoleInit like in DDNet6 - timakro ff0f795 Merge pull request #59 from timakro/pr_reg_cmds_in_console_init - fokkonaut

thx, GER trashmap https://trashmap.ddnet.tw now has a DDNet7 option. Maybe someone can convince @deen to update the other servers as well. Patch is here https://github.com/timakro/ddnet-trashmap/commit/4d19252c37b0714083ff7dff27e1ff4d9c205159, the server_storage.json needs to be updated with a "version": "0.6" field for every server. (edited)

17:12

i thought markdown links worked

thanks a lot @timakro ❤️

if you edit a message it gets completely resent to irc btw

lol @Learath2 merged mi troll commit xd

which?

17:17

ah xd

xd

17:17

clickbait commit messages

17:17

just 2020 things

17:17

i need it im fulltime github influencer

17:18

and when i wanted just a shirt he was trollin me xd. Oh btw @Learath2 my hacktoberfest shirt didnt arrive yet :/

17:19

anyone else ordered a hacktoberfest shirt and got it already? .-.

mr github

greenthing

2

[ddnet:master] 2 new commits

949aa12 Overkill optimize editor code runs 200 fps faster - ChillerDragon 8f9fc8c Merge #2038 - bors[bot]

17:21

[ddnet/ddnet] Pull request closed: #2038 Overkill optimize editor code runs 200 fps faster

:party:

git my shirt @ChillerDragon

17:40

got*

meh :/

17:41

i think they did not found my flat or a neighbour stole it

Image attachment

bluekitty

1

@ChillerDragon I got mine aswell, nice theme this year

18:02

Don't they give you a tracking no? either case just ask them and I'm sure they'll give you a hand

"nice theme this year" fk u :/

is bojidar-bg here?

@Ryozuki you should also use static analyzers like clang-tidy, sanitizers like asan

me?

19:27

what are we talking about?

19:27

pepeH

https://discordapp.com/channels/252358080522747904/293493549758939136/668510503756365825 this one I guess

oh

19:28

lol

no matter if your in trouble or dropping memes heinrich is always there and will serve some serious help

19:30

oh wait

19:31

deen*

[ddnet/ddnet] Pull request opened: #2039 Add set_src to be more teeworlds compatible

thanks to @heinrich5991

@ChillerDragon you forgot some instances of set_glob in cmake/Find*.cmake

oh yikes

19:36

ima force push sec

19:38

fixed

[ddnet:master] 2 new commits

01f4208 Add set_src to be more teeworlds compatible - ChillerDragon 1e257de Merge #2039 - bors[bot]

20:01

[ddnet/ddnet] Pull request closed: #2039 Add set_src to be more teeworlds compatible

[ddnet/ddnet] Pull request opened: #2040 fixed faulty message id

(cherry picked from commit https://github.com/teeworlds/teeworlds/commit/9023796d270b216c5859cc6b351a91a4656c58ec)

@Learath2 asking for the shirt was a good idea i guess. I just wrote them a mail... then i realized i did not check my mailbox in months xxxD

21:22

i just assued the shirt is too big to fit in there anyways

[ddnet/ddnet] Pull request opened: #2041 Strip spaces in browser (server name)

before: !image after: !image

Exported 162 message(s)