DDraceNetwork - developer

I'm pretty sure the speedup code isn't correct either... The max speed thing looks odd. But fixing this would definitely break maps (edited)

is anything correct? xd

00:02

new hookthrough maybe

The original ddrace physics code isn't that great... But you can easily get this wrong and there is just no documentation... And at this time there was nothing like a code review for tw mods

// Explode at most once per team
            int PlayerTeam = ((CGameControllerDDRace*)m_pController)->m_Teams.m_Core.Team(apEnts[i]->GetPlayer()->GetCID());
            if (GetPlayerChar(Owner) ? GetPlayerChar(Owner)->m_Hit & CCharacter::DISABLE_HIT_GRENADE : !g_Config.m_SvHit || NoDamage)
            {
                if (!CmaskIsSet(TeamMask, PlayerTeam)) continue;
                TeamMask = CmaskUnset(TeamMask, PlayerTeam);
            }

00:10

this is the broken part, what would be the correct fix?

00:11

NoDamage is true when the projectile (in this case from the map) has no owner, so its -1. Setting NoDamage to false would fix it, but I want a "correct" fix xd

00:11

(just for myself right now, not ddnet)

yes @deen some official build with official version number. Something that replaces my handcrafted releases i sent over discord.

@ChillerDragon any preferred version number to start with? 0.1, 1.0?

09:57

and it would be great to have a properly working tool for converting maps to 0.7

I think it’s not perfect yet so 0.1 but probably a bit more useful to use 1.0 to not clash with vanilla versions.

13:47

Oh yea the map tool :/

1.0

1