Guild icon
DDraceNetwork
Development / developer
Development discussion. Logged to https://ddnet.tw/irclogs/ Connected with DDNet's IRC channel, Matrix room and GitHub repositories — IRC: #ddnet on Quakenet | Matrix: #ddnet-developer:matrix.org GitHub: https://github.com/ddnet
Between 2019-12-18 00:00:00Z and 2019-12-19 00:00:00Z
Avatar
8e66897 M DarkSpy, M Kalimba - ddnet-maps
Avatar
help, how to open the ddnet server log on linux?
05:35
where i can see all the commands and stuff
05:35
rn when i open the exec it shows nothing but still runs somewhere
06:00
9652ef4 Update brazilian_portuguese.txt - rffontenelle 70e06d8 Merge pull request #2005 from rffontenelle/patch-4 - def-
Avatar
@louis run it from a terminal window
11:27
Longer release description this time? ^^
12:15
4aeeedb Remove strcmp from file score - heinrich5991 71857fd Merge pull request #2007 from heinrich5991/pr_ddnet_rm_string_h - def-
12:15
12:15
i asynced the sdl poll
12:15
makes the FPS and prediction much more consistent
12:18
@deen might be interesting for u 😄
Avatar
indeed, do you plan to merge that to DDNet?
12:18
but is it really better btw?
12:18
i mean you still have the poll latency, you just don't see it
Avatar
i am currently not sure if that breaks other SDL stuff but u can always try my things at my repo https://github.com/Jupeyy/ddnet/tree/test_async_msg_poll
DDraceNetwork, a mod of Teeworlds. Contribute to Jupeyy/ddnet development by creating an account on GitHub.
Avatar
and i thought async polling isn't possible in sdl in general
Avatar
it isnt
12:19
except u move all initalization to another thread
12:19
and thats what i did
12:20
its bit hacky rn, and i dunno if other SDL calls would be need to be called from that thread too
Avatar
@Soreu that's not the release desc, it's at https://ddnet.tw/downloads
Avatar
@deen do you know why the travis mac build fails? it shows missing sdl2, opusfile, etc. (don't need to investigate if you don't know)
Avatar
nope, no idea
12:21
i guess the easiest approach would be to just install the missing packages
Avatar
yes, but it wouldn't continually test that you can build it on a mac without doing so
Avatar
[quakenet] deen BOT 2019-12-18 12:22:40Z
then fetch ddnet-libs I guess
Avatar
ChillerDragon 2019-12-18 12:24:51Z
oh there is no need on mac to install dependencys?
Avatar
[quakenet] deen BOT 2019-12-18 12:26:18Z
we should be bundling them
12:27
I guess some git submodule update would help
12:27
in the .travis file
Avatar
ChillerDragon 2019-12-18 12:27:41Z
so it worked at some point i guess
Avatar
hm, submodule is there
Avatar
cant watch teehistorian demos anymore with new client 😢
Avatar
Travis CI enables your team to test and ship your apps with confidence. Easily sync your projects with Travis CI and you'll be testing your code in minutes.
12:28
sounds like backward-compatibility broke @Learath2
Avatar
ye, it's a bug, should be fixed
Avatar
ChillerDragon 2019-12-18 12:31:48Z
Chillers contribution fork of DDraceNetwork, a cooperative racing mod of Teeworlds - ChillerDragon/ddnet
Avatar
[quakenet] deen BOT 2019-12-18 12:32:22Z
you could ls -lha ddnet-libs and check what's going on in there :D
Avatar
ChillerDragon 2019-12-18 12:33:45Z
xd
Avatar
@heinrich5991 is it a bug with the demos you generate or is it a bug with my code?
Avatar
sounds like a bug with your code when it encounters demos without sha256s
12:34
it sounds like you search for a map with zero sha256 if there's no sha256 in the demo
Avatar
demos without sha256 should be fine as long as they are not marked the newest version
12:35
All my old demos work fine afterall
Avatar
hm. then it might be my fault
Avatar
do you add the map in the demo?
Avatar
Crc = m_DemoPlayer.GetMapInfo()->m_Crc; SHA256_DIGEST Sha = m_DemoPlayer.GetMapInfo()->m_Sha256; pError = LoadMapSearch(m_DemoPlayer.Info()->m_Header.m_aMapName, &Sha, Crc);
12:36
no
Avatar
I guess it tries to extract the map, and that leads to a 0 length map
Avatar
that sounds like you unconditionally search for the map with the sha256, even if it's not present
12:37
even if the sha256 is not present
Avatar
ChillerDragon 2019-12-18 12:37:15Z
12:37
leet
Avatar
@heinrich5991 oh, does LoadMapSearch not handle SHA256_ZEROED?
Avatar
LoadMapSearch searches for a zero sha256 in that case
12:39
pass a null pointer if you want to ignore the sha256 hash
12:39
IIRC
Avatar
Okay, so a Sha == SHA256_ZEROED ? nullptr : &Sha there should fix it
Avatar
yes
Avatar
Also a check for 0 length maps
12:40
@heinrich5991 you put 0 length right?
Avatar
that's in there already I think
12:41
yes
Avatar
Oh, I was thinking ahead 😄
12:41
Maybe I should add a return though, so I can check whether a map was extracted
12:45
@heinrich5991 do you think I should check that the map actually hashes to the hash provided? currently I just trust the hash added
12:45
I guess I should given I'm saving the map and demos could be used to inject maps otherwise
Avatar
well, I looked at it and it looks like an vulnerable file system write as well
Avatar
Doesn't really check that the file is an actual map
Avatar
that's not too bad as long as it's confined to the maps/ directory
12:46
overwriting with wrong maps is not too bad either, the loader will discard the map if the sha256 doesn't match
12:47
it's still a bit bad for the demo to effectively delete maps out of the downloadedmaps/ folder
Avatar
Oh, one more thing, I'm not sure if it's bad or not, but you can craft a demo where size is wrong
12:48
idk what will happen then if the size is too large
Avatar
nothing too bad either
12:48
it will write out a short demo in this case
12:48
or maybe dump some uninitialized memory. hm
Avatar
there is no easy way to figure out if the size is right though :/
12:49
anyway, I'll fix the bug for now
Avatar
@jao if you aren't busy you can give this a try
13:04
DDraceNetwork, a cooperative racing mod of Teeworlds - ddnet/ddnet
13:04
odd dbg msg
flag_unk 1
Avatar
2020 donations bluekitty
Avatar
ChillerDragon 2019-12-18 14:25:25Z
future is now
Avatar
Cellegen | HU 2019-12-18 14:25:37Z
3 people donate kek (edited)
Avatar
ChillerDragon 2019-12-18 14:30:48Z
@deen dont wanna push but are there any issues with https://github.com/ddnet/ddnet7/pull/39 ?
I did basic tests on local server. Found no bugs so far. But I did not go through the full list of things that can be loaded.
Avatar
Faketuning should be gone @ChillerDragon
14:32
it was in 0.6 because we didnt want to break backwards client compatibility
Avatar
ChillerDragon 2019-12-18 14:32:19Z
its not used in this pr
14:32
its just a placeholder
Avatar
Then remove it
Avatar
ChillerDragon 2019-12-18 14:32:33Z
this would break compatibility
14:32
it expects to read something
14:32
i could rename it to FakeTunePlaceholder
14:33
but meh
14:33
just remove it from thr string
Avatar
ChillerDragon 2019-12-18 14:33:25Z
what string
Avatar
Where does it expect to read it?
Avatar
ChillerDragon 2019-12-18 14:33:45Z
from the save blob i guess
Avatar
0.6 and 0.7 savegames are incompatible anyways
14:34
well
Avatar
ChillerDragon 2019-12-18 14:34:26Z
why
Avatar
at least its deactivated
Avatar
ChillerDragon 2019-12-18 14:34:40Z
why are those incompatible?
Avatar
ChillerDragon 2019-12-18 14:35:19Z
but do you really thinking breaking the format is the way to go?
Avatar
well
14:36
you even set it and readded the variable
14:36
just remove it and dont set it
Avatar
ChillerDragon 2019-12-18 14:38:27Z
I mean currently you can save a 0.6 game and then load it in 0.7 and then save again and load in 0.6 without messing up fake tuning
14:38
so where is the problem
Avatar
It is disallowed anyways
Avatar
ChillerDragon 2019-12-18 14:39:04Z
currently yes
14:40
also ammocost is unused in 0.7
Avatar
if it should be activated at some time, then there will be another solution for it. It gets fucked up, for example if you go to another part where in 0.6 you would get faketune_jetpack, you wouldnt get it in 0.7, if you then load in 0.6 again you dont have the correct faketuning
Avatar
ChillerDragon 2019-12-18 14:40:48Z
hm
14:40
true
14:41
so use completley different formats for 0.6 and 0.7 saves :/
14:41
sounds like work
Avatar
of course it is work
Avatar
[quakenet] deen BOT 2019-12-18 14:41:44Z
loads and saves between 0.6 and 0.7 should never be compatible
Avatar
ChillerDragon 2019-12-18 14:41:56Z
oke
Avatar
Vanilla will add simple race support
16:04
It will show the timer correctly
Avatar
they did already
Avatar
We should adapt to it when ite released
16:04
@fokkonaut y but its not yey rlsed
Avatar
I guesd they will rls it on 24
16:05
Shit mobile
Avatar
ChillerDragon 2019-12-18 16:53:55Z
Ok i removed the 0.6 stuff from the savegames
Avatar
hey guys. i have problems with cursor when i'm using graphics tablet
19:02
xd
Avatar
why are u playing teeworlds with a graphics tablet
19:06
teeworlds handles cursors oddly its hard to play with touchscreen/tablet like you would expect
Avatar
bcs i prefer to use the tablet like a main device
19:08
and it's fun to play with tablet xd
Avatar
eh, never tried this or heard anyone else do it
19:10
what kinda problems do you get?
Avatar
Avatar
@Mathan my tablet has a mouse mode in its driver settings, which i use for playing tw
Avatar
I played tw with graphic tablet long time ago
19:19
I made it compatible on my client, its very cool to play with it, fng zcatch and block, but i dont prefer ddnet
Avatar
@Learath2 you were the last to change this, would be nice if you could check if this is correct behaviour, i didn't find anything wrong :D
Exported 160 message(s)