DDraceNetwork - developer

bors[bot]

[ddnet:master] 2 new commits

0498df2 Update localizations (Thanks to Cellegen for report) - def- d597322 Merge #1978 - bors[bot]

10:19

bors[bot]

[ddnet/ddnet] Pull request closed: #1978 Update localizations (Thanks to Cellegen for report)

bors[bot]

[ddnet:master] 2 new commits

c1a7961 Write out sql server prefix to failed_sql.sql - def- d8cd6aa Merge #1976 - bors[bot]

12:09

bors[bot]

[ddnet/ddnet] Pull request closed: #1976 Write out sql server prefix to failed_sql.sql

bors[bot]

[ddnet:master] 2 new commits

37ef242 Clean up color handling a bit - def- e02cd32 Merge #1979 - bors[bot]

12:22

bors[bot]

[ddnet/ddnet] Pull request closed: #1979 Clean up color handling a bit

Is it saver to call static functions from threads than class methods?

No difference, however you can't pass a non-static method as a pointer, so the first is usually more convenient.

oh ok thats nice

13:54

but if i singiggle snuggly my sketchy pointer to a object in my thread i can happily call methods there even if they get executed in other threads as well?

13:55

only problem is object variables i guess

You can't even take a pointer to a member function iirc

14:20

and it wouldn't even make much sense, you can't call a member function without an object. It's signature actually includes the object as a parameter

yy i have a pointer to the obj

If you just pass a pointer to the object that's also fine. But threads are pretty dangerous

14:23

You might want a lock

i dont know exactly what a lock is but i have a var that is shared by both threads and tracks state of thread

When you modify a variable another thread could be reading that variable and that causes issues. To fix it you can have a lock, that makes sure only one thread is using the variable at a time

hmm sounds good

14:28

but too lazy rn to understand how to use it xd

14:29

i dont see how my threads could mess something up

14:29

ikr famous last words

Or you can make reads and writes atomic, which fixes a lot of issues but there still might be other timing issues, e.g. memory ordering :/

my main thread sets the state var to running then spawns a thread if not running already and the thread then sets state to done and the main thread checks if its done in the gameloop

14:30

sounds save to me

14:30

so i spawn max one thread at a time

14:30

*additional

“Some people, when confronted with a problem, think ‘I know, I’ll use multithreading’. Nothhw tpe yawrve o oblems.” (Eiríkr Åsheim, 2012)

xd

14:31

im sure it will be fine

Well the writes and reads are not atomic, so the thread can set the value halfway, then the other thread can read a trap representation, which invokes undefined behaviour

what reads and write you mean? to file?

Reading and writing to the variable in the memory

oh wait ye i read and write to file at same time ur right its messed up xd

14:33

but not to variables

14:33

as far as i know

Well even the variable that holds the state isn't safe, CPUs don't write in one cycle

uh

14:34

yikes

14:34

ok my thread is messed up in all possible ways then

14:34

teach me locks senpai

Is this teeworlds code?

yy

Why don't you just use engine jobs?

looked scary to me

@heinrich5991 made them pretty safe iirc

i can imagine

14:35

but harder to understand than the crap i built

Well actually idk if 0.7 got heinrichs engine jobs

mimimi

What are you making?

ranking

14:35

reading files calculating rank

14:36

but i just realized during the rank calculation other ranks could be saved and then there is read and write to file at the same time which is not too good

This is why people use sql for this kind of stuff

:/

14:36

onbgy doesnt

14:36

he is my big idol

Well I guess you can just do it naively and hope things don't go wrong?

uff

14:37

sounds like a chiller approach

14:37

but works better when i can still hope my code is not broken

You can have a lock for the object you are passing around just to be safe

do you have a quick lock snipped